synapse/changelog.d/8465.bugfix at 0ec0bc3886bd72bdf2f64d455a7d777f4573a4f1 - MirrorHub/synapse - tilera Git

MirrorHub/synapse

mirror of https://mau.dev/maunium/synapse.git synced 2024-11-05 22:28:54 +01:00

Andrew Morgan 3e58ce72b4

Don't bother responding to client requests that have already disconnected (#8465 )

This PR ports the quick fix from https://github.com/matrix-org/synapse/pull/2796 to further methods which handle media, URL preview and `/key/v2/server` requests. This prevents a harmless `ERROR` that comes up in the logs when we were unable to respond to a client request when the client had already disconnected. In this case we simply bail out if the client has already done so.

This is the 'simple fix' as suggested by https://github.com/matrix-org/synapse/issues/5304#issuecomment-574740003.

Fixes https://github.com/matrix-org/synapse/issues/6700
Fixes https://github.com/matrix-org/synapse/issues/5304

2020-10-06 10:03:39 +01:00

1 line

No EOL

81 B

Text

Raw Blame History

Don't attempt to respond to some requests if the client has already disconnected.