0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-11-05 22:28:54 +01:00
synapse/tests/federation
Eric Eastwood 0f971ca68e
Update get_pdu to return the original, pristine EventBase (#13320)
Update `get_pdu` to return the untouched, pristine `EventBase` as it was originally seen over federation (no metadata added). Previously, we returned the same `event` reference that we stored in the cache which downstream code modified in place and added metadata like setting it as an `outlier`  and essentially poisoned our cache. Now we always return a copy of the `event` so the original can stay pristine in our cache and re-used for the next cache call.

Split out from https://github.com/matrix-org/synapse/pull/13205

As discussed at:

 - https://github.com/matrix-org/synapse/pull/13205#discussion_r918365746
 - https://github.com/matrix-org/synapse/pull/13205#discussion_r918366125

Related to https://github.com/matrix-org/synapse/issues/12584. This PR doesn't fix that issue because it hits [`get_event` which exists from the local database before it tries to `get_pdu`](7864f33e28/synapse/federation/federation_client.py (L581-L594)).
2022-07-20 15:58:51 -05:00
..
transport Use HTTPStatus constants in place of literals in tests. (#13297) 2022-07-15 19:31:27 +00:00
__init__.py
test_complexity.py Use HTTPStatus constants in place of literals in tests. (#13297) 2022-07-15 19:31:27 +00:00
test_federation_catch_up.py
test_federation_client.py Update get_pdu to return the original, pristine EventBase (#13320) 2022-07-20 15:58:51 -05:00
test_federation_sender.py Reduce state pulled from DB due to sending typing and receipts over federation (#12964) 2022-06-06 16:46:11 +01:00
test_federation_server.py Rate limit joins per-room (#13276) 2022-07-19 11:45:17 +00:00