synapse/changelog.d/14926.bugfix at 5fdc12f482c68e2cdbb78d7db5de2cfe621720d4 - MirrorHub/synapse - tilera Git

MirrorHub/synapse

mirror of https://mau.dev/maunium/synapse.git synced 2024-11-17 23:42:33 +01:00

Sean Quah 6d14fdc271

Make sqlite database migrations transactional again, part two (#14926 )

#14910 fixed the regression introduced by #13873 where sqlite database
migrations would no longer run inside a transaction. However, it
committed the transaction before Synapse updated its bookkeeping of
which migrations have been run, which means that migrations may be run
again after they have completed successfully.

Leave the transaction open at the end of `executescript`, to restore the
old, correct behaviour. Also make the PostgreSQL behaviour consistent
with SQLite.

Fixes #14909.

Signed-off-by: Sean Quah <seanq@matrix.org>

2023-01-31 11:03:55 +00:00

1 line

138 B

Text

Raw Blame History

Fix a regression introduced in Synapse 1.69.0 which can result in database corruption when database migrations are interrupted on sqlite.