synapse/changelog.d/13879.misc at a52c40e2a6d3a142c9cf768479ec963354c3e360 - MirrorHub/synapse - tilera Git

MirrorHub/synapse

mirror of https://mau.dev/maunium/synapse.git synced 2024-11-15 22:42:23 +01:00

Eric Eastwood df8b91ed2b

Limit and filter the number of backfill points to get from the database (#13879 )

There is no need to grab thousands of backfill points when we only need 5 to make the `/backfill` request with. We need to grab a few extra in case the first few aren't visible in the history.

Previously, we grabbed thousands of backfill points from the database, then sorted and filtered them in the app. Fetching the 4.6k backfill points for `#matrix:matrix.org` from the database takes ~50ms - ~570ms so it's not like this saves a lot of time 🤷. But it might save us more time now that `get_backfill_points_in_room`/`get_insertion_event_backward_extremities_in_room` are more complicated after https://github.com/matrix-org/synapse/pull/13635 

This PR moves the filtering and limiting to the SQL query so we just have less data to work with in the first place.

Part of https://github.com/matrix-org/synapse/issues/13356

2022-09-28 15:26:16 -05:00

1 line

142 B

Text

Raw Blame History

Only pull relevant backfill points from the database based on the current depth and limit (instead of all) every time we want to `/backfill`.