mirror of
https://mau.dev/maunium/synapse.git
synced 2024-06-14 08:38:24 +02:00
a986f86c82
In previous versions of authlib using `client_secret_basic` without a `client_secret` would result in an invalid auth header. Since authlib 1.3 it throws an exception. The configuration may be accepted in by very lax servers, so we don't want to deny it outright. Instead, let's default the `client_auth_method` to `none`, which does the right thing. If the config specifies `client_auth_method` and no `client_secret` then that is going to be bogus and we should reject it
445 lines
17 KiB
Python
445 lines
17 KiB
Python
#
|
|
# This file is licensed under the Affero General Public License (AGPL) version 3.
|
|
#
|
|
# Copyright (C) 2023 New Vector, Ltd
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU Affero General Public License as
|
|
# published by the Free Software Foundation, either version 3 of the
|
|
# License, or (at your option) any later version.
|
|
#
|
|
# See the GNU Affero General Public License for more details:
|
|
# <https://www.gnu.org/licenses/agpl-3.0.html>.
|
|
#
|
|
# Originally licensed under the Apache License, Version 2.0:
|
|
# <http://www.apache.org/licenses/LICENSE-2.0>.
|
|
#
|
|
# [This file includes modifications made by New Vector Limited]
|
|
#
|
|
#
|
|
|
|
from collections import Counter
|
|
from typing import Any, Collection, Iterable, List, Mapping, Optional, Tuple, Type
|
|
|
|
import attr
|
|
|
|
from synapse.config._util import validate_config
|
|
from synapse.config.sso import SsoAttributeRequirement
|
|
from synapse.types import JsonDict
|
|
from synapse.util.module_loader import load_module
|
|
from synapse.util.stringutils import parse_and_validate_mxc_uri
|
|
|
|
from ..util.check_dependencies import check_requirements
|
|
from ._base import Config, ConfigError, read_file
|
|
|
|
DEFAULT_USER_MAPPING_PROVIDER = "synapse.handlers.oidc.JinjaOidcMappingProvider"
|
|
# The module that JinjaOidcMappingProvider is in was renamed, we want to
|
|
# transparently handle both the same.
|
|
LEGACY_USER_MAPPING_PROVIDER = "synapse.handlers.oidc_handler.JinjaOidcMappingProvider"
|
|
|
|
|
|
class OIDCConfig(Config):
|
|
section = "oidc"
|
|
|
|
def read_config(self, config: JsonDict, **kwargs: Any) -> None:
|
|
self.oidc_providers = tuple(_parse_oidc_provider_configs(config))
|
|
if not self.oidc_providers:
|
|
return
|
|
|
|
check_requirements("oidc")
|
|
|
|
# check we don't have any duplicate idp_ids now. (The SSO handler will also
|
|
# check for duplicates when the REST listeners get registered, but that happens
|
|
# after synapse has forked so doesn't give nice errors.)
|
|
c = Counter([i.idp_id for i in self.oidc_providers])
|
|
for idp_id, count in c.items():
|
|
if count > 1:
|
|
raise ConfigError(
|
|
"Multiple OIDC providers have the idp_id %r." % idp_id
|
|
)
|
|
|
|
public_baseurl = self.root.server.public_baseurl
|
|
self.oidc_callback_url = public_baseurl + "_synapse/client/oidc/callback"
|
|
|
|
@property
|
|
def oidc_enabled(self) -> bool:
|
|
# OIDC is enabled if we have a provider
|
|
return bool(self.oidc_providers)
|
|
|
|
|
|
# jsonschema definition of the configuration settings for an oidc identity provider
|
|
OIDC_PROVIDER_CONFIG_SCHEMA = {
|
|
"type": "object",
|
|
"required": ["issuer", "client_id"],
|
|
"properties": {
|
|
"idp_id": {
|
|
"type": "string",
|
|
"minLength": 1,
|
|
# MSC2858 allows a maxlen of 255, but we prefix with "oidc-"
|
|
"maxLength": 250,
|
|
"pattern": "^[A-Za-z0-9._~-]+$",
|
|
},
|
|
"idp_name": {"type": "string"},
|
|
"idp_icon": {"type": "string"},
|
|
"idp_brand": {
|
|
"type": "string",
|
|
"minLength": 1,
|
|
"maxLength": 255,
|
|
"pattern": "^[a-z][a-z0-9_.-]*$",
|
|
},
|
|
"discover": {"type": "boolean"},
|
|
"issuer": {"type": "string"},
|
|
"client_id": {"type": "string"},
|
|
"client_secret": {"type": "string"},
|
|
"client_secret_jwt_key": {
|
|
"type": "object",
|
|
"required": ["jwt_header"],
|
|
"oneOf": [
|
|
{"required": ["key"]},
|
|
{"required": ["key_file"]},
|
|
],
|
|
"properties": {
|
|
"key": {"type": "string"},
|
|
"key_file": {"type": "string"},
|
|
"jwt_header": {
|
|
"type": "object",
|
|
"required": ["alg"],
|
|
"properties": {
|
|
"alg": {"type": "string"},
|
|
},
|
|
"additionalProperties": {"type": "string"},
|
|
},
|
|
"jwt_payload": {
|
|
"type": "object",
|
|
"additionalProperties": {"type": "string"},
|
|
},
|
|
},
|
|
},
|
|
"client_auth_method": {
|
|
"type": "string",
|
|
# the following list is the same as the keys of
|
|
# authlib.oauth2.auth.ClientAuth.DEFAULT_AUTH_METHODS. We inline it
|
|
# to avoid importing authlib here.
|
|
"enum": ["client_secret_basic", "client_secret_post", "none"],
|
|
},
|
|
"pkce_method": {"type": "string", "enum": ["auto", "always", "never"]},
|
|
"scopes": {"type": "array", "items": {"type": "string"}},
|
|
"authorization_endpoint": {"type": "string"},
|
|
"token_endpoint": {"type": "string"},
|
|
"userinfo_endpoint": {"type": "string"},
|
|
"jwks_uri": {"type": "string"},
|
|
"skip_verification": {"type": "boolean"},
|
|
"backchannel_logout_enabled": {"type": "boolean"},
|
|
"backchannel_logout_ignore_sub": {"type": "boolean"},
|
|
"user_profile_method": {
|
|
"type": "string",
|
|
"enum": ["auto", "userinfo_endpoint"],
|
|
},
|
|
"allow_existing_users": {"type": "boolean"},
|
|
"user_mapping_provider": {"type": ["object", "null"]},
|
|
"attribute_requirements": {
|
|
"type": "array",
|
|
"items": SsoAttributeRequirement.JSON_SCHEMA,
|
|
},
|
|
"enable_registration": {"type": "boolean"},
|
|
},
|
|
}
|
|
|
|
# the same as OIDC_PROVIDER_CONFIG_SCHEMA, but with compulsory idp_id and idp_name
|
|
OIDC_PROVIDER_CONFIG_WITH_ID_SCHEMA = {
|
|
"allOf": [OIDC_PROVIDER_CONFIG_SCHEMA, {"required": ["idp_id", "idp_name"]}]
|
|
}
|
|
|
|
# the `oidc_providers` list can either be None (as it is in the default config), or
|
|
# a list of provider configs, each of which requires an explicit ID and name.
|
|
OIDC_PROVIDER_LIST_SCHEMA = {
|
|
"oneOf": [
|
|
{"type": "null"},
|
|
{"type": "array", "items": OIDC_PROVIDER_CONFIG_WITH_ID_SCHEMA},
|
|
]
|
|
}
|
|
|
|
# the `oidc_config` setting can either be None (which it used to be in the default
|
|
# config), or an object. If an object, it is ignored unless it has an "enabled: True"
|
|
# property.
|
|
#
|
|
# It's *possible* to represent this with jsonschema, but the resultant errors aren't
|
|
# particularly clear, so we just check for either an object or a null here, and do
|
|
# additional checks in the code.
|
|
OIDC_CONFIG_SCHEMA = {"oneOf": [{"type": "null"}, {"type": "object"}]}
|
|
|
|
# the top-level schema can contain an "oidc_config" and/or an "oidc_providers".
|
|
MAIN_CONFIG_SCHEMA = {
|
|
"type": "object",
|
|
"properties": {
|
|
"oidc_config": OIDC_CONFIG_SCHEMA,
|
|
"oidc_providers": OIDC_PROVIDER_LIST_SCHEMA,
|
|
},
|
|
}
|
|
|
|
|
|
def _parse_oidc_provider_configs(config: JsonDict) -> Iterable["OidcProviderConfig"]:
|
|
"""extract and parse the OIDC provider configs from the config dict
|
|
|
|
The configuration may contain either a single `oidc_config` object with an
|
|
`enabled: True` property, or a list of provider configurations under
|
|
`oidc_providers`, *or both*.
|
|
|
|
Returns a generator which yields the OidcProviderConfig objects
|
|
"""
|
|
validate_config(MAIN_CONFIG_SCHEMA, config, ())
|
|
|
|
for i, p in enumerate(config.get("oidc_providers") or []):
|
|
yield _parse_oidc_config_dict(p, ("oidc_providers", "<item %i>" % (i,)))
|
|
|
|
# for backwards-compatibility, it is also possible to provide a single "oidc_config"
|
|
# object with an "enabled: True" property.
|
|
oidc_config = config.get("oidc_config")
|
|
if oidc_config and oidc_config.get("enabled", False):
|
|
# MAIN_CONFIG_SCHEMA checks that `oidc_config` is an object, but not that
|
|
# it matches OIDC_PROVIDER_CONFIG_SCHEMA (see the comments on OIDC_CONFIG_SCHEMA
|
|
# above), so now we need to validate it.
|
|
validate_config(OIDC_PROVIDER_CONFIG_SCHEMA, oidc_config, ("oidc_config",))
|
|
yield _parse_oidc_config_dict(oidc_config, ("oidc_config",))
|
|
|
|
|
|
def _parse_oidc_config_dict(
|
|
oidc_config: JsonDict, config_path: Tuple[str, ...]
|
|
) -> "OidcProviderConfig":
|
|
"""Take the configuration dict and parse it into an OidcProviderConfig
|
|
|
|
Raises:
|
|
ConfigError if the configuration is malformed.
|
|
"""
|
|
ump_config = oidc_config.get("user_mapping_provider", {})
|
|
ump_config.setdefault("module", DEFAULT_USER_MAPPING_PROVIDER)
|
|
if ump_config.get("module") == LEGACY_USER_MAPPING_PROVIDER:
|
|
ump_config["module"] = DEFAULT_USER_MAPPING_PROVIDER
|
|
ump_config.setdefault("config", {})
|
|
|
|
(
|
|
user_mapping_provider_class,
|
|
user_mapping_provider_config,
|
|
) = load_module(ump_config, config_path + ("user_mapping_provider",))
|
|
|
|
# Ensure loaded user mapping module has defined all necessary methods
|
|
required_methods = [
|
|
"get_remote_user_id",
|
|
"map_user_attributes",
|
|
]
|
|
missing_methods = [
|
|
method
|
|
for method in required_methods
|
|
if not hasattr(user_mapping_provider_class, method)
|
|
]
|
|
if missing_methods:
|
|
raise ConfigError(
|
|
"Class %s is missing required "
|
|
"methods: %s"
|
|
% (
|
|
user_mapping_provider_class,
|
|
", ".join(missing_methods),
|
|
),
|
|
config_path + ("user_mapping_provider", "module"),
|
|
)
|
|
|
|
idp_id = oidc_config.get("idp_id", "oidc")
|
|
|
|
# prefix the given IDP with a prefix specific to the SSO mechanism, to avoid
|
|
# clashes with other mechs (such as SAML, CAS).
|
|
#
|
|
# We allow "oidc" as an exception so that people migrating from old-style
|
|
# "oidc_config" format (which has long used "oidc" as its idp_id) can migrate to
|
|
# a new-style "oidc_providers" entry without changing the idp_id for their provider
|
|
# (and thereby invalidating their user_external_ids data).
|
|
|
|
if idp_id != "oidc":
|
|
idp_id = "oidc-" + idp_id
|
|
|
|
# MSC2858 also specifies that the idp_icon must be a valid MXC uri
|
|
idp_icon = oidc_config.get("idp_icon")
|
|
if idp_icon is not None:
|
|
try:
|
|
parse_and_validate_mxc_uri(idp_icon)
|
|
except ValueError as e:
|
|
raise ConfigError(
|
|
"idp_icon must be a valid MXC URI", config_path + ("idp_icon",)
|
|
) from e
|
|
|
|
client_secret_jwt_key_config = oidc_config.get("client_secret_jwt_key")
|
|
client_secret_jwt_key: Optional[OidcProviderClientSecretJwtKey] = None
|
|
if client_secret_jwt_key_config is not None:
|
|
keyfile = client_secret_jwt_key_config.get("key_file")
|
|
if keyfile:
|
|
key = read_file(keyfile, config_path + ("client_secret_jwt_key",))
|
|
else:
|
|
key = client_secret_jwt_key_config["key"]
|
|
client_secret_jwt_key = OidcProviderClientSecretJwtKey(
|
|
key=key,
|
|
jwt_header=client_secret_jwt_key_config["jwt_header"],
|
|
jwt_payload=client_secret_jwt_key_config.get("jwt_payload", {}),
|
|
)
|
|
# parse attribute_requirements from config (list of dicts) into a list of SsoAttributeRequirement
|
|
attribute_requirements = [
|
|
SsoAttributeRequirement(**x)
|
|
for x in oidc_config.get("attribute_requirements", [])
|
|
]
|
|
|
|
# Read from either `client_secret_path` or `client_secret`. If both exist, error.
|
|
client_secret = oidc_config.get("client_secret")
|
|
client_secret_path = oidc_config.get("client_secret_path")
|
|
if client_secret_path is not None:
|
|
if client_secret is None:
|
|
client_secret = read_file(
|
|
client_secret_path, config_path + ("client_secret_path",)
|
|
).rstrip("\n")
|
|
else:
|
|
raise ConfigError(
|
|
"Cannot specify both client_secret and client_secret_path",
|
|
config_path + ("client_secret",),
|
|
)
|
|
|
|
# If no client secret is specified then the auth method must be None
|
|
client_auth_method = oidc_config.get("client_auth_method")
|
|
if client_secret is None and client_secret_jwt_key is None:
|
|
if client_auth_method is None:
|
|
client_auth_method = "none"
|
|
elif client_auth_method != "none":
|
|
raise ConfigError(
|
|
"No 'client_secret' is set in OIDC config, and 'client_auth_method' is not set to 'none'"
|
|
)
|
|
|
|
if client_auth_method is None:
|
|
client_auth_method = "client_secret_basic"
|
|
|
|
return OidcProviderConfig(
|
|
idp_id=idp_id,
|
|
idp_name=oidc_config.get("idp_name", "OIDC"),
|
|
idp_icon=idp_icon,
|
|
idp_brand=oidc_config.get("idp_brand"),
|
|
discover=oidc_config.get("discover", True),
|
|
issuer=oidc_config["issuer"],
|
|
client_id=oidc_config["client_id"],
|
|
client_secret=client_secret,
|
|
client_secret_jwt_key=client_secret_jwt_key,
|
|
client_auth_method=client_auth_method,
|
|
pkce_method=oidc_config.get("pkce_method", "auto"),
|
|
scopes=oidc_config.get("scopes", ["openid"]),
|
|
authorization_endpoint=oidc_config.get("authorization_endpoint"),
|
|
token_endpoint=oidc_config.get("token_endpoint"),
|
|
userinfo_endpoint=oidc_config.get("userinfo_endpoint"),
|
|
jwks_uri=oidc_config.get("jwks_uri"),
|
|
backchannel_logout_enabled=oidc_config.get("backchannel_logout_enabled", False),
|
|
backchannel_logout_ignore_sub=oidc_config.get(
|
|
"backchannel_logout_ignore_sub", False
|
|
),
|
|
skip_verification=oidc_config.get("skip_verification", False),
|
|
user_profile_method=oidc_config.get("user_profile_method", "auto"),
|
|
allow_existing_users=oidc_config.get("allow_existing_users", False),
|
|
user_mapping_provider_class=user_mapping_provider_class,
|
|
user_mapping_provider_config=user_mapping_provider_config,
|
|
attribute_requirements=attribute_requirements,
|
|
enable_registration=oidc_config.get("enable_registration", True),
|
|
)
|
|
|
|
|
|
@attr.s(slots=True, frozen=True, auto_attribs=True)
|
|
class OidcProviderClientSecretJwtKey:
|
|
# a pem-encoded signing key
|
|
key: str
|
|
|
|
# properties to include in the JWT header
|
|
jwt_header: Mapping[str, str]
|
|
|
|
# properties to include in the JWT payload.
|
|
jwt_payload: Mapping[str, str]
|
|
|
|
|
|
@attr.s(slots=True, frozen=True, auto_attribs=True)
|
|
class OidcProviderConfig:
|
|
# a unique identifier for this identity provider. Used in the 'user_external_ids'
|
|
# table, as well as the query/path parameter used in the login protocol.
|
|
idp_id: str
|
|
|
|
# user-facing name for this identity provider.
|
|
idp_name: str
|
|
|
|
# Optional MXC URI for icon for this IdP.
|
|
idp_icon: Optional[str]
|
|
|
|
# Optional brand identifier for this IdP.
|
|
idp_brand: Optional[str]
|
|
|
|
# whether the OIDC discovery mechanism is used to discover endpoints
|
|
discover: bool
|
|
|
|
# the OIDC issuer. Used to validate tokens and (if discovery is enabled) to
|
|
# discover the provider's endpoints.
|
|
issuer: str
|
|
|
|
# oauth2 client id to use
|
|
client_id: str
|
|
|
|
# oauth2 client secret to use. if `None`, use client_secret_jwt_key to generate
|
|
# a secret.
|
|
client_secret: Optional[str]
|
|
|
|
# key to use to construct a JWT to use as a client secret. May be `None` if
|
|
# `client_secret` is set.
|
|
client_secret_jwt_key: Optional[OidcProviderClientSecretJwtKey]
|
|
|
|
# auth method to use when exchanging the token.
|
|
# Valid values are 'client_secret_basic', 'client_secret_post' and
|
|
# 'none'.
|
|
client_auth_method: str
|
|
|
|
# Whether to enable PKCE when exchanging the authorization & token.
|
|
# Valid values are 'auto', 'always', and 'never'.
|
|
pkce_method: str
|
|
|
|
# list of scopes to request
|
|
scopes: Collection[str]
|
|
|
|
# the oauth2 authorization endpoint. Required if discovery is disabled.
|
|
authorization_endpoint: Optional[str]
|
|
|
|
# the oauth2 token endpoint. Required if discovery is disabled.
|
|
token_endpoint: Optional[str]
|
|
|
|
# the OIDC userinfo endpoint. Required if discovery is disabled and the
|
|
# "openid" scope is not requested.
|
|
userinfo_endpoint: Optional[str]
|
|
|
|
# URI where to fetch the JWKS. Required if discovery is disabled and the
|
|
# "openid" scope is used.
|
|
jwks_uri: Optional[str]
|
|
|
|
# Whether Synapse should react to backchannel logouts
|
|
backchannel_logout_enabled: bool
|
|
|
|
# Whether Synapse should ignore the `sub` claim in backchannel logouts or not.
|
|
backchannel_logout_ignore_sub: bool
|
|
|
|
# Whether to skip metadata verification
|
|
skip_verification: bool
|
|
|
|
# Whether to fetch the user profile from the userinfo endpoint. Valid
|
|
# values are: "auto" or "userinfo_endpoint".
|
|
user_profile_method: str
|
|
|
|
# whether to allow a user logging in via OIDC to match a pre-existing account
|
|
# instead of failing
|
|
allow_existing_users: bool
|
|
|
|
# the class of the user mapping provider
|
|
user_mapping_provider_class: Type
|
|
|
|
# the config of the user mapping provider
|
|
user_mapping_provider_config: Any
|
|
|
|
# required attributes to require in userinfo to allow login/registration
|
|
attribute_requirements: List[SsoAttributeRequirement]
|
|
|
|
# Whether automatic registrations are enabled in the ODIC flow. Defaults to True
|
|
enable_registration: bool
|