synapse/changelog.d/5686.feature at ad167c384903f1e581267faf0d477eebf708a8ee - MirrorHub/synapse - tilera Git

MirrorHub/synapse

mirror of https://mau.dev/maunium/synapse.git synced 2024-11-11 20:42:23 +01:00

Andrew Morgan 72167fb394

Change user deactivated errcode to USER_DEACTIVATED and use it (#5686 )

This is intended as an amendment to #5674 as using M_UNKNOWN as the errcode makes it hard for clients to differentiate between an invalid password and a deactivated user (the problem we were trying to solve in the first place).

M_UNKNOWN was originally chosen as it was presumed than an MSC would have to be carried out to add a new code, but as Synapse often is the testing bed for new MSC implementations, it makes sense to try it out first in the wild and then add it into the spec if it is successful. Thus this PR return a new M_USER_DEACTIVATED code when a deactivated user attempts to login.

2019-07-31 15:19:06 +01:00

1 line

103 B

Gherkin

Raw Blame History

Use `M_USER_DEACTIVATED` instead of `M_UNKNOWN` for errcode when a deactivated user attempts to login.