synapse/changelog.d/9358.misc at ad8589d39254559b3eb4f38c528f8fc827dc4763 - MirrorHub/synapse - tilera Git

MirrorHub/synapse

mirror of https://mau.dev/maunium/synapse.git synced 2024-07-11 13:48:50 +02:00

Jonathan de Jong f5c93fc993

Fix #8518 (sync requests being cached wrongly on timeout) (#9358 )

This fixes #8518 by adding a conditional check on `SyncResult` in a function when `prev_stream_token == current_stream_token`, as a sanity check. In `CachedResponse.set.<remove>()`, the result is immediately popped from the cache if the conditional function returns "false".

This prevents the caching of a timed-out `SyncResult` (that has `next_key` as the stream key that produced that `SyncResult`). The cache is prevented from returning a `SyncResult` that makes the client request the same stream key over and over again, effectively making it stuck in a loop of requesting and getting a response immediately for as long as the cache keeps those values.

Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>

2021-02-24 13:57:00 +00:00

1 line

70 B

Plaintext

Raw Blame History

Added a fix that invalidates cache for empty timed-out sync responses.