0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-12-14 05:03:45 +01:00
synapse/rust
Patrick Cloke e746f80b4f
Do not accept pattern_type from user input in push rules. (#15088)
Internally the push rules module uses a `pattern_type` property for `event_match`
conditions (and `related_event_match`) to mark the condition as matching the
current user's Matrix ID or localpart.

This is leaky to the Client-Server API where a user can successfully set a condition
which provides `pattern_type` instead of `pattern` (note that there's no benefit to
doing this -- the user can just use their own Matrix ID or localpart instead). When
serializing back to the client the `pattern_type` property is converted into a proper
`pattern`.

The following changes are made to avoid this:

* Separate the `KnownCondition::EventMatch` enum value into `EventMatch`
  and `EventMatchType`, each with their own expected properties. (Note that a
  similar change is made for `RelatedEventMatch`.)
* Make it such that the `pattern_type` variants serialize to the same condition kind,
  but cannot be deserialized (since they're only provided by base rules).
* As a final tweak, convert `user_id` vs. `user_localpart` values into an enum.
2023-02-28 10:11:20 -05:00
..
benches Do not accept pattern_type from user input in push rules. (#15088) 2023-02-28 10:11:20 -05:00
src Do not accept pattern_type from user input in push rules. (#15088) 2023-02-28 10:11:20 -05:00
build.rs Implement push rule evaluation in Rust. (#13838) 2022-09-29 16:12:09 +01:00
Cargo.toml Update pyo3-log to v0.8.1 (#15043) 2023-02-13 12:25:56 +00:00