mirror of
https://mau.dev/maunium/synapse.git
synced 2024-07-10 05:08:58 +02:00
2efd050c9d
This fixed the weirdness of 400 vs 404 as http status code in the case the filter id is not known by the server. As e.g. matrix-js-sdk expects 404 to catch this situation this leads to unwanted behaviour.
116 lines
4 KiB
Python
116 lines
4 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Copyright 2015, 2016 OpenMarket Ltd
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
from synapse.api.errors import Codes
|
|
from synapse.rest.client.v2_alpha import filter
|
|
|
|
from tests import unittest
|
|
|
|
PATH_PREFIX = "/_matrix/client/v2_alpha"
|
|
|
|
|
|
class FilterTestCase(unittest.HomeserverTestCase):
|
|
|
|
user_id = "@apple:test"
|
|
hijack_auth = True
|
|
EXAMPLE_FILTER = {"room": {"timeline": {"types": ["m.room.message"]}}}
|
|
EXAMPLE_FILTER_JSON = b'{"room": {"timeline": {"types": ["m.room.message"]}}}'
|
|
servlets = [filter.register_servlets]
|
|
|
|
def prepare(self, reactor, clock, hs):
|
|
self.filtering = hs.get_filtering()
|
|
self.store = hs.get_datastore()
|
|
|
|
def test_add_filter(self):
|
|
request, channel = self.make_request(
|
|
"POST",
|
|
"/_matrix/client/r0/user/%s/filter" % (self.user_id),
|
|
self.EXAMPLE_FILTER_JSON,
|
|
)
|
|
self.render(request)
|
|
|
|
self.assertEqual(channel.result["code"], b"200")
|
|
self.assertEqual(channel.json_body, {"filter_id": "0"})
|
|
filter = self.store.get_user_filter(user_localpart="apple", filter_id=0)
|
|
self.pump()
|
|
self.assertEquals(filter.result, self.EXAMPLE_FILTER)
|
|
|
|
def test_add_filter_for_other_user(self):
|
|
request, channel = self.make_request(
|
|
"POST",
|
|
"/_matrix/client/r0/user/%s/filter" % ("@watermelon:test"),
|
|
self.EXAMPLE_FILTER_JSON,
|
|
)
|
|
self.render(request)
|
|
|
|
self.assertEqual(channel.result["code"], b"403")
|
|
self.assertEquals(channel.json_body["errcode"], Codes.FORBIDDEN)
|
|
|
|
def test_add_filter_non_local_user(self):
|
|
_is_mine = self.hs.is_mine
|
|
self.hs.is_mine = lambda target_user: False
|
|
request, channel = self.make_request(
|
|
"POST",
|
|
"/_matrix/client/r0/user/%s/filter" % (self.user_id),
|
|
self.EXAMPLE_FILTER_JSON,
|
|
)
|
|
self.render(request)
|
|
|
|
self.hs.is_mine = _is_mine
|
|
self.assertEqual(channel.result["code"], b"403")
|
|
self.assertEquals(channel.json_body["errcode"], Codes.FORBIDDEN)
|
|
|
|
def test_get_filter(self):
|
|
filter_id = self.filtering.add_user_filter(
|
|
user_localpart="apple", user_filter=self.EXAMPLE_FILTER
|
|
)
|
|
self.reactor.advance(1)
|
|
filter_id = filter_id.result
|
|
request, channel = self.make_request(
|
|
"GET", "/_matrix/client/r0/user/%s/filter/%s" % (self.user_id, filter_id)
|
|
)
|
|
self.render(request)
|
|
|
|
self.assertEqual(channel.result["code"], b"200")
|
|
self.assertEquals(channel.json_body, self.EXAMPLE_FILTER)
|
|
|
|
def test_get_filter_non_existant(self):
|
|
request, channel = self.make_request(
|
|
"GET", "/_matrix/client/r0/user/%s/filter/12382148321" % (self.user_id)
|
|
)
|
|
self.render(request)
|
|
|
|
self.assertEqual(channel.result["code"], b"404")
|
|
self.assertEquals(channel.json_body["errcode"], Codes.NOT_FOUND)
|
|
|
|
# Currently invalid params do not have an appropriate errcode
|
|
# in errors.py
|
|
def test_get_filter_invalid_id(self):
|
|
request, channel = self.make_request(
|
|
"GET", "/_matrix/client/r0/user/%s/filter/foobar" % (self.user_id)
|
|
)
|
|
self.render(request)
|
|
|
|
self.assertEqual(channel.result["code"], b"400")
|
|
|
|
# No ID also returns an invalid_id error
|
|
def test_get_filter_no_id(self):
|
|
request, channel = self.make_request(
|
|
"GET", "/_matrix/client/r0/user/%s/filter/" % (self.user_id)
|
|
)
|
|
self.render(request)
|
|
|
|
self.assertEqual(channel.result["code"], b"400")
|