mirror of
https://mau.dev/maunium/synapse.git
synced 2024-12-15 07:23:52 +01:00
39230d2171
* Pull Sentinel out of LoggingContext ... and drop a few unnecessary references to it * Factor out LoggingContext.current_context move `current_context` and `set_context` out to top-level functions. Mostly this means that I can more easily trace what's actually referring to LoggingContext, but I think it's generally neater. * move copy-to-parent into `stop` this really just makes `start` and `stop` more symetric. It also means that it behaves correctly if you manually `set_log_context` rather than using the context manager. * Replace `LoggingContext.alive` with `finished` Turn `alive` into `finished` and make it a bit better defined.
221 lines
6.9 KiB
Python
221 lines
6.9 KiB
Python
import twisted.python.failure
|
|
from twisted.internet import defer, reactor
|
|
|
|
from synapse.logging.context import (
|
|
SENTINEL_CONTEXT,
|
|
LoggingContext,
|
|
PreserveLoggingContext,
|
|
current_context,
|
|
make_deferred_yieldable,
|
|
nested_logging_context,
|
|
run_in_background,
|
|
)
|
|
from synapse.util import Clock
|
|
|
|
from .. import unittest
|
|
|
|
|
|
class LoggingContextTestCase(unittest.TestCase):
|
|
def _check_test_key(self, value):
|
|
self.assertEquals(current_context().request, value)
|
|
|
|
def test_with_context(self):
|
|
with LoggingContext() as context_one:
|
|
context_one.request = "test"
|
|
self._check_test_key("test")
|
|
|
|
@defer.inlineCallbacks
|
|
def test_sleep(self):
|
|
clock = Clock(reactor)
|
|
|
|
@defer.inlineCallbacks
|
|
def competing_callback():
|
|
with LoggingContext() as competing_context:
|
|
competing_context.request = "competing"
|
|
yield clock.sleep(0)
|
|
self._check_test_key("competing")
|
|
|
|
reactor.callLater(0, competing_callback)
|
|
|
|
with LoggingContext() as context_one:
|
|
context_one.request = "one"
|
|
yield clock.sleep(0)
|
|
self._check_test_key("one")
|
|
|
|
def _test_run_in_background(self, function):
|
|
sentinel_context = current_context()
|
|
|
|
callback_completed = [False]
|
|
|
|
with LoggingContext() as context_one:
|
|
context_one.request = "one"
|
|
|
|
# fire off function, but don't wait on it.
|
|
d2 = run_in_background(function)
|
|
|
|
def cb(res):
|
|
callback_completed[0] = True
|
|
return res
|
|
|
|
d2.addCallback(cb)
|
|
|
|
self._check_test_key("one")
|
|
|
|
# now wait for the function under test to have run, and check that
|
|
# the logcontext is left in a sane state.
|
|
d2 = defer.Deferred()
|
|
|
|
def check_logcontext():
|
|
if not callback_completed[0]:
|
|
reactor.callLater(0.01, check_logcontext)
|
|
return
|
|
|
|
# make sure that the context was reset before it got thrown back
|
|
# into the reactor
|
|
try:
|
|
self.assertIs(current_context(), sentinel_context)
|
|
d2.callback(None)
|
|
except BaseException:
|
|
d2.errback(twisted.python.failure.Failure())
|
|
|
|
reactor.callLater(0.01, check_logcontext)
|
|
|
|
# test is done once d2 finishes
|
|
return d2
|
|
|
|
def test_run_in_background_with_blocking_fn(self):
|
|
@defer.inlineCallbacks
|
|
def blocking_function():
|
|
yield Clock(reactor).sleep(0)
|
|
|
|
return self._test_run_in_background(blocking_function)
|
|
|
|
def test_run_in_background_with_non_blocking_fn(self):
|
|
@defer.inlineCallbacks
|
|
def nonblocking_function():
|
|
with PreserveLoggingContext():
|
|
yield defer.succeed(None)
|
|
|
|
return self._test_run_in_background(nonblocking_function)
|
|
|
|
def test_run_in_background_with_chained_deferred(self):
|
|
# a function which returns a deferred which looks like it has been
|
|
# called, but is actually paused
|
|
def testfunc():
|
|
return make_deferred_yieldable(_chained_deferred_function())
|
|
|
|
return self._test_run_in_background(testfunc)
|
|
|
|
def test_run_in_background_with_coroutine(self):
|
|
async def testfunc():
|
|
self._check_test_key("one")
|
|
d = Clock(reactor).sleep(0)
|
|
self.assertIs(current_context(), SENTINEL_CONTEXT)
|
|
await d
|
|
self._check_test_key("one")
|
|
|
|
return self._test_run_in_background(testfunc)
|
|
|
|
def test_run_in_background_with_nonblocking_coroutine(self):
|
|
async def testfunc():
|
|
self._check_test_key("one")
|
|
|
|
return self._test_run_in_background(testfunc)
|
|
|
|
@defer.inlineCallbacks
|
|
def test_make_deferred_yieldable(self):
|
|
# a function which retuns an incomplete deferred, but doesn't follow
|
|
# the synapse rules.
|
|
def blocking_function():
|
|
d = defer.Deferred()
|
|
reactor.callLater(0, d.callback, None)
|
|
return d
|
|
|
|
sentinel_context = current_context()
|
|
|
|
with LoggingContext() as context_one:
|
|
context_one.request = "one"
|
|
|
|
d1 = make_deferred_yieldable(blocking_function())
|
|
# make sure that the context was reset by make_deferred_yieldable
|
|
self.assertIs(current_context(), sentinel_context)
|
|
|
|
yield d1
|
|
|
|
# now it should be restored
|
|
self._check_test_key("one")
|
|
|
|
@defer.inlineCallbacks
|
|
def test_make_deferred_yieldable_with_chained_deferreds(self):
|
|
sentinel_context = current_context()
|
|
|
|
with LoggingContext() as context_one:
|
|
context_one.request = "one"
|
|
|
|
d1 = make_deferred_yieldable(_chained_deferred_function())
|
|
# make sure that the context was reset by make_deferred_yieldable
|
|
self.assertIs(current_context(), sentinel_context)
|
|
|
|
yield d1
|
|
|
|
# now it should be restored
|
|
self._check_test_key("one")
|
|
|
|
@defer.inlineCallbacks
|
|
def test_make_deferred_yieldable_on_non_deferred(self):
|
|
"""Check that make_deferred_yieldable does the right thing when its
|
|
argument isn't actually a deferred"""
|
|
|
|
with LoggingContext() as context_one:
|
|
context_one.request = "one"
|
|
|
|
d1 = make_deferred_yieldable("bum")
|
|
self._check_test_key("one")
|
|
|
|
r = yield d1
|
|
self.assertEqual(r, "bum")
|
|
self._check_test_key("one")
|
|
|
|
def test_nested_logging_context(self):
|
|
with LoggingContext(request="foo"):
|
|
nested_context = nested_logging_context(suffix="bar")
|
|
self.assertEqual(nested_context.request, "foo-bar")
|
|
|
|
@defer.inlineCallbacks
|
|
def test_make_deferred_yieldable_with_await(self):
|
|
# an async function which retuns an incomplete coroutine, but doesn't
|
|
# follow the synapse rules.
|
|
|
|
async def blocking_function():
|
|
d = defer.Deferred()
|
|
reactor.callLater(0, d.callback, None)
|
|
await d
|
|
|
|
sentinel_context = current_context()
|
|
|
|
with LoggingContext() as context_one:
|
|
context_one.request = "one"
|
|
|
|
d1 = make_deferred_yieldable(blocking_function())
|
|
# make sure that the context was reset by make_deferred_yieldable
|
|
self.assertIs(current_context(), sentinel_context)
|
|
|
|
yield d1
|
|
|
|
# now it should be restored
|
|
self._check_test_key("one")
|
|
|
|
|
|
# a function which returns a deferred which has been "called", but
|
|
# which had a function which returned another incomplete deferred on
|
|
# its callback list, so won't yet call any other new callbacks.
|
|
def _chained_deferred_function():
|
|
d = defer.succeed(None)
|
|
|
|
def cb(res):
|
|
d2 = defer.Deferred()
|
|
reactor.callLater(0, d2.callback, res)
|
|
return d2
|
|
|
|
d.addCallback(cb)
|
|
return d
|