cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Minor simplification of code

Browse source
This commit is contained in:
Toshio Kuratomi 2015-11-23 16:23:41 -08:00 committed by Matt Clay
parent 3969bba771
commit a90de29ceb
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/ansible/modules/cloud/amazon/ec2.py
View file

@ -888,9 +888,9 @@ def create_instances(module, ec2, vpc, override_count=None):
grp_details = ec2.get_all_security_groups() grp_details = ec2.get_all_security_groups()
if isinstance(group_name, basestring): if isinstance(group_name, basestring):
group_name = [group_name] group_name = [group_name]
unmatched = list(set(group_name) - set([str(grp.name) for grp in grp_details])) unmatched = set(group_name).difference(str(grp.name) for grp in grp_details)
if len(unmatched) > 0: if len(unmatched) > 0:
module.fail_json(msg="the following group names are not valid: %s" % ','.join(unmatched)) module.fail_json(msg="The following group names are not valid: %s" % ', '.join(unmatched))
group_id = [ str(grp.id) for grp in grp_details if str(grp.name) in group_name ] group_id = [ str(grp.id) for grp in grp_details if str(grp.name) in group_name ]
# Now we try to lookup the group id testing if group exists. # Now we try to lookup the group id testing if group exists.
elif group_id: elif group_id: