cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

remove checking of stderr for insserv (#1846)

Browse source 
stderr of insserv can also contain warnings which can be ignored. checking rc only is more accurate.
fixes #1502
This commit is contained in:
TheSameCH 2016-05-05 04:09:55 +02:00 committed by Matt Clay
parent 985abd2020
commit ca8bf6ab4c
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/ansible/modules/system/service.py
View file

@ -826,12 +826,12 @@ class LinuxService(Service):
if self.enable: if self.enable:
(rc, out, err) = self.execute_command("%s %s" % (self.enable_cmd, self.name)) (rc, out, err) = self.execute_command("%s %s" % (self.enable_cmd, self.name))
if (rc != 0) or (err != ''): if (rc != 0):
self.module.fail_json(msg=("Failed to install service. rc: %s, out: %s, err: %s" % (rc, out, err))) self.module.fail_json(msg=("Failed to install service. rc: %s, out: %s, err: %s" % (rc, out, err)))
return (rc, out, err) return (rc, out, err)
else: else:
(rc, out, err) = self.execute_command("%s -r %s" % (self.enable_cmd, self.name)) (rc, out, err) = self.execute_command("%s -r %s" % (self.enable_cmd, self.name))
if (rc != 0) or (err != ''): if (rc != 0):
self.module.fail_json(msg=("Failed to remove service. rc: %s, out: %s, err: %s" % (rc, out, err))) self.module.fail_json(msg=("Failed to remove service. rc: %s, out: %s, err: %s" % (rc, out, err)))
return (rc, out, err) return (rc, out, err)