cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Ovirt host network dict correct (#64437)

Browse source 
* ovirt_host_network: correct comparing of two dicts

* update mode_number for 4th option
This commit is contained in:
Martin Nečas 2019-11-05 14:22:17 +01:00 • committed by ansibot
parent 484943cbd1
commit d9f5be8d0d
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/ansible/modules/cloud/ovirt/ovirt_host_network.py
View file

@ -214,7 +214,7 @@ def get_bond_options(mode, usr_opts):
None, None,
'Dynamic link aggregation (802.3ad)', 'Dynamic link aggregation (802.3ad)',
] ]
if (not 0 < mode_number <= len(modes) - 1): if (not 0 < mode_number <= len(modes)):
return None return None
return modes[mode_number - 1] return modes[mode_number - 1]
@ -245,7 +245,9 @@ def get_bond_options(mode, usr_opts):
class HostNetworksModule(BaseModule): class HostNetworksModule(BaseModule):
def __compare_options(self, new_options, old_options): def __compare_options(self, new_options, old_options):
return sorted(get_dict_of_struct(opt) for opt in new_options) != sorted(get_dict_of_struct(opt) for opt in old_options) return sorted((get_dict_of_struct(opt) for opt in new_options),
key=lambda x: x["name"]) != sorted((get_dict_of_struct(opt) for opt in old_options),
key=lambda x: x["name"])
def build_entity(self): def build_entity(self):
return otypes.Host() return otypes.Host()