Commit graph

7523 commits

Author SHA1 Message Date
Joseph Callen
0740753255 Resolves issue with vmware_vm_vss_dvs_migrate module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_vm_vss_dvs_migrate module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
- name: Migrate VCSA to vDS
      local_action:
        module: vmware_vm_vss_dvs_migrate
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        vm_name: "{{ hostname }}"
        dvportgroup_name: Management
```

Module Testing
```
ASK [Migrate VCSA to vDS] *****************************************************
task path: /opt/autodeploy/projects/emmet/site_deploy.yml:260
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859 )" )
localhost PUT /tmp/tmpkzD4pF TO /root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/vmware_vm_vss_dvs_migrate
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/vmware_vm_vss_dvs_migrate; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => {"changed": true, "invocation": {"module_args": {"dvportgroup_name": "Management", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root", "vm_name": "cscvcatmp001"}, "module_name": "vmware_vm_vss_dvs_migrate"}, "result": null}

```
2016-02-05 14:53:36 -05:00
Brian Coca
ff8806eaee Merge pull request #1601 from mixmatch/patch-1
Fix indent
2016-02-05 09:20:15 -05:00
Daniel Petty
a1c2cb0a2e Fix indent 2016-02-03 14:36:04 -07:00
Toshio Kuratomi
14a62fb5d6 Merge pull request #1415 from jtyr/jtyr-yumrepo_params
Adding params option into the yumrepo module
2016-02-02 13:53:39 -08:00
Toshio Kuratomi
73b7b70332 Merge pull request #1582 from caphrim007/fix-missing-validate-certs
Fixes missing validate_certs parameter
2016-02-02 13:47:25 -08:00
Toshio Kuratomi
ec5c03381b Merge pull request #1378 from johanwiren/fix_properties_handling
Fix zfs properties handling
2016-02-02 13:02:43 -08:00
Toshio Kuratomi
f6add50969 Merge pull request #1293 from gerph/gerph-fix-docs-patch
Update 'patch' documentation for src, remote_src, backup and binary.
2016-02-02 12:53:15 -08:00
Toshio Kuratomi
b1e9dc0b52 Allow dnf to remove dependent packages of a package that is being removed
Fixes #1517
2016-02-02 10:40:38 -08:00
Matt Martz
1b5c9ee7f9 Merge pull request #1584 from sivel/doc-fix-ec2_vpc_dhcp_options
DOCUMENTATION and RETURN fixes for modules
2016-02-02 10:02:48 -06:00
Matt Martz
d2e3909443 Fix DOCUMENTATION for ec2_vpc_dhcp_options.py and add missing RETURN to ec2_vol_facts.py 2016-02-02 10:00:51 -06:00
Brian Coca
9aac5784d3 Merge pull request #1565 from mjschultz/welex91
Ensure that port_path is split into at most 2 components.
2016-02-01 23:56:02 -05:00
Brian Coca
14f0ad07ab Merge pull request #1548 from vvanholl/devel
Do not fail when action is delete and volume is not present
2016-02-01 23:54:44 -05:00
Brian Coca
284032efff Merge pull request #1538 from bibliotechy/patch-1
Doc wrongly indicates firewalld permanent flag is required
2016-02-01 23:53:45 -05:00
Brian Coca
5b61c75fa5 added missing verison_added 2016-02-01 23:56:58 -05:00
Brian Coca
0f2cdbeee4 Merge pull request #1532 from mbobakov/devel
Add custom parameter for a sensu_check
2016-02-01 23:51:57 -05:00
Brian Coca
cd64f20034 added missing version_added 2016-02-01 23:55:41 -05:00
Brian Coca
ff554a76d7 Merge pull request #1402 from doalitic/iptables-add-limit-burst
Add limit-burst support to iptables module
2016-02-01 23:50:15 -05:00
Brian Coca
a2532862d8 Merge pull request #1330 from joelthompson/feature/ec2_vpc_dhcp_options
Add new ec2_vpc_dhcp_options module
2016-02-01 23:48:06 -05:00
Brian Coca
20caf29213 Merge pull request #1113 from shawnsi/vpc-route-table-continued
Additional check mode fixes for ec2_vpc_route_table module
2016-02-01 23:46:38 -05:00
Brian Coca
166133b1f8 Merge pull request #1111 from h0nIg/devel
win_acl: windows 2008 fix + special account fix + strict fix
2016-02-01 23:45:26 -05:00
Brian Coca
7e81c60c96 corrected version added 2016-02-01 23:49:05 -05:00
Brian Coca
76feff5b4d Merge pull request #1109 from wimnat/feature/ec2_vol_facts
New module - ec2_vol_facts
2016-02-01 23:43:27 -05:00
Brian Coca
3ca2c51ed9 Merge pull request #1077 from blakfeld/fix_win_unzip
Made win_unzip Powershell Strict Complient
2016-02-01 23:42:47 -05:00
Brian Coca
7c50f4cc8f Merge pull request #831 from viruxel/devel
Enable managing multiple user permissions from one shot
2016-02-01 23:36:36 -05:00
Tim Rupp
56a517b054 Fixes missing validate_certs parameter
The bigip_api method was changed in the module_utils function definition
to include the validate_certs option but the bigip_virtual_server module
was not updated accordingly. This patch updates the method so that the
error message below is not returned to the user

received exception: bigip_api() takes exactly 4 arguments (3 given)
2016-02-01 16:27:09 -08:00
Brian Coca
bec32094ae Merge pull request #1577 from bmillemathias/patch-2
fix typo
2016-02-01 10:25:16 -05:00
Jiri Tyr
7f918b375f Adding params option into the yumrepo module 2016-02-01 13:13:35 +00:00
Baptiste Mille-Mathias
a11220228c fix typo
conainerization => containerization
2016-01-31 20:05:45 +01:00
Brian Coca
fff5ae6994 Merge pull request #1567 from danieljakots/devel
fix the spelling of vim's flavor in the example
2016-01-28 15:59:40 -05:00
Daniel Jakots
d24721f651 fix the spelling of vim's flavor in the example 2016-01-28 21:54:25 +01:00
Toshio Kuratomi
36be779888 Remove duplicate documentation fields 2016-01-28 09:20:55 -08:00
Brian Coca
eaec3cb45f Merge pull request #1564 from dalees/devel
Fix regression of #821 in puppet of show_diff
2016-01-28 12:05:22 -05:00
Sumit Roy
acc51c2944 Ensure that port_path is split into at most 2 components.
cloudstack: cs_instance: fix do not require name to be set to avoid clashes

Require one of display_name or name. If both is given, name is used as identifier.

cloudstack: fix name is not case insensitive

cloudstack: cs_template: implement state=extracted

Update f5 validate_certs functionality to do the right thing on multiple python versions

This requires the implementation in the module_utils code here
https://github.com/ansible/ansible/pull/13667 to funciton

fixed domain_id to actually be supported

also added domain as an alias
alt fixes #1437

Simplify the code and remove use_unsafe_shell=True

While there is no security issue with this shell snippet, it
is better to not rely on shell and avoid use_unsafe_shell.

Fix for issue #1074. Now able to create volume without replica's.

Improved fix for #1074. Both None and '' transform to fqdn.

Fix for ansible-modules-extras issue #1080
2016-01-28 11:02:34 -06:00
Dale Smith
27cd172900 Fix regression of #821 in puppet of show_diff
Issue #821 fix: 1382576100
Regressed since: 6912ca0aca

Issue: #821
2016-01-28 15:48:18 +00:00
Mstislav Bobakov
c4aa5ee024 Add custom parameter for a sensu_check. revert newline 2016-01-28 15:44:57 +03:00
Mstislav Bobakov
6ef3697c52 Add custom parameter for a sensu_check. Fixes.
JSON replaced within dict.
Added more docs.
2016-01-28 15:42:09 +03:00
Brian Coca
7eb3d6e15b Merge pull request #1559 from apenney/more-fixes
DOCS: Fix package list for nmcli module.
2016-01-26 14:17:20 -05:00
Ashley Penney
25262c2238 Fix package list for nmcli module.
There was a missing package that causes this to fail.
2016-01-26 13:38:44 -05:00
Brian Coca
3ed8a2ff67 Merge pull request #1558 from apenney/fix-mtu-docs
Change example to include ethernet as the type.
2016-01-26 11:28:23 -05:00
Ashley Penney
f5bfc4f9e9 Change example to include ethernet as the type. 2016-01-26 11:18:43 -05:00
Brian Coca
cecff17de3 Merge pull request #1513 from AbletonDevTools/devel
Fix #1512 add missing property in win_firewall_rule
2016-01-26 00:01:32 -05:00
Brian Coca
33213dbc24 Merge pull request #1508 from RajeevNambiar/devel
Update sts_assume_role.py for showing the correct example syntax role…
2016-01-26 00:00:49 -05:00
Brian Coca
ffefe5dde8 Merge pull request #1505 from Yannig/devel_fix_pvcreate
Use -f when pvcreate to avoid interactive input.
2016-01-26 00:00:00 -05:00
Brian Coca
98eeb689ce Merge pull request #1514 from doalitic/iptables-fix-append_csv
iptables: fix param check in append_csv function
2016-01-25 23:58:54 -05:00
Brian Coca
a7ad0bc7be Merge pull request #1499 from specnazzz/fix-seport-ports
seport module fails when the `ports` argument is a integer
2016-01-25 23:57:54 -05:00
Brian Coca
ec8bf56448 Merge pull request #1493 from abulimov/filesystem_recreate_with_force
Allow recreation of same FS with force=yes in filesystem module
2016-01-25 23:57:04 -05:00
Brian Coca
1f2b6bf3fd Merge pull request #1492 from alxgu/filesystem_idemponent
Make fileystem module idemponent. Compare devicesize and filesystemsize.
2016-01-25 23:55:34 -05:00
Brian Coca
65686221af Merge pull request #1488 from robbwagoner/ec2-elb-facts-with-instance-health
Include instance states (InService or OutOfService) as ELB facts
2016-01-25 23:54:29 -05:00
Brian Coca
6dfad7d157 Merge pull request #923 from mliudev/fix-rabbitmq_user-list_users
Check that the current output from 'list_users' command contains a '\t'.
2016-01-25 23:47:27 -05:00
Brian Coca
7286ff5024 Merge pull request #1546 from wimnat/feature/missing-doc-fragment
Add missing doc fragments
2016-01-25 23:03:54 -05:00