Commit graph

38844 commits

Author SHA1 Message Date
Matt Martz
17c89d1ffa
Remove unused rslt_q, rename the one queue to final_q everywhere (#43894)
* Remove unused rslt_q, rename the one queue to final_q everywhere

* Test update
2018-08-13 13:43:28 -05:00
Nathaniel Case
5a49567c71
Fix iosxr copy and delete tasks (#44083)
* Fix iosxr copy and delete tasks

* Drop local from non-smoke tasks
2018-08-13 14:20:28 -04:00
Till Maas
bb85bbceeb pip: combine chdir and env only when env is set (#40793)
* pip: combine chdir and env only when env is set

This fixes an AttributeError when chdir without virtualenv is specified:

 File "/tmp/ansible_2UAFsZ/ansible_module_pip.py", line 387, in main
    env = os.path.join(chdir, env)
 File "/usr/lib64/python2.7/posixpath.py", line 75, in join
    if b.startswith('/'):
AttributeError: 'NoneType' object has no attribute 'startswith'

* Add test for pip with chdir

Signed-off-by: Till Maas <opensource@till.name>
2018-08-13 19:59:01 +02:00
Sumit Jaiswal
fd4e774cec
Resolves bug where existing host_record was deleted when existing record name is used with different IP (#43235)
* resolves bug 42937

* resolves integration test failure

* resolves integration test failure

* resolves integration test failure
2018-08-13 17:27:06 +00:00
Sam Doran
6d38167d49
Only template values in vars_prompt rather than all vars (#39304)
* Only template values in vars_prompt rather than all vars

This allows the use of variables in vars_prompt fields but allows variables entered in the prompt to affect play vars rather than throwing an undefined error.

Only post validate if there was a vars_prompt

* Add tests for vars_prompt
2018-08-13 12:54:31 -04:00
Stefan Prietl
d5662df695 Fix actions and wait in os_server_action module (#43504)
* Fix call to sdk.iterate_timeout in os_server_action

* Correct indentation for several actions in os_server_action
2018-08-13 12:52:20 -04:00
Zhikang Zhang
b20d903cc4 Give warning if user inputs not encrypted password to user module (#43615)
* Check the password format

Check the password format and notify user if they
input unencrypted password.

* Fix sanity error

* Add integration test

* Missed a task name

* Hard code the testing password

Since some testing platfrom has no passlib installed

* Add changelog fragment

* Rework some English sentences

* Fix a grammar mistake
2018-08-13 12:45:37 -04:00
Juan Jimenez
cceddfab9b Update lambda.py (#44066)
Timeout doesn't say if in secs, minutes or ??
2018-08-13 12:33:14 -04:00
Rene Moser
ec84c31ace cloudstack: update cloudstack-test-container to v1.1.0 2018-08-13 09:29:47 -07:00
Alex Stephen
50bd91b48b New GCP Module: gcp_compute_backend_service_facts (#44025) 2018-08-13 12:21:49 -04:00
Alex Stephen
fbfea59d7d Bug fixes for gcp_compute_ssl_certificate (#42821) 2018-08-13 12:15:15 -04:00
Alex Stephen
c38e1e5631 Bug fixes for gcp_container_cluster (#42829) 2018-08-13 12:15:02 -04:00
Alex Stephen
dd3c4b0d39 Bug fixes for gcp_pubsub_subscription (#42833) 2018-08-13 12:14:11 -04:00
Alex Stephen
3dc363d135 Bug fixes for gcp_storage_bucket_access_control (#42836) 2018-08-13 12:13:53 -04:00
Alex Stephen
7f10d432ec Bug fixes for gcp_container_node_pool (#42830) 2018-08-13 12:11:06 -04:00
Alex Stephen
7f981b4123 Bug fixes for gcp_dns_managed_zone (#42831) 2018-08-13 12:09:38 -04:00
Alex Stephen
2a346af18b Bug fixes for gcp_compute_instance_group_manager (#42817) 2018-08-13 12:09:23 -04:00
Alex Stephen
c239e6f045 Bug fixes for gcp_compute_https_health_check (#42813) 2018-08-13 12:08:42 -04:00
Alex Stephen
6b5f86a4aa Bug fixes for gcp_compute_image (#42814) 2018-08-13 12:08:12 -04:00
Alex Stephen
439716a832 Bug fixes for gcp_compute_health_check (#42811) 2018-08-13 12:07:24 -04:00
Alex Stephen
c8418a709b Bug fixes for gcp_compute_disk (#42806) 2018-08-13 12:04:57 -04:00
Alex Stephen
146c126780 Bug fixes for gcp_compute_global_address (#42809) 2018-08-13 12:02:10 -04:00
Alex Stephen
65df8834e8 Bug fixes for gcp_compute_forwarding_rule (#42808) 2018-08-13 12:00:11 -04:00
Mike Wiebe
8f75bb5799 nxos issu should abort when issu is not possible. (#43793)
* Use expect module to copy files

* Abort when issu not possible

* Update copy_kick_system_images.yaml

* Update platform/version support
2018-08-13 20:36:42 +05:30
Shuang Wang
11f02cbc8e promote me to a co-maintainer (#43864)
Promote me to a co-maintainer for get_url
2018-08-13 11:00:45 -04:00
Yanis Guenane
fd554e9d75 vultr.py: query_resource_by_key Handle list and dict (#43301)
The Vultr API is inconsistent in the type of the value it returns
based on the resources. While most of the time it will be a dict, for
some resources it will be a list (/v1/user/list, /v1/block/list).

query_resource_by_key() fails if the return value isn't a dict (.items()
does not exist on list). This patch aims to support both list and dict.
2018-08-13 16:59:27 +02:00
Herman
ed29cd7f44 add choices to documentaton for paramater flat (#43939) 2018-08-13 10:57:00 -04:00
Alex Stephen
d1399ec5a2 Bug fixes for gcp_compute_backend_service (#42805) 2018-08-13 10:55:21 -04:00
Alex Stephen
476e98e0cf Bug fixes for gcp_compute_backend_bucket (#42804) 2018-08-13 10:54:56 -04:00
Alex Stephen
4ecdf11aaa Bug fixes for gcp_compute_address (#42704) 2018-08-13 10:50:04 -04:00
Jonny McCullagh
aac668ee1f Update wait_for.py (#44071)
Removed the 'wait 300 seconds' from the examples that did not have the 300 sec timeout

+label: docsite_pr
2018-08-13 10:48:21 -04:00
Ian Wienand
e5dcebaa8e docs: remove "make viewdocs" reference (#43860)
The "viewdocs" target was removed in
0381bc170c681b6ea8a94467c62e0694e3d9029d; running "make webdocs" gets
you the output for initial testing purposes.
2018-08-13 10:39:09 -04:00
Toshio Kuratomi
a0e6ab09d1 Add note to the porting guide about why we're dropping python-2.6 controller support 2018-08-13 07:38:38 -07:00
Toshio Kuratomi
da26ba3760 Documentatin fixes 2018-08-13 07:38:38 -07:00
Toshio Kuratomi
c4951cce0b Exorcise Python-2.6 2018-08-13 07:38:38 -07:00
Nathaniel Case
a3385a60b4
httpapi: let httpapi plugin handle HTTPErrors other than 401 (#43436)
* Hold httpapi response in BytesIO

* Let httpapi plugin deal with HTTP codes if it wants

* Python 3.5 won't json.loads() bytes

* Don't modify headers passed to send

* Move code handling back to send()

but let httpapi plugin have a say on how it happens
2018-08-13 10:25:06 -04:00
Deepak Agrawal
65772ede26
Iosxr: integration test failure on devel (#44057) 2018-08-13 19:49:56 +05:30
Toshio Kuratomi
e2e44f846c Fix the local and ssh plugins for a cornercase retrying a syscall
The bundled selectors library which is used by the local and ssh
connection plugins had a bug which caused a traceback in a cornercase.
If selectors were in use and a syscall was interrupted, selectors would
attempt to restart the syscall after the interrupt was processed.  if
the attempt determined that the timeout for running the syscall had
already expired, the code attempted to raise OSError.  The raise was
using a Python3-ism and needed to be ported to work on Python2.

Fixes #41630
2018-08-13 07:17:11 -07:00
René Moser
1fb0e11b56
vultr: rename prefix vr_to vultr_ (#43994)
* vultr: rename modules

* replace string vr_ with vultr_

* add deprecation warning

* fix sanity tests

* add changelog
2018-08-13 10:21:50 +02:00
Felix Fontein
ffa720c0f1 doc: acme: add missing maintainers 2018-08-13 08:18:29 +02:00
Ganesh Nalawade
24d112fc60
Fix cli_command junos test failure and update doc (#44021)
* Fix cli_command junos test failure and update doc

*  Fix cli_command module integration test failure
   for junos
*  Update cli_command module doc for prompt and
   config command run scenario's

* Update cli_command module doc
2018-08-13 11:02:43 +05:30
Tim Rupp
0beae82f56
Add no-change handlers and fix utf8 (#44020)
the bigip_command module was not handling utf-8 appropriately. Also,
this patch includes some enhancements for no-change detection
2018-08-12 21:44:49 -07:00
Miguel C
fa8154db40 Fix #43917 (#43929)
Support upper/lower case resource groups
2018-08-13 12:24:13 +08:00
Tim Rupp
0d332dd095
Adds fixes and features to bigip_virtual_server (#44019)
Merging in downstream work from the f5-ansible repository.
2018-08-12 20:46:08 -07:00
Jordan Borean
6ca4ea0c1f
add support for opening shell on remote Windows host (#43919)
* add support for opening shell on remote Windows host

* added arg completion and fix sanity check

* remove uneeded arg
2018-08-13 09:27:59 +10:00
Felix Fontein
aef16ee195 ACME: use Cryptography (if a new enough version is available) instead of OpenSSL (#42170)
* Collecting PEM -> DER conversions.

* Using cryptography instead of OpenSSL binary in some situations.

* Moving key-to-disk writing for key content to parse_account_key.

* Rename parse_account_key -> parse_key.

* Move OpenSSL specific code for key parsing and request signing into global functions.

* Also using cryptography for key parsing and request signing.

* Remove assert statements.

* Fixing handling of key contents for cryptography code path.

* Allow to disable the use of cryptography.

* Updating documentation.

* 1.5 seems to work as well (earlier versions don't have EC sign function). Making Python 2.x adjustments.

* Changing option to select_crypto_backend.

* Python 2.6 compatibility.

* Trying to test both backends separately for acme_account.

* Also testing both backends separately for acme_certificate and acme_certificate_revoke.

* Adding changelog entry which informs about select_crypto_backend option in case autodetect fails.

* Fixing YAML.
2018-08-12 19:12:01 +02:00
Felix Fontein
7f41f0168a ACME certificate revocation: add support for new draft-14 error message (#43980)
* Adding support for new certificate-already-revoked error message in draft-14.

* Updating documentation.

* Fixing typo.
2018-08-12 04:29:48 -04:00
Adam Miller
231961564a fix firwewalld permanent zone operations (#42868)
Fixes #42310

Previously, the firewalld module was making a call to
FirewallClientConfig.getZoneNames() which doesn't exist in versions
of firwalld older than 0.4.2, this patch implements the same logic
with older API calls to not require a newer version of firewalld.

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-12 03:08:05 -04:00
Yanis Guenane
ffcdc53536 module_utils/vultr.py: Ensure comparison is accurate (#43298)
In query_resource_by_key(), there is an equal comparison that is made to
know if the object we are looking for is present. Due to type difference
this comparison doesn't always retrieve true, even when it should.

This is due to the fact that the value in r_data dict are of type
unicode, while the other can be of type int, float,... .

```
>>> a = u'1'
>>> type(a)
<type 'unicode'>
>>> b = 1
>>> type(b)
<type 'int'>
>>> a == b
False
>>> str(a) == str(b)
True
```

Hence the values, for comparison purposes, are casted into strings.
2018-08-11 04:48:44 -04:00
Luca Lorenzetto
051320a5f5 docs: Fixed wrong storage platform on module docs for EMC VNX (#43899) 2018-08-11 09:29:34 +02:00