Commit graph

45881 commits

Author SHA1 Message Date
Jill R
1c1da3c11d
Re-enable ec2_vpc_vpn_facts test (#58893) 2019-07-18 09:17:15 -07:00
pratikgadiya12
393e4a41d0 Added support to create and delete multiple databases in MySQL (#58602)
* Added support to create/delete mulitiple databases in MySQL

Fixes: #58370

* Added additional tests cases and fixed documentation changes

* Code refactoring and added tests for better test coverage

- Removed db_exists usage from most of the code. Used existence_list
 and non_existence_list instead

- Added additional tests to cover all scenarios w.r.t creation and deletion
 on multiple databases

- Added tests for dump operations

* Minor fix

* Minor fix - create check mode test

* Added dump tests for better dump tests coverage

* Removed minor database connection details

* fixed error

* Added test case for import operations

* Code refactoring and review fixes

- Added dump all test case

* Fixed review comments

* Minor review comment fixes

* Altered db_create return value

* Removed db_list and altered "does exist" to just "exist"

* Kept db and db_list in module.exit_json

* Refactored tests

- Added removal of dump2 file

* Moved import tests to state_dump_import file

* Removed import tests from multi_db_create_delete

* Updated porting guide, added RETURN block

* Minor identation fix

* Added validation to check if databases are dumped
2019-07-18 16:56:32 +02:00
Felix Fontein
cdf0947df0
Fix typo in import package name. (#59229) 2019-07-18 16:54:33 +02:00
Hannes Ljungberg
0e8eb1d17f pip: Remove unused option use_mirrors and remove all ignore.txt entries
PR #58977

* Remove unused option use_mirrors

* Add changelog fragment
2019-07-18 16:38:37 +02:00
Sam Doran
d2edf1d435 User - Create parent directories if they do not exist in the specified home path (#51043)
* Create a user home directory if it has parents that do not exist

The useradd command line tool does not create parent directories. Check if the specified home path has parents that do not exist. If so, create them prior to running useradd, then set the proper permission on the created directory.

Add tests

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Use dict for default user group in tests

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Fix tests

Signed-off-by: Sam Doran <sdoran@redhat.com>
2019-07-18 10:19:11 -04:00
Chris Archibald
2fbc226509 Update to base Netapp.py for Azure, and Rest API (#59151)
* base changes

* updateS

* fixes

* fies

* updates

* fix issues

* updates
2019-07-18 08:37:00 -04:00
Sumit Jaiswal
b2d8ef69f9
PR to support Ansible Checkmode in Checkpoint modules (#57695)
* added checkmode support

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-07-18 16:26:55 +05:30
Sumit Jaiswal
b01b1d40cf
PR to add Unit TC for Checkpoint network module (#57710)
* cp_network unit TC

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-07-18 16:24:09 +05:30
Eitan Raviv
264945d75f ovirt-host-network: support commit on success (#59212)
In ovirt-engine 4.3 and onwards a 'commit on success' parameter is
available. It is used to commit a network configuration automatically
upon successful application of the configuration without needing a
separate save request.

Therefore since ansible 2.8 if the 'save' parameter is specified as
'true' the commit on success parameter will be set to true and used
instead of making an additional save request.
2019-07-18 06:39:32 -04:00
Martin Nečas
9489433a4d use sysprep only when needed (#59196) 2019-07-18 03:59:51 -04:00
Yunge Zhu
cb201bfba1 add xmltodict to azure requirements file (#55748)
* add xmltodict

* fix lint
2019-07-18 01:32:51 -04:00
n3pjk
7e25a61464 snow: Call Refactored login from snow modules (#59201)
* Remove python shebang from snow_record*
* Add python shebang to all snow modules
* Remove NO_LOG from username
* Call Refactored login from snow modules
2019-07-18 10:53:23 +05:30
Sebastiaan Mannem
d0538c0d7a postgresql_pg_hba: Exception when two lines with same weight are compared (#59198) 2019-07-18 10:50:19 +05:30
Abhijeet Kasurde
8a13b41823
VMware: Use managed object id to find VM (#59143)
* Based upon partial work of wilmardo
* Now, user can specify managed object id of virtual machine to find
an existing virtual machine

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-18 07:38:12 +05:30
James Cassell
28259ee247 dzdo: fix password prompt (#59208) 2019-07-18 10:42:00 +10:00
Matt Davis
277690bcc6 add changelog 2019-07-17 19:11:56 -04:00
Michael Letterle
b8a41a90b8 Wrap Get-MachineSid's body in a try/catch
It's not critical information and there's been a number of issues over
the years with trying to retrieve it. If an exception is thrown just
return null.

Fixes: #47813
2019-07-17 19:11:56 -04:00
Yunge Zhu
42c43a2822 add azure_rm_keyvaultkey_info module (#55754) 2019-07-18 06:55:51 +08:00
Matt Clay
13bbfacb04 Show ansible-test --explain errors in CI. 2019-07-17 15:34:00 -07:00
Toshio Kuratomi
5392d8697d
Docs scripts cleanup (#59169)
* Fix dump_keywords to require attribute docs

* Change the documentation commands to make definition files positional

Since the definition files are mandatory, make them positional
parameters instead of options.
2019-07-17 12:01:07 -07:00
Brian Coca
c2253c8133
Allow for no role_versions to be present (#56519)
* Allow for no role_versions to be present

  fixes #46650

  better info on fetch, ensure list return

* use correct to_
2019-07-17 12:35:24 -04:00
Brian Coca
4ef2545eb5
if users are None/empty, dont assume sameness (#58875) 2019-07-17 11:17:48 -04:00
Brian Coca
48d4d6ec69
Stop ignoring merge hash behaviour in inventory (#58460)
* stop ignoring merge hash behaviour in inventory

fixes #58120

* added porting note

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-07-17 11:16:56 -04:00
Andrey Klychkov
0e09800a9a Postgresql modules: tidying up of CI tests (#59099) 2019-07-17 11:00:40 -04:00
Brian Coca
a39b721db5
fixes to config manager (#58530)
* skip unreadable ansible.cfg

* all types should check for type

* patch access for tests and fix tests that relied on missing files not being checked
2019-07-17 10:39:30 -04:00
Brian Coca
5ac2c6d4fe
remove unused and obsolete bsd port makefile (#58633)
freebsd itself has maintained and up to date version of port
2019-07-17 10:36:44 -04:00
dx0xm
b8eba8e1f0 VMware: Add testcase for vmware_dvs_portgroup_facts (#59088)
* Tests for choosing specific DVS while gathering facts

Signed-off-by: dx0xm <52723266+dx0xm@users.noreply.github.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-17 18:31:52 +05:30
Phillipe Smith
ce907c8b90 New module os_group_info (#57120)
* Added domain_id param to get_group

* Added module os_group_facts based on os_project_facts

* Fix pep8 alarms and version_added to 2.9

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Fixes based on https://github.com/ansible/ansible/pull/57120#issuecomment-511338588

* Update lib/ansible/modules/cloud/openstack/os_group_info.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/openstack/os_group_info.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/openstack/os_group_info.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Removed availability_zone option

* Revert "Removed availability_zone option"

This reverts commit 20155c0b0f.

* Reverted to the original code to open a new Pull Request
2019-07-17 13:55:53 +02:00
Jordan Borean
edfdf30bcb Improve docs for win_service for custom account rights (#59155) 2019-07-17 08:03:47 +01:00
dx0xm
09aa98bf43 VMware: Gather facts about vlan id from DVS Portgroup in vmware_dvs_portgroup_facts (#59085) 2019-07-17 11:39:44 +05:30
Hannes Ljungberg
6f94995b52 npm: Validate all option types (#58965)
* Add type validation for name, version and registry
* Add changelog fragment
* Remove ignore of E337 and E338
2019-07-17 09:34:58 +05:30
Eugene Narciso
fbb4eaaba9 Update net_static_route document (#59168)
Update net_static_route examples section document, the missing colon can potentially cause confusion.
2019-07-17 09:08:34 +05:30
Sumit Jaiswal
0bde145b1f PR to fix minor issues with Checkpoint module (#58049)
* minor checkpoint module fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* state default value set

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-07-16 18:51:32 -04:00
Fred-sun
6430205d39 Update azure_rm_virtualmachine related document (#58861)
* Update azure_rm_virtualmachine_facts module's documentation with nitzmahone feedback, CI fixes

* 'remove_on_absent' does not define choices
2019-07-16 15:58:14 -05:00
Matt Clay
493785ccef Remove extra blank line from galaxy .travis.yml.
This fixes the last yamllint error on the file.

The file is currently ignored by CI, but that will be changing soon.
2019-07-16 13:50:19 -07:00
Matt Davis
d28f25d118
patch ansible-connection collection plugin loading (#59119) 2019-07-16 13:46:15 -07:00
Matt Clay
d4dec59cb0 Fix collection loader builtin handling. (#58897)
- Support more import statements:

  from ansible_collections.ansible.builtin.plugins.module_utils import basic
  from ansible_collections.ansible.builtin.plugins.module_utils.basic import AnsibleModule

- Add unit tests for more import statements.
- Raise ImportError instead of returning None if load_module fails.
2019-07-16 13:40:22 -07:00
Shachaf92
681ab6515a win_domain_group_membership - Fix to a fix in extra_args (#58943)
* win_domain_group_membership - Fix to a fix in extra_args

* addig missing l on the fly
2019-07-17 05:38:42 +10:00
Alicia Cozine
e5e3486be6 clarifies how ASK works for Tower credentials (#59050)
* clarifies how ASK works for credentials
2019-07-16 15:37:47 -04:00
Toshio Kuratomi
019d078a5a
Move common build code from _build_helpers (#55986)
We have some common code used by several docs scripts.  Migrate that
into the build-only shared code repository.

* Move lib/ansible/utils/_build_helpers.py to the directory for common
  build code
* Migrate docs/bin/dump_config.py to a build-ansible subcommand
* Migrate dump_keywords to the build-ansible framework
  * Make the script more maintainable by using functions and good
    variable names
  * Port to Python3 idioms
  * Fix bug so that private attributes will be undocumented
* Move generate_man to a build-ansible subcommand
* Port plugin_formatter to a build-ansible subcommand
* Rework command_plugins so that docs scripts can target Python-3.4+ and
  releng-only subcommands can use more recent versions of Python.
  The architecture is now that command_plugins/* need to be importable
  on Python-3.4.  The init_parsers() method needs to run on Python-3.4.
  But the main() method can utilize features of more recent Python as
  long as it fits within those parameters.
* Update docs build requirements

Port the plugin_formatter to build-ansible framework
2019-07-16 12:19:01 -07:00
Fred-sun
65e0f37fc0 Update azure_rm_virtualnetwork related document (#59023)
* Update azure_rm_virtualnetwork related documentation
2019-07-16 14:18:20 -05:00
Kyle Sferrazza
b376c91749 win_hotfix: fix docs typo (#59124) 2019-07-16 14:09:13 -05:00
Fred-sun
c7387549a4 Update azure_rm_virtualnetworkpeering related document (#59025)
* Update azure_rm_virtualnetworkpeering related documentation
2019-07-16 14:04:32 -05:00
Matt Clay
cb0dfc9793 Prepare pylint test for collections support. 2019-07-16 11:24:16 -07:00
Chris Archibald
8bf069114f New Module: Vscan Enable (#57953)
* new module

* fix netapp.py

* updates

* fixes
2019-07-16 13:40:56 -04:00
Sam Doran
d17e7a91b1
Add test for meta: end_play (#59118)
- Set ansible_python_interpreter for hosts using local connection
2019-07-16 12:41:48 -04:00
Wojciech Sciesinski
e8a7d89180 Correct a documentation of the jenkins_plugin module (#59139) 2019-07-16 11:46:18 -04:00
Dara Poon
b16c264dca chroot connection plugin: defer get_option() call (#59065)
* The chroot connection plugin crashes because its constructor calls
  self.get_option(...) before the plugin loader has established its
  self._load_name.  Therefore, we should defer the self.get_option(...)
  call so that it happens in connect().

Fixes #59063
2019-07-16 11:31:06 -04:00
Kiyo Nagamine
88c4cf28ea Modified blockinfile module's exmple using loop keyword (#59022) 2019-07-16 11:13:04 -04:00
Ewoud Kohl van Wijngaarden
9c5b3401ff Close file after using it (#59000) 2019-07-16 10:07:27 -05:00