Commit graph

9468 commits

Author SHA1 Message Date
Peter Sprygada
1dd2b849dc fixes default value in docstring for http (#4985)
The docstring incorrectly stated the default value for http is yes when
indeed its no.  This fixes the docstring
2016-09-23 12:10:15 -04:00
Peter Sprygada
a923689182 fixes bug where setting state=absent in nxos_nxapi is not idempotent (#4984)
When setting state=absent the nxos_nxapi module would always try to remove
the configuration regardless of the current state of the device.  This will
fix that problem.

This also updates the docstring to correctly reflect https as default=no

fixes #4955
depends on ansible/ansible#17728
2016-09-23 12:10:03 -04:00
John R Barker
a829ca29ee Force is not a 2.2 feature
9b5e6bbfa1 incorrectly chopped some text around
2016-09-23 15:25:44 +01:00
Matt Clay
8d3119dfe5 Add shellcheck to sanity checks. (#4976)
Also disable deprecation warnings during module validation.
2016-09-22 16:34:36 -07:00
Trond Hindenes
ab1ac22187 win_feature_docs_update (#4421) 2016-09-22 15:31:15 -07:00
Timothy Appnel
b995358185 Fixes grammatical error in assert module example (#4972) 2016-09-22 09:49:26 -05:00
Ryan S. Brown
0f505378c3 Accept JSON type as the content of policy_json parameter on iam_policy module 2016-09-21 15:04:09 -04:00
Søren Kröger
cb9fc47cbc Added single_transaction and quick to db_dump (#3687)
It was missing before, ...
2016-09-21 20:41:56 +02:00
JesseEmond
1f741b69f4 Unarchive stop passing file mode to tar command (#4179)
Fixes #4063.

Tar does not use this parameter on extraction (-x) or diff (-d)(the
only two cases where it is passed in unarchive). It only uses it on
creation:
https://www.gnu.org/software/tar/manual/html_section/tar_33.html

Providing `unarchive` with a file mode of `0755` (octal) makes it pass
the argument `--mode 493` (493 = 0755 in decimal) to `tar`, which then
fails while verifying it (because it contains an invalid octal char
'9'). Not passing the parameter to tar solves the issue.
2016-09-21 20:38:05 +02:00
Marius Gedminas
c354c974e7 postgresql_db: fix inverted 'changed' logic when state=absent (#4934)
Fixes #4933.
2016-09-21 19:14:03 +02:00
David Shrewsbury
4bd2a409e6 Correct reuse_fips param to reuse_ips (#4939)
This new parameter was incorrectly named. Fixing to match the expected
name in the shade library.
2016-09-21 08:57:02 -05:00
Toshio Kuratomi
b4f1d0d0c2 Fix pip freeze workaround with virtualenv (#4951) 2016-09-20 18:20:13 -07:00
Matt Clay
3486395970 Remove script previously used by Travis. 2016-09-20 11:42:15 -07:00
Toshio Kuratomi
5b1994cb42 pip list isn't available on pip less than 1.3 so make a fallback (#4947) 2016-09-20 11:02:14 -07:00
Chris Houseknecht
16c9597ca7 Merge pull request #4943 from chouseknecht/devel
Improve error handling in docker_service module
2016-09-20 12:02:31 -04:00
Timothy Appnel
b87bf7c12d Adds docs for msg param in assert modules plus some other clean up (#4926) 2016-09-20 10:51:57 -05:00
Peter Sprygada
3a2cfadb31 fixes junos_config to be idempotent when confirming a commit (#4946)
The junos_config module would always return true when confirming a commit
This changes the module to now check first making the feature idempontent
2016-09-20 11:42:51 -04:00
René Moser
19be0da3b0 iam_cert: remove choice list for dup_ok type bool (#4940)
See 8879931f0c
2016-09-20 17:36:02 +02:00
Toshio Kuratomi
70d4ff8e38 Fix parsing of pip output 2016-09-20 08:00:30 -07:00
Toopy
6fbd72db82 Fix git get_diff TypeError when fetch (#4881) 2016-09-20 10:50:42 -04:00
Lars Engels
a49cd08832 Add support for password aging on Solaris (#4372)
* Add support for password aging on Solaris

* Fix shadow file editing when {MIN,MAX,WARN}WEEKS is not set in /etc/default/passwd

* Un-break with python3

* _Really_ un-break with python3
2016-09-20 10:42:27 -04:00
Chris Houseknecht
4a560d4a15
Cast scale value to int. Fixes #4592. 2016-09-20 10:29:27 -04:00
Rob Cutmore
12a7027c49 Pip: use 'pip list' when available for package list (#4644)
* Pip: handle parsing different pip commands

* Pip: use 'pip list' when available

* Pip: explicitly check which command is used

* Pip: add error checking when fetching packages
2016-09-20 07:05:08 -07:00
Chris Houseknecht
5ab1a6f88d
Make project start and stop error handling more resilient, and improve message text. 2016-09-20 09:45:26 -04:00
indispeq
20e08b2cdf Fix openstack security group rule vrrp choice apostrophe error (#4750)
Fixes #4444 that was erroneously closed and thought fixed
2016-09-20 14:39:01 +02:00
Peter Sprygada
4c8e32ee27 fixes import statements in junos_package module (#4929)
This fixes the import statement to import NetworkModule from network instead
of from junos
2016-09-19 23:18:35 -04:00
Peter Sprygada
df4a9dabd5 fix up junos_facts import statements (#4928)
This fixes the junos_facts import statements and removes importing
NetworkModule from the junos shared module.
2016-09-19 23:18:26 -04:00
Peter Sprygada
a3807eee10 fix import in junos_command module (#4927)
This fixes the import statements in the junos_command module to be
consistent with all junos_* modules
2016-09-19 23:13:53 -04:00
Peter Sprygada
16f298138c roll up of bug fixes for junos_config module (#4925)
* fixed docstring referencing old arguments
* changed out lxml for xml library to avoid import errors
* fixed issue when trying to confirm a commit will end up a NOOP
* fixed issue for passing replace argument to load_config method
2016-09-19 22:27:07 -04:00
Peter Sprygada
446c7de239 bug fixes in junos_netconf module (#4924)
* fixes exception thrown when sending commands to device
* fixes exception thrown when retrieving current resource instance
* fixes issue where netconf would be configured in some instances when state
  was set to absent
* now returns the command string sent to the remote device
* fixes argument name to be netconf_port with alias to listens_on
2016-09-19 22:26:56 -04:00
Josh Lothian
6950e79cde Fix YAML syntax in NXOS documentation (#4922)
* Fix YAML syntax in NXOS documentation

Use ':' and not '=' to ensure valid YAML
in the EXAMPLES

* Correcting introduced syntax error
2016-09-19 22:22:12 -04:00
Michael Scherer
d1bdd883a2 Remove duplicate key 'author' (#4919) 2016-09-19 21:19:23 -04:00
Peter Sprygada
8351186bc7 Merge pull request #4908 from mscherer/fix_junus_doc
Fix duplicate required key error
2016-09-19 21:18:11 -04:00
Peter Sprygada
539e39df8d Merge pull request #4910 from GGabriele/feature_fix
Fix nxos_feature 2.2
2016-09-19 21:17:14 -04:00
Will Thames
a076309a0f Check whether yum file or URL install is an upgrade (#4547)
Rather than just checking whether a package with the right
name is installed, use `local_nvra` to check whether the
version/release/arch differs too.

Remove `local_name` as it is a shortcut too far.

Fixes #3807
Fixes #4529
2016-09-19 21:13:23 -04:00
Matt Clay
600228ca7f Test module docs on Shippable. (#4921) 2016-09-19 16:59:27 -07:00
Matt Clay
f2c2dddc01 Remove duplicate keys from module docs. (#4920) 2016-09-19 15:01:48 -07:00
Matt Clay
27d2950e2d Remove Travis config since we only use Shippable. (#4916) 2016-09-19 12:35:37 -07:00
Peter Sprygada
e3b6f52bf5 Merge pull request #4914 from privateip/eos_command
bug fix that now catches FailedConditionalError when specifying conditionals
2016-09-19 14:46:34 -04:00
Peter Sprygada
0d847e4b86 Merge pull request #4913 from privateip/nxos_command
adds exception handling to nxos_command for FailedConditionalError
2016-09-19 14:46:25 -04:00
GGabriele
169b722d73 Add feature mappings 2016-09-19 18:50:30 +02:00
Peter Sprygada
3714b30a9f bug fix that now catches FailedConditionalError when specifying conditionals
This is related to ansible/ansible#17638 and updates the eos_command module
to catch the exception and return a santatized error.
2016-09-19 12:39:44 -04:00
Peter Sprygada
2e357e262c adds exception handling to nxos_command for FailedConditionalError
This adds exception handling as per ansible/ansible#17638 to the
nxos_command module.
2016-09-19 12:32:37 -04:00
Peter Sprygada
318c115e9b Merge pull request #4906 from GGabriele/portchannel_fix
Fixing nxos_portchannel
2016-09-19 11:09:44 -04:00
Michael Scherer
7173162c51 Fix duplicate required key error
ansible-doc -vvvv -l show this warning:

   [WARNING]: While constructing a mapping from /home/misc/checkout/git/ansible/lib/ansible/modules/core/network/junos/junos_config.py,
   line 88, column 5, found a duplicate dict key (required). Using last defined value only.
2016-09-19 17:05:32 +02:00
Peter Sprygada
773063f88c Merge pull request #4907 from privateip/fix-4905
eos_eapi module allows independent configuration of protocol and port
2016-09-19 10:57:10 -04:00
Peter Sprygada
4ff0fd3910 eos_eapi module allows independent configuration of protocol and port
The eos_eapi module would not configure the port if the protocol wasn't
configured as reported in #4905.  This changes the behavior to now allow
the port to be configured independently

fixes #4905
2016-09-19 10:53:43 -04:00
GGabriele
d632cce546 Fixed docstring 2016-09-19 14:35:51 +02:00
GGabriele
5174e3f31f Fixing nxos_portchannel 2016-09-19 14:27:23 +02:00
Harnek Sidhu
1df235f8ca Created digital_ocean_block_storage module (#4469) 2016-09-19 08:54:14 +01:00