Commit graph

27276 commits

Author SHA1 Message Date
James Cassell
1fb0335243 group_chars: default change warning only when needed 2019-06-04 14:04:17 -07:00
Abhijeet Kasurde
b8b0a2a20c aws: Update description for iam_role (#57346)
If IAM Role is created without description using aws cli or UI,
then Ansible failed to update description for such IAM role.
This fixes such condition.

Fixes: #52942

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-04 11:52:03 -07:00
Chris Archibald
57b3160f13 new feature (#57320) 2019-06-04 13:57:54 -04:00
dw
3fadf4a1cb Fix file descriptor leak in lineinfile module. (#57328) 2019-06-04 12:45:19 -04:00
Fred-sun
1ddb37cdc2 Update azure_rm_mariadbserver related document (#57333) 2019-06-04 11:41:26 -04:00
Nick Dokos
22b45f2c06 Clarify description of 'state' in the package module (#57241) 2019-06-04 09:45:49 -04:00
Fred-sun
2cb3094b68 Update azure_rm_mysqlconfiguration related document (#57335) 2019-06-04 09:41:00 -04:00
Fred-sun
15034fb5b5 Update azure_rm_mysqldatabase related document (#57338) 2019-06-04 09:37:22 -04:00
Abhijeet Kasurde
ee8a607cca ipaddr: Handle network address in ipmath (#57149)
* Updated testcase, documentation

Fixes: #54457

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-04 14:01:18 +05:30
Sumit Jaiswal
e620e27609
PR to fix the bug 57215 & 56300 under Nios Host_Record module (#57221)
* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* shippable error fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* review comment fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-04 10:52:16 +05:30
Sandeep Kasargod
78f6a7cbb1 New module for managing export groups in Vexata storage arrays. (#55481)
* Vexata export group module.
* Fix messages / error handling paths.
2019-06-04 10:05:40 +05:30
Chris Van Heuveln
6bb13bbb84 nxos_vlan: fix broken purge behavior (issue #57101) (#57229)
* nxos_vlan: fix broken purge behavior (issue #57101)

Symptoms/Analysis:
- `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1.
- `nxos` devices do not allow removing vlan 1 and raise a cli exception error
- Previous fix #55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g.
 - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true`
 - results in proper purging but vlan 4 is not created

Solutions:
- ignore vlan 1 when purging
- remove the `not purge` check from state present logic

Added additional unit tests and integration tests.
Tested against all regression platforms.

* PEP fixes

* Add agg_show_vlan_brief.txt fixture

* Add warning for removing vlan 1

* change method name check
2019-06-04 09:14:09 +05:30
Aaron Smith
333f54ec3b cloud/amazon/aws_config_recorder: add empty resourceTypes list if undefined (#50286) 2019-06-03 15:45:38 -07:00
Mikhail Naletov
8cf6f56a01 Added sort option for zabbix_screen module (#56237)
* Added sort option for zabbix_screen module

* FIX: sort variable

* Added changelog file

* Fixed misspelling

* Update lib/ansible/modules/monitoring/zabbix/zabbix_screen.py

Changed spelling in the documentation

Co-Authored-By: flowerysong <junk+github@flowerysong.com>
2019-06-03 21:23:20 +02:00
Felix Fontein
7b40b569b2
Rename memset_*_facts to memset_*_info (#57030)
* Rename memset_*_facts to memset_*_info

* Add changelog.
2019-06-03 21:19:49 +02:00
Stefan Horning
ddfaa83ccf s3_bucket: add encryption capabilities to the module (#55985)
* s3_bucket: add encryption capabilities to the module
2019-06-03 11:25:09 -07:00
Fred-sun
3587f346c0 Update azre_rm_mariadbfirewallrule related document (#57288) 2019-06-03 12:51:02 -05:00
Fred-sun
ceb91ef80a Update azure_rm_mariadbdatabase relate document (#57287) 2019-06-03 12:49:38 -05:00
Martin Nečas
ea939c7e3e ovirt vnic profile update readme (#57298)
removes second of two identical examples
2019-06-03 11:35:10 -05:00
Piotr Gbyliczek
ec511e84bc Update azure_rm_appgateway.py (#56780)
* Update azure_rm_appgateway.py documentation to explain the dependency of authentication_certificates on cookie_based_affinity being enabled
2019-06-03 10:44:15 -05:00
Fred-sun
2d5c9e06fa Update azure_rm_manageddisk related document (#57206)
* Update azure_rm_manageddisk related documentation
2019-06-03 10:32:02 -05:00
Abhijeet Kasurde
0f10c4e8d2 aws: Handle exceptions while describing metric alarm (#57304)
Handle exceptions raised while describing the metric alarms rather than
printing tracebacks.

Fixes: #55786

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-03 11:23:53 -04:00
schowave
e6166b40cc Fixes typo in get_url (#57305)
Fixes Typo, need instead of ned
2019-06-03 20:36:48 +05:30
Fred-sun
6306f18fc3 Update azure_rm_loganalyticsworkspace related module document (#57158)
* Update azure_rm_loganalyticsworkspace related module documentation
2019-06-03 10:05:20 -05:00
Marcello Barnaba
0e25f8aef2 Add find module patterns option use cases documentation (#57089)
* Specify that the pattern is matched against the dirent basename
* Specify that regexen must match the whole name of the dirent. It has been a pitfall for me.
2019-06-03 10:00:15 -05:00
Andrey Klychkov
86be0985ce removed_module func: removed extra spaces from msg and docstring (#57209) 2019-06-03 10:00:19 -04:00
Sam Doran
2e0229a4b6 ansible-vault: convert vault_password_files to list to prevent traceback (#57186)
* Convert vault_password_files to a list

* Add changelog and tests
2019-06-03 12:14:06 +02:00
Sloane Hertel
21cd24a0dd improve conditional warnings (#57190)
* Fix order for warning on templated conditionals

Fix bare variable warnings when the variable is a boolean

* changelog

* Add tests for cases that should and should not give warnings

If the behavior may change when the default behavior for CONDITIONAL_BARE_VARS becomes False there should be a warning. Boolean type conditionals will not change in behavior so don't warn.

* oops, forgot to add files

* typo
2019-06-03 12:12:32 +02:00
Andrey Klychkov
fecffea370 postgresql_db: add note to doc about pg_dump (#57297)
* postgresql_db: add note to doc about pg_dump

* Update lib/ansible/modules/database/postgresql/postgresql_db.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-03 05:19:06 -04:00
Andrey Klychkov
96bf243265 New module postgresql_copy: copy data between a file and a table (#56835)
* New module postgresql_copy

* New module postgresql_copy: added tests

* New module postgresql_copy: changed tests

* New module postgresql_copy: doc format fixes

* New module postgresql_copy: fixes

* New module postgresql_copy: added upper, PostgreSQL

* New module postgresql_copy: fixed description

* New module postgresql_copy: added note about superuser

* New module postgresql_copy: remove SQLParseError

* New module postgresql_copy: fixed opt_need_quotes type

* New module postgresql_copy: fixed check_mode

* New module postgresql_copy: small fix
2019-06-03 19:11:50 +10:00
René Moser
0c66a5d3ca
cloudcscale_floating_ip: add types (#56924) 2019-06-03 10:43:32 +02:00
rajaspachipulusu17
6b2688245e Pluribus Networks ipv6security raguard port module with UT (#57033)
* Pluribus Networks ipv6security raguard port module with UT

* Dox fix
2019-06-03 11:44:28 +05:30
rajaspachipulusu17
b8a317c527 Pluribus Networks vrouter packet relay module with UT (#57155)
* Pluribus Networks vrouter packet relay module with UT

* Doc fix
2019-06-03 11:43:29 +05:30
Felix Fontein
b33c9dad40 Improve docs w.r.t. networks_cli_compatible. (#56971) 2019-06-02 23:38:21 -04:00
Dodge245
012609b09a VMware: Update doc for num_cpus and num_cpu_cores_per_socket calculation (#57227)
Updated document to explain num_cpus is multiple num_cpu_cores_per_socket.
2019-06-02 17:39:33 +05:30
Abhijeet Kasurde
c8eda7773e
VMware: Update vmware_guest_powerstate (#57000)
* Updated documentation
* Updated testcases
* Updated example
* Updated logic
* Provided option to specify task name, task description, task enable status etc.

Fixes: #56987

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-01 08:10:05 +05:30
Fabrice
7364e79c0d k8s: Fix .to_dict not needed (#56147)
* k8s: Fix .to_dict not needed

* Add changelog fragment
2019-06-01 11:42:48 +10:00
Matt Martz
8bd4e2a144 cert validation fixes - Attempt 2 (#55953)
* Attempt 2 of cert validation fixes

* Remove unused code

* Cleanup the tmp cert using atexit

* Fix linting issues

* Only add SSLValidationHandler when not HAS_SSLCONTEXT

* Catch value errors on non PEM certs

* Only catch NotImplementedError to avoid masking issues

* set self._context even with PyOpenSSLContext for conformity

* Fix error building

* normalize how we interact with the context we create

* Remove unused code

* Address test for py3.7 message difference

* open_url should pass the ca_path through

* Account for new error in url lookup test

* Guard some code behind whether or not we are validating certs

* Make _make_context public

* Move atexit.register up to where the tmp file is created
2019-05-31 16:35:25 -04:00
Paddy Newman
2ef7759be1 Allow syslog_json callback options to be set in an Ansible configurat… (#57232)
* Allow syslog_json callback options to be set in an Ansible configuration file.

The syslog_json documentation says that it supports options via an Ansible
configuration file. In fact, they can only be specified via environment
variables.

I've updated the module to use the standard "get_options" handling which means
that it can now support options via environment variables *or* the
configuration file.

Options can be set in the configuration file as follows:

```
callback_whitelist = syslog_json

[callback_syslog_json]
syslog_server = localhost
syslog_port = 514
syslog_facility = user
```

* Use the original, documented, names for the modules options.

In the documentation text change syslog_server to server, syslog_port to port
and syslog_facility to facility.

* Add an item to the changelog.

* Update 57232-syslog-json-configuration-options.yml

Fix a YAML syntax error / typo.
2019-05-31 14:29:15 -04:00
Dag Wieers
fd95c7b506 Fix CI issue 2019-05-31 14:12:20 -04:00
Julian Paul Dasmarinas
e1d0795aa3 beadm: Make creation of boot environments in snapshot format idempotent 2019-05-31 14:12:20 -04:00
Andrew Klaus
d8bf4f1ebb Adding support for OpenBSD syspatch (#55561)
* Initial commit

* Fixing issue where applying always returned changed status

* Adding return variables: reboot_needed, rc, stderr, stdout, warnings
2019-05-31 13:42:01 -04:00
Nathaniel Case
4142cd595e
Plugin paths need to be sent in exectutor, too (#57126)
* Combine `_start_connection` methods into executor
2019-05-31 11:44:42 -04:00
Rohit
ae033f1ec3
vyos interfacefix and test cases (#57169)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-05-31 16:13:40 +05:30
Sebastiaan Mannem
223f509ea3 Issue 56430 (#57147)
* Adding integration test for 127.0.0.1/32 and ::1/128.

* Making sure file is not corrupted when render fails

* Fixes #56430

* Adding changelog for MR 57147/Issue 56430
2019-05-31 12:32:28 +02:00
Fred-sun
94b711bac5 Update azure_rm_mariadbconfiguration related document (#57207) 2019-05-31 13:46:08 +08:00
Fred-sun
3ef09496a3 Update azure_rm_hdinsightcluster related document (#57037)
* Update azure_rm_hdinsightcluster related documentation
2019-05-30 10:34:38 -05:00
Ondra Machacek
6bceea4f51 kubevirt: Rewrite merge dict method 2019-05-30 07:41:21 -07:00
Richlv
94e2d87b2f suggest to use sequential IDs (#57142)
##### SUMMARY
Suggest to use sequential IDs - otherwise action is considered to be changed always.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-05-30 10:39:59 -04:00
Fred-sun
42acf740e4 Update azure_rm_loadbalancer relate module document (#57154) 2019-05-30 10:37:51 -04:00