Commit graph

46421 commits

Author SHA1 Message Date
Matt Clay
27ff8b1a80 Clean up unused config usage in integration tests. 2019-08-14 09:44:36 -07:00
Andrey Klychkov
7955405a23 optparse_helpers: improve unit tests for version() (#59626)
optparse_helpers: improve unit tests for version()
2019-08-14 10:32:26 -05:00
Chris Archibald
fed6598e28 fixes (#60146) 2019-08-14 10:26:12 -04:00
Miguel Angel Muñoz González
4cae96109b FortiOS modules for 2.9 - 1 (#60469)
* FortiOS modules for 2.9 - 1

* Fix empty choices and avoid E337,E338 warnings

* Ansible comments on version_added and ignore.txt only on this PR files

* Add version_added also for state attribute

* Avoid null choices on dlp_sensor

* Change required flag according to argspec
2019-08-14 19:44:51 +05:30
Ganesh Nalawade
5923a64b20 Update junos_facts gather_network_resources choices (#60467)
*  Add negation choice for individual resource names
2019-08-14 19:28:55 +05:30
Paul Belanger
55d3ecff01 Remove unused variables / imports (#60505)
These helps with the clean up of migrating eos to a collection.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-14 19:26:34 +05:30
Chris Archibald
645eebdbbb new options (#60142) 2019-08-14 09:51:38 -04:00
Chris Archibald
ae794369f8 new module: na_ontap_vserver_cifs_security (#59817)
* new module

* fixes
2019-08-14 09:02:56 -04:00
Rohit
69bc24f607
lag interfaces resource module (#59175)
* lag interfaces resource module

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity check imports

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dict_diff usage issue fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* new task

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* overridden updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dict update

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* facts merged

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* rebased and merged

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* new failures added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* obsolete file removed

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dependency added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-08-14 17:31:49 +05:30
Martin Nečas
d8d00c36fa ovirt_vm add linux boot param warning (#60474)
* ovirt_vm add kernel param check

* update check

* update docs phrase

* use douple quotes
2019-08-14 06:24:29 -04:00
Alexandre Mulatinho
b2f1993b20 FreeIPA: Add dynamic update to zones in IPA (#59489)
This feature add a new option to `ipa_dnszone` called
**dynamicupdate** as requested by issue #46768.

It allow user to change between default option `false`
to `true` if user/sysadmin wishes to make zone dynamically
updated.

Fixes #46768

Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
2019-08-14 15:38:06 +05:30
Alexandre Mulatinho
7b0a5fb487 ipa_dnsrecord.py: ttl is not required to change zones in ipa (#59924)
this fixes the error reported on issue #56872, is user not pass the argument
module 'record_ttl' it simples removes from json dictionary to make the
correct post request.

Fixes #56872
Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
2019-08-14 15:37:33 +05:30
Ryan Butler
abf7cf97df VMware: Fix typo in vmware_host_dns_facts.py (#60542)
Correct *search_doamin* to *search_domain*
2019-08-14 14:56:04 +05:30
Felix Fontein
99fb0fcb2f docker_logout: report change on successful logout (#60381)
* Mark logout as changed when docker logout does not return 'Not logged in to '.

* Add changelog.

* Improve logout detection.

* Also return output of 'docker logout'.
2019-08-14 05:23:38 -04:00
Stefan Horning
6337fbbfe5 Fix naming in example code documentation section for aws_codebuild and aws_codepipeline modules (#60495) 2019-08-14 05:23:25 -04:00
Trishna Guha
d5d88f9b11
Add nxos_interfaces resource module (#60421)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-14 13:38:22 +05:30
Sam Doran
0f35e4b7b9 apt_facts - Fix cache related performance regression (#60511)
* apt_facts - Fix cache related performance regression

* Another minor performance improvement
2019-08-14 03:43:52 -04:00
Matt Clay
b07f96c31d
Fix integration test temp dir usage. (#60555)
* Fix xfs_quota integration test temp dir usage.
* Fix lvg integration test temp dir usage.
* Fix filesystem integration test temp dir usage.
* Fix connection_windows_ssh test temp dir usage.
2019-08-14 00:12:05 -07:00
Matt Clay
ba1b4565d3 Clean up ansible-test results path handling.
This brings us closer to being able to use `tests/` instead of `test/` in collections.
2019-08-13 21:51:57 -07:00
Matt Clay
f0d32a2de0 Remove old Makefile targets.
- `pep8` - There is no need to give it more prominent placement than other sanity tests.
- `pyflakes` - The project only makes use of `pylint` and `pycodestyle`. Having the target implies that it should work.
- `loc` - Not used. Easily run manually if needed.
2019-08-13 20:32:16 -07:00
Jordan Borean
737a500a30
template - move backup to its own doc (#59893)
* template - move backup to its own doc

* Use the backup doc fragment for template
2019-08-14 09:48:37 +10:00
Brian Coca
a8d01cf2a2 Made galaxy token file location configurable (#59387)
* Made galaxy token file location configurable

  also made file handling 'unicode safe'

* only create a token on demand

* convert into decorator in case other funcs need
2019-08-14 09:47:40 +10:00
Toshio Kuratomi
3f784caed1 Table fixing (#60177)
* Change formatting of the network/user_guide tables

* Tables had hardcoded line breaks to workaround a bug in the
  read-the-docs theme.  Change those so that they now flow according to
  the browser size.

* Also switch away from grid tables to the simpler to create and read
  simple tables

* Changes to table stylesheet

* valign all content, not just the first column.  This becomes important
  with more than two columns
* Set the font-weight to the first <p> element inside of the first
  column.  This allows us to simplify the first column when everything
  there is the attribute name

* Change platform_index footnote from numbered to dagger symbol

The footnote notation was very odd to read.  Try using a symbol for the
footnote instead of a number to see if that will clarify it.  We can't
manually specify symbolled footnotes, though, so we have to emulate a
footnote with an internal link.  This loses the backref to each place
that the footnote was used but since that was the portion which was hard
to read, perhaps that's for the best.
2019-08-13 18:23:32 -05:00
Jordan Borean
14a7722e39
ansible-galaxy tidy up arg parse with better validation (#59957)
* ansible-galaxy tidy up arg parse with better validation

* Add support back in for -v before sub aprser

* Added deprecation warning for manually parsed verbosity
2019-08-14 06:36:29 +10:00
Matt Clay
1b8aa798df
Update ansible-test integration config handling. (#60448)
* Move Ansible test config into env vars.

This allows ansible-test to use an empty Ansible config file, leaving open the option for users to customize the one used to run tests (although such usage is discouraged).

* Use config from content under test when present.
2019-08-13 13:18:55 -07:00
Toshio Kuratomi
d9b3af523b Galaxy meta docs table (#60171)
* Use an rst table instead of a raw html table

* Rst is easier to read so we want to use it wherever possible
* Fix the jinja2 filters which create links so that they do not include
  extraneous whitespace in the URL

* Normalize description data before sending them to the templates
2019-08-13 15:00:13 -05:00
Matt Clay
60f8483603
Add missing boilerplate to collections test. (#60507)
* Add missing boilerplate to collections test.
* Remove redundant Python version check.
2019-08-13 12:20:14 -07:00
René Moser
7a2483c47e purefa_phonehome: implement check mode support (#57585) 2019-08-13 13:27:18 -04:00
pguermo
8923d13537 proxmox_kvm: While a VM is beeing created, vm has no name item (#58196)
* While a VM is beeing created, vm as no name attribute

* Add changelogs fragment
2019-08-13 19:22:17 +02:00
Andrey Klychkov
21863d48f3 unit tests: remove unused imports (#60462) 2019-08-13 19:21:43 +02:00
Iain Madder
1b1216d2d1 Update file.py's help doc, and narrow down diff logic, for recent pull 56353 (#59069)
* Limiting when path_content is generated

path_content will be empty and unnecessary in all scenarios except when changing the state of a folder to absent, so adding in a check to limit when this parameter is defined
2019-08-13 12:59:13 -04:00
Sam Doran
a20848bf66
Use new version of default test image that contains Python 3.8.0b3 (#60139) 2019-08-13 12:28:02 -04:00
Christian
49dea22467 Update developing_plugins.rst (#60482)
##### SUMMARY
documentation example-yaml for lookup-plugin seems to have an indent-error


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-08-13 10:43:38 -05:00
Felix Fontein
fca8a5ef76 Move all module renames into new section. (#60483) 2019-08-13 10:05:31 -05:00
Simon Dodsley
848c945a2c Fix updating hosts idempotency in purefa_host (#60367) 2019-08-13 10:53:11 -04:00
Jered Sutton
6915ea96f1 Clarify behavior of --skip-tags, --list-tasks, and --list-tags. (#60492) 2019-08-13 09:47:28 -05:00
Matt Martz
ba81084a49
Provide nice error when the shell plugin is incompatible with the con figured become plugin (#60441)
* Provide nice error when the shell plugin is incompatible with the configured become plugin. Fixes #57770

* Add todo

* Add missing import
2019-08-13 09:37:53 -05:00
Nathaniel Case
6b5c7f7c42
Add new module eos_interfaces (#59729)
* Move module_utils

* Add eos_interfaces and deprecate eos_interface

* Add boilerplate, update ignores.txt

* Try to reconcile eos provider documentation with argspec

* Try to work around unknown interfaces

* Move param_list_to_dict to utils
2019-08-13 10:09:52 -04:00
Nilashish Chakraborty
ef0f28097e
Remove lo from config (#60480)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-13 19:10:56 +05:30
Chris Archibald
2e819c87db new options (#60145) 2019-08-13 09:35:01 -04:00
Gonéri Le Bouder
df2a09e998 vmware: avoid unnecessary copy() call (#60476)
Two vmware modules uses copy() to duplicate an internal instance of a
pyvmomi object. This to be able to modify the object during an iteration.

See: https://github.com/ansible/ansible/pull/60196/files#r312643761

Closes: #60399
2019-08-13 09:27:22 -04:00
Shaun M
fa783c027b Adding waiter to cluster remove process (#57324)
* Adding waiter to cluster remove process

* blank line contains whitespace

* update aws_eks integration test

* Refactor aws_eks test suite to use pip

* update version testing

* missing parens...

* add changelog fragment

* Add waiter to module_utils, fix exception handling.

* Correct EKS waiter checks
2019-08-13 23:11:21 +10:00
Felix Fontein
2d98734ad5 Amazon modules: rename _facts with ansible_facts result to _info (#60178)
* aws_s3_bucket_facts -> aws_s3_bucket_info

* cloudformation_facts -> cloudformation_info

* cloudfront_facts -> cloudfront_info

* ecs_service_facts -> ecs_service_info

* efs_facts -> efs_info

* Add changelog and porting guide entry.

* lambda_facts -> lambda_info

* Improve examples.

* Add subsection on renamed modules.

* Add sentence on registering variables.

* Fix ReST.

* Instead of renaming lambda_facts, deprecate it and replace with new module.

* Rename internal variable.

* Re-add sanity ignores for lambda_facts.
2019-08-13 08:01:37 -04:00
Martin Nečas
dee13ea4f8 ovirt vm update kernel docs (#60407)
* ovirt vm update kernel docs

* update doc phrase

* update docs
2019-08-13 07:11:05 -04:00
Martin Nečas
e3d13cbcdc Ovirt host update force docs (#60202)
* update docs

* update pep8 syntax

* update pep8 syntax
2019-08-13 06:35:05 -04:00
Martin Nečas
5972567ab6 ovirt_vm update tempalte search by datacenter (#60461) 2019-08-13 06:16:25 -04:00
Nilashish Chakraborty
6110dcc789
Add iosxr_lldp_interfaces resource module (#60411)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-13 14:58:55 +05:30
Matt Davis
a40baf22fa
various mod_args fixes (#60290)
* various mod_args fixes

* filter task keywords when parsing actions from task_ds- prevents repeatedly banging on the pluginloader for things we know aren't modules/actions
* clean up module/action error messaging. Death to `no action in task!`- actually list the candidate modules/actions from the task if present.

* remove shadowed_module test

* previous discussion was that this behavior isn't worth the complexity or performance costs in mod_args

* fix/add test, remove module shadow logic

* address review feedback
2019-08-13 09:57:49 +01:00
Ganesh Nalawade
9efa00e762
Add [junos_lldp_global] model (#59712)
* Add [junos_lldp_global] model

*  Add new resource module junos_lldp_global
*  Targets model https://github.com/ansible/network/pull/30
*  Deprecate junos_lldp module

* Run lldp integration test only if protocol supported
2019-08-13 13:05:17 +05:30
Trishna Guha
0acf7be56a
Add nxos_lacp_interfaces resource module (#60313)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-13 12:13:35 +05:30