Commit graph

2647 commits

Author SHA1 Message Date
Michael Scherer
2ad3a46e13 sort the option_key to have a constant predictable line 2013-10-24 23:47:34 +02:00
Michael Scherer
7afaeea131 adding a single comma at the end of the options list confuse the module
it start to duplicate line, because this create
a empty option in the list, and so the module add a new line along the previous
one. See

>>> ' a,b, '.strip().split(',')
['a', 'b', '']
2013-10-24 23:46:49 +02:00
jctanner
ee4b3a1446 Merge pull request #4631 from mmoya/mysql_variables-fix3
Fail if requested variable is not available
2013-10-24 10:37:37 -07:00
jctanner
9c108efd47 Merge pull request #4624 from SirScott/freebsd_service_module_uwsgi
Fix broken FreeBsdService class
2013-10-24 10:36:05 -07:00
James Tanner
664c4839eb Set version_added for ec2_eip's in_vpc parameter 2013-10-24 12:19:43 -04:00
jctanner
4fbfa4706f Merge pull request #4593 from pas256/eip-vpc
Add VPC support for EIP module
2013-10-24 10:22:43 -07:00
James Tanner
14e2961268 Set bigip_pool_member version added to 1.4 2013-10-24 11:41:34 -04:00
James Tanner
740491e0ce Fixes #4500 change ec2 module params to type=bool
Revert 4833c2fdf0
2013-10-24 09:19:25 -04:00
jctanner
602e7483c2 Merge pull request #4112 from jsdalton/add_az_support_to_ec2_elb
Add enable_availability_zone parameter to ec2 module.
2013-10-22 14:01:24 -07:00
jctanner
ff4ac6a3ad Merge pull request #4054 from mhite/bigip_pool_member
New bigip_pool_member module
2013-10-22 13:55:41 -07:00
Maykel Moya
6155bf2c55 Fail if requested variable is not available 2013-10-22 09:30:19 +02:00
Scott Sturdivant
037dcbb4da If the output of rcvar isn't a key=value pair, ignore it. 2013-10-21 14:20:54 -06:00
Michael DeHaan
ce8b0944a9 Misc pep8 fixes 2013-10-19 13:03:15 -04:00
Michael DeHaan
91c34af12a Fix deprecation warnings in the Google modules. 2013-10-19 13:03:14 -04:00
Michael DeHaan
c981999975 Merge pull request #4592 from mscherer/fix_4586
setup module, replace ':' by '_' in interface name, fix #4586
2013-10-19 09:07:56 -07:00
Jimmy Tang
858b3da2ae check for ubuntu distribution first 2013-10-19 14:41:00 +01:00
Michael DeHaan
26e2447b94 Merge pull request #4595 from mscherer/fix_4563
fix logic in module host to add aliases even if none exist already, fix #4563
2013-10-18 17:09:23 -07:00
Michael DeHaan
f694ef315a Merge pull request #4594 from mscherer/fix_4587
fix distribution detection in apt_repository module, so it also work on mint as it work on Debian, partially fix #4587
2013-10-18 17:08:35 -07:00
Michael Scherer
4fb753997f fix logic in module host to add aliases even if none exist already, fix #4563
self._has_aliases is used to know if a alias already exist, but
the test we want is to know if we need to add a new alias, which
is stored in self.aliases
2013-10-19 01:51:42 +02:00
Michael Scherer
ee62de7887 fix distribution detection in apt_repository module, so it also work
on Mint as it work on Debian, fix #4587.

PPAs are not supported however, since that's a Ubuntu specific feature
and mint is detected as a generic distribution and use a different
codename than the Ubuntu release it is based on, which mean that apt_repository
cannot add detect and add the proper url without a better heuristic.
2013-10-19 00:57:08 +02:00
Michael Scherer
fa0d869ddd setup module, replace ':' by '_' in interface name, fix #4586 2013-10-19 00:24:07 +02:00
Peter Sankauskas
27fa111c4d Now this disassociates EIPs from instances inside a VPC correctly. Time
for a PR.
2013-10-18 15:12:49 -07:00
James Tanner
251b52bef8 Fixes #4454 Make a temporary clean cnf file if unable to parse existing 2013-10-18 17:42:40 -04:00
Peter Sankauskas
9f279618fe First round of changes to the EIP module to get it to be able to work well inside a VPC, and to be able to delete EIPs as well 2013-10-18 14:38:58 -07:00
jctanner
8e8d9bca37 Merge pull request #4562 from nimbis/devel
Adding aws_access_key and aws_secret_key aliases to ec2_group arguments
2013-10-18 06:17:50 -07:00
Brian Schott
f775bea0b1 added aws_access_key and aws_secret_key aliases to ec2_group arguments 2013-10-17 15:23:24 -04:00
jctanner
6fc1c0a8a3 Merge pull request #4539 from sayap/git-sha1
git: Always return the before/after revisions, even in check mode.
2013-10-17 11:36:03 -07:00
Michael DeHaan
2e257c4ec4 Merge pull request #4568 from mmoya/features
Improve change detection in mysql_variables
2013-10-17 10:51:36 -07:00
James Tanner
54781bdfe1 Fixes #4554 Enumerate user homedir if not passed as an argument 2013-10-17 13:15:32 -04:00
Maykel Moya
2d33cf898c Improve change detection in mysql_variables
mysql_variables bindly executes a SET var = value query even when
the variable already has the requested value.

With this patch the query is executed only if the current value is
different to the requested one.
2013-10-17 19:13:58 +02:00
Michael DeHaan
2b20be94e0 Various standardization to the proposed gce_storage module to bring things in line with updates to the S3 module.
Some typo fixes.

Further testing required.
2013-10-17 10:49:51 -04:00
Michael DeHaan
f8b4f59113 Merge pull request #4333 from bennojoy/gcs
support for google cloud storage module
2013-10-17 07:35:53 -07:00
Michael DeHaan
870bb4b1db Merge pull request #4395 from erjohnso/devel
adding Google Compute Engine modules and inventory plugin
2013-10-17 07:30:55 -07:00
Maykel Moya
a96f75c396 Do key validation only when key is provided
key_id is optional, the previous code didn't handle the case of key_id
not specified
2013-10-17 12:04:04 +02:00
jctanner
6dedb68bde Merge pull request #4517 from adfinis-sygroup/devel
Remove keys regardless of the options
2013-10-16 17:40:43 -07:00
jctanner
9543169cca Merge pull request #4480 from joemaller/absent_path_fix
ignore src when file module state=absent
2013-10-16 17:29:21 -07:00
jctanner
94fac29bf7 Merge pull request #4428 from robparrott/devel
Properly handle DEFAULT section with ConfigParser in ini_file modules
2013-10-16 17:18:17 -07:00
James Tanner
798dba436a Fixes #4350 Create homedirectory if create=yes and directory is missing 2013-10-16 20:08:41 -04:00
Michael DeHaan
4127b5dbc9 Merge pull request #4544 from mmoya/features
apt_key: Validate key_id and accept a leading '0x'
2013-10-16 12:32:28 -07:00
Maykel Moya
5d41d2eaa4 apt_key: Validate key_id and accept a leading '0x' 2013-10-16 20:52:18 +02:00
Lorin Hochstein
87055995b9 s3: better check for walrus
Check for Walrus endpoint by looking to see if the endpoint is not AWS.

This fixes a bug where the user specifies an AWS endpoint via S3_URL,
but the code interprets it as Walrus and then fails.
2013-10-16 13:22:41 -04:00
James Tanner
f233e29386 mysql_db: if connection is a socket, do not specify hostname 2013-10-16 09:59:31 -04:00
James Tanner
9128862b3b Fixes #4301 Use module_common functions for mysqldump and return better errors 2013-10-16 09:51:08 -04:00
Yap Sok Ann
e568c63108 git: Don't add --branch while cloning if the version is a SHA-1 hash. 2013-10-16 20:37:07 +08:00
Yap Sok Ann
d77276380f git: Handle network problem when running git ls-remote. 2013-10-16 20:37:07 +08:00
Yap Sok Ann
633438bfbb git: Always return the before/after revisions, even in check mode.
The return values from check mode and non-check mode should match in all cases,
except when a SHA-1 hash is used as version, as there is no way to check if it
is a valid hash using `git ls-remote`.

Also, to accomodate this change, the force flag for the reset function has been
removed so that we can do the checking in main.
2013-10-16 20:37:07 +08:00
Yap Sok Ann
12c4bf51b8 git: Make function get_remote_head usable when cloning.
This allows the module to return the before/after revisions in all cases.
2013-10-16 20:37:07 +08:00
Yap Sok Ann
3ff0c6d50d git: Remove unnecessary return code checking.
The functions either return rc=0 or call fail_json themselves.
2013-10-16 20:37:06 +08:00
Yap Sok Ann
201ff02d1f git: Full length SHA-1 in, full length SHA-1 out.
This removes ambiguity at the expense of slight backward incompatibility.
2013-10-16 20:37:06 +08:00
James Tanner
56ffd4edbb Fixes #4532 Send easy_install to get_bin_path instead of None 2013-10-15 18:15:08 -04:00