Commit graph

12905 commits

Author SHA1 Message Date
Rene Moser
7a28ad63f7 dynamodb_table: doc fix 2016-12-08 11:33:59 -05:00
Matt Ferrante
99c8e82b60 dynamo db indexes 2016-12-08 11:33:59 -05:00
Michael Scherer
eefd716e8c Add better type checking for elasticsearch_plugin 2016-12-08 11:33:59 -05:00
Michael Scherer
4c63a958e5 Use no_log for the password for maven_artifact module 2016-12-08 11:33:59 -05:00
Michael Scherer
9f90c2355f Add the proper type for the various path argument 2016-12-08 11:33:59 -05:00
Casey Lucas
4cd9933388 fix edge case where boto returns empty list after subnet creation 2016-12-08 11:33:59 -05:00
Michael Gruener
1d0ae2f4ed cloudflare_dns: Fix wrong variable name 2016-12-08 11:33:58 -05:00
Emilien Macchi
1c94395a96 system/puppet: allow to run puppet -e
-e or --execute [1] allows to execute a specific piece of Puppet code
such a class.

For example, in puppet you would run:
puppet apply -e 'include ::mymodule'

Will be in ansible:
puppet: execute='include ::mymodule'

[1] http://docs.puppetlabs.com/puppet/latest/reference/man/apply.html#OPTIONS
2016-12-08 11:33:58 -05:00
Andrea Scarpino
45a32137ad win_unzip: Use absolute path for src and dest
win_unzip fails to extract files when either src or dest contains
complex paths such as "..\..\" or "C:\\Program Files" (double slashes).
Fix this by fetching absolute path of both before invoking CopyHere
method.
2016-12-08 11:33:58 -05:00
jhawkesworth@users.noreply.github.com
d2fe2287f9 Added return documentation to win_regmerge module 2016-12-08 11:33:58 -05:00
Michael Scherer
184d9fc4e5 Fix type used by the module
Set int for the various port (and so avoid to convert them later)
Set no_log=True for the login_password
Verify that db is a int, so avoid a conversion
2016-12-08 11:33:58 -05:00
Michael Scherer
8abe22c917 Fix ssl to be a bool, required to fix #1732
May also fix #1869
2016-12-08 11:33:58 -05:00
Michael Scherer
1a05e0f1c8 Use proper type for riak config_dir argument 2016-12-08 11:33:58 -05:00
Michael Scherer
49aa069c94 Add proper type to path and link
Since both of them are path, it should be checked using the
proper type.
2016-12-08 11:33:58 -05:00
Michael Scherer
2760c2ded0 Reindent with_items, fix #1849 2016-12-08 11:33:58 -05:00
Dennis Conrad
0254cbad9a Fix for existing ENIs w/ multiple security groups
Do a sorted comparison of the list of security groups supplied via `module.params.get('security_groups')` and the list of security groups fetched via `get_sec_group_list(eni.groups)`.  This fixes an incorrect "The specified address is already in use" error if the order of security groups in those lists differ.
2016-12-08 11:33:58 -05:00
Andrea Scarpino
f56c557a93 Fix issue #1406 about win_firewall_rule
I changed the logic here to always use 'netsh ... show rule' keywords as keys for $fwsettings map. While the translation (e.g. Enabled -> enable) is performed when invoking 'netsh ... add rule' command.

I tested rule creation and rule creation when the rule was already existing on Windows Server 2012.
2016-12-08 11:33:58 -05:00
Andrea Scarpino
e16bd19401 win_unzip: overwrite any existing file 2016-12-08 11:33:58 -05:00
Rob White
7b0b4262e5 Allow SNS topics to be created without subscriptions. Also added better error handling around boto calls. 2016-12-08 11:33:58 -05:00
Fernando J Pando
be083a8fbe author added 2016-12-08 11:33:58 -05:00
Fernando J Pando
6d69956f83 Fix SNS topic attribute typo
Enables adding SNS topic policy. 'Policy' attribute is capitalized.
2016-12-08 11:33:58 -05:00
Joel Thompson
61672e5c61 Ensure ec2_win_password doesn't leak file handle
Currently the module doesn't explicitly close the file handle. This
wraps the reading of the private key in a try/finally block to ensure
the file is properly closed.
2016-12-08 11:33:58 -05:00
Rene Moser
b92b30e3b3 ec2_vpc_dhcp_options: doc fix, add version_added to new args
See #1640
2016-12-08 11:33:58 -05:00
Andy Nelson
5718a5caac Updated ec2_vpc_dhcp_options 2016-12-08 11:33:57 -05:00
Justin Good
f85f575a58 Add support for recursive znode deletion 2016-12-08 11:33:57 -05:00
James Moore
0ecaea3ac1 Added a source parameter for setting the JIT client name 2016-12-08 11:33:57 -05:00
Darek Kaczyński
9e918b5955 Removed debug return values 2016-12-08 11:33:57 -05:00
Darek Kaczyński
7127a45d96 ecs_service will now compare whole model and update it if any difference found. Documentation #1483. Workaround for datetime fileds #1348. 2016-12-08 11:33:57 -05:00
Darek Kaczyński
9b27ed6c5d ecs_service_facts documentation fixes #1483. Workaround for datetime fileds #1348. 2016-12-08 11:33:57 -05:00
Nate Smith
b820017ed0 Allow numeric npm package versions
When passing a package version that parses as a number (e.g. `1.9`), the version should be converted to a string before being concatenated to the package name.
2016-12-08 11:33:57 -05:00
Ritesh Khadgaray
d8ea847739 zabbix_host : add the ability to set inventory_mode 2016-12-08 11:33:57 -05:00
Rene Moser
427ab2f016 osx_defaults: doc fix, add version_added for host agrument
See #1364
2016-12-08 11:33:57 -05:00
Greg Hurrell
a58a91410d osx_defaults: add "host" attribute
This allows us to configure defaults using the `-currentHost` or `-host`
arguments to the `defaults` executable.
2016-12-08 11:33:57 -05:00
Alex Kalinin
e97ca89953 Fix vmware_portgroup throwing an error if port group already exists 2016-12-08 11:33:57 -05:00
t.goto
8a3c60cfd2 add exit_json
add exit_json code to succesfully exit, when you want to delete the already
deleted host.
Without this, playbook fails with
`Specify at least one group for creating host`
which is not correct message.
2016-12-08 11:33:57 -05:00
t.goto
b03d1da393 change host.delete() parameter for newer ZBX api.
As of Zabbix API 2.4, host.delete() will not takes parameter with
`hostid` property but only the array of it.
https://www.zabbix.com/documentation/2.2/manual/api/reference/host/delete

fix #1800
2016-12-08 11:33:57 -05:00
nonshankus
30d76cd37c Fixing win_updates example for listing available updates. 2016-12-08 11:33:57 -05:00
Rene Moser
2430e295a6 lvol: remove unused import
See #1425
2016-12-08 11:33:57 -05:00
Jonas Vermeulen
2149a7b1f6 Added resizing based on %values. Included support for VG|PVS|FREE 2016-12-08 11:33:57 -05:00
lsb
2095aa5100 Update mongodb_user.py
Typo
2016-12-08 11:33:56 -05:00
Rene Moser
39ece09e86 cloudflare_dns: minor code improvments
Tweaked some things on top of the well done PR #1768

- json import
- fix expetion handling
- fix indentation
2016-12-08 11:33:56 -05:00
Michael Gruener
68fc8e75f6 Module to manage Cloudflare DNS records 2016-12-08 11:33:56 -05:00
Toshio Kuratomi
5b84102a15 Doc fixes 2016-12-08 11:33:56 -05:00
Michael Scherer
61bdf9ee0f Fix #1809, use the proper method to fail 2016-12-08 11:33:56 -05:00
Matt Clay
9c883f689d Add optional mysql connect timeout. 2016-12-08 11:33:56 -05:00
Gabriel Burkholder
6a202054f8 Fixes route53_facts to use max_items parameter with record_sets query. 2016-12-08 11:33:56 -05:00
nonshankus
a1fdff4c97 Adding missing attributes regarding the hosted zone. 2016-12-08 11:33:56 -05:00
Emilien Macchi
f0f1d1edc4 system/puppet: add --certname parameter
certname [1] can be a useful parameter when we need to specify a
certificate name different from the default value [2] in Puppet.

Ex: the hosts have different names, in advanced network isolation
setups.

Also, it can be used when we want to run Puppet with a specific node
definition and not using hostname or fqdn to match the nodes where we want to
run Puppet [3] (not recommended by Puppetlabs though).

[1] https://docs.puppetlabs.com/puppet/latest/reference/configuration.html#certname
[2] Defaults to the node’s fully qualified domain name
[3] http://docs.puppetlabs.com/puppet/latest/reference/lang_node_definitions.html#naming
2016-12-08 11:33:56 -05:00
saez0pub
029b608e1e Prevent reinstallation in case of group package 2016-12-08 11:33:56 -05:00
Miguel Martín
da668dca56 Replace deprecated zabbix api method 'exists' to support zabbix 3.0 2016-12-08 11:33:56 -05:00
David Shrewsbury
cd2c7deec4 Add os_group.py OpenStack module
Allows an admin (or privileged user) to manage Keystone v3
groups.
2016-12-08 11:33:56 -05:00
David Shrewsbury
e25c04aeb0 Add new os_flavor_facts.py module
New module to retrieve facts about existing instance flavors.
By default, facts on all available flavors will be returned.
This can be narrowed by naming a flavor or specifying criteria
about flavor RAM or VCPUs.
2016-12-08 11:33:56 -05:00
David Shrewsbury
b697d986c1 Add new os_keystone_role module.
This new module allows for creating and deleting Keystone
roles.
2016-12-08 11:33:56 -05:00
Doug Luce
030fbaef64 Use os module for checking absolute/joining paths 2016-12-08 11:33:55 -05:00
Doug Luce
d4275e576e cronvar.py: support absolute destinations
Mainly so /etc/crontab can be written to.
2016-12-08 11:33:55 -05:00
Rene Moser
c00688a118 iptables: add defaults to docs 2016-12-08 11:33:55 -05:00
David Hocky
4abd217aa5 add version added to new params 2016-12-08 11:33:55 -05:00
David Hocky
a3b7dbe1df fix doc issue 2016-12-08 11:33:55 -05:00
David Hocky
994edea253 add support for setting dscp marks with iptables module 2016-12-08 11:33:55 -05:00
liquidat
7abe6b0e8c correct win_firewall state parameter
- original parameter comment was probably copy&paste error
- new comment highlights that firewall rules can be
  added or removed altering this parameter
2016-12-08 11:33:55 -05:00
Toshio Kuratomi
32ff89b30e Fix module docs 2016-12-08 11:33:55 -05:00
Rene Moser
fd68e66827 cloudstack: new module cs_zone_facts 2016-12-08 11:33:55 -05:00
Michael Scherer
4589b67a44 Remove unused variables
Session_id is unused in update_session, changed is always specifically
set in all exit_json call, and consul_client.session.destroy return True
or False, and is unused later (nor checked)
2016-12-08 11:33:55 -05:00
Michael Scherer
fabd619070 Rename consul variable to consul_client
Since the module is also named consul, pyflakes emit a warning
about it since the variable shadow the module.
2016-12-08 11:33:55 -05:00
Michael Scherer
78571c053b Pyflakes complain about unused import, so remove it 2016-12-08 11:33:55 -05:00
Michael Scherer
334bfbd465 Add a datacenter parameter, fix #1693 2016-12-08 11:33:55 -05:00
Eike Frost
b8b2613c35 Replace deprecated exists API for Zabbix 3.0 compatibility 2016-12-08 11:33:55 -05:00
Calvin Walton
f623057e0e zabbix_maintenance: Stop using api removed in zabbix 3.0 2016-12-08 11:33:55 -05:00
Ricky Cook
4a9daf6bae New json_fail syntax for dnsimple module 2016-12-08 11:33:55 -05:00
yta
0446231380 osx_defaults: Do not make any changes in check mode 2016-12-08 11:33:55 -05:00
Ritesh Khadgaray
06d2682b08 Fix test failure for lxc_container
TRACE:
    while parsing a block mapping
      in "<string>", line 33, column 13:
                    description: resulting state of  ...
                    ^
    expected <block end>, but found ','
      in "lxc_container.RETURN", line 419, column 53:
         ... "/tmp/test-container-config.tar",

ERROR: RETURN is not valid YAML. Line 419 column 53
2016-12-08 11:33:54 -05:00
Brian Coca
bb355e6ccd add container name to return and document return
fixes #1848
2016-12-08 11:33:54 -05:00
mxpt user
0798bfe2dc Fixing typo in bigip_monitors Correcting set_template_int_property to set_template_integer_property 2016-12-08 11:33:54 -05:00
nitzmahone
2afecc7198 fix version_added issues in win_iis_website 2016-12-08 11:33:54 -05:00
nitzmahone
2e4cb9c651 added doc note to win_iis_website site_id arg 2016-12-08 11:33:54 -05:00
Corwin Brown
659c1078ba Updated Documentation to include site_id param 2016-12-08 11:33:54 -05:00
Corwin Brown
2c9512aece Adding Site_ID param 2016-12-08 11:33:54 -05:00
Brian Coca
864bf4e19e added new puppet path to bin search
fixes #1835
2016-12-08 11:33:54 -05:00
Brian Coca
b1281319c1 updated to match core module forms 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
bb27e38578 corrected replacement of last backslash 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
cd0e97dc77 corrected requirements 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
5f9eaf193e fixxed problems related to path input 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
0d01a36dd9 first implementation of win_share module 2016-12-08 11:33:54 -05:00
Marcin Dobosz
6f68db5c1a Fix win_iis_webapppool module to not null ref when removing an apppool using PS4 2016-12-08 11:33:54 -05:00
nitzmahone
092c3ccbde fix default arg handling and error messages in win_file_version 2016-12-08 11:33:54 -05:00
nitzmahone
db58300aa7 fix missing bracket in win_file_version 2016-12-08 11:33:54 -05:00
Sam Liu
a077c4bc9d fix some error for passing CI build. 2016-12-08 11:33:53 -05:00
Sam Liu
b174416895 Fixed: exception swallowing 2016-12-08 11:33:53 -05:00
Sam Liu
d5fe7633e2 new module win_file_version 2016-12-08 11:33:53 -05:00
liquidat
87bc5fcb24 remove legacy action style from examples
- "action" style invoking is a legacy way to call modules
- the examples were updated to the typical style of calling complex
  modules:

ovirt:
  parameter1: value1
  parameter2: value2
  ...
2016-12-08 11:33:53 -05:00
Matt Martz
019a944fb3 Catch errors related to insufficient (old) versions of pexpect. Fixes #13660 2016-12-08 11:33:53 -05:00
Will Keeling
876fe06290 Better handling of package groups in pacman module 2016-12-08 11:33:53 -05:00
Jonathan Mainguy
ac8b171da4 fixes bug where puppet fails if logdest is not specified 2016-12-08 11:33:53 -05:00
Toshio Kuratomi
c602d49d42 Fail due to no dnf module installed earlier as we use a dnf utility function to determine if we have permission to install packages. 2016-12-08 11:33:53 -05:00
Jiri Tyr
bb194b03bc Removing parameter from yum_repository module 2016-12-08 11:33:53 -05:00
Jiri Tyr
709ae10207 Adding more options to the yum_repository module 2016-12-08 11:33:53 -05:00
Eike Frost
85f6bb4d8e Check whether interface-list exits before querying its length 2016-12-08 11:33:53 -05:00
Ricardo Carrillo Cruz
9fea94b5bf Fix instantiation of openstack_cloud object in os_project
The os_project module instantiates the openstack cloud object
by passing the module params kwargs.
As the params contain a key named 'domain_id', this is used
for domain in the OpenStack connection, instead of the domain value
the user specifies on the OSCC clouds.yaml or OpenStack envvars.
This fix corrects this by popping the 'domain_id' key, so it we
keep the value but it's not passed later on module.params.
2016-12-08 11:33:53 -05:00
Darek Kaczyński
17a6cea512 ecs_task module documentation fixes 2016-12-08 11:33:53 -05:00
Joseph Callen
773db55233 Resolves issue with vmware_migrate_vmk module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_migrate_vmk module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
- name: Migrate Management vmk
      local_action:
        module: vmware_migrate_vmk
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        esxi_hostname: "{{ hostvars[item].hostname }}"
        device: vmk1
        current_switch_name: temp_vswitch
        current_portgroup_name: esx-mgmt
        migrate_switch_name: dvSwitch
        migrate_portgroup_name: Management
      with_items: groups['foundation_esxi']
```

Module Testing
```
TASK [Migrate Management vmk] **************************************************
task path: /opt/autodeploy/projects/emmet/tasks/deploy/migrate_vmk.yml:3
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252 )" )
localhost PUT /tmp/tmpdlhr6t TO /root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168 )" )
localhost PUT /tmp/tmpqfZqh1 TO /root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882 )" )
localhost PUT /tmp/tmpf3rKZq TO /root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/" > /dev/null 2>&1
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-01) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp001", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-01"}
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-02) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp002", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-02"}
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-03) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp003", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-03"}
```
2016-12-08 11:33:53 -05:00