Commit graph

35239 commits

Author SHA1 Message Date
Sloane Hertel
a0e96efec7 Add aws_s3 integration tests for multipart GET operations (#34657)
* Add aws_s3 integration tests for multipart GET operations

* Make multipart test platform-specific

* Use YAML anchors to simplify passing credentials

* Run tests on Linux and MacOSX
2018-01-09 18:05:22 -05:00
Matt Clay
82b5a6a0c9
Fix ansible-test network-integration command. (#34661)
* Fix ansible-test network platform init filter.
* Fix ansible-test network inventory generation.
* Remove ios/csr1000v from CI.
* Run network tests on Python 2.7 and 3.6.
2018-01-09 14:52:36 -08:00
Matt Martz
55352bdda4
Error early if executing python version doesn't meet documented minimums (#34655)
* Error early if executing python version doesn't meet documented minimums. Fixes #34597

* Make recommended enhancements
2018-01-09 16:17:55 -06:00
Ryan Brown
2f66755849 New Lookup Plugin: aws_service_ip_ranges (#32749)
* added ranges lookup

* Add docs

* Use `open_url` from module_utils

* Fix error handling on open_url

* Fix ConnectionError exception import
2018-01-09 17:16:45 -05:00
Tim Rupp
70e49b9243
Updates module utils for f5 (#34660)
These module utils are a refactor of the legacy ones and, in addition,
there are several new methods and classes to support f5 modules going
forward
2018-01-09 12:15:02 -08:00
Matt Martz
d1846425db
Provide a way to explicitly invoke the debugger (#34006)
* Provide a way to explicitly invoke the debugger with in the debug strategy

* Merge the debugger strategy into StrategyBase

* Fix some logic, pin to a single result

* Make redo also continue

* Make sure that if the debug closure doesn't need to process the result, that we still return it

* Fix failing tests for the strategy

* Clean up messages from debugger and exit code to match bin/ansible

* Move the FieldAttribute higher, to apply at different levels

* make debugger a string, expand logic

* Better host state rollbacks

* More explicit debugger prompt

* ENABLE_TASK_DEBUGGER should be boolean, and better docs

* No bare except, add pprint, alias h, vars to task_vars

* _validate_debugger can ignore non-string, that can be caught later

* Address issue if there were no previous tasks/state, and use the correct key

* Update docs for changes to the debugger

* Guard against a stat going negative through use of decrement

* Add a few notes about using the debugger on the free strategy

* Add changelog entry for task debugger

* Add a few versionadded indicators and a note about vars -> task_vars
2018-01-09 13:50:07 -06:00
Steve Glendinning
e802b769e6 Ios logging (#33151)
* ios_logging: Handle IOS versions that dont put the word host in logging config

This change allows the ansible module to parse and match either variant
being present in running-config.

* ios_logging: enhance logging buffered to handle both size and level

This change allows ios_logging to ensure local (buffered) logging
is configured with both the correct buffer size and logging level,
when both are specified on the task.
2018-01-09 14:07:31 -05:00
Will Thames
39af276639 Respect egress rule definitions when creating security groups in default VPC (#34626)
* Add test for unexpected egress rule in default VPC

When passing rules_egress to ec2_group, the default
egress rule shouldn't be created (if `purge_rules_egress`)
is set. Test this.

* Respect egress rule defintions for default VPC groups

When passing rules_egress and purge_rules_egress, the
default egress rule should not be created

Fixes #34429

* Change AWS credential passing to be YAML anchors

Vastly simplify the AWS tasks by reducing the credentials to a YAML
block
2018-01-09 13:44:13 -05:00
Matt Clay
58f06feee7 Show python and pip version in container build. 2018-01-09 10:17:00 -08:00
Dag Wieers
f67f8c7bc9
Fix examples with correct names 2018-01-09 18:26:05 +01:00
David Soper
99524e7262 World Wide Port/Node Name documentation updated to match UCS Manager online help. (#34648)
kwargs variable argument setup simplified.
2018-01-09 18:05:25 +01:00
Will Thames
ec5e509233 [cloud] Don't log AWS credentials when creating YAML anchor for ECS integration tests (#34625)
Turn `no_log` on when setting the fact.
2018-01-09 10:47:29 -05:00
Matt Martz
03794864c2
Fix piped transfer with become (#34584)
* Ignore become if we shouldn't be sudoable

* More explicit passing of kwargs

* dd/piped put should be sudoable=False. Fixes #34523
2018-01-09 09:32:27 -06:00
René Moser
fbe46c5e21
cs_vpn_customer_gateway: fix missing return doc (#34644) 2018-01-09 16:13:24 +01:00
Ricardo Carrillo Cruz
4b53539e27
Fix enable_https alias docstring (#34633)
* Fix enable_https alias docstring

* Explicitly set https on test, as we are setting https_port anyways
2018-01-09 15:24:45 +01:00
Chris Houseknecht
623ff39443
Separate common and raw (#34563) 2018-01-09 07:22:46 -05:00
Abhijeet Kasurde
b14c8b130f yum: handle exception in local_envra (#34400)
This fix adds rpm.error exception which is raised when
API unable to get envra information from RPM package.
Also, adds integration test for local_envra method.

Fixes: #30074

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-09 12:28:55 +01:00
osLEccse
9c7d987395 Update developing_api.rst (#34629)
Module path needs to be array instead of a string variable in order to work.
2018-01-09 11:23:01 +00:00
Abhijeet Kasurde
7d037991a3 nmcli: Handle dbus exception (#34577)
This adds exception handling for dbus related code.

Fixes: #34546

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-09 10:03:36 +01:00
Anil Kumar Muraleedharan
436ca0a0a1 Bug Fix at cnos.py (#34607)
* Bug Fix at cnos.py

* Removed extra blank space
2018-01-09 08:33:45 +00:00
Clement Trebuchet
d5a8974ef3 Add the ability for the ios_vrf module to apply route targets to a VRF (#34248)
* Add the ability for the ios_vrf module to apply route targets to a VRF

* Fix W293 blank line contains whitespace
2018-01-09 02:04:18 -05:00
David Soper
9d1c48f7a4 Document descriptions updated to match UCS Manager online help. (#34593)
kwargs variable argument setup simplified.
2018-01-09 07:58:22 +01:00
Matt Clay
77726b471f Make xattr test conditional on feature support. 2018-01-08 22:39:37 -08:00
Lars Kellogg-Stedman
29fbf0c756 remove erroneous '.' in docsite footer (#34592)
This removes an erroneous '.' in the docsite that someone pointed out
on irc.
2018-01-08 22:36:47 -08:00
Matt Clay
9599630976
Fixes for dnf and user integration tests. (#34603)
* Fix user test.
* Use `dnf` instead of `yum` in dnf test.
* Install correct version of rpmfluff for tests.
2018-01-08 16:36:53 -08:00
Matt Martz
70cafcdef6 First pass at fixing #33064 (#33636) 2018-01-08 18:13:22 -05:00
Cedric Pimenta
cd1b144c0a Improve documentation about Comment filter (#34539)
Include a mention to the decoration option, which allows someone to
specify the character comment to be used.
2018-01-08 15:07:32 -08:00
Adam Miller
80fb81414b
initial firewalld integration tests (#31725)
* Add a couple test cases to get some baseline integration testing in
for firewalld.

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>
2018-01-08 14:23:50 -08:00
Adam Miller
a67e922a40 fix ansible-galaxy requirements.yml import_tasks->include in docs (#34519)
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-01-08 16:18:40 -06:00
Matt Martz
df909c5726
Fix with_items debug loop example. Fixes #34540 (#34578) 2018-01-08 16:13:10 -06:00
Abhijeet Kasurde
08a1d47427 nmcli: Add missing 'primary' option (#34252)
This fix adds missing 'primary' option in nmcli module.

Fixes: #30405

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-08 13:37:21 -08:00
Adam Miller
39edee7572
service_facts module (#34065)
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-01-08 13:35:16 -08:00
Daniel Shepherd
56da2c13d6 [cloud] Add ipv6 support to ec2_vpc_nacl_facts (#30581)
* wrap boto3 connection in try/except and handle exception, add traceback import

* params dont need to be mutually exclusive and support check mode

* add check to set nacl_ids to empty list instead of None for boto3 func

* standard exception handling using traceback

* update current RETURN documentation which is incorrect.

* update logic to check for and return ipv6 cidr instead of ipv4 cidr in a NACL

* ignore default and reserved rule numbers - greater than 32766

* was breaking on non-standard protocol numbers - AWS nacls now support full list -1 to 254

* update port range and icmp type/code handling

* add some more detail to returned nacl entries

* Update exception handling to account for BotoCoreError

Remove exception handling from the boto connection creation since it does nothing

* rules numbers from 32767 to 65535 are reserved for internal AWS use so we ignore here
2018-01-08 16:24:40 -05:00
Dag Wieers
dca5d9bbd4
Fix typo and copyright statement 2018-01-08 22:14:55 +01:00
Matt Clay
d5eef2f8a9 Use dnf upgrade in Fedora Dockerfiles. 2018-01-08 13:08:29 -08:00
Matt Clay
61d155b315 Update Fedora Dockerfiles for Python 3 testing. 2018-01-08 12:46:08 -08:00
Vinay Dandekar
f20af4b909 [cloud] Change S3 MD5 checksum for multipart support in aws_s3 (#34216)
- If file has only one part and is uploaded as multipart, it is still computed the same way as having multiple parts
2018-01-08 15:21:45 -05:00
Tomas Tomecek
0587aedc01 synchronize: add support for buildah (#33823)
Fixes #33533

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
2018-01-08 11:51:49 -08:00
Jordan Borean
c9e9422133 Added new windows module changelog entry 2018-01-09 05:46:51 +10:00
Jordan Borean
b2a415daae
win_certificate_store: added new module (#33980)
* win_certificate_store: added new module

* added warning about become or credssp for pfx
2018-01-09 05:44:24 +10:00
Sloane Hertel
34206a0402 ec2_vpc_vgw_facts: fix getting facts about gateways without tags (#34575) 2018-01-08 13:16:49 -05:00
Ganesh Nalawade
458cc38992
Fix connection type in junos integration tests (#34583)
* Fix connection type in junos integration tests

*  For find module in junos integration test
   add connection type local and delegate task to localhost

* Fix review comment
2018-01-08 23:22:53 +05:30
David Soper
dc85176512 Document descriptions updated to match UCS Manager online help. (#34581)
kwargs variable argument setup simplified.
2018-01-08 18:39:23 +01:00
Sloane Hertel
788010d0f0 [cloud][testing] New integration tests for ec2_asg (#30554)
* Add some integration tests for ec2_asg.

* Remove exception handling from ec2_asg boto3 connection since it is handled in boto3_conn().

* Update test failure assertions

* Use yaml anchor for credentials and remove unnecessary dependencies.

* Move AWS boto3 module credentials tests to separate target

* Remove filters from tests
2018-01-08 11:21:49 -05:00
Nathaniel Case
46263d77f1
Fixes for nxos_config integration tests (#34579)
* deletage_to: localhost -> connection: local

* Fix test setup
2018-01-08 10:56:47 -05:00
John R Barker
42dd48a6d0
Update done Network 2018-01-08 15:21:43 +00:00
Samer Deeb
473b2d58ec Add new module mlnxos_mlag_vip for configuring MLAG VIP on Mellanox network devices (#34285)
* Add new module mlnxos_mlag_vip for configuring MLAG VIP on Mellanox
network devices

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Remove unused variables

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix Test class name

* Fix Documentation

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix MAC address case-insensitive

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix MAC address unit-test

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-08 14:31:51 +00:00
Samer Deeb
ad73bda323 Add new module mlnxos_protocol for enabling disabling protocols on MLNX-OS Mellanox network devices (#34286)
* Add new module mlnxos_protocol for enabling disabling protocols on
MLNX-OS Mellanox network devices

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix Test Class name

* Fix IP routing protocol support

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Add missing support for check_mode, and Fix documentation

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-08 14:30:30 +00:00
Samer Deeb
943107b1b9 Add new module mlnxos_facts for retrieving facts of MLNX-OS Mellanox network devices (#34287)
* Add new module mlnxos_facts for retrieving facts of MLNX-OS Mellanox
network devices

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix Documenation and Examples

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-08 14:29:16 +00:00
Johannes Truschnigg
00d75ff449 Fix Linux blockdevice size computation (#34475)
Linux' sysfs _always_ reports device size in 512b sector units,
regardless of the device's actual, physical blocksize.
2018-01-08 06:18:25 -08:00