Commit graph

9266 commits

Author SHA1 Message Date
Gregor Giesen
2f3fdc4975 cron: replacement for os.getlogin() (#4777)
os.getlogin() returns the user logged in on the controlling terminal. However
'crontab' only looks for the login name of the process' real user id which
pwd.getpwuid(os.getuid())[0] does provide.

While in most cases there is no difference, the former might fail under certain
circumstances (e.g. a lxc container connected by attachment without login),
throwing the error 'OSError: [Errno 25] Inappropriate ioctl for device'.
2016-09-12 07:39:12 +02:00
Peter Sprygada
987d9b2b4a Merge pull request #4785 from privateip/nxos_config
roll up updates to nxos_config module
2016-09-11 23:47:31 -04:00
Peter Sprygada
61f9fde886 Merge pull request #4788 from privateip/sros_config
roll up updates to sros_config module
2016-09-11 23:47:18 -04:00
Peter Sprygada
3f5e9ee526 Merge pull request #4786 from privateip/iosxr_config
roll up of updates to iosxr_config module
2016-09-11 23:47:04 -04:00
Peter Sprygada
e722ecc3b4 Merge pull request #4784 from privateip/junos_config
roll up updates to junos_config module
2016-09-11 23:46:53 -04:00
Peter Sprygada
739cc715df Merge pull request #4787 from privateip/vyos_config
roll up of updates to vyos_config module
2016-09-11 23:46:38 -04:00
Peter Sprygada
bb66f10b44 Merge pull request #4789 from privateip/ios_config
roll up of updates to ios_config module
2016-09-11 23:46:26 -04:00
Peter Sprygada
efff96bbdd Merge pull request #4790 from privateip/eos_config
roll up of updates to eos_config module
2016-09-11 23:46:09 -04:00
Peter Sprygada
e5ae9b9eea Merge pull request #4783 from privateip/ops_config
roll up updates to ops_config module
2016-09-11 23:45:58 -04:00
nitzmahone
1a0e15094f Fix win_user issue with disabled accounts/expired passwords
Disabled and password-expired accounts cannot call ValidatePassword successfully

fixed #4369
2016-09-11 20:41:54 -07:00
Peter Sprygada
19f1bc07cb roll up updates to nxos_config module
* remote 'updates' argument
* clean up functions
* update doc strings
* add required_if dependencies
2016-09-11 23:25:33 -04:00
Peter Sprygada
42856d9949 roll up updates to junos_config module
* remove 'update' argument
* update doc strings
* reorder functions
2016-09-11 23:23:57 -04:00
Peter Sprygada
f5e64a8953 roll up updates to ops_config module
* 'before' and 'after' now only apply to 'lines' argument
* add required_if dependencies
* update doc strings
* remove 'update' argument
* clean up functions
2016-09-11 23:22:00 -04:00
Peter Sprygada
4f03036428 roll up updates to sros_config module
* update doc strings
* update message if rollback isn't configured
2016-09-11 23:19:23 -04:00
Peter Sprygada
4217adb469 roll up of updates to vyos_config module
* remove 'udpates' argument
* add required_if dependencies
* clean up functions
* update doc strings
2016-09-11 23:17:21 -04:00
Peter Sprygada
e6f1f295f7 roll up of updates to iosxr_config module
* 'before' and 'after' arguments now only apply to 'lines'
* update doc strings
* remove update argument
* clean up warnings
2016-09-11 23:14:28 -04:00
Peter Sprygada
9b5e6bbfa1 roll up of updates to ios_config module
* 'before' and 'after' are now only applied to 'lines'
* remove update argument
* update doc strings
* add path argument when performing config difference
2016-09-11 23:11:59 -04:00
Peter Sprygada
9df9a1dbd4 roll up of updates to eos_config module
* removes update argument
* adds `config` option to replace argument
* moves session management into shared module
* cleans up doc strings
* `before` and `after` args now only apply to lines
2016-09-11 15:31:53 -04:00
Andrew Gaffney
0c05f0dfa4 Fix missing colons in network module examples (#4778) 2016-09-10 14:46:30 +01:00
Peter Sprygada
1ab343a74c Merge pull request #4775 from privateip/sros_rollback
add new module sros_rollback
2016-09-10 02:46:00 -04:00
Peter Sprygada
8e1e8c2cca add new module sros_rollback
Provides a configuration resource for managing the rollback feature on
remote devices running Nokia SROS
2016-09-10 02:43:25 -04:00
Chris Houseknecht
ea9c53e709 Merge pull request #4774 from chouseknecht/devel
Set default log_driver to None
2016-09-10 01:42:13 -04:00
Chris Houseknecht
de0122fdaf
Set default log_driver to None to prevent config comparison when a log_driver is not specified. Fixes #4600. 2016-09-10 01:31:36 -04:00
Chris Houseknecht
01c4d5f99d Merge pull request #4773 from chouseknecht/devel
Purge networks by network name
2016-09-10 00:55:31 -04:00
Chris Houseknecht
0d43a01462 Purge networks using network name rather than ID. Fixes 4596. 2016-09-10 00:51:21 -04:00
Chris Houseknecht
6a9c531bdd Merge pull request #4772 from chouseknecht/devel
Default restart_retries to None rather than 0. Fixes #4534.
2016-09-09 22:33:45 -04:00
Chris Houseknecht
cac4e68090
Default restart_retries to None rather than 0. Fixes #4534. 2016-09-09 22:20:56 -04:00
Ryan Brown
819fe45864 Fix failure when powering on/off EC2 instances by tag only. (#4767)
If you apply `wait=yes` and use `instance_tags` as your filter for
stopping/starting EC2 instances, this stack trace happens:

```
An exception occurred during task execution. The full traceback is:                                                                          │~
Traceback (most recent call last):                                                                                                           │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1540, in <module>                                                            │~
    main()                                                                                                                                   │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1514, in main                                                                │~
    (changed, instance_dict_array, new_instance_ids) = startstop_instances(module, ec2, instance_ids, state, instance_tags)                  │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1343, in startstop_instances                                                 │~
    if len(matched_instances) < len(instance_ids):                                                                                           │~
TypeError: object of type 'NoneType' has no len()                                                                                            │~
                                                                                                                                             │~
fatal: [localhost -> localhost]: FAILED! => {"changed": false, "failed": true, "invocation": {"module_name": "ec2"}, "module_stderr": "Traceb│~
ack (most recent call last):\n  File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1540, in <module>\n    main()\n  File \"/tmp/│~
ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1514, in main\n    (changed, instance_dict_array, new_instance_ids) = startstop_instances│~
(module, ec2, instance_ids, state, instance_tags)\n  File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1343, in startstop_insta│~
nces\n    if len(matched_instances) < len(instance_ids):\nTypeError: object of type 'NoneType' has no len()\n", "module_stdout": "", "msg": "│~
MODULE FAILURE", "parsed": false}
```

That's because the `instance_ids` variable is None if not supplied
in the task. That means the instances that result from the instance_tags
query aren't going to be included in the wait loop. To fix this, a list
needs to be kept of instances with matching tags and that list needs to
be added to `instance_ids` before the wait loop.
2016-09-09 19:38:05 -04:00
Dag Wieers
1cda0b1819 Ensure unicode characters in zip-compressed filenames work correctly (#4702)
* Ensure unicode characters in zip-compressed filenames work correctly

Another corner-case we are fixing hoping it doesn't break anything else.

This fixes:
- The correct encoding of unicode paths internally (so the filenames we scrape from the output and is returned by zipfile match)
- Disable LANG=C for the unzip command (because it breaks the unicode output, unlike on gtar)

* Fix for python3 and other suggestions from @abadger
2016-09-09 09:26:19 -07:00
Peter Sprygada
477c71d985 minor updates to junos_package module for 2.2 (#4761)
* replaces get_module() with NetworkModule()
* removes old call to package_version()
2016-09-09 17:25:21 +01:00
Peter Sprygada
4277b88de5 update junos_facts module to remove get_module() factory function (#4760)
Replaces get_module() with NetworkModule instance
2016-09-09 17:22:43 +01:00
Peter Sprygada
7b46245ecb Merge pull request #4758 from privateip/iosxr_config
adds path kwarg when difference() is called from iosxr_config
2016-09-09 08:56:06 -04:00
Peter Sprygada
3d365c5cf8 adds path kwarg when difference() is called from iosxr_config
Adds the path kwarg to handle use cases with exact and strict matching
2016-09-09 08:46:33 -04:00
Peter Sprygada
684c6897e2 Merge pull request #4701 from GGabriele/nxos_vrrp
nxos_vrrp update
2016-09-08 22:00:39 -04:00
Peter Sprygada
c113a3ef8e Merge pull request #4686 from GGabriele/nxos_igmp_interface
Adding nxos_igmp_interface
2016-09-08 22:00:22 -04:00
Peter Sprygada
24b68d73e8 Merge pull request #4684 from GGabriele/nxos_vrf_interface
nxos_vrf_interface support for 2.1 and 2.2
2016-09-08 22:00:10 -04:00
Peter Sprygada
fd2a0da5b1 Merge pull request #4682 from GGabriele/nxos_vlan
nxos_vlan support 2.1 and 2.2
2016-09-08 22:00:01 -04:00
Peter Sprygada
fda1771276 Merge pull request #4685 from GGabriele/nxos_igmp
Adding nxos_igmp
2016-09-08 21:59:34 -04:00
Peter Sprygada
412a44317c Merge pull request #4683 from GGabriele/nxos_vrf
Updating nxos_vrf
2016-09-08 21:59:20 -04:00
Peter Sprygada
550001372e Merge pull request #4681 from GGabriele/nxos_ping
nxos_ping support for 2.1 and 2.2
2016-09-08 21:58:58 -04:00
Peter Sprygada
e6bbc5a828 Merge pull request #4680 from GGabriele/nxos_ip_interface
nxos_ip_interface support for 2.1 and 2.2
2016-09-08 21:58:21 -04:00
Peter Sprygada
49cb49f8b9 Merge pull request #4677 from GGabriele/nxos_reboot
Adding nxos_reboot
2016-09-08 21:57:52 -04:00
Peter Sprygada
1a0e3003a0 Merge pull request #4676 from GGabriele/nxos_feature
nxos_feature 2.1 and 2.2 support
2016-09-08 21:57:15 -04:00
Peter Sprygada
a71a36cee2 Merge pull request #4675 from GGabriele/nxos_rollback
Adding nxos_rollback
2016-09-08 21:57:00 -04:00
Peter Sprygada
9377666fc4 Merge pull request #4672 from GGabriele/nxos_vrf_af
Adding nxos_vrf_af
2016-09-08 21:55:56 -04:00
Peter Sprygada
6d02dc4f2c Merge pull request #4670 from GGabriele/nxos_vpc_interface
Adding nxos_vpc_interface
2016-09-08 21:55:44 -04:00
Peter Sprygada
30c8c8e17e Merge pull request #4669 from GGabriele/nxos_vpc
Adding nxos_vpc
2016-09-08 21:55:20 -04:00
Peter Sprygada
944aa8644b Merge pull request #4673 from GGabriele/nxos_vxlan_vtep
Adding nxos_vxlan_vtep
2016-09-08 21:55:06 -04:00
Peter Sprygada
0bcad5a71d Merge pull request #4667 from GGabriele/nxos_static_route
Adding nxos_static_route
2016-09-08 21:54:55 -04:00
Peter Sprygada
fce047f2f4 Merge pull request #4666 from GGabriele/nxos_smu
Adding nxos_smu
2016-09-08 21:54:16 -04:00