Commit graph

7199 commits

Author SHA1 Message Date
Michael DeHaan
35cb9dc22f Work in progress about cleaning up template code. 2013-10-19 11:39:52 -04:00
Michael DeHaan
baebe6da0a Merge pull request #4598 from awiddersheim/patch-1
Fixed typo in docsite/rst/playbooks_tags.rst
2013-10-19 06:23:27 -07:00
awiddersheim
9d141c5f34 Fixed typo in docsite/rst/playbooks_tags.rst 2013-10-18 23:00:50 -04:00
Michael DeHaan
232eb9f8e6 Merge pull request #4595 from mscherer/fix_4563
fix logic in module host to add aliases even if none exist already, fix #4563
2013-10-18 17:09:23 -07:00
Michael DeHaan
b5c34308dd Merge pull request #4594 from mscherer/fix_4587
fix distribution detection in apt_repository module, so it also work on mint as it work on Debian, partially fix #4587
2013-10-18 17:08:35 -07:00
Michael Scherer
d5c290b513 fix logic in module host to add aliases even if none exist already, fix #4563
self._has_aliases is used to know if a alias already exist, but
the test we want is to know if we need to add a new alias, which
is stored in self.aliases
2013-10-19 01:51:42 +02:00
Michael Scherer
19bb44288e fix distribution detection in apt_repository module, so it also work
on Mint as it work on Debian, fix #4587.

PPAs are not supported however, since that's a Ubuntu specific feature
and mint is detected as a generic distribution and use a different
codename than the Ubuntu release it is based on, which mean that apt_repository
cannot add detect and add the proper url without a better heuristic.
2013-10-19 00:57:08 +02:00
Michael DeHaan
7b6d64d98c Merge pull request #4591 from bcoca/scriptnonrootsudosafe
now correctly changes script permission in all cases
2013-10-18 15:04:09 -07:00
James Tanner
3c4dd618e4 Fixes #4454 Make a temporary clean cnf file if unable to parse existing 2013-10-18 17:42:40 -04:00
Brian Coca
c476ed93ca now correctly changes script permission in all cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2013-10-18 16:52:15 -04:00
Michael DeHaan
1d090b5b25 Merge pull request #4588 from maxamillion/maxamillion/docfix-changed_when
fix change_when example for False
2013-10-18 11:35:00 -07:00
Adam Miller
5b2338b2bf fix change_when example for False 2013-10-18 13:13:13 -05:00
James Tanner
8478e82647 Fixes #4583 enforce that vars_files is a list 2013-10-18 11:19:16 -04:00
jctanner
92edf99c80 Merge pull request #4562 from nimbis/devel
Adding aws_access_key and aws_secret_key aliases to ec2_group arguments
2013-10-18 06:17:50 -07:00
Michael DeHaan
b0f6e77f66 Merge pull request #4571 from tgerla/whitespace
add_group module: strip trailing/leading whitespace from comma-separated group names
2013-10-17 16:09:09 -07:00
Tim Gerla
51a1709253 add_group module: strip trailing/leading whitespace from comma-separated group names 2013-10-17 14:13:55 -07:00
James Tanner
242f20c297 Fixes #4402 wrong order for isinstance parameters in dnstxt.py 2013-10-17 15:43:39 -04:00
Brian Schott
bdc8ea828e added aws_access_key and aws_secret_key aliases to ec2_group arguments 2013-10-17 15:23:24 -04:00
jctanner
12eaefb7e6 Merge pull request #4539 from sayap/git-sha1
git: Always return the before/after revisions, even in check mode.
2013-10-17 11:36:03 -07:00
Michael DeHaan
8666f8ea24 Merge pull request #4568 from mmoya/features
Improve change detection in mysql_variables
2013-10-17 10:51:36 -07:00
James Tanner
4f674ec522 Fixes #4554 Enumerate user homedir if not passed as an argument 2013-10-17 13:15:32 -04:00
Maykel Moya
b90a250165 Improve change detection in mysql_variables
mysql_variables bindly executes a SET var = value query even when
the variable already has the requested value.

With this patch the query is executed only if the current value is
different to the requested one.
2013-10-17 19:13:58 +02:00
Michael DeHaan
8a516d1479 Various standardization to the proposed gce_storage module to bring things in line with updates to the S3 module.
Some typo fixes.

Further testing required.
2013-10-17 10:49:51 -04:00
Michael DeHaan
4bdf3da25a Merge pull request #4333 from bennojoy/gcs
support for google cloud storage module
2013-10-17 07:35:53 -07:00
Michael DeHaan
baa13a5cc7 Merge pull request #4395 from erjohnso/devel
adding Google Compute Engine modules and inventory plugin
2013-10-17 07:30:55 -07:00
Michael DeHaan
ffaabc54bb Merge pull request #4559 from greenalto/fix_typo
Fix typo
2013-10-17 07:26:33 -07:00
Greg Karékinian
86f4e03bb5 Fix typo 2013-10-17 16:00:58 +02:00
Michael DeHaan
4484ba8a49 Merge pull request #4553 from mmoya/features
Do key validation only when key is provided
2013-10-17 05:18:17 -07:00
Maykel Moya
2592b2c3f9 Do key validation only when key is provided
key_id is optional, the previous code didn't handle the case of key_id
not specified
2013-10-17 12:04:04 +02:00
jctanner
6480945184 Merge pull request #4541 from Kami/improve_template_render_error_messages
Make errors which get thrown during template rendering more user-friendly
2013-10-16 17:52:07 -07:00
jctanner
7e8e186b3b Merge pull request #4517 from adfinis-sygroup/devel
Remove keys regardless of the options
2013-10-16 17:40:43 -07:00
jctanner
c737f222d5 Merge pull request #4480 from joemaller/absent_path_fix
ignore src when file module state=absent
2013-10-16 17:29:21 -07:00
jctanner
51a1a54bfb Merge pull request #4428 from robparrott/devel
Properly handle DEFAULT section with ConfigParser in ini_file modules
2013-10-16 17:18:17 -07:00
James Tanner
23cbdba65e Fixes #4350 Create homedirectory if create=yes and directory is missing 2013-10-16 20:08:41 -04:00
Michael DeHaan
8a3f222d41 Merge pull request #4548 from stoned/ansible-doc-fix
Fix 'ansible-doc -l' runtime error following commit 4430d0f
2013-10-16 15:59:41 -07:00
Stoned Elipot
c7217a8f1b Fix 'ansible-doc -l' runtime error following commit 4430d0f
skip "module" not found as plugin, id est directory
2013-10-16 21:58:54 +02:00
Michael DeHaan
f9ac88c9da Merge pull request #4547 from stoned/find_plugin-fix
when searching for a plugin only look for a regular file
2013-10-16 12:35:02 -07:00
Michael DeHaan
db7e4510f2 Merge pull request #4544 from mmoya/features
apt_key: Validate key_id and accept a leading '0x'
2013-10-16 12:32:28 -07:00
Stoned Elipot
4430d0f5a6 when searching for a plugin only look for a regular file 2013-10-16 21:23:37 +02:00
Michael DeHaan
1317ece644 Merge pull request #4543 from lorin/s3-walrus
s3: better check for walrus
2013-10-16 12:18:48 -07:00
Maykel Moya
1a79d9ae58 apt_key: Validate key_id and accept a leading '0x' 2013-10-16 20:52:18 +02:00
Lorin Hochstein
1c5bdba977 s3: better check for walrus
Check for Walrus endpoint by looking to see if the endpoint is not AWS.

This fixes a bug where the user specifies an AWS endpoint via S3_URL,
but the code interprets it as Walrus and then fails.
2013-10-16 13:22:41 -04:00
Tomaz Muraus
922f61899e Throw a more user-friendly exception during template rendering process. 2013-10-16 16:48:17 +02:00
James Tanner
807e602228 mysql_db: if connection is a socket, do not specify hostname 2013-10-16 09:59:31 -04:00
James Tanner
84a692bcf7 Fixes #4301 Use module_common functions for mysqldump and return better errors 2013-10-16 09:51:08 -04:00
Michael DeHaan
efe2a9fb1d Merge pull request #4538 from mulby/gabe/arguments-sudo
Ensure non-root users can read arguments file when using sudo_user and non-standard modules
2013-10-16 06:07:55 -07:00
Yap Sok Ann
8519d586ba git: Don't add --branch while cloning if the version is a SHA-1 hash. 2013-10-16 20:37:07 +08:00
Yap Sok Ann
9f8cdac0aa git: Handle network problem when running git ls-remote. 2013-10-16 20:37:07 +08:00
Yap Sok Ann
a53e7045a6 git: Always return the before/after revisions, even in check mode.
The return values from check mode and non-check mode should match in all cases,
except when a SHA-1 hash is used as version, as there is no way to check if it
is a valid hash using `git ls-remote`.

Also, to accomodate this change, the force flag for the reset function has been
removed so that we can do the checking in main.
2013-10-16 20:37:07 +08:00
Yap Sok Ann
b9558828e8 git: Make function get_remote_head usable when cloning.
This allows the module to return the before/after revisions in all cases.
2013-10-16 20:37:07 +08:00