Brian Coca
5b1a508d6a
restored quotes to checksum description to avoid breaking docs
2016-12-08 11:23:39 -05:00
Gerard Lynch
27f93bef40
minor doc fix
2016-12-08 11:23:39 -05:00
muszynski@so1.net
2e3ad2b80a
description for the get_url module describing checksum verification before file download
2016-12-08 11:23:39 -05:00
Colin Hutchinson
d70c33f932
make a text link into a actual hyperlink
...
the text link doesn't fit on some screen resolutions. Making it into sphinx hyperlink will solve that
2016-12-08 11:23:39 -05:00
Matias De Carli
f2bc0a6d85
keep backwards compatibility
2016-12-08 11:23:39 -05:00
Simon Li
607b7c14bd
Fix incorrect variable in group.py: user -> group
2016-12-08 11:23:39 -05:00
Toshio Kuratomi
99659c8667
Fix docs build
2016-12-08 11:23:38 -05:00
David Shrewsbury
bf9c3e0092
Add author to os_router
2016-12-08 11:23:38 -05:00
David Shrewsbury
78ea0df607
Deprecate older router modules.
...
The quantum_router_gateway.py and quantum_router_interface.py modules
are deprecated with this change.
2016-12-08 11:23:38 -05:00
James Cammarata
395253c581
A few bug fixes and tweaks for the accelerate module
2016-12-08 11:23:38 -05:00
Brian Coca
45907f2ff3
removed typo
2016-12-08 11:23:38 -05:00
Brian Coca
d55ba3ab7c
removed syslog in favor of common module logging functions
2016-12-08 11:23:38 -05:00
Brian Coca
682cb99d45
revert must_exist
2016-12-08 11:23:38 -05:00
Shayne Clausson
92f88a4cb4
Replaces 'old' get_ec2_creds connection method with get_aws_connection_info to support passing in security_token for temporary creds.
2016-12-08 11:23:38 -05:00
David Shrewsbury
f91cc1d3e5
Allow setting external attribute
...
With shade > 0.13.0, networks can be created that are externally
accessible. This adds a parameter for that.
Also, add RETURN documentation and 'if __name__' check around call
to main().
2016-12-08 11:23:38 -05:00
David Shrewsbury
14546fe33c
Allow complete router configuration
...
This change allows one to completely configure a router, including
gateway and interfaces, using the latest shade (>0.13.0).
2016-12-08 11:23:38 -05:00
justnom
b724bf8f1c
Adding additional Docker log drivers.
...
Adding additional `log_driver` choices:
* journald
* gelf
* fluentd
Compatible with Docker version >= 1.8.0
2016-12-08 11:23:38 -05:00
Alex Kessinger
4d227e508d
Fix a argument mismatch in elasticache
...
I think in this commit 720aeffca2
There was bug introduced where the ElastiCacheManager init method has
a number of positional arguments like so.
```py
def __init__(self, module, name, engine, cache_engine_version, node_type,
num_nodes, cache_port, parameter_group, cache_subnet_group,
cache_security_groups, security_group_ids, zone, wait,
hard_modify, region, **aws_connect_kwargs):
```
But then later in the code the positional arguments are passed in
like this.
```py
elasticache_manager = ElastiCacheManager(module, name, engine,
cache_engine_version, node_type,
num_nodes, cache_port,
cache_subnet_group,
cache_security_groups,
security_group_ids, parameter_group, zone, wait,
hard_modify, region, **aws_connect_kwargs)
```
If you count, you can see that cache_subnet_group, is being passed in
where the manager expects to see parameter_group.
2016-12-08 11:23:38 -05:00
Matt Calhoun
52f9c3468c
The variable $uppercase_cert_thumbprint cannot be retrieved because it has not been set.
2016-12-08 11:23:38 -05:00
Matt Calhoun
a9d954b087
The variable $winrm_cert_thumbprint cannot be retrieved because it has not been set.
2016-12-08 11:23:38 -05:00
Matt Calhoun
70f7f144e0
The variable $https_listener cannot be retrieved because it has not been set.
2016-12-08 11:23:38 -05:00
Matt Calhoun
72970ab7a8
The variable $winrm_https_listener_path cannot be retrieved because it has not been set
2016-12-08 11:23:38 -05:00
Jens Carl
00f9dfac34
Change type of parameter 'template' to 'path'.
2016-12-08 11:23:38 -05:00
Gerard Lynch
f85a8ac746
allow use of volume_type in volumes dict
2016-12-08 11:23:37 -05:00
Jens Carl
507111f090
Fix to handle user directory within parameter 'template'.
2016-12-08 11:23:37 -05:00
Toshio Kuratomi
e7a48cfb40
Use is_executable from its new location
2016-12-08 11:23:37 -05:00
Toshio Kuratomi
e7d9d86ec9
No longer check for tmp_path being sent as we don't use it here anyway
2016-12-08 11:23:37 -05:00
Tom Bamford
dbf882a600
Clarify available options for device_mapping parameter of ec2_ami module
2016-12-08 11:23:37 -05:00
varnav
a05df49998
Fixed confusion in the docs
...
As 'path' is actually alias for 'dest', this could be confusing.
2016-12-08 11:23:37 -05:00
Toshio Kuratomi
58573187f8
Change the example of rsync_opts to use a list instead of a string
...
Fixes #9889
2016-12-08 11:23:37 -05:00
Shawn Silva
2962dabeda
Fix for modifying the size of an RDS instance. When attempting to modify the size of an RDS instance Ansible succeeds and returns a "changed" status. However, no changes are applied to the RDS instance. Boto is looking for a keyword parameter of "allocated_storage" to update the size, and this parameter wasn't being included.
2016-12-08 11:23:37 -05:00
Selivanov Pavel
63d2575f9f
ec2_group.py: added ICMP rule example
2016-12-08 11:23:37 -05:00
Greg DeKoenigsberg
c2cc7f17a3
Change author field for os_redhat_subscription.py
2016-12-08 11:23:37 -05:00
Nathaniel Felsen
ec14a5c728
Adding support for access logs in ELB
2016-12-08 11:23:37 -05:00
dagnello
ec1c18e3d5
Adding new os_subnets_facts module
...
There can be instances during an Ansible play where the list of subnets
currently available from OpenStack is required. This update provides
subnet list functionality as a new os_subnets_facts module.
2016-12-08 11:23:37 -05:00
Matias De Carli
d32809cadb
updated dependencies to work with azure.py 1.0.1
2016-12-08 11:23:37 -05:00
dagnello
d46894cf91
Adding new image facts module
2016-12-08 11:23:37 -05:00
dagnello
d76f6cceed
Adding os_port Module to openstack ansible modules
2016-12-08 11:23:36 -05:00
whiter
82c898be5a
Remove 'str' type so that json is properly quoted
2016-12-08 11:23:36 -05:00
Chris Church
7eb7efb737
Fix win_lineinfile to pass integration tests when strict mode is enabled.
2016-12-08 11:23:36 -05:00
dagnello
a4148c50e9
Adding os_networks_facts module
...
There can be instances during an Ansible play where the list of networks
currently available from OpenStack is required. This update provides
network list functionality as a new os_networks_facts module.
2016-12-08 11:23:36 -05:00
Abitha Palaniappan
5047561036
os_server: Adding support to accept 'n' nic args as a string containing list
2016-12-08 11:23:36 -05:00
Mike Boone
dd76088019
Updated link to the FAQ.
2016-12-08 11:23:36 -05:00
evanccnyc@users.noreply.github.com
ff81aa11c0
Fixing ec2_asg termination_policy
...
If this isnt set, it wont launch the instances because it needs to default to "Default" despite what boto docs say.
2016-12-08 11:23:36 -05:00
Chris Church
c56db7920a
Revert "Improvements to win_feature"
2016-12-08 11:23:36 -05:00
James Cammarata
4a4674ca24
Fix syntax error in synchronize docstring
2016-12-08 11:23:36 -05:00
David Shrewsbury
b67fb2bd29
More os_router module cleanup and fixes.
...
Added a RETURN section, corrected version_added value, removed use of
'result' in exit_json() calls.
2016-12-08 11:23:36 -05:00
Frank van Tol
db6c6ec5c9
Update s3.py
...
We are copying from S3, the bucket is the source, not the target.
2016-12-08 11:23:36 -05:00
Rob
08999ecfd1
Update iam_policy.py
...
Fixed doc for policy_name - it is a required field
Removed empty aliases
2016-12-08 11:23:36 -05:00
Chris Church
c35d7304c9
Revert "Rename powershell versions of setup and slurp so they don't shadow the python versions of these modules."
...
This reverts commit d4e16b0c73
.
2016-12-08 11:23:36 -05:00
Gerard Lynch
3339749017
order params, add missing tag param. update examples
2016-12-08 11:23:36 -05:00
Toshio Kuratomi
29cfd80220
Fix improper indentation
2016-12-08 11:23:36 -05:00
skylerbunny
dabf94ab1f
Explanation of privilege escalation in notes
...
An attempt to make clear how privilege escalation works with respect to the src/source host and dest/destination host. One existing note was incorporated into three new ones, iterating each.
2016-12-08 11:23:36 -05:00
Toshio Kuratomi
8ce7348d52
Rename powershell versions of setup and slurp so they don't shadow the python versions of these modules.
...
This change goes along with https://github.com/ansible/ansible/02502c5727753d02819cb32b94dc2035b65d81a7
2016-12-08 11:23:35 -05:00
Evan Carter
5cd3217fc8
fixing termination policies for ec2_asg
2016-12-08 11:23:35 -05:00
Evan Carter
e9c04cfdfd
Fixing bug #2058 and adding some backwards compatibility
2016-12-08 11:23:35 -05:00
Brian Coca
99159b3cdd
changed chmod to 2.4 compat
2016-12-08 11:23:35 -05:00
Rob
4f9bb86e58
Add exception handling to iam
2016-12-08 11:23:35 -05:00
wimnat
540061c9fc
Remove unnecessary json.loads
2016-12-08 11:23:35 -05:00
Tom Fotherby
135e7c60de
Fix #1984 - allow load_balancer_port as a variable
2016-12-08 11:23:35 -05:00
Abitha Palaniappan
d26bff8162
Add support for port-id,port-name to nics in os_server
2016-12-08 11:23:35 -05:00
Sam Mingo
75473c0fd0
Update get_url.py
...
Fixed typo with header parameter to get_url in the documentation.
2016-12-08 11:23:35 -05:00
Victor Costan
8d9768c049
Fix indentation in os_server documentation
2016-12-08 11:23:35 -05:00
Yanchek99
ebbd206e86
Fixed typo for instance_tags documentation
2016-12-08 11:23:35 -05:00
David Dyball
cdff62643b
Updated PR based on comments
2016-12-08 11:23:35 -05:00
Taneli Lepp
fb317c72b6
Added option to set multiple ACLs for S3 objects. Also verifies the selected permissions against Boto's canned ACL strings list.
2016-12-08 11:23:35 -05:00
Bret Martin
b1c5b17155
Use general-purpose parameter mutual exclusion code for network_interfaces
2016-12-08 11:23:35 -05:00
Bret Martin
0afa813324
Add alias network_interface
and accept a string for a single ENI
2016-12-08 11:23:35 -05:00
Bret Martin
df8b2d45bc
Add network_interfaces example
2016-12-08 11:23:35 -05:00
Bret Martin
96d8401fb4
Remove aliases specification from documentation since there are none
2016-12-08 11:23:35 -05:00
Brian Coca
281a92bbdd
corrected whitepace
2016-12-08 11:23:34 -05:00
Toshio Kuratomi
b952dff2c1
correct documentation formatting
2016-12-08 11:23:34 -05:00
Victor Costan
2f11d96d49
os_server: nice error when flavor not found
...
When we can't find the VM flavor that the user requests, this change replaces the non-descript stack trace with a clear error message.
2016-12-08 11:23:34 -05:00
Bret Martin
df713192b4
Add network_interfaces parameter to ec2 module to support launch-time ENIs
2016-12-08 11:23:34 -05:00
Toshio Kuratomi
b3262479e9
Fix read-only usage to depend on the docker-py and docker server version
2016-12-08 11:23:34 -05:00
Toshio Kuratomi
13ab511642
We had two separate methods trying to do the same thing but neither one was complete. This merges them so that all of the options get parsed and applied.
2016-12-08 11:23:34 -05:00
Toshio Kuratomi
33f5afa779
Make sure listener ports are ints.
...
May fix #1984
2016-12-08 11:23:34 -05:00
Brian Coca
917b7071d6
partially reverted previous change to deal with systemctl show status not returning errors on missing service Now it looks for not-found key instead of running status which does return error codes when service is present but in diff states. fixes #12216
2016-12-08 11:23:34 -05:00
James Martin
c90bf9df98
Adds sanity check to make sure nics is a list.
2016-12-08 11:23:34 -05:00
Charles Paul
6011381bf0
vm_floppy 2.0 support
2016-12-08 11:23:34 -05:00
Chrrrles Paul
1ae0427d4e
Revert "Add 2.0 docs - Revert "add virtual floppy to VMware guest""
2016-12-08 11:23:34 -05:00
Chrrrles Paul
e8aaed3bbb
Revert "add virtual floppy to VMware guest"
2016-12-08 11:23:34 -05:00
Brian Coca
fd23120d42
check systemctl status before show as show will not return antyhing other than rc=0 even when it fails.
2016-12-08 11:23:34 -05:00
Colin Hutchinson
9d77cef5be
Remove the sample SHA256
...
putting a full sha256 made the width of the table in the generated docs not fit on some screens
2016-12-08 11:23:34 -05:00
Tony Kinsley
79f98bffcf
Adding start and stop actions to os_server_actions
...
Also making the os_server module allow a server in the possible new
states from the os_server_actions changes
2016-12-08 11:23:34 -05:00
Chris Church
9ed0a5a920
* Update core modules to fix strict mode errors. * Also fix creates parameter issue in win_msi as described in https://github.com/ansible/ansible-modules-core/issues/129 , slightly different fix from https://github.com/ansible/ansible-modules-core/pull/1482 * Fix setup.ps1 module issue described in https://github.com/ansible/ansible-modules-core/issues/1927
2016-12-08 11:23:34 -05:00
Bruno Galindro da Costa
6f36629d13
Added termination_policies option
2016-12-08 11:23:33 -05:00
Jérémie Astori
6695cc5c21
Fix physical walk on acl module for Linux
...
`-h` is for BSD [1] while `-P`/`--physical` is for Linux [2].
This commit fixes that option now that acl module is (temporarily)
only supported for Linux.
I will re-add `-h` when fixing BSD support.
[1]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[2]: http://linuxcommand.org/man_pages/setfacl1.html
2016-12-08 11:23:33 -05:00
Jérémie Astori
186cc7cb17
Make sure entry is not sent when acl state=query
2016-12-08 11:23:33 -05:00
Jérémie Astori
3568f1cd78
Make sure permission-less entries are accepted when state=absent
...
Also, remove that try condition as, at that stage, no permissions with
other than 2 or 3 fields are sent to the function.
2016-12-08 11:23:33 -05:00
Jérémie Astori
a93445c798
Remove support for d[efault]:
in entry permissions
...
It is not documented in [the Ansible doc page][1] nor
[the BSD setfacl man entry][2] (which means it might not be compatible
with BSD) so removing it does not break the API.
On the other hand, it does not conform with POSIX 1003.1e DRAFT
STANDARD 17 according to the [Linux setfacl man entry][3] so safer to
remove.
Finally, the most important reason: in non POSIX 1003.e mode, only ACL
entries without the permissions field are accepted, so having an
optional field here is very much error-prone.
[1]: http://docs.ansible.com/ansible/acl_module.html
[2]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[3]: http://linuxcommand.org/man_pages/setfacl1.html
2016-12-08 11:23:33 -05:00
Toshio Kuratomi
ffbd1efaa7
Remove non-ascii quote char
2016-12-08 11:23:33 -05:00
Rick Mendes
8048c4482a
using single device_id and enabling release on disassociation
2016-12-08 11:23:33 -05:00
Marius Gedminas
b2fc74337a
authorized_key: fix example in documentation
...
'key=' cannot be pointing to a file name; it needs to be the key itself as a string (or a URL).
2016-12-08 11:23:33 -05:00
Tim Rupp
223cac3f39
Add hostname support for Kali linux 2.0
...
This patch allows the hostname module to detect and set the hostname for a
Kali Linux 2.0 installation. Without this patch, the hostname module raises
the following error
hostname module cannot be used on platform Linux (Kali)
Kali is based off of Debian.
2016-12-08 11:23:33 -05:00
Luke
aa9b8b8552
removed hyphens in module name in examples
2016-12-08 11:23:33 -05:00
Timothy Appnel
488749500e
Clarified and cleaned up grammar of error messages.
2016-12-08 11:23:33 -05:00
Timothy Appnel
d811a51744
Fixed call to undefined attribute when RDS module timeouts waiting.
2016-12-08 11:23:33 -05:00
Marius Gedminas
f97d00fbad
user: don't generate SSH keys in check mode
...
Fixes https://github.com/ansible/ansible/issues/11768
Test plan:
- (in a Vagrant VM) created a user 'bob' with no ssh key
- ran the following playbook in check mode:
---
- hosts: trusty
tasks:
- user: name=bob state=present generate_ssh_key=yes
- saw that ansible-playbook reported "changes=1"
- saw that /home/bob/.ssh was still absent
- ran the playbook for real
- saw that /home/bob/.ssh was created
- ran the playbook in check mode again
- saw that ansible-playbook reported no changes
- tried a variation with a different username for a user that didn't
exist: ansible-playbook --check worked correctly (no errors, reported
"changed")
2016-12-08 11:23:33 -05:00
Marius Gedminas
270c2e8bbd
apt: check for "0 upgraded" to be at the beginning of the line
...
Fixes #1678 .
2016-12-08 11:23:33 -05:00
Till Backhaus
e005ef0c36
Delete dead and broken code
2016-12-08 11:23:33 -05:00
Omri Iluz
1c6acc3e8f
No need for .keys on volumes list
...
Since c3f92cca21
changed "volumes" to be a list instead of a dictionary, we don't need (and cannot) .keys when appending to set.
Reported as bug #1957
2016-12-08 11:23:33 -05:00
Simon Li
28c44c554c
Don't fail in check_mode if user exists
...
PR #1651 fixed issue #1515 but the requirement for path to be defined is unecessarily strict. If the user has previously been created a path isn't necessary.
2016-12-08 11:23:33 -05:00
James Cammarata
b9ca912ffe
Fixing region requirement regarding euca clusters
...
Fixes ansible/ansible#11023
2016-12-08 11:23:32 -05:00
nitzmahone
51154a6991
added windows facts ansible_lastboot, ansible_uptime_seconds
...
switched OS object to Get-CimInstance since we need a DateTime object for lastbootuptime
2016-12-08 11:23:32 -05:00
Toshio Kuratomi
1102afed43
Fix for the case where plugins aren't loaded on old RHEL systems
2016-12-08 11:23:32 -05:00
Toshio Kuratomi
77457feda6
Return change results in a dictionary listing the package names.
...
Fix a parsing problem when package names contain a dot.
2016-12-08 11:23:32 -05:00
Brian Richards
c054a058c0
Preventing servers that are deleted and left in the deleted state from being included in the server list
2016-12-08 11:23:32 -05:00
Nithy Renganathan
eb3f28effc
Handle the changed value
2016-12-08 11:23:32 -05:00
Jason Cowley
2c511a9470
Add support for S3 canned permissions. resolves #1939
2016-12-08 11:23:32 -05:00
Sam Yaple
f2c1eeb54c
Actually remove the section we are replacing
2016-12-08 11:23:32 -05:00
Sam Yaple
52d364b74c
Refix bug 1226 after revert
...
This patch properly fixes bug 1226 without introducing a breaking
change to idempotency which was introduced in PR #1358
We can properly assign permissions to databases with a '.' in the name
of the database as well as assign priviliges to all databases as
specified with '*'
2016-12-08 11:23:32 -05:00
Jérémie Astori
1b34f1a7ac
Fix wrong expectation regarding entry format in acl module
2016-12-08 11:23:32 -05:00
Jérémie Astori
6c298e20c0
Fix wrong processing of lines returned by setfacl in test mode
2016-12-08 11:23:32 -05:00
Jérémie Astori
08e8f732c5
Fix minor whitespace issues
2016-12-08 11:23:32 -05:00
Brian Coca
9ad712018c
deal with more failures when apt module fails to instantiate pkg fixes #1499
2016-12-08 11:23:32 -05:00
Mahesh Sawaiker
4b6471d5e7
support creating role only
2016-12-08 11:23:32 -05:00
Ilya Epifanov
cbbf284a74
fixed memory_limit for docker api version >= 1.19
2016-12-08 11:23:32 -05:00
David M. Lee
4cd2fcf917
ec2_vol: Added missing "needs 2.0" doc
...
The ability to find-or-create a volume was added in 2.0. Added note to
the example.
2016-12-08 11:23:32 -05:00
Evan Carter
c1526ff87b
Adding the ability to associate eips with network interfaces
2016-12-08 11:23:31 -05:00
Shobhit Srivastava
316ccb0e65
checking remote_group_id while comparing os_security_group_rule
2016-12-08 11:23:31 -05:00
Sam Yaple
f8bcdffa36
Revert "escapeds changes"
...
While this change doesn't break the creation, it does break
idempotency. This change will convert '*.*' to '`*`.*' which is
functionally the same, however when the user_mod() function looks up
the current privileges with privileges_get() it will read '*.*'
Since '*.*' != '`*`.*' it will go through the process of updating the
privleges always resulting in a 'changed' result.
This reverts commit db9ab9b262
.
2016-12-08 11:23:31 -05:00
Brian Lloyd
e6ffb60855
Windows implementation of lineinfile and related documentation
2016-12-08 11:23:31 -05:00
Jason DeTiberus
3619630972
python 2.4 syntax fix
2016-12-08 11:23:31 -05:00
Jason DeTiberus
8bc90c6a62
Add example for changing consumed subscriptions
2016-12-08 11:23:31 -05:00
Adam Ever-Hadani
8fb52e0a8b
added support for 'collectstatic clear' in django_manage.py
2016-12-08 11:23:31 -05:00
brannon
8691d56f3c
Support creating new VMs by cloning an existing VM. Support setting power state of cloned VMs.
2016-12-08 11:23:31 -05:00
Scot Spinner
0fff871819
one thing missed
2016-12-08 11:23:31 -05:00
Guto Andreollo
81a1579e20
Added the 'hw_interfaces' array, listing the names of all interfaces present on the VM as 'ansible_interfaces' lists the ones seen by the operating system
2016-12-08 11:23:31 -05:00
Andrew Briening
bd531f87bc
Show the exception messages
2016-12-08 11:23:31 -05:00
Matthias Frey
2ed50d5e5b
assemble: add file validation support.
2016-12-08 11:23:31 -05:00
Nikolay Ivanko
33f1da6452
add virtual floppy to VMware guest
2016-12-08 11:23:31 -05:00
Mehul Ved
832f251e90
renamed variables type to cdb_type and version to cdb_version.
2016-12-08 11:23:31 -05:00
HAMSIK Adam
217764ba3c
Rebase start/stop instance pull code
2016-12-08 11:23:31 -05:00
Александр Костырев
ec8a94f748
Fix documentation of authorized_key.py
...
man for sshd http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man8/sshd.8?query=sshd
says there's no "host" option but "from".
2016-12-08 11:23:31 -05:00
Brian Coca
a1992ad890
updated encoding comment and expanded authors field
2016-12-08 11:23:31 -05:00
Jérémie Astori
288a9d8500
Set version number in recursive option description
2016-12-08 11:23:30 -05:00
Jérémie Astori
17170992c3
Ensure Python 2.4 compatibility and Linux-restricted support
...
- Make build_entry compatible with Python 2.4
- Re-add missing warning/comment that was forgotten while refactoring
- Replace `all()` with a good ol' for-loop Python 2.4 compatibility
- Make a condition check more explicit (when `state` is `query`)
- Make sure this module can only be run with on a Linux distribution
- Add a note about Linux-only support in the documentation
- Set the version in which recursive support was added, 2.0
2016-12-08 11:23:30 -05:00
Brian Coca
c341df2231
updated docs for package
2016-12-08 11:23:30 -05:00
Marius Gedminas
9ab2e9c740
Fix obvious copy-paste error in module docs
2016-12-08 11:23:30 -05:00
Brian Coca
34f8eb0f4c
made continue into a pass (there was no loop)
2016-12-08 11:23:30 -05:00
Brian Coca
686026919e
avoid shlex exceptions in rc parsing (happens with multiline entries) fixes #1898
2016-12-08 11:23:30 -05:00
Michael J. Schultz
c7eb08b217
Return an iterable instead of None
...
By default `.get()` will return `None` on a key that doesn't exist. This
causes a `TypeError` in the `for` loop a few lines down. This change simply
returns an iterable type to avoid the error.
2016-12-08 11:23:30 -05:00
Evgeny Vereshchagin
fe840225fb
Fix service.enable on: Debian 8, Ubuntu 15.04
...
Workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751638
See https://github.com/systemd/systemd/issues/937
2016-12-08 11:23:30 -05:00
Austin Hyde
ca512b5def
Always end rc.conf entries with a new line
2016-12-08 11:23:30 -05:00
Brian Coca
a8b24699be
added gpg2 as fallback fixes #1796
2016-12-08 11:23:30 -05:00
Brian Coca
4856f78031
updated win_file version_added fixes #1893
2016-12-08 11:23:30 -05:00
Toshio Kuratomi
a765411284
Another way that the serialization of the boto results can fail
2016-12-08 11:23:30 -05:00
Toshio Kuratomi
1f9580f257
Quote checksum description to fix docs
2016-12-08 11:23:30 -05:00
Toshio Kuratomi
cae0c2741c
Another launchconfig field needs to be explicitly converted for json serialization
...
Fixes #1848
2016-12-08 11:23:30 -05:00
sebi
ce1afd01e0
mem_limit client version check
2016-12-08 11:23:30 -05:00
Toshio Kuratomi
a10b0e6fff
Modify the default for synchronize's dest_port again
2016-12-08 11:23:30 -05:00
Toshio Kuratomi
052320b452
Update docs to reflect precedence for synchronize's dest_port param
2016-12-08 11:23:29 -05:00
Toshio Kuratomi
9ba5a438a8
Allow mode as a synchronize parameter (handled in action plugin)
2016-12-08 11:23:29 -05:00
Toshio Kuratomi
98e600961f
Set a default value for DEFAULT_DOCKER_API_VERSION so we can create the AnsibleModule without docker-py
2016-12-08 11:23:29 -05:00
Ted Timmons
7027de77b7
fix ugly documentation
...
current version dumps a character per line in the docs: http://docs.ansible.com/ansible/cloudformation_module.html
2016-12-08 11:23:29 -05:00
Chris Church
1b6edab87c
Add check mode support for Windows modules that don't modify the remote system.
2016-12-08 11:23:29 -05:00
Mehul Ved
bb6762dffd
Added support for instance types.
...
Added type and version parameters to be passed to rax_cdb module
so users can create Percona and MariaDB instance types.
2016-12-08 11:23:29 -05:00
Benjamin Baumer
d38cd4896d
version_added for switch Parameter changed to 2.0 Add comment to explain check_rc Parameter in _exec Function Optimize code and clean up is_svn_repo Function
2016-12-08 11:23:29 -05:00
queridiculo
92615669c0
yum: improved check_mode handling and package update flow.
2016-12-08 11:23:29 -05:00
Austin Brown
9ffde6c048
Adding version detection
2016-12-08 11:23:29 -05:00
Benjamin Baumer
04add7409e
Fix: Calling svn info to determine if dest is an svn Working Copy, to support updates in Subfolders with Subversion > 1.8 Fix: Ignoring svn:externals on local Modification Check. Add: Added Argument switch to alow skipping the svn switch call.
2016-12-08 11:23:29 -05:00
Kamil Madac
08a2f01a5f
Fixed bug, when MX records pointed to ORIGIN(@) caused unintentional change of random A record.
2016-12-08 11:23:29 -05:00
Evan Kaufman
b3495e238c
Add disabled option to cron module
2016-12-08 11:23:29 -05:00
Andrew Briening
a886690309
Adds basic authentication & skip certificate validation to win_get_url module
2016-12-08 11:23:29 -05:00
Trond Hindenes
1ee2ddcbf4
updated win_feature.ps1 with improvements
2016-12-08 11:23:29 -05:00
Markus Juenemann
47065c2a43
Removed check whether destination directory is writable from files/unarchive.py. This check will prevent extraction of an archive if the archive does not actually write to the destination directory but only writes to any writable sub-directories of it. The underlying tar command will report errors should it try to write to read-only directories.
2016-12-08 11:23:29 -05:00
Monty Taylor
f71446045f
Add OpenStack Group content module
2016-12-08 11:23:29 -05:00
Scot Spinner
bcc57875ed
adding parameter group option
2016-12-08 11:23:29 -05:00
Jamie Hannaford
0eef7cadfa
Add wait and wait_timeout options for provisioning servers
2016-12-08 11:23:28 -05:00
Jason DeTiberus
c2bc5a20fa
bugfixes for redhat_subscription
...
- correctly return pool ids for newer versions of subscription-manager
- allow for managing subscriptions after initial registration.
2016-12-08 11:23:28 -05:00
David Shrewsbury
94ae8bbc9b
Update os_router to the latest version
...
This version uses the latest shade for a cleaner interface,
support for check mode, and updating an existing router.
2016-12-08 11:23:28 -05:00
Monty Taylor
5ca11fa255
Add OpenStack Router module
...
Also deprecate old quantum_router module
2016-12-08 11:23:28 -05:00
Vladimir Mihailenco
de8c453ac6
rackspace: pass full path to the isdir.
2016-12-08 11:23:28 -05:00
Sam Thursfield
cad0adc691
Fix permissions issue with 'cron' module
...
I have a task like this in a playbook. The ansible_ssh_user is 'root'
for this host.
- cron:
hour: 00
job: /home/backup/backup.sh
name: baserock.org data backup
user: backup
Running it gave me the following error:
TASK: [backup cron job, runs every day at midnight] ***************************
failed: [baserock-backup1] => {"failed": true}
msg: crontab: can't open '/tmp/crontabvVjoZe': Permission denied
crontab: user backup cannot read /tmp/crontabvVjoZe
The temporary file created by the 'cron' module is created with the
Python tempfile.mkstemp() function. This creates a file that is readable
only by 'root' (mode 600). The Busybox `crontab` program then checks if
the file is readable by the 'backup' user, and fails if it isn't. So we
need to make sure the file is world-readable before running `crontab`.
2016-12-08 11:23:28 -05:00
Rowan Wookey
7d85477acb
Fixes #542 error when ec2_asg arguments aren't specified
...
If max_size/min_size/desired_capacity are omitted
when updating an autoscaling group use the existing values
2016-12-08 11:23:28 -05:00
Robb Wagoner
aed7d903ee
Include a CFN stack's resources in the result
2016-12-08 11:23:28 -05:00
Jan Inowolski
3d45384aed
update git remote url before ls-remote
...
related to #8177
2016-12-08 11:23:28 -05:00
Matt Ferrante
74b4882415
ec2_ami can update an ami's launch_permissions
2016-12-08 11:23:28 -05:00
Hideki Saito
2cb83fb196
The nova_compute module create a list of un-use floating ip by value of fixed_ip.
...
Fixes #249
2016-12-08 11:23:28 -05:00
Jérémie Astori
edf531efd7
Add recursive support for ACL module ( fix #5053 , fix #5550 , fix #7276 )
2016-12-08 11:23:28 -05:00
muffl0n
6482d1344a
Allow additional hashing algorithms. Directly use hashlib and check if used algorithm is supported.
2016-12-08 11:23:28 -05:00
Robert Jailall
6530e76880
Refactor ec2_snapshot to make it more testable
2016-12-08 11:23:28 -05:00
Hagai Kariti
83aff77c26
made wait
default to True in ec2_snapshot
2016-12-08 11:23:28 -05:00
Hagai Kariti
fcd2b354b2
Add to the ec2_snapshot module the ability to create a snapshot only if one hasn't recently been created
...
- Added snapshot_max_age parameter
- Updated docs
- Made the default value of wait to be false, as it used to be
2016-12-08 11:23:28 -05:00
Toshio Kuratomi
49ee99fe73
result is now a dict and so needs different access syntax
...
Fixes #1848
2016-12-08 11:23:27 -05:00
Toshio Kuratomi
b91684b8ad
Remove unneeded urllib2 import
2016-12-08 11:23:27 -05:00
Brian Coca
ae18b7633c
returned version added
2016-12-08 11:23:27 -05:00
James Cammarata
99075976a8
Fix missing params to download_s3file in s3
2016-12-08 11:23:27 -05:00
James Cammarata
689f13548f
Fixing s3 failures when bucket names contain dots
2016-12-08 11:23:27 -05:00
Brian Coca
9241955076
added missing version_Added to extra_hosts fixes #1843
2016-12-08 11:23:27 -05:00
Pierre-Louis Bonicoli
fd88e8af53
fix error occurring with Debian
...
Error was: AttributeError: 'SourcesList' object has no attribute 'repos_urls'
2016-12-08 11:23:27 -05:00
Abhijit Menon-Sen
9b496818cf
Simplify distribution test
...
If it's Ubuntu, use UbuntuSourcesList; if it's any other apt-friendly
distribution, use SourcesList; otherwise, fail.
2016-12-08 11:23:27 -05:00
Abhijit Menon-Sen
ca50b5c5e0
Make SourcesList __init__ method also set self.module
...
This was originally required to allow other methods in SourcesList to
fail, but subsequent changes rendered that unnecessary, and it's just
a cleanup now, and avoids passing in module separately to save().
2016-12-08 11:23:27 -05:00
Abhijit Menon-Sen
46c015375d
Clarify HAVE_PYTHON_APT/install_python_apt handling in apt_repository
...
1. Don't test check_mode in both the caller and in the callee.
2. Don't test HAVE_PYTHON_APT inside an if that tests HAVE_PYTHON_APT
3. Don't be irritatingly vague about why the module fails ("You may be
seeing this because…").
Note that if «apt-get -y install python-apt» succeeds with rc==0, but
for some reason python_apt is not usable afterwards, this will break
because the imports in install_python_apt aren't wrapped inside a
try/except.
In other words, we assume that install_python_apt either succeeds or
fails with a traceback. This commit doesn't affect that behaviour.
2016-12-08 11:23:27 -05:00
Abhijit Menon-Sen
7643d3aecf
Fix call to _expand_ppa
2016-12-08 11:23:27 -05:00
brannon
824503fc19
Fix windows feature example to actually install IIS
2016-12-08 11:23:27 -05:00
Brian Coca
7d660adb39
changed verbose override variable
2016-12-08 11:23:27 -05:00
Micheal Waltz
5f0d989973
Fix incorrect var name for api_version
2016-12-08 11:23:27 -05:00
Luke Rohde
05974273b3
Use msg kwarg to pass error message in ec2_snapshot
2016-12-08 11:23:27 -05:00
Brian Coca
cd072e3090
added version added to headers in s3
2016-12-08 11:23:26 -05:00
Jaime Gago
b203deee31
Fix example indentation bug
2016-12-08 11:23:26 -05:00
Brian Coca
92dfe33021
defined DEFAULT_DOCKER_API_VERSION to avoid it erroring out before we send the message that docker.py is missing
2016-12-08 11:23:26 -05:00
Toshio Kuratomi
a01a800b65
Fi the local_rsync_path parameter used by the action plugin
2016-12-08 11:23:26 -05:00
Brian Coca
3b94910d4e
minor doc fixes to get_url
2016-12-08 11:23:26 -05:00
Toshio Kuratomi
103b150090
Convert object into dict so it will turn into json properly
2016-12-08 11:23:26 -05:00
James Cammarata
05c6732462
Prefer non-zero rc's over text analyis in service status checks
...
Fixes ansible/ansible#10441
2016-12-08 11:23:26 -05:00
Bill Nottingham
d4069a8a8a
Warn on use of sudo, etc. in shell/command.
2016-12-08 11:23:26 -05:00
James Cammarata
ba9ba7d0f5
In copy, set the mode before running th validation
...
Because some programs that do validation (like visudo) may require
the permissions to be more restricted.
Fixes ansible/ansible#11385
2016-12-08 11:23:26 -05:00
saito-hideki
19cd35806f
Add Solaris support in hostname module
...
feature_pull_request: #1804
2016-12-08 11:23:26 -05:00
Brian Coca
357d542bb3
clarified error messages to actually give back ansible module option instead of internal boto field name
2016-12-08 11:23:26 -05:00
Jesse Keating
a913370687
Handle non-updatable openstack subnet details
...
Some things cannot be updated via the API, so check for those and fail
if the user is wanting to update them. Also don't try to update ipv6
stuff, as that doesn't work and will cause a traceback.
2016-12-08 11:23:26 -05:00
Jens Carl
c0eedc6e87
Fix missing alias "groups".
2016-12-08 11:23:26 -05:00
Brian Coca
56354731ce
fixed fragment docs
2016-12-08 11:23:26 -05:00
Brian Coca
e5fe763474
fixed version added
2016-12-08 11:23:26 -05:00
Feanil Patel
e4898a4348
If overwrite is set, download eagerly.
...
If the we are going to overwrite the file anyway,
there is no need to do any checksums locally or
grab the remote etag.
2016-12-08 11:23:26 -05:00
Micheal Waltz
950701ba3e
Use a if/else instead to avoid loading possibly invalid values for Memory
2016-12-08 11:23:25 -05:00
Micheal Waltz
af5e402b87
Set the API version when checking differences in containers and use this to determine the location of the Memory value depending on the version used.
...
In v1.18 and earlier it was ['Config']['Memory'], but in v1.19 it
changed to ['HostConfig']['Memory'].
2016-12-08 11:23:25 -05:00
billwanjohi
167e940e78
iam: don't delete passwords by default
2016-12-08 11:23:25 -05:00
Igor Khomyakov
9a599e35c1
fixed 'present'
2016-12-08 11:23:25 -05:00
Micheal Waltz
f36666ae1d
Use proper HostConfig element which contians the proper Memory value - fixes #1766
2016-12-08 11:23:25 -05:00
Lars Kellogg-Stedman
3d79d96a1b
restore mem_limit
...
mem_limit got lost in the #1744 ; this restores it. Thanks to @dgromov
for the report.
2016-12-08 11:23:25 -05:00
Lars Kellogg-Stedman
562341049e
docker: fix parsing of docker __version__ string
...
If `docker.__version__` contains non-digit characters, such as:
>>> import docker
>>> docker.__version__
'1.4.0-dev'
Then `get_docker_py_versioninfo` will fail with:
ValueError: invalid literal for int() with base 10: '0-de'
This patch corrects the parsing of the version string so that
`get_docker_py_versioninfo` in this example would return:
(1, 4, 0, '-dev')
2016-12-08 11:23:25 -05:00
Mike Putnam
9623cd570c
Add missing GPLv3 License header
...
Fixes #1643
2016-12-08 11:23:25 -05:00
Ash Caire
682bf34a43
add headers param to s3 uploads
2016-12-08 11:23:25 -05:00
Dan
5b4e7c797f
Added header support
...
Added the ability to pass custom http headers to the fetch_url method.
2016-12-08 11:23:25 -05:00
KIKUCHI Koichiro
dab7305d3b
Fix service enabled check failure on FreeBSD
2016-12-08 11:23:25 -05:00
Sébastien Gross
0fd3ece053
Allow '*' as empty password.
...
If `password` is defined as `*` `useradd` or `usermod` returns an error:
msg: usermod: Invalid password: `*'
This works very well on Linux host to not define any password for a
user (mainly useful if your setup is only based on SSH keys for
auth). On OpenBSD this does not work, so we have to ignore the encrypted
password parameter if it defined as `*`.
2016-12-08 11:23:25 -05:00
Andrey Trubachev
b93633d7c2
Fix python-2.4 compatibility
2016-12-08 11:23:25 -05:00
Andrey Trubachev
c55187ff42
Fix 'wait_for' doesn't work with ipv6only host
2016-12-08 11:23:25 -05:00
khassen
8b60dd349d
Use the common/shared MD5 function.
2016-12-08 11:23:25 -05:00
Brian Coca
f15ce1433a
added version_added to body_format in uri
2016-12-08 11:23:25 -05:00
fti7
581ce7dd32
mount: Support for Check-Mode
2016-12-08 11:23:24 -05:00
Greg DeKoenigsberg
ffb1cab213
Add new policy guidelines for Core
2016-12-08 11:23:24 -05:00
Johan Haals
6a9a4d905a
ensures API compatibility for read_only containers
2016-12-08 11:23:24 -05:00
Guilherme Carlos
aaac05c96c
Fix login_user on mysql_user
...
`login_username` was provided but `login_user` is the correct option
2016-12-08 11:23:24 -05:00
Toshio Kuratomi
55271467d4
Remove validate_certs as the url is not user settable so we always want to validate the certificate
2016-12-08 11:23:24 -05:00
Artur Cygan
d71b1444a9
Update route53.py
...
Fix typos
2016-12-08 11:23:24 -05:00
Chris Church
d8f5a34d85
Save user after creating before trying to read/set other properties. Fixes #1241
2016-12-08 11:23:24 -05:00
Johan Haals
c88feaff7e
changed version_added for read_only param
...
this feature will be released in 2.0
2016-12-08 11:23:24 -05:00
Baraa Basata
63a619fbae
Fix iam_policy example
2016-12-08 11:23:24 -05:00
Will Thames
e5d96dc934
Correct handling of empty role_attr_flags
...
role_attr_flags is the empty string by default, not None.
2016-12-08 11:23:24 -05:00
Yuhui Huang
621b396bd9
Checking pip uninstall output in both stdout and stderr
2016-12-08 11:23:24 -05:00
Johan Haals
6231a9d52f
Added support for --read-only Docker containers
...
Adds support for mounting the container's root filesystem as read only.
2016-12-08 11:23:24 -05:00
Constantin
7a7b8b913a
Added additional stat output values
...
Included in the output as well:
- file extension
- file attributes
- file owner
- creation, last access and last write timestamps (in UNIX format)
2016-12-08 11:23:24 -05:00
Jeff Widman
70b3290a3b
Move validate command into doc fragment and fix a few typos
2016-12-08 11:23:24 -05:00
Chris AtLee
e7af5d2384
Add support for 'update' parameter to hg module
2016-12-08 11:23:24 -05:00
Jesse Sandberg
807feb3ac4
Validate variable, return only the found variable value instead of tuple
...
Docs imply the mysql_variables is used to operate a single variable therefore
- fail before making any db connections if variable is not set
- validate chars for mysql variable name with re.match(^[a-z0-9_]+)
- use "SHOW VARIABLE WHERE Variable_name" instead of LIKE search
- getvariable() returns only the value or None if variable is not found
- the module returns only the found variable value instead of tuple for easier operation eg. as registere variable in tasks
2016-12-08 11:23:24 -05:00
sysadmin75
9bd58bd224
Fix to revoke privileges for mysql user = '' Issue #9848
2016-12-08 11:23:24 -05:00
Christian Hammerl
426ec96ea5
docker: add support to add/drop capabilities
2016-12-08 11:23:23 -05:00
Brian Coca
9b38e47d70
added rickmendes as maintainer
2016-12-08 11:23:23 -05:00
Brian Coca
1976ed931a
minor doc fixes to docker_user
2016-12-08 11:23:23 -05:00
Brian Coca
b62a6f01ab
added version_Added for new signal option in docker module
2016-12-08 11:23:23 -05:00
Brian Coca
723a48ca73
added versionadded to new option in pip module
2016-12-08 11:23:23 -05:00
Brian Coca
07fedaa03a
corrected v ersion added
2016-12-08 11:23:23 -05:00
ayush
f46daacf67
Updated doc strings so each character isn't considered a line
2016-12-08 11:23:23 -05:00
Toshio Kuratomi
8eba30b488
Deprecated _ec2_ami_search now verifies SSL certificates
2016-12-08 11:23:23 -05:00
Daniel Kerwin
277065a302
Too late for 1.8
2016-12-08 11:23:23 -05:00
Daniel Kerwin
3a68101fa3
Switch to _cap_ver_req and add cpu_set to create_containers
2016-12-08 11:23:23 -05:00
Alan Scherger
861d260b6c
fix docs; only delete network if fwname is not provided
2016-12-08 11:23:23 -05:00
HelenaTian
1b614172f5
Update gce.py to correctly handle propagated metadata type from a mother template
...
My project is using Ansible to automate cloud build process. Ansible has a core module gce.py for managing GCE instances.
We've come across a use case that's not yet supported - when executing ansible-playbook, if a child template is included, then metadata which is defined in and propagated from the mother template is treated as string type and not parsed correctly(which instead is dictionary type), and triggers release flow failure.
We currently put some fix by explicitly casting metadata to string type in our own branch, but would like to contribute the fix to Ansible so that everyone onboarding GCE and using Ansible for release management could benefit from it, or hear owner's opinion on fixing the issue if there's a better fix in owner's mind:)
2016-12-08 11:23:23 -05:00
Petros Moisiadis
68ef885e71
make migrate command idempotent with django built-in migrations
...
Django since version 1.7 has built-in migrations, so no need to have south installed with recent django versions. The 'migrate' command works with built-in migrations without any change, but the output is different than the output produced by south, which breaks idempotence. This commit fixes this.
2016-12-08 11:23:23 -05:00
nemunaire
f37510ebaa
Add optional signal parameter when killing docker container
2016-12-08 11:23:23 -05:00
Isaac Simmons
07ccd3c86b
Handle ini file properties that contain interpolation errors in the initial values
2016-12-08 11:23:23 -05:00
Wouter Bolsterlee
3d7e3e3c3d
Add a virtualenv_python argument to the pip module
...
This allows specifying the Python version to use when creating the
virtualenv. See issue #586 .
2016-12-08 11:23:23 -05:00
Wouter Bolsterlee
5a0157a4f2
A few coding style cleanups
2016-12-08 11:23:22 -05:00
Wouter Bolsterlee
e8a0b8b8ae
Fix typo in version_added
field.
2016-12-08 11:23:22 -05:00
Daniel Kerwin
5b029bde98
Renamed to cpu_set
2016-12-08 11:23:22 -05:00
Daniel Kerwin
940baa92a6
Add support for cpusets. Requires docker-py >= 0.6.0
2016-12-08 11:23:22 -05:00
Brian Coca
87c8d016dc
added version_Added to get_url's force_basic_auth
2016-12-08 11:23:22 -05:00
Patrik Lundin
88881415e9
synchronize: add flag for verifying target host.
...
Add the possibility to verify the target host using a "verify_host"
flag. It is disabled by default to not change the module behaviour.
2016-12-08 11:23:22 -05:00
Brian Coca
7a6c8251dd
prevent usless assignment of home
2016-12-08 11:23:22 -05:00
bambou
ac41e7c669
Check if the gid is set
2016-12-08 11:23:22 -05:00
Brian Coca
fedd1bed1f
minor doc fixes, version added for latest feature
2016-12-08 11:23:22 -05:00
Herby Gillot
c0676f93f5
rds: add the ability to reboot RDS instances
2016-12-08 11:23:22 -05:00
Eero Niemi
1f560f8dae
Fixed parameter validation when creating a volume from a snapshot
2016-12-08 11:23:22 -05:00
whiter
2dc689894c
Added 'resource_tags' alias
2016-12-08 11:23:22 -05:00
Brian Coca
a0b0c022b8
corrected version_added
2016-12-08 11:23:22 -05:00
Brian Coca
6980503357
updated to add missing 'use' option
2016-12-08 11:23:22 -05:00
David Shrewsbury
014459e5ef
Add new os_nova_flavor module.
...
The os_nova_flavor module allows a user with administrative privileges
to create and delete nova flavors.
2016-12-08 11:23:22 -05:00
Brian Coca
ec6e75f1cc
attempt to fix check mode when state='absent'
2016-12-08 11:23:21 -05:00
Mischa ter Smitten
10cae0acb3
The tilde expansion doesn't work with user.home
2016-12-08 11:23:21 -05:00
HAMSIK Adam
e04a4a4114
Use mutually_exclusive in AnsibleModule
2016-12-08 11:23:21 -05:00
otdw
8740b44205
removed required together for resource pools, clusters, and template deployments. fixes inability to deploy from template on vsphere clusters without resource pools. Also, resource pools and cluster should not be required together as they are independant in vsphere
2016-12-08 11:23:21 -05:00
Iiro Uusitalo
d6fc0ac5be
uri.py is not using module_utils/urls.py from ansible core
2016-12-08 11:23:21 -05:00
HAMSIK Adam
3d3be5e91f
Fix missing ,
2016-12-08 11:23:21 -05:00
whiter
a5a9c92fcd
Fixed dicts comparison for tags
2016-12-08 11:23:21 -05:00
Brian Coca
e4dd0d98d4
now captures any exceptions when trying to create directories
2016-12-08 11:23:21 -05:00
whiter
54b02ee0da
ec2_vpc_net refactor
2016-12-08 11:23:21 -05:00
HAMSIK Adam
b7a13e263f
Add version
2016-12-08 11:23:21 -05:00
HAMSIK Adam
05df069176
Add module parameter for security group name. This make ec2_elb_lb module consitent with others
2016-12-08 11:23:21 -05:00
Maksim Losev
482d8da2dc
Use HostConfig object when creating container with Docker Remote API > 1.15
...
This is mlosev's patch (from #1208 ), rebased against devel as of
2790af2
. It resolves #1707 , which was caused by an API incompatibility
between the docker module and server API version 1.19.
2016-12-08 11:23:21 -05:00
Lars Kellogg-Stedman
e031efd82c
Do not erroneously mask exceptions
...
There was a catch-all `except` statement in `create_containers`:
try:
containers = do_create(count, params)
except:
self.pull_image()
containers = do_create(count, params)
This would mask a variety of errors that should be exposed, including
API compatability errors (as in #1707 ) and common Python exceptions (KeyError, ValueError, etc) that could result from errors in the code.
This change makes the `except` statement more specific, and only attempts to pull the image and start a container if the original create attempt failed due to a 404 error from the docker API.
2016-12-08 11:23:21 -05:00
Lars Kellogg-Stedman
6116e4cdab
docker: permit empty or false pid
...
The `docker` Python module only accepts `None` or `'host'` as arguments.
This makes it difficult to conditionally set the `pid` attribute using
standard Ansible syntax.
This change converts any value that evaluates as boolean `False` to
`None`, which includes empty strings:
pid:
As well as an explicit `false`:
pid: false
This permits the following to work as intended:
- hosts: localhost
tasks:
- name: starting container
docker:
docker_api_version: 1.18
image: larsks/mini-httpd
name: web
pid: "{{ container_pid|default('') }}"
If `container_pid` is set to `host` somewhere, this will create a
Docker container with `pid=host`; otherwise, this will create a
container with normal isolated pid namespace.
2016-12-08 11:23:21 -05:00
Brian Coca
9e54efd3fd
fixed version added, reworded description a bit
2016-12-08 11:23:21 -05:00
Brian Coca
16a4ff3462
fixed minor doc issues
2016-12-08 11:23:21 -05:00
Brian Coca
0cab021168
Revert "Revert "ec2_lc - include all launch config properties in the return""
2016-12-08 11:23:20 -05:00
Brian Coca
af8ded66cc
Revert "ec2_lc - include all launch config properties in the return"
2016-12-08 11:23:20 -05:00
Toshio Kuratomi
a655241488
Minor touch ups of vsphere_guest code.
2016-12-08 11:23:20 -05:00
Brian Coca
60d160a2e9
Also document in example that unarchive download was added in 2.0
2016-12-08 11:23:20 -05:00
Mitchell Ludwig
b664603a4d
Improved stat documentation
2016-12-08 11:23:20 -05:00
Frank van Tol
39e24e89f4
Remove default port value, it does not work in _requires_destroy_and_create logic
...
When creating a Redis cluster, every run it gets destroyed and recreated because the port number of memcached is used as the default.
2016-12-08 11:23:20 -05:00
Frank van Tol
6655cd89c4
Update elasticache.py
2016-12-08 11:23:20 -05:00
Frank van Tol
426f93a291
Remove default for engine_version
...
Redis and memcached have different engine version numbering, there can not be a shared default value.
2016-12-08 11:23:20 -05:00
Nicholas O'Connor
b95cb3f4e9
Created option snapshot_to_clone. When specified, snapshot_to_clone will create a linked clone copy of the VM.
2016-12-08 11:23:20 -05:00
Apoorva Kulkarni
1f35e578b4
s3 module: Add missing version tag to "encrypt" parameter
2016-12-08 11:23:20 -05:00
Chris Church
31a01305ba
Set force=yes as the default, add force parameter to module docs.
2016-12-08 11:23:20 -05:00
James Cammarata
5efeeb156b
Correctly default crypt_scheme in htpasswd
2016-12-08 11:23:20 -05:00
Chris Faulkner
18b157fbac
Report change status on django_manage collectstatic.
2016-12-08 11:23:20 -05:00
Evan Carter
d3ef622627
Adding default cooldown to AWS ASG
2016-12-08 11:23:20 -05:00
vanga
ddd399fe7a
Throw error if encryption is set while passing a snapshot id
2016-12-08 11:23:20 -05:00
Chris Meyers
0dbf41e740
ensure password or ssh cert specified
2016-12-08 11:23:20 -05:00
Tom Paine
e97124d609
Update vsphere_guest.py
2016-12-08 11:23:20 -05:00
acaveroc
dda41fd95a
Add version_added and type of parameter
2016-12-08 11:23:19 -05:00
acaveroc
2c6f69c95e
Assorted minor bug fixes
...
- Modified data type for port definition from string to integer
- Modified login_host default value for compatibilize with port definition according with MySQL Documentation (https://dev.mysql.com/doc/refman/5.0/en/connecting.html )
2016-12-08 11:23:19 -05:00
acaveroc
1283fdd118
Add port definition support for mysql_vars module
2016-12-08 11:23:19 -05:00
Joel Thompson
f1ab33ad7b
Adding ability to filter AWS Route 53 private hosted zones by attached VPC
2016-12-08 11:23:19 -05:00
Hennadiy (Gena) Verkh
098126807d
Update uri.py
...
Added methods 'TRACE', 'CONNECT' from https://www.rfc-editor.org/rfc/rfc2616.txt , section 5.1.1
Added method 'REFRESH'
2016-12-08 11:23:19 -05:00
Tal Auslander
8766641871
use ConvertTo-Bool for the force parameter
2016-12-08 11:23:19 -05:00
Tal Auslander
64f19fc4c6
stop reading from url on error
2016-12-08 11:23:19 -05:00
Tal Auslander
9c6d829991
add force parameter to win_get_url
2016-12-08 11:23:19 -05:00
Tal Auslander
26a54897a2
win_get_url re-download file only if modified
2016-12-08 11:23:19 -05:00
Hennadiy (Gena) Verkh
852c232b2d
Removed method restriction in uri module
2016-12-08 11:23:19 -05:00
Ian Babrou
9219aeaaeb
Pulling missing docker image before doing anything
2016-12-08 11:23:19 -05:00
Nic O'Connor
c68d1ffa60
Added the ability to Linked_clone from snapshot
2016-12-08 11:23:19 -05:00
Simon Olofsson
a3cb6d2f16
Add option docker_user for docker module.
...
docker_user can be used to specify the user or UID to use within the
container.
2016-12-08 11:23:19 -05:00
Iiro Uusitalo
b92dabb9fb
Refactor force basic auth, now all modules which use fetch_url() can use force_basic_auth
2016-12-08 11:23:19 -05:00
Toshio Kuratomi
05be82183f
Add notes about loop squashing and 1.9.2 change to install packages in one yum transaction
2016-12-08 11:23:19 -05:00
Monty Taylor
8e26a7ae17
Fix a small typo in parameter processing
2016-12-08 11:23:19 -05:00
Brian Coca
f8f4a7dcdf
added ignore hidden to assemble
2016-12-08 11:23:18 -05:00
Jesse Keating
16381fb5c0
Plumb ipv6 modes into os_subnet
...
Shade already supports these, we just need to plumb them into the module
code.
2016-12-08 11:23:18 -05:00
Jesse Keating
72809ac329
Fix up docs
2016-12-08 11:23:18 -05:00
Sean Chittenden
4c8b573e2c
Fix group mod and group add for FreeBSD
2016-12-08 11:23:18 -05:00
Juho-Mikko Pellinen
29620b78fa
Change the default flag value to None to prevent AWS complaining: "Instance creation failed => InvalidBlockDeviceMapping: the encrypted flag cannot be specified since device /dev/sda1 has a snapshot specified."
2016-12-08 11:23:18 -05:00
Monty Taylor
530f12035b
Update docstring to show port ranges as optional
2016-12-08 11:23:18 -05:00
David Shrewsbury
789c1fcbe7
Correct port matching logic
...
Port matching logic did not take into account recent shade change
to equate (None, None) to (1, 65535) when Nova is the backend.
Also, this encapsulates the port matching logic into a single function
and heavily documents the logic.
2016-12-08 11:23:18 -05:00
Flyte
2f46364921
Provide correct kwargs to rds2 connection when making a final snapshot
2016-12-08 11:23:18 -05:00
David Shrewsbury
387fe5b0e7
Change required parameters for rules module
...
The ports and protocol are no longer required (and now depends on
a new version of shade).
2016-12-08 11:23:18 -05:00
Davide Guerri
531b93490b
Fix reuse argument documentation
2016-12-08 11:23:18 -05:00
Davide Guerri
95cfe3da96
Update os_floating_ip with new shade methods
2016-12-08 11:23:18 -05:00
Monty Taylor
4f2028439f
Use int in the parameter list instead of casting
2016-12-08 11:23:18 -05:00
dagnello
2c3fc61357
Resolving issues in rule comparison algorithm
...
Port range min/max values are at times represented as string and
compared to int equivalents. This fix explicitly ensures all
port range values are ints for proper comparisons.
2016-12-08 11:23:18 -05:00
David Shrewsbury
e7dd93c5c1
Compare ports as strings
...
Ports as returned from shade are ints. They are strings as they come
in to the module.
2016-12-08 11:23:18 -05:00
David Shrewsbury
14212c37e2
Fix syntax error
2016-12-08 11:23:18 -05:00
Monty Taylor
60102e36e2
Return rule object
2016-12-08 11:23:18 -05:00
David Shrewsbury
174254a423
Update secgroup rules module for latest shade
...
This allows the rules module to work against either nova or neutron
for handling security groups. New parameters for 'direction' and
'ethertype' are added.
Check mode is supported with this version.
2016-12-08 11:23:18 -05:00
David Shrewsbury
fcc1d643f6
Recongnize None and -1 port equivalency
...
shade 0.7.0 represents disabled min/max ports as None (in the
neutron style) rather than -1. Recognize this as the same as -1.
2016-12-08 11:23:17 -05:00
David Shrewsbury
b42a9d56e6
Fix id value reference
2016-12-08 11:23:17 -05:00
David Shrewsbury
f02ec15c17
Update rules mode for latest shade
...
Shade 0.7.0 normalized the security group data that is returned,
when using nova, to look more like neutron security group data.
This adjusts for that change.
2016-12-08 11:23:17 -05:00
dagnello
ecef2aadba
Minor fixes for os_security_group_rule module
...
Was not able to use this module as it was. The changes submitted
resolved the issues I ran into in order to get it working.
2016-12-08 11:23:17 -05:00