Commit graph

44776 commits

Author SHA1 Message Date
Nabeel Al-Saber
480b47d3b2 Add Oracle scenario guide (#58443)
* Create and update docs/docsite/rst/scenario_guides/guide_oracle.rst
2019-06-29 11:14:42 -07:00
Sloane Hertel
c67980e07b Handle vaulted non-ascii characters for Python2 (#58503)
* Handle vaulted non-ascii characters for Python2

* Add a test to ensure str() no longer raises UnicodeEncodeError

(cherry picked from commit 826f224f02)
2019-06-29 11:13:55 -07:00
Sam Doran
7700c5086d [stable-2.8] Use atexit to cleanup tmp dirs (#56532)
* Wrap everything in try/except to avoid leaving files behind
* Add unit tests, integration tests, and changelog
* Do text the correct way.
(cherry picked from commit 6cf6f5a34b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-29 11:13:28 -07:00
Sam Doran
dd304b4811 [stable-2.8] hostname - fix Oracle Linux (#58510)
(cherry picked from commit 1a5ae366f4)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-28 10:00:12 -07:00
Sloane Hertel
cb70656c99 Fix notifying handlers by using an exact match (#55624)
* Fix notifying handlers by using an exact match rather than a string subset if listen is text rather than a list

* Enforce better type checking for listeners

* Share code for validating handler listeners

* Add test for handlers without names

* Add test for templating in handlers

* Add test for include_role

* Add a couple notes about 'listen' for handlers

* changelog

(cherry picked from commit ec1287ca7e)
2019-06-28 09:22:39 -07:00
Sam Doran
8cc128b8f5 [stable-2.8] podman_image_info - Do not fail when nonexistant image name is provided (#57962)
* Account for older versions of Podman lacking 'exists'
(cherry picked from commit 9ba7015458)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-28 09:16:24 -07:00
Strahinja Kustudic
ab97f58764 Fix version_added for gcp_compute
(cherry picked from commit 16610fa399)
2019-06-28 08:03:04 -07:00
Felix Fontein
b13a5d32c2 the env argument for docker_container wants a dict, not a list (#58475) (#58486)
(cherry picked from commit 3ec4739cc7)
2019-06-28 08:54:27 -05:00
Sam Doran
bbbacebf01 [stable-2.8] Make nuage_vspk test more reliable
- don't background the nuage-vsd-sim
- increase the asncy timeout
- use uri to actually query the simulator API to make sure it is ready for connections
(cherry picked from commit 911a2ec6d3)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-26 14:47:11 -07:00
Alicia Cozine
af1ca7bfcb
Datadog_monitor: Fix docs with datatypes of params (#58371) (#58404)
Fixes: #58342

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

(cherry picked from commit bc3c90f2f1)
2019-06-26 11:56:53 -05:00
Andrey Klychkov
a6ecc6c243 Backport 57507 postgresql_pg_hba bugfix (#58384)
* Merge authentication options back into a single field to prevent losing options beyond the first (#57507)

* Merge authentication options back into a single field to prevent losing options beyond the first

* Add integration test and changelog

* Fix multiple options for local type connections. Also fix sorting errors between local type connections that lack a src

* Build again because of github problems?

* Add spaces before comments

(cherry picked from commit 5cc6486a2b)
2019-06-26 08:32:46 -07:00
Strahinja Kustudic
084283233a Set correct version and update changelog fragment 2019-06-26 06:35:42 -07:00
Strahinja Kustudic
2ff60747b4 Add service_account_contents parameter to allign with the modules (#57848)
(cherry picked from commit 7fd10d821c)
2019-06-26 06:35:42 -07:00
Andrey Klychkov
4624f8af13 Backport PR for 58315 2019-06-25 15:13:19 -07:00
Andrey Klychkov
b2cbbaed26 postgresql_membership: remove debug print (#58315)
(cherry picked from commit cf528c562a)
2019-06-25 15:13:19 -07:00
Matt Martz
fd73fe02b4 [stable-2.8] Set _ansible_verbose_override in gather_facts action plugin. Fixes #58310 (#58339)
(cherry picked from commit bc25ac2)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-06-25 15:12:49 -07:00
markafarrell
9406fbe4a2 [stable-2.8] also allow None Type for safe eval (#58269)
(cherry picked from commit 8555b72)

Co-authored-by: markafarrell <mark.andrew.farrell@gmail.com>
2019-06-25 08:08:10 -07:00
Tobias
95c2763f40 [2.8] ipaddr: Handle ipaddress index in network correctly
* This commit prevents integer indices from being parsed as ip nets
* ipaddr: unit tests for empty string

Fixes #57895

Signed-off-by: Tobias Schramm <tobleminer@gmail.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit e7c39460ed)
2019-06-24 19:35:27 -07:00
Felix Fontein
b75ff85e9c Use newer test container.
(cherry picked from commit b78d23d4ad)
2019-06-24 15:44:17 -07:00
Andrey Klychkov
8f97d6da8b Backport PR of 57391 postgresql_table - fix conflicts 2019-06-24 15:18:25 -07:00
Andrey Klychkov
5ebc83bce6 Backport PR of 57391 postgresql_table - bugfix of schema handling 2019-06-24 15:18:25 -07:00
Felix Fontein
5e177d73a9 openssl_certificate: fix failing SAN comparisons (#58256)
* Fix failing SAN comparison for older cryptography versions due to not implemented __hashh__ functions.

* Fix SAN comparison: IPv6 addresses need to be normalized before comparing strings.

* Add changelog.

* Fix comment.

(cherry picked from commit 75ca8eb42f)
2019-06-24 15:17:41 -07:00
lolcube
5d3eebb610 openssh_keypair: bugfix make regenerating keypairs via force possible… (#57801)
* openssh_keypair: bugfix make regenerating keypairs via force possible / add invalid file handling

* openssh_keypair: change permissions of read-only file instead of deleting it for regeneration; add changelog fragment

* address review feedbak, refactor

* add integration tests for bigfixes

* linter: fix indent

* fixup integration tests: use force when regenerating an invalid file

* linter: fix indent

* openssh_keypair: address review feedback

* openssh_keypair: fixup, remove backtick

* openssh_keypair: address review feedback

* Only pass 'y' into stdin of ssh-keygen when file exists.

(cherry picked from commit 547a29805e)
2019-06-24 15:17:08 -07:00
Andrey Klychkov
7a9fe9ea7b postgresql_privs: bugfix of 27327 - incorrect views handling (#58272)
(cherry picked from commit 278c59b17e)
2019-06-24 15:16:07 -07:00
Felix Fontein
7c22c81c5c Adjust tests to new error messages for older docker-py versions. (#58253)
(cherry picked from commit 66a4000058)
2019-06-24 15:13:30 -07:00
Felix Fontein
b7cc98e86e docker_* modules: improve error message when docker-py is missing (#57914)
* Improve error for docker modules when docker-py can't be imported.

* Add changelog.

* Mention platform and Python interpreter in more cases.

* Clarify wording.

* Adjust tests.

(cherry picked from commit 4a12be31fb)
2019-06-24 15:13:30 -07:00
Klaus Frank
e7356957ee Fix ansible-vault cipher_whitelist (#57272)
* Fix ansible-vault cipher_whitelist Fixes: #57271

* Add changelog for #57272
2019-06-24 15:13:10 -07:00
Felix Fontein
f4ff3ade1f Remove from sanity ignores. (#57911)
(cherry picked from commit 808cf4aa26)
2019-06-24 15:10:26 -07:00
ndclt
6e2bcc3d8e Coherence between example and text (use of to_native) (#58279) (#58283)
(cherry picked from commit 4376e88849)
2019-06-24 11:57:00 -05:00
Mariusz Mazur
d9155944cf Backport/2.8/57685 (#57794)
* kubevirt: enable/update tests + fix merge_dicts() (#57685)

* Actually run the unit tests and separate them into two files

* Re-add recursion to merge_dicts()

* Update tests to work with current code

(cherry picked from commit 51add5aa79)

* Changelog fragment

* Replace nested function with dict_transformations.dict_merge
2019-06-24 09:26:42 -07:00
Sam Doran
2cc8f3afb7 [stable-2.8] hostname - Correct distribution for various Linux distros based on output from distro library (#56936)
* Adjust hostname classes based on output from distro

Corrects the following:
- OpenSUSE Leap
- ArchARM
- Oracle Linux

* Add CoreOS and Clear Linux distributions
(cherry picked from commit bd55617a5b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-21 15:40:22 -07:00
Sam Doran
6bd8e3d002 [stable-2.8] Add Fedora 30 to test matrix (#57713)
Remove Fedora 28 from test matrix
(cherry picked from commit 7b9d991f78)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-21 15:39:18 -07:00
Sumit Jaiswal
062074e68e Backport PR to fix ios_facts ansible_net_model (#58174)
* PR to fix where ansible_net_model was not being populated (#58159)

* fix bug 57285

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* minor fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* adding TC fix related

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable error

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 58d446e61a)

* fix ansible_net_model

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* Fix ios test for python2 non-ascii paths

(cherry picked from commit eb7e4591ae)
2019-06-21 15:35:33 -07:00
Sam Doran
9d82c470ca [stable-2.8] Check that provider['options'] is a dictionary in validate-modules (#58078)
(cherry picked from commit dc8f7b38e6)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-21 12:13:21 -07:00
Andrey Klychkov
f548999290 PostgreSQL modules: move params mapping from main to connect_to_db() function Backport/2.8/55799 (#57473)
* PostgreSQL modules: move params mapping from main to connect_to_db() function (#55799)

* PostgreSQL modules: move params mapping from main to connect_to_db() function

* PostgreSQL modules: fix postgresql_db

* PostgreSQL modules: fixes

(cherry picked from commit 9b17346d1e)

* postgresql moving params mapping to connect_to_db: added changelog fragment

* postgresql moving params mapping to connect_to_db: add get_conn_params, fix conflicts
2019-06-21 06:32:18 -07:00
Felix Fontein
6a71aef6c5 docker_*: make modules more robust on Docker errors (#57913)
* Improve general error behavior if a Docker error is not caught.

* Don't die when network doesn't exist.

* Add changelog.

* Make API version always available. Also catch errors when retrieving version.

* Fix error message.

* Adjust fallback error messages.

(cherry picked from commit f8f2738351)
2019-06-20 19:09:57 -07:00
Brian Coca
04e94274fb safe_eval fix (#57188)
* just dont pass locals

 - also fix globals
 - added tests

* fixed tests

(cherry picked from commit b9b0b23015)
2019-06-20 18:22:29 -07:00
Matt Martz
5e0c623f38 [stable-2.8] Create new instance of the action plugin per until iteration. Fixes #57886 (#58022)
(cherry picked from commit ffd1171)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-06-20 18:21:53 -07:00
Sam Doran
169dfc807e [stable-2.8] passwordstore lookup - replace expired GPG key (#58141)
- Replace private key that expired an 2019-06-20 with a key that does not expire
- Document how to generate a new GPG key using an input file
(cherry picked from commit b9d77b997e)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-20 15:33:00 -07:00
Dmitriy Yakovlev
cd00cb1e8c docker_swarm_service: Added default value for mounts.source (#58039)
* Added default value for mounts.source

* Added the changelog fragment

* Added tests

* Fixed separators

* Moved the teardown section at the end

(cherry picked from commit 122d4164c5)
2019-06-20 13:58:45 -07:00
Paul Belanger
546cc087aa Use wait_for in prepare_junos_tests.yaml (#57073)
This should reduce the amount of time we are waiting for netconf to come
online.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit 7f536630eb)
2019-06-20 13:58:08 -07:00
Felix Fontein
5f719bba18 crypto modules: Improve requirements / error messages (#57868)
* Reformat requirements.

* Include Python lib versions in lib required error messages, if available.

* Update lib/ansible/modules/crypto/openssl_publickey.py

Co-Authored-By: MarkusTeufelberger <mteufelberger@mgit.at>

* Add changelog.

(cherry picked from commit 4188cd299b)
2019-06-20 13:57:33 -07:00
Felix Fontein
ad00823266 docsite: remove lexers which have been fixed in Pygments 2.4.0 (#57508)
* Remove lexers which have been fixed in Pygments 2.4.0.
* Add Pygments >= 2.4.0 to test runner.
* Fix pages that triggered lexer errors.

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
(cherry picked from commit 505c99265c)
2019-06-20 11:12:16 -07:00
Sumit Jaiswal
4cb505a310 PR to fix ios bgp TC failure (#58010)
* fix ios bgp tc failure

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* skip test with 15.6(T)2 ios

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* skip test with 15.6(T)2 ios

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 77b6255305)
2019-06-20 11:01:35 -07:00
Matt Martz
c42a6155a9 [stable-2.8] ssh: Ensure debug messages are properly converted to text (#57850)
* ssh: Ensure debug messages are properly converted to text. Fixes #57843

* surrogate_then_replace is default, be less explicit

* We only needed to_text for display, not exceptions
(cherry picked from commit 375ac76)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-06-20 10:58:15 -07:00
Yurii Vlasenko
7d9a527086 docker_container: Change expected config source (#57969)
* Change expected config source

* make it conditional

* rename property

* Add changelog fragment

* make it string

* Update changelogs/fragments/57969-docker_container-change-expected-config-source.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8c1c2afd02)
2019-06-20 10:40:36 -07:00
Sandra McCann
e7551ead6c [backport][2.8] add dropdown version selection to docsite (55655) (#58096)
* cherry-pick f3720c90e0, with correct version
2019-06-19 15:50:50 -05:00
Alicia Cozine
80062dc6be
removes link from 404 content, explains options (#57971) (#58091)
(cherry picked from commit 8dfa376e1c)
2019-06-19 14:17:49 -05:00
Paul Belanger
2dac2d1601 Pull request for temp/iosxr-back (#58075)
* Fix python3 encoding with iosxr_config (#57919)

Python3 requires bytes when writing files.

(cherry picked from commit d40c44bd56)
Depends-On https://github.com/ansible/ansible/pull/58073
Signed-off-by: Paul Belanger <pabelanger@redhat.com>

* Add changelog fragment

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-19 10:57:10 -07:00
Chris Archibald
ba30649af9 Backport/2.8/57379 (#58080)
* Duplicate rules were being created if rule index was not set (#57379)

* bug fixes

* Revert "bug fixes"

This reverts commit 2d839ecf35.

* bug fix

(cherry picked from commit e80d6f18ce)

* add fragment
2019-06-19 10:56:15 -07:00