Commit graph

3564 commits

Author SHA1 Message Date
Stephen Fromm
4eaee3df0a Various cleanup to run_command
* Rename fail_on_rc_non_zero to check_rc, much more succinct.
* Simplify method defintion
* Fix command module and drop shell=shell option; whether to use
  shell is determined by if args is a list.
2013-01-13 11:24:21 -08:00
Stephen Fromm
4f110e4fc6 Merge pull request #1865 from sfromm/issue1738
Add run_command to module_common and update modules to use it.
2013-01-13 08:44:33 -08:00
Stephen Fromm
3fb21a5281 Update modules to use run_command in module_common.py
This updates apt, apt_repository, command, cron, easy_install, facter,
fireball, git, group, mount, ohai, pip, service, setup, subversion,
supervisorctl, svr4pkg, user, and yum to take advantage of run_command
in module_common.py.
2013-01-13 08:37:19 -08:00
Stephen Fromm
300531507b Add method run_command to module_common.py
This adds a helper method that modules can call to execute a command via
subproces.  It takes two arguments: the command to run and
keyword options that control how the process is executed.  Supported
options are: fail_on_rc_non_zero, close_fds, and executable.
fail_on_rc_non_zero will call fail_json if the command fails.  If
args is a list, the command will be run with shell=False; otherwise, if
a string, it will be run with shell=True.  Otherwise, run_command() returns
the returncode, stdout, and stderr.
2013-01-13 08:30:33 -08:00
Daniel Hokka Zakrisson
5d067497e3 Enable --list-hosts with a list of hosts 2013-01-13 15:29:32 +01:00
Daniel Hokka Zakrisson
a19a13ffa7 Add check for multiple keys in one invocation 2013-01-13 15:16:13 +01:00
Daniel Hokka Zakrisson
d11262af4d Fix raw (no executable) support on -c local 2013-01-13 15:16:13 +01:00
Daniel Hokka Zakrisson
5231be5d4b Add sudo password support for local 2013-01-13 15:16:13 +01:00
Daniel Hokka Zakrisson
7ecab22302 Move sudo command making to one common function 2013-01-13 15:16:13 +01:00
Daniel Hokka Zakrisson
c339434e57 Merge pull request #1863 from blair/remove-unused-sys-import
hacking/env-setup: remove unused sys import.
2013-01-13 05:54:42 -08:00
Daniel Hokka Zakrisson
630a8055c1 Merge pull request #1864 from eval/git-module-prevent-permission-denied
Prevent permission denied when cloning
2013-01-13 05:52:52 -08:00
Gert Goet
f4dcb33ccc Prevent permission denied when cloning
Without read permission to the current working directory, git-clone will
fail:
root@host:~$ sudo -u git -H git clone \
  git://github.com/ansible/ansible.git /home/git/ansible
fatal: Could not change back to '/root': Permission denied

This commit ensures that the working directory is changed to the
parent-folder of the destination before doing the clone.
2013-01-13 13:07:22 +01:00
Blair Zajac
ec5f6ae246 hacking/env-setup: remove unused sys import. 2013-01-12 19:07:50 -08:00
Michael DeHaan
b0ab81b237 Merge pull request #1862 from jpmens/doc-ex-ssh
typo in ssh private key name
2013-01-12 10:18:56 -08:00
Jan-Piet Mens
fc3f50454d typo in ssh private key name 2013-01-12 15:54:21 +01:00
Michael DeHaan
1cbc9569b3 Merge pull request #1853 from jure/more_info_from_ec2
EC2 module should report back the public_dns_name too
2013-01-10 16:07:55 -08:00
Daniel Hokka Zakrisson
060266e291 Python 2.4 fixes for modules 2013-01-10 19:24:23 +01:00
Daniel Hokka Zakrisson
3bc6228b97 Handle unreadable /proc/xen/capabilities
Fixes #1854.
2013-01-10 18:22:01 +01:00
Jure Triglav
3f43ede70c Fix indentation 2013-01-10 16:21:18 +01:00
Jure Triglav
2ee05f0c96 EC2 module should report back the public_dns_name too. 2013-01-10 16:14:47 +01:00
Michael DeHaan
b9442b2468 Merge pull request #1845 from leucos/patch-1
Updates Arch PKGBUILD to include other man pages
2013-01-10 05:06:59 -08:00
Michael DeHaan
f095f7c8c5 Merge pull request #1851 from Pinkbyte/distribution_fix
Fix distribution detection - return string instead of functions
2013-01-10 05:03:17 -08:00
Sergey Popov
e41f89d507 Fix distribution detection - return string instead of functions 2013-01-10 15:13:35 +04:00
Daniel Hokka Zakrisson
9649e4bf15 Merge pull request #1838 from jvantuyl/with_sequence
add with_sequence lookup plugin
2013-01-09 16:18:17 -08:00
Jayson Vantuyl
13ddd39db9 add with_sequence lookup plugin
Plugin allows you to do easy counts for items.
2013-01-09 15:30:24 -08:00
Daniel Hokka Zakrisson
b57b1f4cbe Correct name is login_user
Fixes #1848.
2013-01-09 23:57:36 +01:00
Michel Blanc
0526d08b85 Updates Arch PKGBUILD to include other man pages
Man pages for ansible-pull and ansible-docs are now installed properly
2013-01-09 17:28:55 +01:00
Daniel Hokka Zakrisson
a699685698 Merge pull request #1844 from dagwieers/import-fix
Revert the import of C in script
2013-01-09 07:03:26 -08:00
Dag Wieers
fb802beee7 In PR #1804 the use of C in script was moved to _low_level_execute_command()
So we cannot get rid of this one now.
2013-01-09 15:54:10 +01:00
Daniel Hokka Zakrisson
7782923ea2 Revert #1818 but avoid double-dwim, fixing relative fileglob 2013-01-09 14:52:52 +01:00
Daniel Hokka Zakrisson
891b1e371a Default to not using an executable
For compatibility with older releases as well as avoiding things like
action: raw executable= show status
to communicate with devices that don't have sh.
2013-01-09 14:15:47 +01:00
Daniel Hokka Zakrisson
92ad206b84 Use re instead of shlex.split to find executable
shlex.split will strip quotes and it might not even be sh at this point.
2013-01-09 14:13:53 +01:00
Michael DeHaan
910667152c Merge pull request #1843 from dagwieers/import-cleanup
Clean up imports (taken from PR #1804)
2013-01-09 04:56:58 -08:00
Dag Wieers
b781438480 Clean up imports (taken from PR #1804) 2013-01-09 13:51:27 +01:00
Daniel Hokka Zakrisson
87b2378e22 Resolve variable references inside variables
Fixes the case where variable x is '$y' and y is a dict(foo='bar') and
an attempt to access ${x.foo} is made.
2013-01-09 13:45:55 +01:00
Daniel Hokka Zakrisson
073fb21bcb Document that task includes are now infinite depth 2013-01-09 13:41:14 +01:00
Daniel Hokka Zakrisson
1b5d039bf4 Extend executable= support in raw to include no execuable
Useful for managing not-UNIX things.
2013-01-08 17:45:37 +01:00
Daniel Hokka Zakrisson
4955587d8c Merge pull request #1798 from dagwieers/raw-executable
Allow to change executable (shell/interpreter) when using raw
2013-01-08 08:35:08 -08:00
Daniel Hokka Zakrisson
c23eda82c2 Allow pattern[0] to address a single node
Replaces erroring out on it and requiring the abysmal pattern[0-0]
instead.
2013-01-07 18:20:09 +01:00
Michael DeHaan
03ab074d0d Merge pull request #1821 from leucos/path-expand-fix
Expands path on file operations
2013-01-07 05:05:20 -08:00
Michael DeHaan
713ce4c0cf Merge pull request #1832 from legrostdg/devel
add encoding documentation in postgresql_db
2013-01-07 05:03:39 -08:00
Michael DeHaan
3f4847a3ab Merge pull request #1830 from willthames/fix_tilde_path_in_file
Fix behaviour when file handles a path with tilde
2013-01-07 05:03:09 -08:00
Félix Sipma
0ba7cf58e9 add encoding documentation in postgresql_db 2013-01-07 12:58:18 +01:00
willthames
4e50478a05 Fix behaviour when file handles a path with tilde
Two problems here
* unchecked exception handling and erroneous assumption as to why
  an exception might fire
* although the file module expands the path, when using file_args
  the unexpanded path is passed.

Expected result: ~/path/to/file should work fine
Actual result: exception is because it doesn't find file with a message
about not being able to get the selinux context
2013-01-07 16:30:29 +10:00
Daniel Hokka Zakrisson
4d48daff80 Actually allow using connection: on a task 2013-01-06 18:46:34 +01:00
Daniel Hokka Zakrisson
637370089a Skip polling when all hosts were skipped
Fixes #1823.
2013-01-06 16:49:29 +01:00
Daniel Hokka Zakrisson
1fa83fa584 Merge pull request #1813 from legrostdg/devel
postgresql_db fails with owner containing a "-"
2013-01-06 07:34:29 -08:00
Félix Sipma
02f531c609 remove quotes in has_table_privilege and has_database_privilege 2013-01-05 19:31:31 +01:00
Daniel Hokka Zakrisson
947ec34116 Merge pull request #1807 from willthames/openlog_unicode_fix
syslog.openlog does not cope with unicode first argument
2013-01-05 08:17:03 -08:00
Daniel Hokka Zakrisson
04f7066745 Merge pull request #1822 from leucos/pkgbuild-fix
Arch PKGBUILD fixes
2013-01-05 08:13:46 -08:00