Commit graph

4151 commits

Author SHA1 Message Date
Michael Scherer
4ed4bfff90 Do not fail if we try to generate a ssh key for a user without being root
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.

So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
2014-04-28 12:29:57 +02:00
mkosmach
cfc8b1c561 add simplejson as alternative to json 2014-04-25 02:44:51 -07:00
Ben
834115290d updated example to include instance_type 2014-04-24 11:50:49 -06:00
Ben
06ff535098 Added instance_type to ec2_lc variable list 2014-04-24 11:47:41 -06:00
Michael DeHaan
a9b4fcf703 Add missing license headers to two modules and standardize formatting of another. 2014-04-24 10:32:54 -04:00
James Cammarata
89d61b8a7d Add parameters to get_url for the url username/password
Fixes #6928
2014-04-24 00:26:50 -05:00
James Cammarata
33c1f697d2 Merge branch 'apt_key_format' of https://github.com/andreasf/ansible into andreasf-apt_key_format 2014-04-24 00:02:10 -05:00
James Cammarata
404412f254 Fixing the version_added string in the vsphere_guest module 2014-04-23 22:46:14 -05:00
James Cammarata
6aaf249847 Merge branch 'vmware_core' of https://github.com/rhoop/ansible into rhoop-vmware_core 2014-04-23 21:12:40 -05:00
James Cammarata
e7ce49f750 Merge pull request #7141 from lamby/devel
Correct/update debconf examples - need to specify vtype.
2014-04-23 21:09:52 -05:00
npeters
43ac7a7984 Remove invalid variable 2014-04-24 01:12:55 +02:00
James Cammarata
98d949e143 Merge pull request #7047 from joshuaconner/docker_bugfix_exclude_entrypoint_from_command_check
docker: exclude 'entrypoint' from comparing 'command' param with containers
2014-04-23 16:14:48 -05:00
James Cammarata
6468b72d59 Merge pull request #7022 from jjshoe/patch-1
apt_key lists all keys in uppercase
2014-04-23 15:58:23 -05:00
Richard Hoop
2364ede3fc Author 2014-04-23 16:53:12 -04:00
Chris Lamb
b123b648a0 Correct/update debconf examples - need to specify vtype.
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
2014-04-23 21:51:01 +01:00
James Cammarata
f068a4f26a Merge pull request #6991 from joshuaconner/bugfix_dont_send_wrong_params_to_dockerclient_start
Docker: don't send wrong parameters to client.start()
2014-04-23 15:48:04 -05:00
Richard Hoop
f6e6b313b7 Ready for pull request 2014-04-23 16:44:49 -04:00
Richard Hoop
f09ecf2239 Core complete 2014-04-23 15:26:03 -04:00
James Cammarata
3b78b05816 Merge pull request #6599 from dmage/nova_region_name
use region_name in nova_compute
2014-04-23 10:15:57 -05:00
James Cammarata
566a284186 Merge pull request #6985 from jimi-c/issue_6763_ec2_vpc_params
Ensure params were set in ec2_vpc before accessing them
2014-04-23 10:08:50 -05:00
James Cammarata
83d6ee998f Merge pull request #7128 from stansonhealth/improve_tag_docu
update ec2_tags documentation to include missing option
2014-04-23 09:31:42 -05:00
Erika Heidi
40e7c6eddc Possible docs error: 'path' instead of 'src'
I came to this example today (line 50), and when I tried it, I got an error:

`msg: src and dest are required for creating links`

So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
2014-04-23 16:00:22 +02:00
Richard Hoop
149a740a1c Started reconfigured 2014-04-23 09:53:12 -04:00
Ted Timmons
118ed766e6 update documentation to include missing option
'list' was added more recently, it was omitted from the documentation.
2014-04-23 08:44:43 -05:00
Richard Hoop
b81d5d532e Creation complete 2014-04-22 17:12:23 -04:00
Richard Hoop
a956522363 More config checks and clean up for vm_config settings 2014-04-22 16:20:04 -04:00
James Cammarata
f6679d4ad4 Merge pull request #7076 from mscherer/better_message_service
Add a better error message for service
2014-04-22 08:44:14 -05:00
Michael Scherer
cf3365b99e Add a better error message for service
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.

So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
2014-04-22 09:13:57 +02:00
Richard Hoop
3dca5d510a Large cleanups. Reintegrating all modules together for a guest 2014-04-21 16:38:31 -04:00
James Cammarata
81f25e8b59 Merge pull request #7089 from dagwieers/debug-docs
Add an example to show all hostvars using debug
2014-04-21 12:11:39 -05:00
James Cammarata
234d0053bf Merge pull request #7096 from CaptTofu/docker
Small bug - 'acts' should be 'facts'
2014-04-21 11:49:26 -05:00
James Cammarata
2725538515 Merge pull request #7095 from radeksimko/pokemon-exc-fix
Prevent catching unrelated exceptions
2014-04-21 11:49:04 -05:00
CaptTofu
45d2cab30c Small bug - 'acts' should be 'facts' 2014-04-21 08:06:00 -07:00
Radek Simko
08befa9c86 Prevention for catching unrelated exceptions added 2014-04-21 15:35:49 +01:00
Radek Simko
7d47f46807 Explicit check of return code for autoinstallation of python-apt added
This will allow easier debugging through more meaningful error message.
2014-04-21 14:10:09 +01:00
Dag Wieers
a19fbc7b24 Add an example to show all hostvars using debug
This is a useful example to help debug how facts and vars are being collated.
2014-04-21 11:40:53 +02:00
Joshua Conner
0ce43d6e3c docker: exclude 'entrypoint' from comparing 'command' param with containers
The JSON the Docker API returns includes the container's ENTRYPOINT value (if it has one) with the 'Command' value. So instead of checking if `container['Command'] == module.params['command']`, we just check that `container['Command'].endswith(module.params['command'])` so the entrypoint won't affect a container being properly classified as matching the module params or not.

Also I refactored a super-long `if` statement into some temporary variables - I did it to help me figure out what was going wrong, and then it makes the code more readable so I kept it.
2014-04-17 16:10:53 -07:00
Joshua Conner
bac2e879b2 docker: send 1.10 params if docker-py is new enough version 2014-04-17 16:05:50 -07:00
Andreas Fleig
cef705d04f apt_key: fix key lookup for 64 bit key ids
Fixes #7018 by extending `all_keys` to work with either short or long keys.

Also removes the ununsed method `key_present`.
2014-04-17 03:51:19 +02:00
Matt Bray
afd0e78f16 docker.client.APIError has moved to docker.errors.APIError
see 18d4db09ec
2014-04-16 23:42:56 +01:00
James Cammarata
019c515a0b Check resource_tags value before using it in ec2_vpc
Fixes #7024
2014-04-16 12:21:32 -05:00
James Cammarata
e1cbdedf19 Merge branch 'devel' of https://github.com/evanccopengeo/ansible into evanccopengeo-devel 2014-04-16 10:24:39 -05:00
jjshoe
eeb2c240ca apt_key lists all keys in uppercase
allow for a little user error
2014-04-16 10:06:59 -05:00
Hernandes B. de Sousa
780b5e0bbf Add missing info for the append option
Both 'default' and 'choices' options were missing at the documentation.
2014-04-16 01:22:12 -03:00
James Cammarata
39356bd83b Get the bin path for commands in the unarchive module
Fixes #6927
2014-04-15 20:39:22 -05:00
evanccopengeo
ab8f9544a6 cleaning up the code a bit more 2014-04-15 18:16:34 -04:00
evanccopengeo
2ab68cba0c fixing bug where if both private_ip and assign_public_p are set ansible fails out 2014-04-15 17:55:26 -04:00
James Cammarata
0c96e2f33b Check to make sure the firewalld client is connected before proceeding
Fixes #6911
2014-04-15 15:03:52 -05:00
Cédric RICARD
556c780ac9 Fixed test on 'cached' parameter.
'cached' parameter is boolean, not string
2014-04-15 16:41:27 +02:00
Joshua Conner
6bf75de95c Docker: don't send wrong parameters to client.start()
As part of being updated for the 1.10 API, a couple of parameters were passed to the docker.client.start() command that it doesn't accept. This caused the module to error out if it tried to start any Docker containers. This removes those parameters so the module works again.
2014-04-14 15:05:42 -07:00