Commit graph

26338 commits

Author SHA1 Message Date
René Moser
5197654437 cloudstack, cs_firewall: fix network not found error in return results (#2006)
Only a small issue in results.

In case of type is ingress, we rely on ip address, but in results we also return the network.
Resolving the ip address works without zone params. If the ip address is not located in the default zone and zone param is not set,
the network won't be found because default zone was used for the network query listing.

However since network param is not used for type ingress we skip the return of the network in results.
2016-12-08 11:34:05 -05:00
René Moser
d7e8dd22df cloudstack: cs_instance: fix template not found (#2005)
Let users decide which filter should be used to find the template.
2016-12-08 11:34:05 -05:00
Rene Moser
b5e4edd9f9 cloudstack: cs_template: fix state=extracted
* url arg is optional but we enforced it
* url is in a required together, but args only relevant while registering
2016-12-08 11:34:05 -05:00
Rene Moser
1b99ae4ac1 cloudstack: fix doc, display_text not required 2016-12-08 11:34:05 -05:00
Rene Moser
871f586378 cloudstack: cs_template: fix cross_zones template removal 2016-12-08 11:34:05 -05:00
David Shrewsbury
b928ffb5ac New OpenStack module os_port_facts (#1986) 2016-12-08 11:34:05 -05:00
Michael Scherer
1d1fba5476 Mark token as no_log, since that's used for auth (#2011) 2016-12-08 11:34:05 -05:00
Andrea Scarpino
b4064a352e The enable parameter is a boolean, then convert to a boolean. (#1607)
At the moment, this only works when 'enable' is equals to 'yes' or 'no'.

While I'm on it, I also fixed a typo in the example and added a required
parameter.
2016-12-08 11:34:05 -05:00
Kamil Szczygieł
26fe35fd0c VMware datacenter module shouldn't hold pyvmomi context in Ansible module object (#1568)
* VMware datacenter module rewritten to don't hold pyvmomi context and objects in Ansible module object

fixed exceptions handling

added datacenter destroy result, moved checks

changed wrong value

wrong value again... need some sleep

* check_mode fixes

* state defaults to present, default changed to true

* module check fixes
2016-12-08 11:34:04 -05:00
Michael Scherer
e986aad9aa Remove dead code (#1303)
The review on https://github.com/ansible/ansible-modules-extras/pull/1303
show the problem was already fixed, so we just need to remove the
code.
2016-12-08 11:34:04 -05:00
stoned
6a77e62df4 cpanm: search both its stderr and its stdout for the message 'is up t…
Note that since cpanm version 1.6926 its messages are sent to stdout
when previously they were sent to stderr.

Also there is no need to initialize out_cpanm and err_cpanm and
check for their truthiness as module.run_command() and str.find()
take care of that.
2016-12-08 11:34:04 -05:00
Evgeni Golov
ab07c9c7e8 do not set LXC default config
this was accidentally re-introduced in 7120fb4b

Signed-off-by: Evgeni Golov <evgeni@golov.de>
2016-12-08 11:34:04 -05:00
Ricardo Carrillo Cruz
079a7dc490 Add os_user_facts module
This module gather facts about one or more OpenStack users
2016-12-08 11:34:04 -05:00
Ricardo Carrillo Cruz
aba0597e45 Add os_keystone_domain_facts module
This module gathers one or more OpenStack domains facts
2016-12-08 11:34:04 -05:00
Matt Hite
a0b483746e Fixes issue #1992 -- fixes issue adding and deleting pools (#1994) 2016-12-08 11:34:04 -05:00
Michael Scherer
7a704ac600 Auth_toekn is a secret, shouldn't be logged (#1999) 2016-12-08 11:34:04 -05:00
Joerg Fiedler
518b03d73f add chroot flag to pkgng in order to allow installation of packages into chroot environments, e.g. jails (#1218) 2016-12-08 11:34:04 -05:00
Him You Ten
87ce503767 added stdout and stderr outputs (#1900)
* added stdout and stderr outputs

Added stdout and stderr outputs of the results from composer as the current msg output strips \n so very hard to read when debugging

* using stdout for fail_json

using stdout for fail_json so we get the stdout_lines array
2016-12-08 11:34:04 -05:00
Matt Hite
d2d4001dc5 New preserve_node parameter to skip unreferenced node removal 2016-12-08 11:34:04 -05:00
kubilus1
bcfab26d78 Unchecked index causes IndexError. 2016-12-08 11:34:04 -05:00
Jasper Lievisse Adriaanse
3a319b9a84 support for 'update_cache' in pkgin module 2016-12-08 11:34:04 -05:00
Michael Scherer
971b570b67 Do not leak passwords in case of error in cloudstack modules 2016-12-08 11:34:04 -05:00
Jonathan Mainguy
4b948af706 Enable stdout and stderr on sucessful runs, making show_diff useable
omit color symbols as ansible makes them illegible
2016-12-08 11:34:04 -05:00
Brian Beggs
75b172c706 hipchat api v2 rooms are now url escaped 2016-12-08 11:34:04 -05:00
Aaron Brady
7e1a538b93 Add to_destination parameter 2016-12-08 11:34:04 -05:00
Vlad Gusev
317fe95be0 system/puppet: add --tags parameter (#1916)
* system/puppet: add --tags parameter

--tags [1] is used to apply a part of the node’s catalog.

In puppet:
puppet agent --tags update,monitoring

In ansible:
puppet: tags=update,monitoring

[1] https://docs.puppetlabs.com/puppet/latest/reference/lang_tags.html#restricting-catalog-runs

* Add example of tag usage.

* system/puppet: add list type for a tags dict.
2016-12-08 11:34:03 -05:00
Michael Scherer
817335ae0d Client_secret is supposed to be kept secret, so mark it as no_log (#1995) 2016-12-08 11:34:03 -05:00
nitzmahone
bd3172b2e8 win_updates fix to use documented InstanceGuid property name 2016-12-08 11:34:03 -05:00
nitzmahone
e20eac089f win_updates shouldn't install hidden updates 2016-12-08 11:34:03 -05:00
Michael Scherer
e7e1a8bfea Avoid token leak by marking it as sensitive with no_log (#1966) 2016-12-08 11:34:03 -05:00
Michael Scherer
ed69d8335e Properly label path argument with type='path' (#1940) 2016-12-08 11:34:03 -05:00
Michael Scherer
b8706a1f95 Do not leak mail password by error 2016-12-08 11:34:03 -05:00
Michael Scherer
0dd3296ddd Mark password as 'no_log', to avoid leaking it 2016-12-08 11:34:03 -05:00
Rob
b93fda8573 Updated Amazon module guidelines regarding boto3
* Updated Amazon module guidelines regarding boto3

* Spelling correction
2016-12-08 11:34:03 -05:00
Andy Baker
c0d281e290 type should be 'list' not the default of 'string' 2016-12-08 11:34:03 -05:00
Evgeni Golov
1847f19e41 don't create world-readable archives of LXC containers
with the default umask tar will create a world-readable archive of the

container, which may contain sensitive data

Signed-off-by: Evgeni Golov <evgeni@golov.de>
2016-12-08 11:34:03 -05:00
Michael Scherer
3b79c1621b Prevent password leaks in notification/irc 2016-12-08 11:34:03 -05:00
Michael Scherer
67b2623e92 Use no_log=True for campfire module to avoid leaks 2016-12-08 11:34:03 -05:00
Michael Scherer
f2bf444395 Set no log for jabber.py password 2016-12-08 11:34:03 -05:00
Evgeni Golov
16b2d85d34 do not use a predictable filenames in the LXC plugin
* do not use a predictable filename for the LXC attach script

* don't use predictable filenames for LXC attach script logging

* don't set a predictable archive_path

this should prevent symlink attacks which could result in

* data corruption

* data leakage

* privilege escalation
2016-12-08 11:34:03 -05:00
Michael Scherer
f47a756c46 Add proper type to cpanm arguments
from_path, locallib, executable should be path to benefits
from path expansion for ~user.
2016-12-08 11:34:03 -05:00
Chulki Lee
432a9a31ca osx_defaults: fix datetime
Fix #1742
2016-12-08 11:34:02 -05:00
Matt Martz
c8bd27f1e8 Rebase PRs against $TRAVIS_BRANCH before performing tests 2016-12-08 11:34:02 -05:00
mo@oclab.net
20fd04b9e7 firewalld: fixes documentation
- removes warning, aligning to existing documentation
- adds version
2016-12-08 11:34:02 -05:00
mo@oclab.net
8b2d484032 firewalld: add/remove interfaces to/from zones 2016-12-08 11:34:02 -05:00
David Hocky
aabd6390d4 fix dscp marking documentation in iptables module 2016-12-08 11:34:02 -05:00
Evgeni Golov
88d8820f1b explicitly set "default: null" in the docs 2016-12-08 11:34:02 -05:00
Evgeni Golov
e1846d2e4b do not set a default config for lxc containers
otherwise deploying user-containers fail as these require information
from ~/.config/lxc/default.conf that the LXC tools will load if no
--config was supplied

Signed-off-by: Evgeni Golov <evgeni@golov.de>
2016-12-08 11:34:02 -05:00
Chris Porter
2b8b04638d fix security vulnerability in lxc module
octal/decimal confusion makes file world-writable before executing it
2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
e3d8facc7f fixxed tests 2016-12-08 11:34:02 -05:00