Commit graph

2418 commits

Author SHA1 Message Date
Max Rothman
f1f201c234 Fix rds "promote" command never promoting
Previously, the `promote` command in the `rds` module would always return OK and never actually promote an instance. This was because `promote_db_instance()` had its conditions backwards: if the instance had the `replication_source` attribute indicating that it **was** a replica, it would set `changed = False` and do nothing. If the instance **wasn't** a replica, it would attempt to run `boto.rds.promote_read_replica()`, which would always fail.
2015-11-24 16:10:28 -05:00
krdlab
dd76b51990 Fix self.changed value in ElbManager (ec2_elb_lb) 2015-11-25 04:42:51 +09:00
joshuaeke
ab420300ef Update ec2.py remove state tag
'exact_count' and 'state' are mutually exclusive options they should not be in the following examples:
- # Enforce that 5 running instances named "database" with a "dbtype" of "postgres" example and 
- # Enforce that 5 instances with a tag "foo" are running
2015-11-24 18:48:59 +00:00
Toshio Kuratomi
8ae30f1822 Minor simplification of code 2015-11-23 16:23:41 -08:00
Toshio Kuratomi
5617cd57cf Merge pull request #2512 from erewh0n/ec2-require-all-groups
Fail ec2 module when group names cannot resolve to IDs
2015-11-23 16:20:31 -08:00
Toshio Kuratomi
1270bacee7 Merge pull request #2425 from aioue/patch-5
Update ec2_elb_lb.py
2015-11-23 15:55:51 -08:00
Matt Martz
03035d7a31 Merge pull request #2524 from Shrews/os_image
Bug fix for os_image and min_disk/min_ram
2015-11-23 16:45:11 -06:00
Brian Coca
6bd8020f65 corrected version_added, removed empty alias 2015-11-24 09:32:46 -08:00
Brian Coca
b789db7b9d Merge pull request #2211 from kai11/feature/spot_launch_group
Added launch group support for ec2 module
2015-11-23 09:31:33 -08:00
David Shrewsbury
d13741314e Bug fix for os_image and min_disk/min_ram
The min_disk and min_ram parameters were not being passed to
the shade API. They also need to be integer values. Also
updated the description of these parameters for better
clarification.
2015-11-23 11:29:00 -05:00
Will Rouesnel
7237798f20 docker: Fix state=reloaded to detect default LoggingDriver for docker
Previously the logging module hard coded the default logging driver. This means
if the docker daemon is started with a different logging driver, the ansible
module would continually restart it when run.

This fix adds a call to docker.Client.info(), which is inspected if a logging
driver is not supplied in the playbook, and the container only restarted if
the logging driver applied differs from the configured default.

In usage, this has solved issues with using alternative logging drivers.
2015-11-24 00:30:42 +11:00
Keith Hassen
39ef6a1a80 Fail if any group name is not resolved to an ID. 2015-11-22 22:07:47 -05:00
Brian Coca
0e043f8c58 Merge pull request #2505 from donckers/devel
Fix #822 - Correct failure to overwrite existing records
2015-11-20 17:22:22 -08:00
Brian Coca
6d722608d6 Merge pull request #2413 from raben2/devel
Absent Function was not working on user with login profile
2015-11-20 17:00:20 -08:00
Daniel Donckers
3b8147af30 Fixes #822 2015-11-20 14:55:39 -06:00
Brian Coca
88e0bfd75d Merge pull request #2492 from Shrews/os_user_group
Fix os_user_group module
2015-11-18 12:55:40 -08:00
Mike Riddle
062c7764e6 Fixed error message: TypeError: fail_json() takes exactly 1 argument (2 given) 2015-11-18 15:10:15 -05:00
Brian Coca
1d6b31a90f fixed break order 2015-11-19 09:28:40 -08:00
David Shrewsbury
2a306c6b8c Fix os_user_group module
This module had a couple of errors in it. Also added check mode
support.
2015-11-18 15:03:07 -05:00
Tom Paine
4bc834485a Update ec2_elb_lb.py 2015-11-18 19:45:32 +00:00
Brian Coca
2c92fc4d3c Merge pull request #2484 from bcoca/ec2_elb_get_really_all
Ec2 elb get really all items
2015-11-17 12:20:51 -08:00
Chrrrles Paul
b1c0249045 Merge pull request #2409 from stewrutledge/reconfnetwork
Added support for reconfiguring network
2015-11-17 09:51:14 +08:00
Brian Coca
1258f82648 Merge pull request #2467 from cinek810/fix_ident
It may be string with int comparison, if ansible user specifies ident…
2015-11-13 14:57:21 -08:00
Marcin Stolarek
b6223ca729 Save changes of special characters to rset, without that comparison rset.to_xml() == wanted_rset.to_xml() will fail if record contains * or @ characters. 2015-11-13 11:32:10 +01:00
Marcin Stolarek
3193961cf5 It may be string with int comparison, if ansible user specifies identifier as int 2015-11-13 10:45:27 +01:00
Steve Spencer
fc5da26dee Sync up with allowable docker volume mounting modes 2015-11-12 10:42:26 +02:00
J Levitt
889274a525 Add rds restore example to list of examples
There was no db restore example. I've provided one that shows how to do the restore, then add a security group (you cannot add the security group during the restore step -- it has to be done in a modify step afterward). Also, I show how to get the endpoint.
2015-11-11 15:15:30 -06:00
Steve Spencer
2c95641d66 Add support for mounting host volumes with Z and z options 2015-11-11 16:44:01 +02:00
Rabenstein
7d665db5e5 Squash of 3 commits for bugfix.
Absent unction was not working on user with login profile
also fixed the exception handling

fixed the delete user function
now works with or without loginprofile (password)

typo
2015-11-11 09:54:55 +01:00
Monty Taylor
ccb39767cf Use add_ips_to_server API
This module is still using an old pre-release API and needs to update
to use the current API.

Co-Authored-By: Marton Kiss <marton.kiss@gmail.com>
2015-11-09 11:38:04 -05:00
Andy Nelson
9618986804 Update to ec2_vpc.py to:
1 allow interface ids and vpc peering connections as route targets
2 set state to "terminated" when VPC is removed
3 fix some comment typos

updates per PR comments
2015-11-08 18:35:27 +00:00
Toshio Kuratomi
f2943bd404 Add zfil as an owner of the docker module 2015-11-06 21:18:46 -08:00
Toshio Kuratomi
4ed7b690f6 Add a new contributor as a maintainer of the docker module 2015-11-06 10:53:33 -08:00
Toshio Kuratomi
750aa16a06 Merge pull request #2093 from zfil/fix_facts
docker module: fix regressions introduced by f38186c and 80aca4b
2015-11-06 10:20:20 -08:00
Tom Paine
dd26c37f6b Update ec2_elb_lb.py
add connection draining default
2015-11-06 17:43:24 +00:00
Will Thames
0dd58e9326 Use connect_to_aws where possible
`connect_to_aws` fixes a bug with security tokens in AWS.
Modules should use that rather than calling
`boto.x.connect_to_region`
2015-11-06 19:05:01 +10:00
Brian Coca
1f9c204178 Merge pull request #2379 from larsks/feature/os_server_facts_returns_list
os_server_facts returns facts about multiple servers
2015-11-05 12:50:29 -05:00
Stewart Rutledge
adbc430984 Added support for reconfiguring network (moving to another switch, for example) 2015-11-04 14:22:08 +01:00
Leonty
cff83dd257 Merge remote-tracking branch 'upstream/devel' into devel 2015-11-04 12:48:14 +03:00
Leonty
5b904c1401 Corrected misspelling in the 'labels' docker parameter documentation. 2015-11-04 12:43:03 +03:00
Toshio Kuratomi
62672b8b85 Merge pull request #2228 from abridgett/feature/add_ec2_elb_lb_idle_timeout
add idle_timeout support
2015-11-03 10:24:58 -08:00
Brian Coca
cac69f3135 added missing version_added 2015-11-03 13:25:46 -05:00
Brian Coca
aa6f80669a Merge pull request #534 from ferrants/ami-launch-permissions
ec2_ami can update an ami's launch_permissions
2015-11-03 13:21:44 -05:00
Brian Coca
c91da5714e Merge pull request #2279 from wimnat/feature/iam_policy_idempotentcy
Allow iam_policy to maintain idempotence if the role referenced has …
2015-11-03 13:10:42 -05:00
Brian Coca
3aee4b9469 Merge pull request #2326 from jibsheet/devel
Mark this as a string so it is rendered in the docs
2015-11-03 13:10:15 -05:00
Toshio Kuratomi
0de2627efc Make cache_parameter_group the name of this new param to match with similar params (leave old name as an alias) 2015-11-02 17:33:04 -08:00
Toshio Kuratomi
e16c5c54fd Revert "Expose cache_parameter_group_name in elasticache module"
This PR #1950 implements duplicate functionality to #1353
This reverts commit b04efa22c4.

Conflicts:
	cloud/amazon/elasticache.py
2015-11-02 17:27:54 -08:00
Brian Coca
59b87836d1 Merge pull request #2222 from pgilad/patch-1
Add state=running on some ec2 examples
2015-11-02 19:12:25 -05:00
Brian Coca
d6c97bc880 Merge pull request #2381 from gregdek/devel
Module ownership changes
2015-11-02 19:00:21 -05:00
Brian Coca
a38e0095f9 added missing version added 2015-11-02 18:54:30 -05:00
Brian Coca
6e905f0586 Merge pull request #1950 from frenchfrywpepper/cache_parameter_group_name
Expose cache_parameter_group_name in elasticache module
2015-11-02 18:49:55 -05:00
Toshio Kuratomi
e318be30ff Fix issues version_added and chaged => changed typo 2015-11-02 10:49:24 -08:00
Michael Schuett
80c2e28a48 Fix message
Previous fix did not actual work. This fix does however.
2015-11-02 10:49:24 -08:00
Michael Schuett
b0357bf9e8 Handle connection error
Try and help when mac hits a connection error.
2015-11-02 10:49:24 -08:00
Michael Schuett
1dcb31cad6 remove .geturl()
Can't call geturl on a string.
2015-11-02 10:49:24 -08:00
Michael Schuett
c126498899 Remove faulty logic
Update logic after splitting the error into two separate messages.
2015-11-02 10:49:24 -08:00
Michael Schuett
1e8d20b0da Documentation Fix
Updated documentation to match current module state.
2015-11-02 10:49:24 -08:00
Michael Schuett
0a5b7087bd Improve Message
Give user a course of action in the case where the suggestions do not
work. This will hopefully allow us to work through any further issues
much faster.
2015-11-02 10:49:24 -08:00
Michael Schuett
addbc329be Improve Error Reporting
This will hopefully help mac users be able to quickly resolve any issues
they may find when trying to use this module.
2015-11-02 10:49:24 -08:00
Michael Schuett
bf5929d32a docker_image TLS
Check commit enables using tls when using the docker_image module. It
also removes the default for docker_url which doesn't allow us to check
for DOCKER_HOST which is a more sane default. This allows you to use
docker_image on OSX but more documentation is needed.
2015-11-02 10:49:24 -08:00
Brian Coca
794cbeea23 use marker instead of is_truncated which does not seem to work 2015-11-02 13:10:20 -05:00
Brian Coca
b90318ae6c loop to get all load balancers, boto limited to 400 at a time
fixes #2115
2015-11-02 13:05:22 -05:00
luto
d5ed8381b6 vsphere_guest: add power status to facts 2015-11-02 17:48:37 +01:00
Brian Coca
77ded03510 Merge pull request #953 from rwky/asg_542
Fixes #542 error when ec2_asg arguments aren't specified
2015-11-02 09:04:42 -05:00
Adrian Bridgett
d4319555a0 Merge branch 'devel' into feature/add_ec2_elb_lb_idle_timeout
* devel: (84 commits)
  Document and return an error if httplib2 >= 0.7 is not present.  We
  since find doesn't make changes, support check mode and gather data for other tasks in check mode
  Correct typo in yum module docs
  Update doc to reflect password is required if adding a new user
  Update error message to be more explicit
  Simplify logic to handle options set to empty string
  Fix to issue 12912. Supply 'force' to install of python-apt.
  Note the difference between yum package groups and environment groups.
  rearranged systemd check, removed redundant systemctl check fixed unused cmd and state var assignements
  added earlier paths to systemd
  make os_router return a top level 'id' key
  Version bump for new beta 2.0.0-0.4.beta2
  allow os_port to accept a list of security groups
  allow os_server to accept a list of security groups
  Add capability for stat module to use more hash algorithms
  allow empty description attribute for os_security_group
  Update hostname.py
  simpler way to check if systemd is the init system
  make os_keypair return a top level 'id' key
  make os_flavor return a top-level 'id' key
  ...
2015-10-29 14:18:34 +00:00
Greg DeKoenigsberg
344cf5fc0e Remove @ralph-tice from maintainership per his request 2015-10-28 14:47:03 -04:00
Greg DeKoenigsberg
7cb9289197 Clarity of owner, even though module is deprecated 2015-10-28 14:40:54 -04:00
Greg DeKoenigsberg
57dcf2c9dd @lorin stepping down as maintainer 2015-10-28 14:38:11 -04:00
Lars Kellogg-Stedman
e70002d2f9 os_server_facts returns facts about multiple servers
have `os_server_facts` call `list_servers` rather than `get_server`, and
treat the `server` parameter as a wildcard pattern.  This permits one to
get facts on a single server:

    - os_server:
        server: webserver1

On mutiple servers:

    - os_server:
        server: webserver*

Or on all servers:

    - os_server:

Introduces a `detailed` parameter to request additional server details
at the cost of additional API calls.
2015-10-28 13:18:54 -04:00
Manuel Tiago Pereira
3079c5e001 Add support for legacy registries to pull_image().
Since we now have several exceptions to the assumption that the
result of the pull would be on the last status line returned by
docker-py's pull(), I've changed the function so that it looks
through the status lines and returns what if finds on it.
Despite the repeated `break`s, the code seems simpler and a little
more coherent like this. From what I've checked using
`https://github.com/jlafon/ansible-profile`, the execution time is
mostly the same.
2015-10-28 11:35:14 +00:00
Brian Coca
3b5afc2393 made port default depending on db engine 2015-10-27 21:49:54 -04:00
Brian Coca
30951e2811 Merge pull request #2345 from larsks/bug/port-allow-secgroup-list
allow os_port to accept a list of security groups
2015-10-26 19:45:39 -04:00
Brian Coca
7c1fcd8e13 Merge pull request #2349 from larsks/bug/router-should-return-id
make os_router return a top level 'id' key
2015-10-26 18:20:26 -04:00
Bermudez, Jaime
6992d0d465 Merge remote-tracking branch 'upstream/devel' into feature/iam_policy_present_state_includes_policy_changes 2015-10-25 08:37:40 -04:00
Brian Coca
ad8fd86467 Merge pull request #2338 from larsks/bug/flavor-should-return-id
make os_flavor return a top-level 'id' key
2015-10-23 14:52:03 -04:00
Brian Coca
0e0c28bfb1 Merge pull request #2344 from larsks/bug/allow-secgroup-list
allow os_server to accept a list of security groups
2015-10-23 14:51:45 -04:00
Brian Coca
3199a73927 Merge pull request #2339 from larsks/bug/keypair-should-return-id
make os_keypair return a top level 'id' key
2015-10-23 14:51:27 -04:00
Brian Coca
59f11aa973 Merge pull request #2336 from larsks/feature/os-subnet-returns-something
return information about created subnet
2015-10-23 14:51:05 -04:00
Lars Kellogg-Stedman
d82460a372 make os_router return a top level 'id' key
make os_router return a top-level 'id' key, much like other
os_* resources.
2015-10-23 13:32:37 -04:00
Lars Kellogg-Stedman
a2fe8dba68 allow os_port to accept a list of security groups
with this commit, the `security_groups` attribute for `os_port` will
accept either a common-delimited string or ` YAML list.  That is, either
this:

    - os_port:
        [...]
        security_groups: group1,group2

Or this:

    - os_port:
        [...]
        security_groups:
          - group1
          - group2
2015-10-23 09:44:07 -04:00
Brian Coca
12b0582f9e Merge pull request #2343 from larsks/bug/secgroup-allow-empty-description
allow empty description attribute for os_security_group
2015-10-23 09:43:01 -04:00
Brian Coca
49a66eb8d2 Merge pull request #2337 from larsks/bug/os-network-always-unchanged
make os_network correctly report changed status
2015-10-23 09:42:45 -04:00
Lars Kellogg-Stedman
b0c10a7d31 allow os_server to accept a list of security groups
This commit allows the `security_groups` parameter of the `os_server`
module to be either a YAML list or a common-delimited string (much like
the `nics` attribute).  E.g., this:

    - os_nova_server:
        [...]
        security_groups:
          - default
          - webserver

Or this:

    - os_nova_server:
        [...]
        security_groups: default,webserver
2015-10-22 22:53:05 -04:00
Lars Kellogg-Stedman
da0fbfc564 allow empty description attribute for os_security_group
The `os_security_group` module would fail if there was no `description:`
attribute:

    localhost | FAILED! => {
        "changed": false,
        "failed": true,
	"msg": "Error creating security group larstest: Invalid input for
	description. Reason: 'None' is not a valid string."
    }

This commit makes the default description `''` rather than `None`.
2015-10-22 21:26:47 -04:00
Brian Coca
1ca4543e48 Merge pull request #2315 from Etherdaemon/fix_aws_iam_connection_12831
fixes #12831 by updating the boto iam connection method
2015-10-22 16:17:57 -04:00
Bermudez, Jaime
d5f48d29e1 Simplify logic around "present" state and skip dupes. If the policy doesn't exist or the policy document doesn't match or if we're not skipping dupes, then we go ahead and update the respective user/group/role policy. 2015-10-22 14:54:28 -04:00
Lars Kellogg-Stedman
377811dac2 make os_keypair return a top level 'id' key
make os_keypair return a top-level 'id' key, much like other os_*
resources.
2015-10-22 13:59:45 -04:00
Lars Kellogg-Stedman
8368da4297 make os_flavor return a top-level 'id' key
make os_flavor return a top-level 'id' key, much like other os_*
resources.
2015-10-22 13:56:56 -04:00
Lars Kellogg-Stedman
c54c5c8234 make os_network correctly report changed status
The `os_network` module was incorrectly returning changed=False whether
or not the network was created.  This commit makes the changed return
value useful.
2015-10-22 13:38:32 -04:00
Lars Kellogg-Stedman
d73f5a4adb return information about created subnet
make os_subnet behave like os_network in terms of returning information
about the created resource.  With this commit, os_subnet will return the
created subnet in `subnet` and the subnet id in `id`.
2015-10-22 13:27:17 -04:00
David Shrewsbury
5d73a9a4c5 Fix for routers without external interfaces 2015-10-22 11:52:28 -04:00
Matt Martz
2e49d89be7 Merge pull request #2328 from emonty/bug/is-public
Actually pass in is_public to create_image
2015-10-21 19:46:18 -05:00
Monty Taylor
e7bdf7f7f6 Actually pass in is_public to create_image
Fixes #2325
2015-10-22 08:52:05 +09:00
Brian Coca
88e7dcf174 fixed mispelled description 2015-10-21 19:39:17 -04:00
Etherdaemon
08559670e5 Update try statement as pointed out by defionscode 2015-10-22 09:12:58 +10:00
Etherdaemon
d6da9c1516 Merge branch 'devel' into fix_aws_iam_connection_12831 2015-10-22 09:09:30 +10:00
Kevin Falcone
735eefb2ca Mark this as a string so it is rendered in the docs
When this was treated as a boolean, sphinx was leaving the Default
column on http://docs.ansible.com/ansible/ec2_module.html blank,
implying it would use AWS's default.  In reality, it passes False, which
overrides the defaults at AWS (it's possible to boot an instance which
AWS claims will always have EBS optimization without it because of this
silently passed False).
2015-10-21 16:43:50 -04:00
Toshio Kuratomi
bc3b1abd68 Another fix for docs 2015-10-21 08:40:10 -07:00
Toshio Kuratomi
e41cde3116 Correct docs build 2015-10-21 08:36:08 -07:00
Matt Martz
dc1f0c6f9f Merge pull request #2319 from Shrews/os_user
Add OpenStack Keystone User module
2015-10-20 15:43:50 -05:00
David Shrewsbury
fde149cbe8 Clarify password requirement and add return docs. 2015-10-20 15:49:52 -04:00
David Shrewsbury
cdf7117f7e Add OpenStack Keystone User module
This is a replacement for PR #1598 and fixes #283
2015-10-20 13:29:41 -04:00
Brian Coca
377aaf526c Merge pull request #2292 from Constantin07/update_ec2_ami_find
Included 'block_device_mapping' in the output of module and other mis…
2015-10-20 13:07:00 -04:00
Constantin Bugneac
01b8432496 Added documentation for returned structure 2015-10-20 09:30:57 +01:00
Etherdaemon
2b2285eb67 fixes #12831 by updating the boto iam connection method to connect_to_region 2015-10-20 16:38:27 +10:00
Brian Coca
14f32de7a6 added missing version_added to new accesslogs feature 2015-10-19 20:11:54 -04:00
Brian Coca
f4ed4b37a9 Merge pull request #2126 from nfelsen/access_logs
Adding support for access logs in ELB
2015-10-19 20:06:31 -04:00
Brian Coca
250b1f48fc Merge pull request #2274 from niothiel/devel
Remove duplicate logic
2015-10-19 17:53:53 -04:00
Brian Coca
0f308e1e07 Merge pull request #2275 from larsks/bug/2253
fix handling of nics argument
2015-10-19 16:39:51 -04:00
Brian Coca
b73ffa3b6f Merge pull request #2310 from Shrews/os_router
Fix os_router to accept internal interfaces
2015-10-19 16:24:54 -04:00
David Shrewsbury
55e9dc73f5 Fix os_router to accept internal interfaces
Allow the 'interfaces' attribute to represent internal router
interfaces, composed of subnet names, and the 'external_fixed_ips'
attribute to represent external interface subnet/IP.
2015-10-19 15:53:15 -04:00
Brian Coca
300c816503 Merge pull request #2180 from wimnat/feature/issue-695
Resolve issue 695 (no change reported) and other misc fixes
2015-10-19 10:47:02 -04:00
Lars Kellogg-Stedman
06098a9d69 fix handling of nics argument
The existing code was receiving a list of strings and erroneously
assuming it was being given a list of dictionaries, leading it to fail
with:

    AttributeError: 'str' object has no attribute 'get'

This commit corrects the list handling code to check the type of each
item and handle it appropriately.   Also, based on bcoca's comment
in #2253, thie code removes the special case for a string-only argument.

By transforming string arguments into dicts and then handling them like
any other dict argument, this also permits arguments of the form:

    nics: net-name=mynet

Or:

    nics: port-name=mynet

Previous versions of this code only supported `net-id` and `port-id` in
string specifications.
2015-10-18 21:54:40 -04:00
Monty Taylor
4590ba4e59 Make the auto ip parameter auto_ip
There was a parameter in the docs called 'public_ip' that didn't
actually exist. Additionally, auto_floating_ip is not consistent with
the underlying parameter which is auto_ip - for no good reason.

Add auto_ip as the real parameter, and then make public_ip and
auto_floating_ip as aliases for it for backwards compatability.

Fixes #2301
2015-10-18 14:11:26 -04:00
Brian Coca
1ec0c1893a added note on when reboot command became available
fixes #2050
2015-10-17 00:49:01 -04:00
Brian Coca
5da7cf696c fixed results docs 2015-10-16 14:12:11 -04:00
Toshio Kuratomi
3af0d509c5 Some docs fixes 2015-10-16 11:03:53 -07:00
Constantin Bugneac
e715f7f968 Included 'block_device_mapping' in the output of module and other missing attributes 2015-10-16 16:08:10 +01:00
Nathaniel Felsen
2e74b17fad fixing merge conflict 2015-10-16 00:25:15 -07:00
Brian Coca
f2cd132cd0 Merge pull request #2287 from pgilad/patch-1
Docs: add state choices to ec2_elb_lb
2015-10-15 18:19:56 -04:00
Gilad Peleg
68e1ff2f81 Docs: remove redundant quotes in ec2_elb docs 2015-10-16 00:57:04 +03:00
Gilad Peleg
970185f2d2 Docs: add state choices to ec2_elb_lb
add state options (`present` and `absent`) to `ec2_elb-lb` doc
2015-10-16 00:37:21 +03:00
Brian Coca
7b21bc7144 Merge pull request #2238 from dagnello/server_meta_string
Adding string support to metadata argument
2015-10-15 14:44:57 -04:00
Brian Coca
3e22a45401 Merge pull request #2217 from wimnat/feature/issue-868
Add region to doc and handle missing region parameter
2015-10-15 10:17:14 -04:00
Brian Coca
6e54a5edc5 Merge pull request #2077 from dagnello/subnet_list_state
Adding os_subnets_facts module
2015-10-15 08:52:19 -04:00
whiter
6fc58855b9 Allow iam_policy to maintain idempotentce if the role referenced has been removed 2015-10-15 13:21:05 +11:00
whiter
5e61f0882b Add region to doc and handle missing region parameter 2015-10-15 01:31:42 +00:00
Rob
3360cef024 Update ec2_vol.py
Changed=true now reported on new volume.
Only detach volume when instance is specified as 'None' or '' rather than whenever instance is not specified at all
Fix regression caused by 6b27cdc where by no volume is created if id or Name is not supplied
Remove unnecessary empty aliases
Corrected example to use acceptable parameter for ions
Added exception handling to get_all_instances call
Moved the attachment state validation code to attach_volume function rather than create_volume function
Refactored attach_volume and detach_volume so that changed state can be passed back to call
Created get_volume_info function so that state=present and state=list can return the same data.  Also added instance_id as a returned value in attachment_set dict
Updated aws connection method so that boto profile can be used
2015-10-15 01:20:23 +00:00
Brian Coca
f35ab5faca Merge pull request #2106 from dagnello/port_module
Adding os_port Module to openstack ansible modules
2015-10-14 16:40:11 -04:00
Val Komarov
986d4064e9 Remove duplicate logic 2015-10-14 15:54:04 -04:00
Brian Coca
eb30416d71 Merge pull request #2114 from matiasdecarli/devel
Update Azure Module to work with azure.py=1.0.1
2015-10-14 15:46:26 -04:00
Brian Coca
4c14e6267f Merge pull request #2258 from SamYaple/fix_docker_bug_2257
Don't assume ExposedPorts exists (bug #2257)
2015-10-14 11:31:06 -04:00
Adam Williamson
64b8596250 fix #2043: strip empty dict from end of 'pull' stream
When pulling an image using Docker 1.8, it seems the output
JSON stream has an empty dict at the very end. This causes
ansible to fail when pulling an image, as it's expecting a
status message in that dict which it uses to determine whether
it had to download the image or not. As a bit of an ugly hack
for that which remains backward compatible, try the last item
in the stream, and if it's an empty dict, take the last-but-one
item instead.

The strip() is needed as the exact value appears to be '{}/r/n';
we could just match that, but it seems like the kind of thing
where maybe it'd happen to just be '{}/n' or '{}' or something
in some cases, so let's just use strip() in case.
2015-10-13 22:33:46 -07:00
Sam Yaple
f15d285514 Catch the second occurance of ExposedPorts as well 2015-10-13 10:34:08 +00:00
Sam Yaple
9db5ac8e45 Don't assume ExposedPorts exists (bug #2257)
A recent change [1] in docker between v1.8.2 and v1.8.3 changed what
is returned in the json when inspecting an image. Five variables which
could have been expected before will now be omited when empty. Only
one of those variables is being addressed in the docker, ExposedPorts.

Unfortunately there was also no API version change on this so this
can't be easily corrected with pinning the API to the older version.

This does a get() which will return None if the variable is not in the
dict formed from the json that was returned. Everything else works the
same way.

[1] 9098628b29
2015-10-13 10:24:36 +00:00
Brian Coca
6f9ff0b914 Merge pull request #2248 from Constantin07/devel
ec2_vol: added deleteOnTermination in the output of list option
2015-10-12 18:47:31 -04:00
Brian Coca
da1a317f7d Merge pull request #2139 from justnom/devel
Adding additional Docker log drivers.
2015-10-12 18:45:55 -04:00
Brian Coca
f1fc76d732 Merge pull request #2214 from fperks/fix-ec2-error-on-instance-status-change
Fix error on ec2 status change
2015-10-12 18:38:10 -04:00
Brian Coca
547cafe278 Merge pull request #2198 from hutchic/patch-2
make a text link into a actual hyperlink
2015-10-12 18:29:45 -04:00
Adrian Bridgett
cc821492d3 remove unneeded aliases 2015-10-12 17:45:37 +01:00
Constantin Bugneac
83291dbefc Added deleteOnTermination in the output of list option 2015-10-12 10:49:16 +01:00
Abhijit Menon-Sen
ebd8b12e15 Add missing variable initializations
Without this, «ec2: state=stopped instance_ids=…» would fail with a
traceback like this:

    if inst.get_attribute('sourceDestCheck')['sourceDestCheck'] != source_dest_check:
NameError: global name 'source_dest_check' is not defined
2015-10-11 07:25:56 +05:30
Aaron Boushley
81e9d1bde5 Fix issue with comparing versions improperly.
This allows old versions of docker api to function.
2015-10-09 16:26:46 -07:00
Brian Coca
f707a711cd doc fixes 2015-10-09 18:36:58 -04:00
dagnello
83a9f293fd Adding string support to metadata argument
This patch adds support to setting metadata key/value through a string
argument.  Variables can now be used for both the metadata key and
value.

example:
meta: "{{ var1 }}:SomeValue,key:{{ var2 }}"
2015-10-09 15:28:56 -04:00
Frank van Tol
2c24d0482b Update ec2_asg.py 2015-10-09 14:35:26 +02:00
Adrian Bridgett
686ceb81d7 add idle_timeout support 2015-10-08 16:28:01 +01:00
Brian Coca
5f1f1b2904 Merge pull request #2216 from wimnat/feature/revert-1906
Set default of dimensions parameter to be empty dict
2015-10-08 11:03:21 -04:00
Rob
5a6599d70d Move import statements for easier debugging (correct line numbers) 2015-10-08 14:03:40 +11:00
Brian Coca
9eb0c178ec Merge pull request #725 from robbwagoner/cloudformation-resources
module cloudformation: include a CFN stack's resources in the result
2015-10-07 21:35:39 -04:00
Brian Coca
85570152a7 Merge pull request #1626 from kmadac/fixed-digital-ocean-domain-MX-Origin-Error
Fixed bug, when MX records pointed to ORIGIN(@) caused unintentional …
2015-10-07 21:35:06 -04:00
Brian Coca
692781c936 Merge pull request #2070 from fvant/patch-7
We are copying from S3,  the bucket is the source, not the target.
2015-10-07 21:34:48 -04:00
Brian Coca
969c4eb493 Merge pull request #2078 from abithap/devel
os_server: Adding support to accept 'n' nic args as a string containi…
2015-10-07 21:34:33 -04:00
Brian Coca
7af7ef2ef7 Merge pull request #2086 from wimnat/feature/issue-2085
Remove 'str' type so that json is properly quoted
2015-10-07 21:34:00 -04:00
Brian Coca
af82f4b23e Merge pull request #2105 from dagnello/network_list_state
Adding os_networks_facts module
2015-10-07 21:33:28 -04:00
Brian Coca
00a18c2a6e Merge pull request #2110 from dagnello/os_image_facts
Adding new image facts module
2015-10-07 21:32:48 -04:00
Brian Coca
cb203420ed added version added to new rax_cdb choices 2015-10-07 21:30:17 -04:00
Brian Coca
202236f47f Merge pull request #1689 from mehulved/devel
Added support for instance types.
2015-10-07 21:27:06 -04:00
Brian Coca
547690c785 Merge pull request #2169 from stelligent/devel
Replaces 'old' get_ec2_creds connection method with get_aws_connection_info
2015-10-07 21:26:14 -04:00
Brian Coca
c4f64d822c changed modules to use common ec2 docs for region 2015-10-07 16:16:24 -04:00
fperks
7fd3262c3c Fix error on ec2 status change
Both `source_dest_check` and `termination_protection` variables are not
available within the scope of the startstopec2 instance method. This just
pulls them from module.params.
2015-10-07 13:43:57 -04:00
Gilad Peleg
5f914e854b Add state=running on some ec2 examples
`state=running` was missing in some of the ec2 module examples
2015-10-07 14:49:05 +03:00
Rob
ca517abf07 Set default of dimensions parameter to be empty dict 2015-10-07 13:54:00 +11:00
Kai Webber
d0b30dd86d Added launch group support for ec2 module 2015-10-06 20:26:10 +03:00
Andrew Pashkin
cee7e928fc Add 'entrypoint' parameter to Docker module 2015-10-06 12:47:47 +03:00
Adrian Lopez
8c7d697c17 Fix yaml syntax 2015-10-06 10:26:44 +02:00
dagnello
3365dad0d8 Adding os_port Module to openstack ansible modules 2015-10-05 19:36:37 -04:00
James Cammarata
a3e7f5cfcc Merge pull request #2062 from wimnat/feature/iam_policy_doc_fix
Update iam_policy.py doc and state default parameter
2015-10-05 16:53:14 -04:00
James Cammarata
02c9a1b336 Merge pull request #2158 from Shrews/os_network
Allow setting external attribute
2015-10-05 16:22:42 -04:00
Brian Coca
d4a03eed10 Merge pull request #2201 from halberom/qfix
ec2_tag - minor doc fix
2015-10-04 13:27:58 -04:00
Gerard Lynch
8b1ee3d6cb minor doc fix 2015-10-04 17:32:12 +01:00
Colin Hutchinson
f7aa6c4d27 make a text link into a actual hyperlink
the text link doesn't fit on some screen resolutions. Making it into sphinx hyperlink will solve that
2015-10-03 21:50:15 -04:00
Michael Fenn
9b04ca55f1 Support cloning VMs into a specific VM folder
The pysphere VIVirtualMachine.clone() method supports specifying a VM
folder to place the VM in after the clone has completed.  This exposes
that functionality to playbooks.

Also documents that creating VMs could always place VMs in a specific
folder.
2015-10-03 14:31:22 -04:00
Matias De Carli
c2520e6b67 keep backwards compatibility 2015-10-03 14:03:54 -03:00
Toshio Kuratomi
dbc860daaa Fix docs build 2015-10-02 09:21:29 -07:00
Brian Coca
79ec9efd7b Merge pull request #1048 from emonty/feature/os_router
Add OpenStack Router module
2015-10-02 10:10:31 -04:00
David Shrewsbury
aa1e8b8b05 Add author to os_router 2015-10-02 09:41:18 -04:00
David Shrewsbury
08e91ef68f Deprecate older router modules.
The quantum_router_gateway.py and quantum_router_interface.py modules
are deprecated with this change.
2015-10-02 09:24:03 -04:00
Andrew Pashkin
e96549c95d Harden matching running containers by "command" in the Docker module
Before this patch:

  - Command was matched if 'Command' field of docker-py
    representation of Docker container ends with 'command' passed
    to Ansible docker module by user.
  - That can give false positives and false negatives.
  - For example:
      a) If 'command' was set up with more than one spaces,
         like 'command=sleep  123', it would be never matched again
         with a container(s) launched by this task.
         Because after launching, command would be normalized and
         appear, in docker-py API call, just as 'sleep 123' - with one
         space. This is false negative case.
      b) If 'entrypoint + command = command', for example
         'sleep + 123 = sleep 123', module would give false positive
         match.

This patch fixes it, by making matching more explicit - against
'Config'->Cmd' field of 'docker inspect' output, provided by docker-py
API and with proper normalization of user input by splitting it to
tokens with 'shlex.split()'.
2015-10-02 12:30:03 +03:00
Mike
8c9a9c0802 update_disks(): added origins of the code. 2015-10-01 17:38:46 +01:00
Mike Christofilopoulos
83074ad501 add new disks automatically when the 'vm_disk' section changes 2015-10-01 17:29:21 +01:00
Matt Martz
45c5b4bf4b Merge pull request #1002 from vmihailenco/fix/rx-isdir-path
rackspace: pass full path to the isdir.
2015-10-01 10:59:43 -05:00
Brian Coca
da220e0bb0 added version_added 2015-10-01 00:13:58 -04:00
Nathaniel Felsen
8ec17d0fd9 Adding support for access logs in ELB 2015-09-30 18:02:47 -07:00
Alex Kessinger
4308ae25c4 Fix a argument mismatch in elasticache
I think in this commit 720aeffca2

There was bug introduced where the ElastiCacheManager init method has
a number of positional arguments like so.

```py
    def __init__(self, module, name, engine, cache_engine_version, node_type,
                 num_nodes, cache_port, parameter_group, cache_subnet_group,
                 cache_security_groups, security_group_ids, zone, wait,
                 hard_modify, region, **aws_connect_kwargs):
```

But then later in the code the positional arguments are passed in
like this.

```py
    elasticache_manager = ElastiCacheManager(module, name, engine,
                                             cache_engine_version, node_type,
                                             num_nodes, cache_port,
                                             cache_subnet_group,
                                             cache_security_groups,
                                             security_group_ids, parameter_group, zone, wait,
                                             hard_modify, region, **aws_connect_kwargs)
```

If you count, you can see that cache_subnet_group, is being passed in
where the manager expects to see parameter_group.
2015-09-29 16:51:26 -07:00
Brian Coca
653b55bf68 Merge pull request #2160 from j-carl/fix_amazon-cloudformation-userdir
Fix to handle user directory within parameter 'template'.
2015-09-28 15:23:19 -04:00
Jens Carl
dc109387bd Change type of parameter 'template' to 'path'. 2015-09-28 18:25:23 +00:00
Shayne Clausson
841835ebac Replaces 'old' get_ec2_creds connection method with get_aws_connection_info to
support passing in security_token for temporary creds.
2015-09-28 19:50:02 +02:00
Toshio Kuratomi
a4ac171a07 Merge pull request #2124 from halberom/ec2_adjust_vol_handling
ec2 - allow use of volume_type in volumes dict
2015-09-28 09:04:12 -07:00
Gerard Lynch
1857263b63 allow use of volume_type in volumes dict 2015-09-28 17:02:46 +01:00
Toshio Kuratomi
d5f62798f0 Docs fixes 2015-09-28 08:22:36 -07:00
Toshio Kuratomi
6cad03644f Merge pull request #2130 from shawnsilva/modify-rds-size
Fix for modifying the size of an RDS instance.
2015-09-28 07:38:43 -07:00
Toshio Kuratomi
3b5f232d4d Merge pull request #2143 from atplanet/ec2-ami-mod-clarify-block-device-mapping
Clarify available options for device_mapping parameter of ec2_ami module
2015-09-28 07:28:08 -07:00
Toshio Kuratomi
b28df8d600 Merge pull request #2127 from selivan/patch-1
ec2_group.py: added ICMP rule example
2015-09-27 12:06:25 -07:00
Jens Carl
e25605cd5b Fix to handle user directory within parameter 'template'. 2015-09-25 21:59:14 +00:00
Leonty
2080c8ab6e Support 'labels' parameter for docker. 2015-09-25 23:58:20 +03:00
David Shrewsbury
750a91520f Allow setting external attribute
With shade > 0.13.0, networks can be created that are externally
accessible. This adds a parameter for that.

Also, add RETURN documentation and 'if __name__' check around call
to main().
2015-09-25 14:58:47 -04:00
David Shrewsbury
d52bb67978 Allow complete router configuration
This change allows one to completely configure a router, including
gateway and interfaces, using the latest shade (>0.13.0).
2015-09-25 13:09:02 -04:00
dagnello
40974a9811 Adding new os_subnets_facts module
There can be instances during an Ansible play where the list of subnets
currently available from OpenStack is required.  This update provides
subnet list functionality as a new os_subnets_facts module.
2015-09-24 16:08:20 -07:00
dagnello
7d09437328 Adding os_networks_facts module
There can be instances during an Ansible play where the list of networks
currently available from OpenStack is required.  This update provides
network list functionality as a new os_networks_facts module.
2015-09-24 16:07:45 -07:00
Abitha Palaniappan
e64791ef1a os_server: Adding support to accept 'n' nic args as a string containing list 2015-09-24 14:00:27 -07:00
Tom Bamford
4e1d28e311 Clarify available options for device_mapping parameter of ec2_ami module 2015-09-24 12:37:03 +00:00
justnom
518ac36878 Adding additional Docker log drivers.
Adding additional `log_driver` choices:
* journald
* gelf
* fluentd

Compatible with Docker version >= 1.8.0
2015-09-23 11:54:51 -04:00
Matt Martz
e8227dea7a Merge pull request #1290 from jamiehannaford/rs-as-wait
Rackspace: Add wait and wait_timeout options for provisioning servers to Auto Scale
2015-09-22 16:17:18 -05:00
Shawn Silva
ba8930c83a Fix for modifying the size of an RDS instance.
When attempting to modify the size of an RDS instance Ansible succeeds and
returns a "changed" status. However, no changes are applied to the RDS
instance. Boto is looking for a keyword parameter of "allocated_storage" to
update the size, and this parameter wasn't being included.
2015-09-22 10:46:20 -04:00
Selivanov Pavel
ec24a86f69 ec2_group.py: added ICMP rule example 2015-09-22 16:56:13 +03:00
Brian Coca
8b7e692494 Merge pull request #1353 from awesomescot/devel
adding parameter group option
2015-09-21 08:31:40 -04:00
dagnello
842f09cf24 Adding new image facts module 2015-09-20 21:15:40 -07:00
Matias De Carli
854ffcb605 updated dependencies to work with azure.py 1.0.1 2015-09-19 15:19:28 -03:00
EC
9168ed4736 Fixing ec2_asg termination_policy
If this isnt set, it wont launch the instances because it needs to default to "Default" despite what boto docs say.
2015-09-17 15:47:16 -04:00
James Cammarata
d2c7d30c50 Merge pull request #250 from saito-hideki/bug/249
The nova_compute module create a list of un-use floating ip by value of fixed_ip
2015-09-17 11:25:35 -04:00
James Cammarata
64c0b67154 Merge pull request #1599 from emonty/feature/os_user_group
Add OpenStack Group content module
2015-09-17 11:22:56 -04:00
James Cammarata
b743224aa9 Merge pull request #1831 from tkinz27/os_start_stop
Adding start and stop actions to os_server_actions
2015-09-17 11:19:30 -04:00
Rob
9bf0d06e4a Update iam_policy.py
Fixed doc for policy_name - it is a required field
Removed empty aliases
2015-09-17 17:52:42 +10:00
Jumpei Ogawa
7b4b61faff Add explanation in case that ipv4_range is required 2015-09-17 15:37:07 +09:00
Jumpei Ogawa
08b09fcc70 Add better error message when specified network doesn't exist and ipv4_range is not specified 2015-09-17 15:31:14 +09:00
Philippe Jandot
8052d49b07 fix regression introduced by f38186ce8b, and propose a fix for docker facts 2015-09-16 16:49:09 +02:00
Gerard Lynch
3d12e53a28 order params, add missing tag param. update examples 2015-09-16 11:29:36 +01:00
whiter
719f68e057 Remove 'str' type so that json is properly quoted 2015-09-16 17:52:43 +10:00
Toshio Kuratomi
636eecf354 Fix improper indentation 2015-09-15 14:25:22 -07:00
Brian Coca
367b4f07a1 Merge pull request #2047 from tomfotherby/patch-1
Allow load_balancer_port as a Ansible variable
2015-09-15 11:15:36 -04:00
Brian Coca
4a8a54950c Merge pull request #2067 from wimnat/feature/issue-2066
Add exception handling to iam
2015-09-15 10:46:26 -04:00
James Cammarata
8125ae624a Merge pull request #2075 from evanccnyc/ec2_asgfix
fixing termination policies for ec2_asg
2015-09-15 10:29:34 -04:00
Evan Carter
2e84bb9c99 fixing termination policies for ec2_asg 2015-09-14 18:31:22 -04:00
Brian Coca
8a7946b91d Merge pull request #2064 from wimnat/feature/issue-2063
Remove unnecessary json.loads
2015-09-14 16:46:34 -04:00
David Shrewsbury
ef93fb1c14 More os_router module cleanup and fixes.
Added a RETURN section, corrected version_added value, removed use of
'result' in exit_json() calls.
2015-09-14 16:20:18 -04:00
Brian Coca
a0997e8940 Merge pull request #1757 from gutoandreollo/devel
Added the 'hw_interfaces' array
2015-09-14 15:08:47 -04:00
Brian Coca
b2e5dd2c47 Merge pull request #1807 from brannon/supportVMClones
Support cloning VMs (in addition to templates)
2015-09-14 14:26:48 -04:00
Evan Carter
70ed99ec26 Fixing bug #2058 and adding some backwards compatibility 2015-09-14 11:27:37 -04:00
Frank van Tol
a7667fcaf2 Update s3.py
We are copying from S3,  the bucket is the source, not the target.
2015-09-14 15:57:48 +02:00
Rob
da29956f03 Add exception handling to iam 2015-09-14 15:43:49 +10:00
wimnat
8e9c85bed2 Remove unnecessary json.loads 2015-09-14 14:23:34 +10:00
Brian Coca
beb60133ba Merge pull request #2042 from abithap/devel
Add support for port-id,port-name to nics in os_server
2015-09-10 21:15:23 -04:00
Tom Fotherby
54ae73b1a3 Fix #1984 - allow load_balancer_port as a variable 2015-09-10 17:34:38 +01:00
Brian Coca
05c3b3ea15 minor doc fix 2015-09-10 09:07:59 -04:00
Abitha Palaniappan
f449a0f48c Add support for port-id,port-name to nics in os_server 2015-09-09 15:38:39 -07:00
Brian Coca
1c7e8ef1a0 Merge pull request #2034 from pwnall/patch-2
Fix indentation in os_server documentation
2015-09-09 11:49:08 -04:00
Brian Coca
951f5807b9 Merge pull request #2028 from rosmo/s3-permissions
Added option to set multiple ACLs for S3 objects
2015-09-09 08:40:30 -04:00
Victor Costan
2cc431f791 Fix indentation in os_server documentation 2015-09-09 01:29:38 -04:00
Toshio Kuratomi
9363369a4c Merge pull request #1991 from daviddyball/devel
Docker module log-opt support
2015-09-08 13:27:36 -07:00
Taneli Lepp
15f4b59619 Added option to set multiple ACLs for S3 objects. Also verifies the
selected permissions against Boto's canned ACL strings list.
2015-09-08 20:00:14 +03:00
Brian Coca
c4140cc6db Merge pull request #2021 from h3biomed/enis_at_launch
ec2: allow ENIs to be specified at instance launch
2015-09-08 12:45:05 -04:00
Yanchek99
7104096c7c Fixed typo for instance_tags documentation 2015-09-08 09:16:53 -07:00
David Dyball
a0a374b8ca Updated PR based on comments 2015-09-08 16:19:26 +01:00
Bret Martin
27e9318ffe Use general-purpose parameter mutual exclusion code for network_interfaces 2015-09-06 14:00:35 -04:00
Bret Martin
44f3618dd3 Add alias network_interface and accept a string for a single ENI 2015-09-06 13:53:28 -04:00
Bret Martin
5db3f14e94 Add network_interfaces example 2015-09-06 13:18:20 -04:00
Bret Martin
a20a78a50c Remove aliases specification from documentation since there are none 2015-09-06 13:03:04 -04:00
Brian Coca
f1efc121ee corrected whitepace 2015-09-06 11:18:47 -04:00
Toshio Kuratomi
34655e8e29 correct documentation formatting 2015-09-05 08:56:02 -07:00