Commit graph

47624 commits

Author SHA1 Message Date
Matt Martz
594a0fa9ae Add new truthy and falsy jinja2 tests (#62602) 2019-10-02 13:58:28 -04:00
Mike Wiebe
918f768890 [stable-2.9] Fix nxos_l3_interfaces module and tests (#62545)
* Fix nxos_l3_interfaces module and tests

* Use get_interface_type

* get_interface_type in utils lib
2019-10-02 13:43:17 -04:00
Vishnu Priya Ananthu Sundaram
926e423690 Add Azure Stack supported API profiles (#62675)
* Add Azure Stack supported API profiles

* Bug fix

* add enum package to requirements

* Revert bacl latest profile changes

* Bug fixes

* Bug fix
2019-10-02 13:04:28 -04:00
Nilashish Chakraborty
69317a9d3e IOS-XR: Fix iosxr_lag_interfaces intermittent failures (#62998)
* Fix iosxr_lag_interfaces intermittent failures

*  If the dictionary is read out of order from member
   the current logic in `diff_list_of_dicts` returns
   unwanted diff. Hence use `dict_diff` utils
   function instead of sets.

Remove zip() to make existing tests happy

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Address review comments

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-10-02 11:43:29 -04:00
Adam Miller
8bcf11fee9 dnf - properly handle idempotent removal of wildcard globs (#63034)
Signed-off-by: Adam Miller <admiller@redhat.com>
2019-10-02 11:05:12 -04:00
Chris Houseknecht
911aa6aab9
Default collection install path to first path in COLLECTIONS_PATHS (#62870) 2019-10-02 10:22:00 -04:00
Gonéri Le Bouder
1fd79240db vmware_httpapi: version_added==2.10
`vmware_httpapi` hierachy will actually be released with Ansible 2.10, not
2.9. This commit fixes the `version_added` field.
2019-10-02 09:38:19 -04:00
Andrey Klychkov
0706782e4e mysql_replication: add return value, remove extra argument from function (#63036) 2019-10-02 13:33:53 +02:00
The Magician
d6781a2a5a Bug fixes for GCP modules (#61590) 2019-10-01 18:27:51 -04:00
The Magician
2b535cc59a Bug fixes for GCP modules (#61829) 2019-10-01 18:27:42 -04:00
The Magician
53cd75bee6 Bug fixes for GCP modules (#61916) 2019-10-01 18:27:19 -04:00
The Magician
b4d15b3040 Bug fixes for GCP modules (#61917) 2019-10-01 18:27:03 -04:00
The Magician
ecc47b653b Bug fixes for GCP modules (#61918) 2019-10-01 18:26:56 -04:00
Felix Fontein
8bfc39e231 ACME module defaults (#62719)
* Add module defaults group 'acme'.

* Start YAML document.
2019-10-01 17:14:22 -04:00
Will Smith
50d1cbd30a fix issue #60237 when non-ascii is returned from the WLC (#60243)
* fix issue #60237 when non-ascii is returned from the WLC

* update test to work with python3 through use of six library

* remove trailing white space
2019-10-01 16:52:35 -04:00
Toshio Kuratomi
30cc54da8c rpmfilename must be constructed using rpmmacros
Different subpackages have different names so, at the least, the %NAME
macros must be used when constructing the rpmfilename.  Otherwise each
subsequent subpackage will overwrite the previous one.

This reinstates dag's fix from d4b6aecd97

Fixes #62673
2019-10-01 10:29:40 -07:00
Matt Clay
ada02f1966 Limit Shippable matrix check to ansible repo. 2019-10-01 09:53:19 -07:00
Sander
f102705c95 changed capitals vSphere (#62975) 2019-10-01 16:41:50 +02:00
Andrey Klychkov
d8109550ec mysql_replication: setup a later version of MariaDB (#62993) 2019-10-01 08:29:40 +02:00
Toshio Kuratomi
593d639160 Fixes to the rpm dependencies
* Remove duplicate bundled provides line in the rpm spec file
* Remove jmespath and passlib on RHEL7 as these are optional dependencies
  which aren't shipped with RHEL7
2019-09-30 20:51:16 -07:00
Jeff Geerling
1e6fd6f54d Adjust documentation for yum clean to use best practices (#62898)
The yum module docs suggested using `shell: yum clean all`, which gives an `ansible-lint` error. Plus, you should use the `command` module unless you need more advanced features than just passing in an arbitrary command. Fixes that problem by using the `command` module in the example instead.
2019-09-30 18:33:53 -04:00
Ningú
87a6f8397e Concise file module example description (#62932)
A file won't be created by the example, the execution would fail unless the file already exists as specified by the module options
2019-09-30 18:30:33 -04:00
Akira Yokochi
6bbd9c9eca add ios/iosxr deprecated modules (#62908) 2019-09-30 18:18:57 -04:00
Matt Clay
3f2380ccce Exclude tmp dir from ansible-test results copy.
This fixes test errors related to failures copying temporary test results files from a remote system back to the local system.

It also speeds up processing of test results and reduces network utilization by avoiding the temporary files.
2019-09-30 18:18:37 -04:00
Andreas Olsson
0d79013f51 Modernize Vagrant documentation (#62923)
* By requiring a slightly newer Vagrant version (from 2015) we get the
  same generated Ansible inventory format is still used by today's
  version of Vagrant. That extended inventory format also has the
  benefit of allowing for simpler Ansible examples.

* Switching to a current and supported Ubuntu LTS version.
2019-09-30 17:47:57 -04:00
Mario Lenz
d01035ef25 VMware: Move helper functions from vmware_host_config_manager to module util. 2019-09-30 16:55:36 -04:00
Alex Ratner
ad580a71c4 fix minor typos (#62950) 2019-09-30 15:31:35 -04:00
Andreas Olsson
c8315bfd60 Prefer https:// links in the docs site (#62939)
This is a follow-up of last year's 1a11cec. It deals with links which
at that point either were not present or did not support https://.
2019-09-30 15:11:19 -04:00
Gonéri Le Bouder
7ecfa4a471 vmware guidlines: adjust the location of cloud-config-vcenter.ini.template (#62970)
Update the location of the cloud-config-vcenter.ini.template template.
The file has been moved by: 2e7d36a3f9.
2019-09-30 14:21:35 -04:00
pgbidkar
c6c13b5626 Fixing typo mistake in testbed with section. Deploy template from content library is supported from 67U3 2019-09-30 11:54:15 -04:00
Nilashish Chakraborty
67213ccb4d
Fix traceback for empty config (#62520)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-09-30 20:37:28 +05:30
Martin Nečas
9aff5f6007 ovirt_vm add reboot state (#62785)
* ovirt_vm add reboot state

* update pep8 syntax

* update docs

* correct whitespace
2019-09-30 10:46:19 -04:00
Paul Belanger
44a6c69562
Remove unused variables from nxos_ping / nxos_snapshot (#62933)
This was caught by our network collections lint jobs.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-30 10:12:31 -04:00
Jan Zmeskal
50dc41cca2 ovirt: Fixing typo in ovirt_disk examples (#62962) 2019-09-30 08:25:34 -04:00
Rene Moser
c24a85c793 lookup: lmdb_kv: fix for py3 2019-09-30 11:00:00 +02:00
Rene Moser
6370c63efc lookup: lmdb_kv: add tests 2019-09-30 11:00:00 +02:00
Jan-Piet Mens
a2270ead2f new lookup plugin: LMDB - allow wildcard searches - make dbname configurable for with_lmdb_kv: - added built-in documentation - incorporate suggested changes by dw - comment spaces - outdent for the bot 2019-09-30 11:00:00 +02:00
Felix Fontein
62c0cae29a
docker_container: fix idempotency for network IP addresses (#62928)
* Specifying IP addresses needs API version 1.22 or newer.

* Simplify code.

* Use IPAMConfig.IPv*Address instead of IPAddress and GlobalIPv6Address.

* Add changelog.

* Fix syntax errors.

* Add integration test.

* Don't rely on netaddr.

* Normalize IPv6 addresses before comparison.

* Install netaddr, and use it.
2019-09-30 10:47:02 +02:00
Felix Fontein
a79f7e575a
docker_image and docker_login: move tests needing a registry into own target, add tests for docker_login (#62721)
* Move tests with docker registry into own target.

* Add docker_login tests.

* Add step which makes sure hello-world:latest is around.

* Make work inside docker container.

* Add dependency.

* Use plaintext password.

* Forgot check_mode.

* Add no_log to avoid double log output in verbose mode.
2019-09-30 06:09:00 +02:00
Michael Scherer
75c4e9ec05 Fix _validate_csr_subject and _validate_csr_signature (#62790)
On python 3, if there is no explicit "return True", the
function call will be seen as "False", thus failling the module
2019-09-29 16:17:38 +02:00
Felix Fontein
fd627e3b78
docker_container: document some of the unexpected behaviors. (#62325) 2019-09-29 14:52:47 +02:00
Andreas Olsson
75dfe6c88a nsupdate: Use authoritative server for zone lookup (#62329)
Using a regular recursive resolver to lookup the zone name might not
work when the zone in question belong to a private/internal
domain. The authoritative server being used on the other hand will
definitely know about the zone(s) it's serving.

This approach is also consistent with the nsupdate module already
querying the specified authoritative server for TTL values.

The reason for the implementation having to loop until finding a
direct match is to account for different SOA responses triggered by
CNAMEs and DNAMEs. The previously used `dns.resolver.zone_for_name()`
function does the same.

Resolves #62052
2019-09-28 19:34:28 +02:00
psharkey
ee91714eb2 New module: Add module to collect Amazon AWS IAM user info (cloud/amazon/iam_user_info) (#23382)
* AWS: new module iam_user_info

Signed-off-by: psharkey <psharkey@cleo.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Rename from iam_user_facts to iam_user_info.

Rename and target 2.10.

Fixing docs.

* Adding iam_user_info integration test.

Removing unnecessary tasks.

Fixing yamllint failure test/integration/targets/iam_user_info/defaults/main.yml:5:1: empty-lines: too many blank lines (1 > 0).

* name paramter is optional

* Switch to use AnsibleAWSModule.

* Convert to using fail_json_aws

* Rework asserts to inspect ARN.

* Move integration tests from iam_user_info to iam_user.

* Fix pep8 problems.

* ec2_argument_spec not needed with AnsibleAWSModule.

* Switch to use helper in AnsibleAWSModule.

* Add iam_user_info to the aws group.

* Add support for pagination and backoff.

* Check improper parameter usage first.

* Adding test cases for multiple users.

* Rmoving unneeded line.

* Remove unneeded imports.

* Switch to catch BotoCoreError.

* Adding tests for exception coverage.

* Compare user info directly with values from created user.
2019-09-28 22:00:59 +10:00
Andrey Klychkov
334d2ce764 mysql_replication: add CI tests for MariaDB (#62907) 2019-09-27 09:29:34 -04:00
bverschueren
c3eceb3a0d support creating an image from a volume (#59574)
* support creating an image from a volume

* leave filename/volume optional

* enforce volume/filename mutual exclusivity

* bump version_added to 2.10 for volume option

* add changelog fragment
2019-09-27 14:29:34 +02:00
Pilou
3c8abc0b82 cron: add integration tests (#59830)
* cron: add integration tests

Use faketime in order to reduce waiting time. Using opensuse15
container:

    Tuesday 30 July 2019  23:03:19 +0000 (0:00:05.410)       0:01:28.291 **********
    ===============================================================================
    cron : install cron and faketime packages ------------------------------ 78.65s
    cron : wait 70 seconds max ---------------------------------------------- 5.41s
    Gathering Facts --------------------------------------------------------- 0.97s
    cron : enable cron service ---------------------------------------------- 0.72s
    cron : Use faketime with cron service ----------------------------------- 0.71s
    cron : command ---------------------------------------------------------- 0.41s
    cron : create directory for cron drop-in file --------------------------- 0.41s
    cron : add cron task ---------------------------------------------------- 0.40s
    cron : command ---------------------------------------------------------- 0.25s
    cron : command ---------------------------------------------------------- 0.25s
    cron : include_vars ----------------------------------------------------- 0.06s

* cron test, simplify: use Environment instead ExecStart

Thanks to mscherer for the suggestion.

* clean up comment: remove reference to outdated path

$OUTPUT_DIR is a plain path which doesn't reference any other
environment variables

* cron test: display elapsed time

* cron test: display some logs in case of failure

* cron test: handle FreeBSD

* cron tests: add checks
2019-09-26 21:50:54 +02:00
mohamed chiheb ben jemaa
e7436e278f Remove Latin phrases from the docs (#62419)
* add styleguide about avoiding use of latin words
2019-09-26 15:12:24 -04:00
Nathaniel Case
8b9c2533b5
Remove check_args from nxos (#62625)
* Remove check_args from nxos

* Clean up check_args from nxos
2019-09-26 15:02:09 -04:00
Nathaniel Case
89abfcdb18
Remove check_args from eos & ios (#62623)
* Remove check_args from eos & ios

* Clean up check_args from eos & ios

* Missed ios_vrf
2019-09-26 15:01:53 -04:00
Matt Clay
831e1bf2e0 Fix ansible-test PYTHONPATH handling.
Running from an installed version of ansible-test now results in tests using a dedicated directory for PYTHONPATH instead of using the site-packages directory where ansible is installed.

This provides consistency with tests running from source, which already used a dedicated directory.

Resolves https://github.com/ansible/ansible/issues/62716
2019-09-26 14:02:19 -04:00