Commit graph

47961 commits

Author SHA1 Message Date
Agustín Herranz
f0cadb9843 Fix AWS iam_user remove (#59079)
* Make iam_user not fail on user deletion.

- Use guard clause on already absent user
- Refactor, use variable instead nested dict
- Ensure needed prerequisites for boto3 delete_user successfully
- Use AnsibleAWSModule on iam_user.
- Fix fail_json_aws calls

* Add s-hertel comments to PR
2019-10-21 17:06:05 +02:00
Robert A. Rawls
6046386dba doc: win_user: fix typo in the description of the groups modifyer (#63743) 2019-10-21 17:02:39 +02:00
Andrey Klychkov
891489a27e postgresql_publication: fix logic (#63737) 2019-10-21 15:14:23 +01:00
Mark Chappell
145b79ef0e ec2_instance test cleanup (#63708)
* ec2_instance/ec2_instance_info : Fixup sanity test errors

* Move ec2_instance integration tests to use aws_defaults

* Search for the AMI instead of hardcoding an AMI

* Make our VPC CIDR variable

* Remove AZ assumptions - no guarantees about specific AZs being available

* Make sure we terminate instances when we're done with them.

* Add a 10 second pause for IAM roles to become available before using them

* Wait on instance changes by default

* Switch out t2 instances for t3 they're cheaper and have more CPU available

* Pull t3.nano instance info a little earlier

* rework vpc_name and vpc_cidr a little

* Mark ec2_instance tests unsupported for now, they take too long
2019-10-21 14:55:44 +02:00
sky-joker
aa671be28b zabbix_host: fix https://github.com/ansible/ansible/issues/63449 (#63637) 2019-10-21 06:12:10 -04:00
Abhijeet Kasurde
f92c99b413 gitlab_*: remove deprecated functionalities (#61912)
* Documentation update
* Remove deprecated functionalities

Fixes: #61898 #61897 #61896 #61895 #61894 #61893

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-10-20 07:38:08 -04:00
phongle1205
331d51fb16 Attach an attached/detached volume from OpenStack VM’s should return similar information (#21558)
Currently, attach an attached volume from OpenStack VM’s returns only
argument data. It is better to return full data as attaching a detached
volume.

In my use case, I need the extra data to mount and format the volume.
2019-10-20 12:36:50 +05:30
Sergey Trukhin
78158c2e63 mysql_db: Add option hex_blob in db_dump operation (#23891)
Added support for --hex-blob option to mysql_db module.
This option is for dump binary columns using hexadecimal notation (for example, 'abc' becomes 0x616263).
The affected data types are BINARY, VARBINARY, the BLOB types, and BIT.
2019-10-20 11:48:46 +05:30
Toshio Kuratomi
cc1ff57c5b
AH servers include automation-hub as part of the server configuration. (#63700)
* AH servers include automation-hub as part of the server configuration.

So we don't need to add it here.

Fixes #63699

* Update unittests for the fix to galaxy wait_import_task
2019-10-19 12:40:45 -07:00
Andrea Scarpino
8f843bbaa5 iptables: support wait parameter (#47877)
Version 1.4.20 doesn't support 'wait' at all
Version 1.6.0 requires an argument for it
2019-10-19 22:27:45 +05:30
Gary Williams
3f0479279e VMware: Add a parameter wait_for_ip_address_timeout in vmware_guest (#63557)
* Added a parameter (wait_for_ip_address_timeout) to allow a longer timeout than the default.
* Removed the wait_for_vm_ip function in this module as one in module_utils is already being used elsewhere.
2019-10-19 22:15:28 +05:30
Andrey Klychkov
b6e997aa5f Cleanup after MariaDB integration tests (#63657) 2019-10-19 13:10:35 +02:00
zhongjun2
64989bea6a hwc: Add eip module (#60182) 2019-10-19 12:58:29 +02:00
Lukas Kämmerling
86e4dcbaed hcloud: Add protection support to hcloud_server and hcloud_server_info (#63669) 2019-10-19 12:57:00 +02:00
zhongjun2
c904336db0 hwc: Add security group rule module (#60186) 2019-10-19 12:53:02 +02:00
zhongjun2
420de44a57 hwc: Add port module (#60188) 2019-10-19 11:32:10 +02:00
zhongjun2
652de1a7fd hwc: Add new module to peering (#60190)
* Add peering module

* Update hwc_vpc_peering_connect.py
2019-10-19 11:27:53 +02:00
Guillaume Martinez
0af32a1093 gitlab_modules : remove misssing required parameter (#63690)
* gitlab_group: remove required=True on server_url param

* gitlab_project: remove required=True on server_url param

* Revert "Example incorrect: server_url is required argument (#63670)"

This reverts commit b02467961a.
This modification shouldn't have been made.
This parameter is deprecated and #60425 forget to remove the required
parameter
2019-10-19 13:57:18 +05:30
zhongjun2
e0b4fafb22 hwc: Add disk module (#59919) 2019-10-19 10:09:40 +02:00
zhongjun2
39201d1ba3 hwc: Add instance module (#60180) 2019-10-19 09:50:03 +02:00
zhongjun2
7ed6a0037c hwc: Add security group module (#60187)
* Add security group module

* Update hwc_vpc_security_group.py
2019-10-19 09:43:50 +02:00
Tiziano Müller
034afd40a3 zypper: add additional flag --force-resolution (#61705) 2019-10-19 09:40:47 +02:00
René Moser
712abfd1a1
cloudstack: exoscale: fix boilerplate (#63532) 2019-10-19 09:37:23 +02:00
hexdump0x0200
df0e747899 ASA: fixes #59007 (#59008) 2019-10-19 11:36:16 +05:30
Lukas Kämmerling
8eb46acbb1 hcloud: Add Delete Protection to hcloud_volume and hcloud_volume_info (#63665) 2019-10-18 23:28:12 +02:00
Lukas Kämmerling
e9e4b02b92 hcloud: Add Delete Protection to hcloud_floating_ip and hcloud_floating_ip_info (#63663) 2019-10-18 23:27:23 +02:00
Nathaniel Case
d98482c294
eos_vlans: Never try to set vlan_id as a property (#63689) 2019-10-18 16:55:27 -04:00
JayalakshmiV
93280bd59c exos_l2_interfaces Resource module (#63113)
* Resource module for exos_l2_interfaces
2019-10-18 13:10:19 -04:00
Sam Doran
dcec3d000e syslogger - disable check mode (#63646) 2019-10-18 13:01:03 -04:00
hexdump0x0200
cb0ee51712 ios_bgp: fixes #57666 (#57667)
* ios_bgp: fixes #57666

* ios_bgp: add integration tests
2019-10-18 21:25:45 +05:30
Felix Fontein
04252cf90d Improve validation of module return values (#63411)
* Add contains: validation for return values.

* Only require returned: on top level.

* Fix various return value problems.

* Update ignore.txt.

* Two more.
2019-10-18 16:01:52 +01:00
Sam Doran
4de516d35f Do not set ANSIBLE_LIBRARY in env-setup.fish (#63688)
Setting this env var was removed from env-setup back in 2014. Not sure why it is in this setup script and it interferes with the defult search path
2019-10-18 10:56:19 -04:00
Nathaniel Case
741d529409
Eos vlan override (#63639)
* Fix overridden & deleted in eos_vlans

* Fix vlan creation in overridden

* Right, Python 2.6
2019-10-18 10:36:30 -04:00
David O'Brien
4326165be5 Update win_regmerge.py (#63633)
##### SUMMARY
<!--- s/windows/Windows/ in title -->


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-18 15:33:39 +01:00
Ondra Machacek
5b2d625eb7 ovirt: Fix fetching of nested attributes (#61841)
This patch is fixing the fetching of nested attributes.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1748025
2019-10-18 13:40:41 +01:00
abarbare
4e50096663 fix: scaleway api endpoint (#63436) 2019-10-18 13:31:33 +01:00
Xu Yuandong
39c92310b4 Add a new module ce_lldp to manage Link Layer Discovery Protocol(LLDP) (#63395)
* new module ce_lldp

* update for shippable

* update for shippable

* update for shipabble

* update

* merge confilcts

* add integration test.

* update for shippable.

* update for bad-whitespace

* update for shippable

* update for shippable

* update for shippable

* update license.

* update for typo.
2019-10-18 13:15:42 +01:00
Erik Zettel
5ea72934bd Fix obvious typos (#62821)
* lib/ansible/modules/cloud/digital_ocean/digital_ocean_snapshot_info.py: fix typos

* lib/ansible/modules/cloud/ovirt/ovirt_host_network.py: fix typos

* test/integration/targets/cnos_backup/README.md: fix typos

* test/integration/targets/cnos_bgp/README.md: fix typos

* test/integration/targets/cnos_command/README.md: fix typos

* test/integration/targets/cnos_conditional_command/README.md: fix typos

* test/integration/targets/cnos_conditional_template/README.md: fix typos

* test/integration/targets/cnos_config/README.md: fix typos

* test/integration/targets/cnos_facts/README.md: fix typos

* test/integration/targets/cnos_image/README.md: fix typos

* test/integration/targets/cnos_rollback/README.md: fix typos

* test/integration/targets/cnos_save/README.md: fix typos

* test/integration/targets/cnos_showrun/README.md: fix typos

* test/integration/targets/cnos_template/README.md: fix typos

* test/integration/targets/cnos_vlag/README.md: fix typos

* test/integration/targets/enos_command/README.md: fix typos

* test/integration/targets/enos_config/README.md: fix typos

* test/integration/targets/enos_facts/README.md: fix typos

* test/legacy/roles/cnos_backup/README.md: fix typos

* test/legacy/roles/cnos_bgp/README.md: fix typos

* test/legacy/roles/cnos_command/README.md: fix typos

* test/legacy/roles/cnos_conditional_command/README.md: fix typos

* test/legacy/roles/cnos_conditional_template/README.md: fix typos

* test/legacy/roles/cnos_ethernet/README.md: fix typos

* test/legacy/roles/cnos_facts/README.md: fix typos

* test/legacy/roles/cnos_image/README.md: fix typos

* test/legacy/roles/cnos_portchannel/README.md: fix typos

* test/legacy/roles/cnos_rollback/README.md: fix typos

* test/legacy/roles/cnos_save/README.md: fix typos

* test/legacy/roles/cnos_showrun/README.md: fix typos

* test/legacy/roles/cnos_template/README.md: fix typos

* test/legacy/roles/cnos_vlag/README.md: fix typos

* test/legacy/roles/cnos_vlan/README.md: fix typos
2019-10-18 12:56:55 +01:00
Prasad Katti
aeb0dde7cc Update description for firstmatch option (#62896)
##### SUMMARY
This fixes issue https://github.com/ansible/ansible/issues/62862. The edit makes the description for the `firstmatch` option clearer.

The `firstmatch` option was introduced by PR https://github.com/ansible/ansible/pull/33825


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-18 12:53:50 +01:00
jlreiter
0b97180c74 adding ostype win10 support (#62987) 2019-10-18 12:44:39 +01:00
herpus-derpus
b02467961a Example incorrect: server_url is required argument (#63670)
##### SUMMARY
The example "Delete GitLab Group" does not work.

- name: "Delete GitLab Group"
  gitlab_group:
    api_url: https://gitlab.example.com/
    api_token: "{{ access_token }}"
    validate_certs: False
    name: my_first_group
    state: absent

It errors with: 
fatal: [myhost.mydomain.com -> localhost]: FAILED! => {"changed": false, "msg": "missing required arguments: server_url"}

If you provide server_url and api_url, it complains that they are mutually exclusive:
fatal: [myhost.mydomain.com -> localhost]: FAILED! => {"changed": false, "msg": "parameters are mutually exclusive: api_url|server_url"}

This means there is no logical path in the use of the module where api_url can be specified without resulting in at least one of these fatal errors. I suggest adjusting the examples in the meantime, then changing the module to move away from the soon-to-be deprecated server_url parameter, removing it as a required argument.

This likely applies to all Examples, so this change proposes at least putting in the required parameter in the examples.

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-18 12:34:00 +01:00
herpus-derpus
2ef4ac1404 Typo usersername should be username (#63671)
##### SUMMARY
Typo in examples using api_username. Example incorrectly has usersername.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-18 12:32:37 +01:00
Felix Fontein
4b1fdee119
docker_container: deprecate trust_image_content (#63420)
* Deprecate trust_image_content.

* Add changelog.

* Mention it has never been used; removed test stub.
2019-10-18 13:03:42 +02:00
zhongjun2
b243494a29 Add subnet module (#60183)
* Add subnet module

* Update hwc_vpc_subnet.py

* Add subnet module
2019-10-18 11:00:32 +01:00
Thierry Sallé
0b9c241822 Grafana dashboard : added folder parameter + fix when uid is missing in json file (#63342)
Related: ansible/ansible#61685
2019-10-18 10:35:56 +01:00
zhongjun2
7d9a0baa7f Add private ip module (#60191)
* Add private ip module

* Update hwc_vpc_private_ip.py

* Add private ip module
2019-10-18 10:15:13 +01:00
Xu Yuandong
47c31c201b action/ce.py:clear configuration candidate when return to user-view. (#63513)
* clear configuration candidate when return to user-view.

* add a changelog fragment for the pr.

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml
2019-10-18 10:09:47 +01:00
Andrey Klychkov
d22dc5ab8b doc: postgresql_user: Add changelog fragment for 63565 (#63666) 2019-10-18 10:59:20 +02:00
Lukas Kämmerling
f1c6a3331f hcloud: Add delete_protection to hcloud_network and hcloud_network_info (#63656) 2019-10-18 10:54:01 +02:00
Sumit Jaiswal
4f2665810f
Fix IOS_VLANS override operation for new VLANs (#63624)
* fix vlans override state

* adding code comment
2019-10-18 13:56:23 +05:30