Commit graph

6833 commits

Author SHA1 Message Date
Michael J. Schultz
63d7bbea19 Return an iterable instead of None
By default `.get()` will return `None` on a key that doesn't exist. This
causes a `TypeError` in the `for` loop a few lines down. This change simply
returns an iterable type to avoid the error.
2015-08-12 12:13:29 -05:00
Brian Coca
0c403781a7 Merge pull request #1905 from evverx/fix-legacy-services-enabled
Fix service.enabled on: Debian 8, Ubuntu 15.04
2015-08-12 10:18:50 -04:00
Evgeny Vereshchagin
55e8863cb4 Fix service.enable on: Debian 8, Ubuntu 15.04
Workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751638
See https://github.com/systemd/systemd/issues/937
2015-08-12 14:13:19 +00:00
Brian Coca
072c4f38ea Merge pull request #62 from 0x46616c6b/user-add-skeleton-support
Add support for skeleton directory (useradd -k) in user module
2015-08-12 09:17:35 -04:00
Brian Coca
7f01246bb5 updated win_file version_added
fixes #1893
2015-08-10 10:11:40 -04:00
Toshio Kuratomi
dea5f5d15e Another way that the serialization of the boto results can fail 2015-08-07 12:27:57 -07:00
Toshio Kuratomi
8412adc4f9 Quote checksum description to fix docs 2015-08-06 21:10:03 -07:00
Toshio Kuratomi
484b2451b4 Merge branch 'pr/141' into devel 2015-08-06 14:49:52 -07:00
muffl0n
4f0cf6d2ca Allow additional hashing algorithms. Directly use hashlib and check if
used algorithm is supported.
2015-08-06 14:49:07 -07:00
Toshio Kuratomi
4c622a0338 Another launchconfig field needs to be explicitly converted for json serialization
Fixes #1848
2015-08-06 08:41:23 -07:00
Toshio Kuratomi
34b4d9c8b2 Merge pull request #1882 from sebi-hgdata/sebi/docker_memory_version_check
mem_limit client version check
2015-08-06 07:52:15 -07:00
sebi
599d60efc0 mem_limit client version check 2015-08-06 16:46:01 +03:00
Brian Coca
016b4ede2e minor doc fix 2015-08-05 17:36:16 -04:00
Toshio Kuratomi
f39e5ffa1d Modify the default for synchronize's dest_port again 2015-08-05 13:05:59 -07:00
Toshio Kuratomi
ed2d8121b3 Update docs to reflect precedence for synchronize's dest_port param 2015-08-05 12:46:01 -07:00
Toshio Kuratomi
0071fd0bf7 Allow mode as a synchronize parameter (handled in action plugin) 2015-08-05 11:54:36 -07:00
Chris Church
7adb789870 Merge pull request #1850 from cchurch/windows_check_mode
Add check mode support for Windows modules.
2015-08-04 19:07:18 -04:00
Brian Coca
762e43c50f Merge pull request #1860 from tedder/patch-1
fix ugly documentation
2015-08-03 12:56:04 -04:00
Toshio Kuratomi
1001eae3c8 Set a default value for DEFAULT_DOCKER_API_VERSION so we can create the AnsibleModule without docker-py 2015-08-03 08:44:48 -07:00
Ted Timmons
40519de8e7 fix ugly documentation
current version dumps a character per line in the docs: http://docs.ansible.com/ansible/cloudformation_module.html
2015-08-01 17:30:15 -07:00
Robert Jailall
d10f3f7a7e Refactor ec2_snapshot to make it more testable 2015-08-01 08:11:17 -07:00
Hagai Kariti
1f447ad5ba made wait default to True in ec2_snapshot 2015-08-01 07:54:15 -07:00
Hagai Kariti
a91db23b56 Add to the ec2_snapshot module the ability to create a snapshot only if one hasn't recently been created
- Added snapshot_max_age parameter
- Updated docs
- Made the default value of wait to be false, as it used to be
2015-08-01 07:54:15 -07:00
Toshio Kuratomi
42d3d02855 Merge pull request #51 from cewood/ec2-group/cidr-ip-list
Support specifying cidr_ip as a list
2015-08-01 07:45:38 -07:00
Toshio Kuratomi
be468ff9d3 result is now a dict and so needs different access syntax
Fixes #1848
2015-07-31 20:58:04 -07:00
Toshio Kuratomi
4928357667 Remove unneeded urllib2 import 2015-07-31 20:58:04 -07:00
Chris Church
bad636152a Add check mode support for Windows modules that don't modify the remote system. 2015-07-31 18:04:34 -04:00
Toshio Kuratomi
549df99c5b Merge pull request #1842 from amenonsen/repos-urls
another solution to apt_repository/repos_urls traceback on Debian (PR #1738, bug #1684)
2015-07-30 17:42:40 -07:00
Brian Coca
1268a83eb7 Merge pull request #1782 from civisanalytics/iam_dont_delete_passwords_silently
iam: don't delete passwords by default
2015-07-30 19:51:57 -04:00
Brian Coca
1f7686fd31 returned version added 2015-07-30 17:04:41 -04:00
James Cammarata
79f21c6ec9 Fix missing params to download_s3file in s3 2015-07-30 14:49:45 -04:00
Brian Coca
697307f88c Merge pull request #1670 from mikeputnam/issue-1643-gpl-header
Add missing GPLv3 License header
2015-07-30 14:39:44 -04:00
James Cammarata
4c4e978360 Fixing s3 failures when bucket names contain dots 2015-07-30 13:47:01 -04:00
Brian Coca
c6da9d0758 added missing version_Added to extra_hosts
fixes #1843
2015-07-30 13:05:00 -04:00
Brian Coca
d6b9989c71 Merge pull request #1820 from jaimegago/patch-1
Fix example indentation bug
i seem to have misread the patch, i thought it was doing the contrary of what it was. Sorry, merging it in now.
2015-07-30 09:52:00 -04:00
Pierre-Louis Bonicoli
2fdb197245 fix error occurring with Debian
Error was: AttributeError: 'SourcesList' object has no attribute 'repos_urls'
2015-07-30 13:16:56 +05:30
Abhijit Menon-Sen
74a27ffe52 Simplify distribution test
If it's Ubuntu, use UbuntuSourcesList; if it's any other apt-friendly
distribution, use SourcesList; otherwise, fail.
2015-07-30 13:16:56 +05:30
Abhijit Menon-Sen
44d16240a8 Make SourcesList __init__ method also set self.module
This was originally required to allow other methods in SourcesList to
fail, but subsequent changes rendered that unnecessary, and it's just
a cleanup now, and avoids passing in module separately to save().
2015-07-30 13:11:43 +05:30
Abhijit Menon-Sen
6afa1da910 Clarify HAVE_PYTHON_APT/install_python_apt handling in apt_repository
1. Don't test check_mode in both the caller and in the callee.
2. Don't test HAVE_PYTHON_APT inside an if that tests HAVE_PYTHON_APT
3. Don't be irritatingly vague about why the module fails ("You may be
   seeing this because…").

Note that if «apt-get -y install python-apt» succeeds with rc==0, but
for some reason python_apt is not usable afterwards, this will break
because the imports in install_python_apt aren't wrapped inside a
try/except.

In other words, we assume that install_python_apt either succeeds or
fails with a traceback. This commit doesn't affect that behaviour.
2015-07-30 13:03:10 +05:30
Abhijit Menon-Sen
653fd34ed7 Fix call to _expand_ppa 2015-07-30 09:02:18 +05:30
Toshio Kuratomi
2785364ebe Merge pull request #1736 from larsks/bug/docker-version-parse
docker: fix parsing of docker __version__ string
2015-07-29 12:36:37 -07:00
Chris Church
4eb547fe4e Merge pull request #1837 from brannon/patch-1
Fix windows feature example to actually install IIS
2015-07-29 15:27:34 -04:00
brannon
4a30e35e53 Fix windows feature example to actually install IIS 2015-07-29 12:23:37 -07:00
Brian Coca
0e9fccd098 changed verbose override variable 2015-07-29 14:54:19 -04:00
Cameron Wood (@cewood)
4241d940b7 Support specifying cidr_ip as a list
Update/fix to Support specifying cidr_ip as a list

Unicode isn't compatible with python2, so we needed some other
solution to this problem. The simplest approach is if the ip item
isn't already a list, simply convert it to one, and we're done.
Thanks to @mspiegle for this suggestion.
2015-07-29 19:11:43 +10:00
Brian Coca
49400d90ac Merge pull request #1830 from ecliptik/devel
Fix incorrect var name for api_version
2015-07-28 18:25:20 -04:00
Micheal Waltz
b43f236b05 Fix incorrect var name for api_version 2015-07-28 15:11:33 -07:00
Brian Coca
e16993ae55 Merge pull request #1827 from thyming/fix-ec2-snapshot-error
Use msg kwarg to pass error message in ec2_snapshot
2015-07-28 16:30:40 -04:00
Luke Rohde
88a0d79873 Use msg kwarg to pass error message in ec2_snapshot 2015-07-28 16:02:49 -04:00
Brian Coca
c579f53a15 Merge pull request #1818 from j2sol/no_ipv6_update_subnet
Handle non-updatable openstack subnet details
2015-07-28 15:00:30 -04:00