Commit graph

28380 commits

Author SHA1 Message Date
Rohit
d8f9904f43
vyos_lldp_global (#59627)
* vyos_lldp_global

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity checks

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* deprecated changes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* branch conflict resolved

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity check passes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-08-19 17:31:09 +05:30
Sumit Jaiswal
b55a54469c
Resource module for ios_vlans (#59640)
* ios_vlans resource module

* fix shippable error

* fix shippable

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix vlans resource

* fix facts doc

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable n review

* fix test

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix indentation

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix review

* fix shebang

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-19 16:03:29 +05:30
Mark Chappell
8e99f0ecc6 aws_kms: Rename various policy manipulation options to reduce confusion (#60561)
* aws_kms: Rename various policy manipulation options to reduce confusion

AWS KMS now has the concept of issuing a 'grant', which is independent
of the policy attached to a key.  Rename the following options to make
it clearer that the operate on the CMK Policy *not* on CMK Grants

* aws_kms: don't just rename grant_types/mode, deprecate them too.
2019-08-19 19:44:03 +10:00
Miguel Angel Muñoz González
20f9e72c74 Fortinet's new module for fortios_router_key_chain (#60758) 2019-08-19 15:08:46 +05:30
Miguel Angel Muñoz González
be639a57f8 Fortinet's new module for fortios_router_isis (#60757) 2019-08-19 15:05:16 +05:30
Miguel Angel Muñoz González
174a854e05 Fortinet's new module for fortios_router_community_list (#60756) 2019-08-19 15:02:44 +05:30
Miguel Angel Muñoz González
78a382e91d Fortinet's new module for fortios_router_aspath_list (#60755) 2019-08-19 15:01:55 +05:30
Felix Fontein
7a9e865a23 docker_image_info: improve docs (#60622)
* Improve return value documentation.

* Improve example.

* Fix typo.

* Update lib/ansible/modules/cloud/docker/docker_image_info.py

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>

* Update lib/ansible/modules/cloud/docker/docker_image_info.py

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-08-19 03:21:50 -04:00
Ryan Butler
555b8413a1 VMware: Add uptime and maintenance mode in vmware_host_facts (#60688)
* adding host facts
* adding to test
2019-08-19 10:57:01 +05:30
Jordan Borean
aea52c67d6
ansible-galaxy: create parent dir for token file (#60615)
* ansible-galaxy: create parent dir for token file

* The path unfrack is already done by config

* Move common dir creation to ansible cli

* Add warning if dir failed to be created

* remove testing path

* Make mode a position arg not kwarg
2019-08-19 06:21:47 +10:00
Klaus Frank
fb2c1d4577 Make win_domain_user idempotent for password changes (#58383)
* Make win_domain_user idempotent for passwordchanges

* Add changelog fragment

* Use test-credentials function from win_user.

* Split domain from username

* Update win_domain_user.ps1

* Fix ci

* Update win_domain_user.ps1

Fix ci

* Implement review

* Logic cleanup and remove securestring

* Fix typo

* fix syntax

fix syntax

* Use AD object instead of user input as requested by review

* migrate to Ansible.AccessToken
2019-08-19 06:17:41 +10:00
Klaus Frank
811153afb1 Add exception handling to win_domain_controller (#58234)
* Add exception handling to win_domain_controller

* Add changelog

* Fix PSUseDeclaredVarsMoreThanAssignments

* Remove dns domain cannot be resolved error message

As requested by PR review in https://github.com/ansible/ansible/pull/58234#discussion_r300509880
2019-08-18 16:14:51 -04:00
Klaus Frank
cc5957001c win_domain reboot required exception incorrectly reported (#60496)
* Set reboot required dependent on exception message.

* Use exception id instead of it's message
2019-08-19 06:05:33 +10:00
Felix Fontein
0d88ec241f
openssl_certificate: fix idempotency (#60745)
* Fix openssl_certificate idempotency.

* Add changelog.

* Add integration test.
2019-08-18 20:48:34 +02:00
Felix Fontein
16056f4978
openssl_certificate: check for existence before loading CSR / private keys / ... (#60740)
* Check file existence before loading files.

* Remove superfluous import.

* Add changelog.
2019-08-18 11:41:50 +02:00
Hannes Ljungberg
13364fc530 docker_swarm_service: Allow passing dicts in networks (#58961)
* Add support for passing networks as dicts

* Add function to compare a list of different objects

* Handle comparing falsy values to missing values

* Pass docker versions to Service

* Move can_update_networks to Service class

* Pass Networks in TaskTemplate when supported

* Remove weird __str__

* Add networks integration tests

* Add unit tests

* Add example

* Add changelog fragment

* Make sure that network options are clean

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Set networks elements as raw in arg spec

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix wrong variable naming

* Check for network options that are not valid

* Only check for None options

* Validate that aliases is a list
2019-08-18 08:55:54 +02:00
Felix Fontein
26b9c81a8e
crypto modules: fix sanity errors (#60046)
* Remove sanity warnings.

* Linting.

* More linting.

* Forgot one place.

* no_bytes -> num_bytes
2019-08-18 05:37:57 +02:00
Felix Fontein
ceff0029cb
openssl_certificate: deprecate assertonly provider (#60623)
* Add deprecation marks.

* Add conversion example.

* Split long line.

* Add changelog and porting guide entry.

* Fix unrelated porting guide entry.

* Fix format.

* Fix doc mistakes found in review.

* Fix filter name.

* Compare CSR and cert subject via subject_ordered.
2019-08-18 05:09:49 +02:00
Chris Trufan
86366530e8 Entrust Datacard - Support for "entrust" provider in openssl_certificate module (#59272)
* Addition of entrust provider to openssl_certificate module

* Fix native return values of error messages and JSON response.

* Documentation and syntax fixes per ansibot.

* Refactored structure of for loop due to ansible test failures in python 2.6

* Remove OCSP functionality for inclusion in possible seperate future pull request.

* Remove reissue support.

* Indicate the entrust parameters are specific to entrust.

* Comment fixes to make it clear module_utils request is used.

* Fixes to not_after documentation

* Response to pull request comments and cleanup of error handling for bad connections to properly use the 'six' HttpError for compatibility with both Python 2/3 underlying url libraries.

* pep8/pycodestyle fixes.

* Added code fragment and response to comments.

* Update license to simplified BSD

* Fixed botmeta typo

* Include license text in api.yml

* Remove unsupported certificate types, and always submit an explicit organization to match organization in CSR

* Fix documentation misquote, add expired to a comment, and fix path check timing.

* Update changelogs/fragments/59272-support-for-entrust-provider-in-openssl_certificate_module.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-08-17 21:32:02 +02:00
Sumit Jaiswal
ab07c206aa
Resource module for ios_l2_interfaces (#60344)
* ios_l2_interface checkin

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-17 23:02:36 +05:30
Paul Belanger
c11d144302 Remove unused imports / variables for junos (#60705)
* Remove unused imports / variables for junos

This is to help with the migration to collections.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

* Remove duplicate execute_module() function for junos lacp_interfaces

This seems to have passed lint checks, but something we caught in
collection migration.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-17 22:38:53 +05:30
Felix Fontein
6a786d0d93
openssl_publickey: add cryptography backend (#60387)
* Add cryptography backend.

* Add changelog.

* Make sure requirements are satisfied.

* Use more compatible elliptic curve.

* Decrease required version numbers.

* PyOpenSSL >= 16.0.0 is really needed.

* Update lib/ansible/modules/crypto/openssl_publickey.py

Co-Authored-By: MarkusTeufelberger <mteufelberger@mgit.at>
2019-08-17 18:52:14 +02:00
Felix Fontein
601a4b8f47
get_certificate: add cryptography backend (#60599)
* Add cryptography backend for get_certificate.

* Add changelog.

* Use short names (if possible).

* Adjust version (to behave as pyOpenSSL).

* Work around bugs (needed for cryptography 1.2.3).

* Don't run cryptography backend tests for CentOS 6.

* Bump cryptography requirement to 1.6 or newer.

Otherwise, signature_algorithm_oid isn't there, either.

* Simplify requirement text.

* CentOS 6 has cryptography 1.9, so we still need to block.

* Add auto-detect test.

* Improve YAML.
2019-08-17 16:02:14 +02:00
Felix Fontein
38435e1bd0
openssl_certificate: various assertonly bugfixes (#60658)
* Fix get_relative_time_option for byte string input. Also fix it for None input.

* Using correct property for invalid_at check.

* Fix invalid_at comparison.

* Converting relative timestamps before comparison for valid_at and invalid_at.

* Fixing key usage display for cryptography backend.

* Fix key usage comparison. OBJ_txt2nid always returns 0 for key usage identifiers.

* Add changelog.

* Fix pyOpenSSL key usage comparison.
2019-08-17 15:58:25 +02:00
Felix Fontein
cf69b73c04
openssl_certificate/csr_info: add ordered issuer/subject return value (#60708)
* Add ordered issuer/subject return value.

* Add changelog.
2019-08-17 15:49:54 +02:00
Lukas Kämmerling
100b56439e hcloud_server: Allow users to enable/disable the rescue mode (#60070) 2019-08-17 11:29:58 +02:00
Fabrizio Dall'ara
85f7a7e848 Adding Port Security Timeout option in Interface Policy Port Security (#57108)
* Adding support for port security timeout attribute for ACI Interface Policy Port Security

- Feature Pull Request

Network Module ACI

lib:  _aci_intf_policy_port_security.py

* Fixing missing quotes

* Fixing errors raised by ansible-test sanity test

pylint error E321 missing whitespace after comma

Added version 2.9 as version_added

* Fixing the missing version_added under new port_security_timeout option
2019-08-16 22:17:51 -04:00
Derrick Johnson
175f80c788 aci_epg_to_domain - Add switching_mode support (#58429)
* aci_epg_to_domain - Add switching_mode support

##### SUMMARY
When deploying an AVE with VXLAN, the switching mode cannot be native and must be AVE.

##### ISSUE TYPE
- Feature Pull Request

+label: docsite_pr

* Update aci_epg_to_domain.py

* Update aci_epg_to_domain.py
2019-08-17 03:15:32 +02:00
sig9org
82a00afffb Add aci_extepg.py and aci_extsubnet.py (#58079)
* Add aci_extepg.py and aci_extsubnet.py

* Check pep8 style.

* Remove aci_extsubnet.py.

* Rename to aci_l3out_extepg

* Change file name. (aci_extepg.py -> aci_l3out_extepg.py)
2019-08-17 03:15:18 +02:00
Derrick Johnson
bb7da4239b Fix INTERSITE BUM TRAFFIC ALLOW (#58608)
##### SUMMARY
The payload was using the incorrect keyword to push the True or False statement to the device and was getting dropped. This would also result in erroring out if layer2_unknown_unicase was set to Flood instread of Proxy.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-08-16 21:10:08 -04:00
Nirav Katarmal
b34002bb55 Added preferred group attribute to epg (#59779) 2019-08-17 03:04:52 +02:00
The Magician
11862782ff Bug fixes for GCP modules (#60666) 2019-08-16 17:41:54 -04:00
Matt Davis
68f1e42d95 Minimize collection loader ansible imports
* pass in optional config instead of importing, so other things (eg ansible-test, units) don't have to take a config dependency
2019-08-16 12:36:43 -07:00
Paul Belanger
7f280434de
Remove unused import from eos facts (#60694)
Code clean up to help with collections migration

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-16 15:25:10 -04:00
The Magician
da57c3b334 Bug fixes for GCP modules (#60664) 2019-08-16 15:24:24 -04:00
The Magician
7cee7a6d90 Bug fixes for GCP modules (#60665) 2019-08-16 15:24:15 -04:00
The Magician
8d33e9ae4d Bug fixes for GCP modules (#60667) 2019-08-16 15:23:48 -04:00
The Magician
818d1b2e45 New Module: gcp_cloudfunctions_cloud_function (#60668) 2019-08-16 15:23:39 -04:00
Jiri Tyr
134379b273 Updating documentation for the setup module (#60696) 2019-08-16 13:42:54 -05:00
The Magician
e7a8e48053 New Module: gcp_cloudfunctions_cloud_function_info (#60669) 2019-08-16 14:32:35 -04:00
Dusan Matejka
df9b4faa9f Documented disadvantages of using default zabbix password for all zab… (#60639)
* Update lib/ansible/plugins/doc_fragments/zabbix.py
2019-08-16 10:58:06 -05:00
Mauricio Accetturi Carvalho
477b34c440 Add network and vpc to args (#60657)
* Add network and vpc to args

network and vpc are needed when create a loadbalancer in a vpc in a recent adquired public ip

* version_added in new args
2019-08-16 11:51:20 -04:00
Miguel Angel Muñoz González
7e22c7482e Fortinet's new module for fortios_switch_controller_system (#60691) 2019-08-16 20:40:37 +05:30
Miguel Angel Muñoz González
b4f210945e Fortinet's new module for fortios_system_ha (#60689)
* Fortinet's new module for fortios_system_ha

* Retriggering Ansible checks due to strange failure
2019-08-16 20:40:27 +05:30
Miguel Angel Muñoz González
ca28ae3be5 FortiOS modules for 2.9 - 2 (#60598)
* FortiOS modules for 2.9 - 2

* Fix long lines and ignore.txt
2019-08-16 20:34:37 +05:30
Sumit Jaiswal
585bfead75
fix ios_interfaces (#60687) 2019-08-16 19:25:28 +05:30
Mitsuru Nakakawaji
064cd63f3d fix: docker_swarm_service does not publish both tcp and udp ports (#60616)
* fix: docker_swarm_service does not publish both tcp and udp ports for same published port

* fix the linting problems and add the changelog fragment.

* add test

* modify test to ensure result rather than return value
2019-08-16 15:23:45 +02:00
Felix Fontein
48541910bf
docker_container: add mount endpoint collision detection (#60384)
* Add mount endpoint collision detection.

* Add changelog.

* Fix error.
2019-08-16 15:23:03 +02:00
Alex Stephen
523e40e993 nonetype error (#60603) 2019-08-16 06:04:32 -04:00
Dane DeValcourt
c5c270d9f7 Typo fix in nxos_file_copy.py (#60659)
Corrected typo in example documentation "local_filr_directory" to "local_file_directory"
2019-08-16 10:40:30 +05:30
zingyb
06d1705752 Fix mispelling in postgresql_query docs (#60648)
Changed `arbitraty` to `arbitrary` in postgresql_query docs
2019-08-16 10:38:47 +05:30
Patrick Marques
39d249155a Deprecates Digital Ocean sshkey_facts in favor of new module sshkey_info (#60546)
* Renames Digital Ocean sshkey_facts modules to sshkey_info

* Change digital_ocean_sshkey_facts status to deprected

* Update digital_ocean_sshkey _facts _info doc

* Allow digital_ocean_sshkey_info in Check Mode

* Update lib/ansible/modules/cloud/digital_ocean/_digital_ocean_sshkey_facts.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix _info added version
2019-08-15 23:45:05 +02:00
Simon Dodsley
491a47c7c5 Pure modules: rename _facts with ansible_facts result to _info (#60641) 2019-08-15 22:42:35 +02:00
Paul Belanger
2ce082c277
Remove unused imports / variables (#60654)
This is to help with the migration to collections.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-15 14:58:57 -04:00
Paul Belanger
37b30d18f3
Remove unused variable (#60485)
This is to keep our linters happy for ansible_collection vyos migration.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-15 14:47:21 -04:00
Andreas Jaeger
8b78ba095c Fix capitalization of SUSE (#60625)
The openSUSE project was always capitalized openSUSE, and SUSE does not
use the lowercase "u" since over 15 years. Let's update the docs for
this.
2019-08-15 09:04:58 -05:00
Simon Dodsley
c2160274c6 Update purefa_facts to show details on connected arrays (#60368) 2019-08-15 00:30:30 -04:00
Jordan Borean
4ebac7d5b7
ansible-galaxy - more fixes for verbosity without sub type (#60604)
* ansible-galaxy - more fixes for verbosity without sub type

* remove testing line
2019-08-15 11:53:40 +10:00
Matt Clay
25b20adb94 Fix git module when using absolute repo path.
This prevents a traceback when `repo` is set to an absolute path.
2019-08-14 18:09:56 -07:00
Nathaniel Case
7d3c4a8882
Delay persistent connection until needed (#59153)
* Delay calling connect() until absolutely necessary

* Implement transport_test to enable wait_for_connection

* plugin might be connected already for some reason?

* ensure_connect for httpapi

There's some become shenanigans still needing to be ironed out

* Fix tests for network_cli
2019-08-14 16:58:03 -04:00
René Moser
f02f5c4b5d
cloudscale_server: add tags support (#60396) 2019-08-14 22:55:31 +02:00
René Moser
5298d312a2
cloudscale_server_group: add tags support (#60397) 2019-08-14 22:54:25 +02:00
Lukas Kämmerling
4a09c7a920 hcloud: Add hcloud_rdns Module (#60123) 2019-08-14 22:51:05 +02:00
Richard Bonett
814e24fab5 Add note about registering floating IP (#60494)
* Add note about registering floating IP

* Remove trailing whitespace

* adds info to 'wait' param, edits
2019-08-14 14:30:17 -05:00
Chris Archibald
206594c5f0 New Module: Volume Autosize (#59936)
* add new module

* update volume
2019-08-14 15:21:51 -04:00
Chris Archibald
fed6598e28 fixes (#60146) 2019-08-14 10:26:12 -04:00
Miguel Angel Muñoz González
4cae96109b FortiOS modules for 2.9 - 1 (#60469)
* FortiOS modules for 2.9 - 1

* Fix empty choices and avoid E337,E338 warnings

* Ansible comments on version_added and ignore.txt only on this PR files

* Add version_added also for state attribute

* Avoid null choices on dlp_sensor

* Change required flag according to argspec
2019-08-14 19:44:51 +05:30
Ganesh Nalawade
5923a64b20 Update junos_facts gather_network_resources choices (#60467)
*  Add negation choice for individual resource names
2019-08-14 19:28:55 +05:30
Paul Belanger
55d3ecff01 Remove unused variables / imports (#60505)
These helps with the clean up of migrating eos to a collection.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-14 19:26:34 +05:30
Chris Archibald
645eebdbbb new options (#60142) 2019-08-14 09:51:38 -04:00
Chris Archibald
ae794369f8 new module: na_ontap_vserver_cifs_security (#59817)
* new module

* fixes
2019-08-14 09:02:56 -04:00
Rohit
69bc24f607
lag interfaces resource module (#59175)
* lag interfaces resource module

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity check imports

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dict_diff usage issue fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* new task

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* overridden updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dict update

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* facts merged

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* rebased and merged

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* new failures added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* obsolete file removed

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dependency added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-08-14 17:31:49 +05:30
Martin Nečas
d8d00c36fa ovirt_vm add linux boot param warning (#60474)
* ovirt_vm add kernel param check

* update check

* update docs phrase

* use douple quotes
2019-08-14 06:24:29 -04:00
Alexandre Mulatinho
b2f1993b20 FreeIPA: Add dynamic update to zones in IPA (#59489)
This feature add a new option to `ipa_dnszone` called
**dynamicupdate** as requested by issue #46768.

It allow user to change between default option `false`
to `true` if user/sysadmin wishes to make zone dynamically
updated.

Fixes #46768

Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
2019-08-14 15:38:06 +05:30
Alexandre Mulatinho
7b0a5fb487 ipa_dnsrecord.py: ttl is not required to change zones in ipa (#59924)
this fixes the error reported on issue #56872, is user not pass the argument
module 'record_ttl' it simples removes from json dictionary to make the
correct post request.

Fixes #56872
Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
2019-08-14 15:37:33 +05:30
Ryan Butler
abf7cf97df VMware: Fix typo in vmware_host_dns_facts.py (#60542)
Correct *search_doamin* to *search_domain*
2019-08-14 14:56:04 +05:30
Felix Fontein
99fb0fcb2f docker_logout: report change on successful logout (#60381)
* Mark logout as changed when docker logout does not return 'Not logged in to '.

* Add changelog.

* Improve logout detection.

* Also return output of 'docker logout'.
2019-08-14 05:23:38 -04:00
Stefan Horning
6337fbbfe5 Fix naming in example code documentation section for aws_codebuild and aws_codepipeline modules (#60495) 2019-08-14 05:23:25 -04:00
Trishna Guha
d5d88f9b11
Add nxos_interfaces resource module (#60421)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-14 13:38:22 +05:30
Sam Doran
0f35e4b7b9 apt_facts - Fix cache related performance regression (#60511)
* apt_facts - Fix cache related performance regression

* Another minor performance improvement
2019-08-14 03:43:52 -04:00
Jordan Borean
737a500a30
template - move backup to its own doc (#59893)
* template - move backup to its own doc

* Use the backup doc fragment for template
2019-08-14 09:48:37 +10:00
Brian Coca
a8d01cf2a2 Made galaxy token file location configurable (#59387)
* Made galaxy token file location configurable

  also made file handling 'unicode safe'

* only create a token on demand

* convert into decorator in case other funcs need
2019-08-14 09:47:40 +10:00
Jordan Borean
14a7722e39
ansible-galaxy tidy up arg parse with better validation (#59957)
* ansible-galaxy tidy up arg parse with better validation

* Add support back in for -v before sub aprser

* Added deprecation warning for manually parsed verbosity
2019-08-14 06:36:29 +10:00
René Moser
7a2483c47e purefa_phonehome: implement check mode support (#57585) 2019-08-13 13:27:18 -04:00
pguermo
8923d13537 proxmox_kvm: While a VM is beeing created, vm has no name item (#58196)
* While a VM is beeing created, vm as no name attribute

* Add changelogs fragment
2019-08-13 19:22:17 +02:00
Iain Madder
1b1216d2d1 Update file.py's help doc, and narrow down diff logic, for recent pull 56353 (#59069)
* Limiting when path_content is generated

path_content will be empty and unnecessary in all scenarios except when changing the state of a folder to absent, so adding in a check to limit when this parameter is defined
2019-08-13 12:59:13 -04:00
Simon Dodsley
848c945a2c Fix updating hosts idempotency in purefa_host (#60367) 2019-08-13 10:53:11 -04:00
Matt Martz
ba81084a49
Provide nice error when the shell plugin is incompatible with the con figured become plugin (#60441)
* Provide nice error when the shell plugin is incompatible with the configured become plugin. Fixes #57770

* Add todo

* Add missing import
2019-08-13 09:37:53 -05:00
Nathaniel Case
6b5c7f7c42
Add new module eos_interfaces (#59729)
* Move module_utils

* Add eos_interfaces and deprecate eos_interface

* Add boilerplate, update ignores.txt

* Try to reconcile eos provider documentation with argspec

* Try to work around unknown interfaces

* Move param_list_to_dict to utils
2019-08-13 10:09:52 -04:00
Chris Archibald
2e819c87db new options (#60145) 2019-08-13 09:35:01 -04:00
Gonéri Le Bouder
df2a09e998 vmware: avoid unnecessary copy() call (#60476)
Two vmware modules uses copy() to duplicate an internal instance of a
pyvmomi object. This to be able to modify the object during an iteration.

See: https://github.com/ansible/ansible/pull/60196/files#r312643761

Closes: #60399
2019-08-13 09:27:22 -04:00
Shaun M
fa783c027b Adding waiter to cluster remove process (#57324)
* Adding waiter to cluster remove process

* blank line contains whitespace

* update aws_eks integration test

* Refactor aws_eks test suite to use pip

* update version testing

* missing parens...

* add changelog fragment

* Add waiter to module_utils, fix exception handling.

* Correct EKS waiter checks
2019-08-13 23:11:21 +10:00
Felix Fontein
2d98734ad5 Amazon modules: rename _facts with ansible_facts result to _info (#60178)
* aws_s3_bucket_facts -> aws_s3_bucket_info

* cloudformation_facts -> cloudformation_info

* cloudfront_facts -> cloudfront_info

* ecs_service_facts -> ecs_service_info

* efs_facts -> efs_info

* Add changelog and porting guide entry.

* lambda_facts -> lambda_info

* Improve examples.

* Add subsection on renamed modules.

* Add sentence on registering variables.

* Fix ReST.

* Instead of renaming lambda_facts, deprecate it and replace with new module.

* Rename internal variable.

* Re-add sanity ignores for lambda_facts.
2019-08-13 08:01:37 -04:00
Martin Nečas
dee13ea4f8 ovirt vm update kernel docs (#60407)
* ovirt vm update kernel docs

* update doc phrase

* update docs
2019-08-13 07:11:05 -04:00
Martin Nečas
e3d13cbcdc Ovirt host update force docs (#60202)
* update docs

* update pep8 syntax

* update pep8 syntax
2019-08-13 06:35:05 -04:00
Martin Nečas
5972567ab6 ovirt_vm update tempalte search by datacenter (#60461) 2019-08-13 06:16:25 -04:00
Nilashish Chakraborty
6110dcc789
Add iosxr_lldp_interfaces resource module (#60411)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-13 14:58:55 +05:30
Matt Davis
a40baf22fa
various mod_args fixes (#60290)
* various mod_args fixes

* filter task keywords when parsing actions from task_ds- prevents repeatedly banging on the pluginloader for things we know aren't modules/actions
* clean up module/action error messaging. Death to `no action in task!`- actually list the candidate modules/actions from the task if present.

* remove shadowed_module test

* previous discussion was that this behavior isn't worth the complexity or performance costs in mod_args

* fix/add test, remove module shadow logic

* address review feedback
2019-08-13 09:57:49 +01:00
Ganesh Nalawade
9efa00e762
Add [junos_lldp_global] model (#59712)
* Add [junos_lldp_global] model

*  Add new resource module junos_lldp_global
*  Targets model https://github.com/ansible/network/pull/30
*  Deprecate junos_lldp module

* Run lldp integration test only if protocol supported
2019-08-13 13:05:17 +05:30
Trishna Guha
0acf7be56a
Add nxos_lacp_interfaces resource module (#60313)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-13 12:13:35 +05:30
yanzhangi
4512f664a7 Update ce_bfd_global to fix bugs (#60412) 2019-08-13 02:11:51 -04:00
sky-joker
c27b5ae1a3 add option proxy to get_certificate module (#60076)
* add option proxy to get_certificate module

* Add python 2.7 or higher to requirements

* Modify requirements and add create_default_context module import check processing

* add changelog file for get_certificate

* Modify changelog file
2019-08-13 01:34:04 -04:00
Daniel
262d2a6837 Update docs with file deletion details as recommended in #59051 (#60168) 2019-08-12 15:57:29 -05:00
Dan Hemberger
8346898605 [docs] Fix subversion.py export example (#60438)
The svn export example was missing the `export: yes` parameter. It was accidentally omitted when the syntax was changed in ad6999e2eb.
2019-08-12 15:52:36 -05:00
James Cassell
8bca160363 add vfat to selinux special_context_filesystems (#59823)
vfat is the format of the /boot/efi partition on UEFI hosts and does
not support SELinux labels

add an environment variable for this config option
2019-08-12 14:45:27 -04:00
The Magician
6cb5b67b22 Bug fixes for GCP modules (#60115) 2019-08-12 14:34:20 -04:00
The Magician
be459c00bf Bug fixes for GCP modules (#60337) 2019-08-12 14:31:35 -04:00
The Magician
687da46a85 Bug fixes for GCP modules (#60338) 2019-08-12 13:41:41 -04:00
helterskelter01
0855820574 Update package_facts.py (#60402)
Fixed a type in the description about the package_facts module where information was typed informatino.
2019-08-12 10:51:25 -05:00
Alexander Kapshuna
d320222eb3 gitlab_runner: document minimal dependency version (#60371) 2019-08-12 10:50:34 -05:00
Alexander Kapshuna
273a2d7a79 gitlab_runners (#60370)
Fix choices formatting in plugin option.
2019-08-12 10:49:12 -05:00
Adrian L Lange
7e69d67f28 Fix firewalld rich_rule example (#60379)
The rich rule example didn't specify the `family` field, which firewalld will fail on if not provided.
2019-08-12 10:44:39 -05:00
Marius Gedminas
c71622b31a user: createhome=no home=/no/such/dir (#60310)
Fixes #60307.

This bug was introduced in commit d2edf1d435
("User - Create parent directories if they do not exist in the specified
home path (#51043)") and did not make it into any releases.
2019-08-12 10:37:45 -04:00
Chris Archibald
13403b3688 update to command (#60141) 2019-08-12 10:30:00 -04:00
Chris Archibald
5df9075386 New Module: na_ontap_ports (#59814)
* new module

* fixes
2019-08-12 10:23:24 -04:00
Nathan Swartz
abc5654738 Fix netapp_e_iscsi_target chap secret size and clearing functionality. (#57135) 2019-08-12 09:52:40 -04:00
Nilashish Chakraborty
09f712c7f3
Add iosxr_lldp_global resource module (#60074)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-12 18:03:23 +05:30
Dmitriy Rabotyagov
8d3fa2251e Search project in domain when it's defined (#59876)
Since there might be several projects with the same name in different
domains, it's required to define domain_id during project search.
Otherwise openstacksdk will raise "Multiple matches found" error
2019-08-12 07:05:36 -04:00
Miguel Angel Muñoz González
60a1545092 Fortinet's new module for fortios_switch_controller_vlan (#59630)
* Fortinet's new module for fortios_switch_controller_vlan

* Update fortios_switch_controller_vlan.py

* Update fortios_switch_controller_vlan.py
2019-08-12 14:58:02 +05:30
Miguel Angel Muñoz González
f1a4ab0aa5 Fortinet's new module for fortios_switch_controller_virtual_port_pool (#59601)
* Fortinet's new module for fortios_switch_controller_virtual_port_pool

* Update fortios_switch_controller_virtual_port_pool.py

* Update fortios_switch_controller_virtual_port_pool.py
2019-08-12 14:56:11 +05:30
Miguel Angel Muñoz González
079a4408ab Fortinet's new module for fortios_switch_controller_switch_profile (#59683)
* Fortinet's new module for fortios_switch_controller_switch_profile

* Update fortios_switch_controller_switch_profile.py

* Update fortios_switch_controller_switch_profile.py
2019-08-12 14:55:19 +05:30
René Moser
602aded6ec
vultr: vultr_block_storage_facts to info (#60230) 2019-08-12 10:36:21 +02:00
Pavan Bidkar
0a90ec90c0 VMware: handle KeyError in get_vm API (#60204)
Fixed if conditions for all VM params
2019-08-12 14:03:13 +05:30
Ganesh Nalawade
8cbfa75038
Add [junos_lacp] model (#59705)
* Add [junos_lacp] model

*  Add new resource module junos_lacp.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/28

* Fix CI issues

* Fix CI failures
2019-08-12 13:54:44 +05:30
Felix Fontein
84d89190c7 openssh_keypair: Forgot version_added in #59268. (#60394) 2019-08-12 10:22:27 +02:00
sushma-alethea
622a493ae0 icx: new module icx_ping (#59975)
* new module

* new module

* new terminal

* new terminal

* new cliconf

* new cliconf

* cliconf

* cliconf

* icx cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx test units module

* icx units module

* icx units module

* icx banner unit test

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* added notes

* removed icx rst

* new changes

* new changes

* deleted icx rst

* icx .rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* changes resolved

* PR comments resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* Update platform_index.rst

PR comment resolved

* new module icx_ping

* new changes

* Fixed bot error
2019-08-12 12:01:15 +05:30
Ganesh Nalawade
fdf48ed0b4
Add [junos_lacp_interfaces] resource module (#59708)
* Add [junos_lacp_interfaces] resource module

*  Add new resource module junos_lacp_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/36

* Fix sanity test failure
2019-08-12 11:24:34 +05:30
Maxim Babushkin
dda80c46e9 openssh_keypair - Add key `comment` to return output (#59268)
If the comment will be provided during the key creation, it will be
diplayed in the return values.
Same will be on the comment change.
2019-08-11 13:47:34 +02:00
René Moser
8da48b1a40
inventory: cloudscale: extend examples (#60306) 2019-08-11 11:17:47 +02:00
yanzhangi
e956753e83 Update ce_acl_advance to fix bugs (#60377) 2019-08-11 03:38:22 -04:00
Maxim Babushkin
27e414200f openssh_keypair - Add public key and key comment validation (#57993)
- Split the key validation to separate private and public.
- In case public key does not exist, recreate it.
- Validate comment of the key.
- In case comment changed, update the private and public keys.
2019-08-10 18:57:35 -04:00
Steve Holton
a3d55a5ddb fix spelling: certifivate -> certificate (#60369)
##### SUMMARY
spelling fix

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-08-10 18:39:26 -04:00
yanzhangi
7a37ad1f93 update ce_acl_advance to fix bugs (#60353) 2019-08-10 00:54:39 -04:00
The Magician
86ead40c2b New Module: gcp_compute_snapshot_info (#60342) 2019-08-09 19:26:59 -04:00
The Magician
30ad73f1c1 Bug fixes for GCP modules (#60339) 2019-08-09 19:17:44 -04:00
The Magician
5d4c3ad97e Bug fixes for GCP modules (#60340) 2019-08-09 19:17:36 -04:00
Simon Dodsley
1b45abc4f3 Fix major bug in the last update of this module. (#60223) 2019-08-09 18:11:33 -04:00
Felix Fontein
8b68feb67e
acme_certificate: allow to download alternate certificate chains (#56334)
* Improve link handling.

* Also fetch alternate certificate chains.

* Add retrieve_all_alternates option.

* Simplify code.

* Forgot when condition.

* Add tests for retrieve_all_alternates.

* Fixes.

* Moved utility function for link parsing to module_utils.

* Fix grammar.
2019-08-09 23:54:48 +02:00
Sebastian Neuser
e9fc095123 Improve docker_compose module documentation (#60064)
* Improve docker_compose module documentation

* Swap usage of C() and I()

* Further improvements

* Mentions of files (docker-compose.yml) are now rendered correctly.
* Compose files are now called just that.

* Further clarify options "services", "stopped" and "restarted"

* Update lib/ansible/modules/cloud/docker/docker_compose.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/docker/docker_compose.py

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-08-09 23:51:58 +02:00
Felix Fontein
3290b8343c
docker: fix sanity errors (#60047)
* Remove sanity check errors.

* More linting.

* Forgot to update places.

* Remove choices which aren't provided in argspec.
2019-08-09 23:50:11 +02:00
Paul Belanger
4f78b694f0
Remove unused imports / variables from vyos modules (#60333)
This code is not used, lets remove it.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-09 16:47:08 -04:00
Alex Stephen
2e90efd4a7 Changing GCP Facts modules to Info Modules (#60172)
* file changes, porting guide, changelog fragment, renaming autoscaler, removing rst links
* Apply suggestions from code review

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-08-09 15:13:08 -05:00
Chris Archibald
b6202dde32 Allow firmware update for (SP, ACP, Shelf, Disk) (#58597)
* update

* Revert "update"

This reverts commit 84848f8291.

* correct module

* fixes
2019-08-09 16:04:46 -04:00
Yaakov Selkowitz
93d9d64038 facts: fix double-counting of CPUs on POWER systems (#58360)
On POWER systems, /proc/cpuinfo provides a 'processor' entry as a
counter, and a 'cpu' entry with a description (similar to 'model name'
on x86). Support for POWER in get_cpu_facts was added via the 'cpu'
entry in commit 8746e692c1.  Subsequent
support for ARM64 in commit ce4ada93f9
used the 'processor' entry, resulting in double-counting of cores on
POWER systems.

When unit tests were later written for this code in
commit 55306906cf, the erroneous values
were just accepted in the test instead of being diagnosed.

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
2019-08-09 13:01:29 -04:00
Shachaf92
b5f42869dc win_dns_record PTR docs update (#60158)
* win_dns_record PTR docs update

* Update win_dns_record.py
2019-08-09 11:04:09 -05:00
Nathan Swartz
d61df0a9ba Lun mapping upstream dev (#57096)
* Fix hosts with same lun number conflict in netapp_e_lun_mapping.

This patch fixes an issue of when multiple hosts are created and then
subsequently volume(s) are mapped to them using the same specified number.

* Fix netapp_e_host module bug when lun=0

* Add thin-volumes to the netapp_e_lun_mapping update_mapping_info method.
2019-08-09 08:25:38 -04:00
Chris Archibald
48021a4200 add modify to snapshot policy (#59149) 2019-08-09 07:56:31 -04:00
Fred-sun
f088621610 Update azure_rm_webapp related document (#59027)
* Update azure_rm_webapp related document

* resolve format error

* remove whitespace

* update new

* updated according by comments

* update new according by comments

* add support time
2019-08-09 07:30:57 -04:00
Jordan Borean
dbd082efe4
Ansible.AccessToken - Added shared util for managing a Windows access token (#60302)
* Ansible.AccessToken - Added shared util for managing a Windows access token

* Fix tests when running in CI

* More fixes for older servers

* More fixes for Server 2008
2019-08-09 21:10:44 +10:00
Felix Fontein
49e16922b2 Remove no longer necessary check (since elements is procesed for path). (#59953) 2019-08-09 09:40:26 +02:00