cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
46613 commits 47 branches 390 tags 440 MiB
Commit graph

28380 commits

Author SHA1 Message Date
zingyb
06d1705752 Fix mispelling in postgresql_query docs (#60648) 
Changed `arbitraty` to `arbitrary` in postgresql_query docs
 2019-08-16 10:38:47 +05:30
Patrick Marques
39d249155a Deprecates Digital Ocean sshkey_facts in favor of new module sshkey_info (#60546) 
* Renames Digital Ocean sshkey_facts modules to sshkey_info

* Change digital_ocean_sshkey_facts status to deprected

* Update digital_ocean_sshkey _facts _info doc

* Allow digital_ocean_sshkey_info in Check Mode

* Update lib/ansible/modules/cloud/digital_ocean/_digital_ocean_sshkey_facts.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix _info added version
 2019-08-15 23:45:05 +02:00
Simon Dodsley
491a47c7c5 Pure modules: rename _facts with ansible_facts result to _info (#60641) 2019-08-15 22:42:35 +02:00
Paul Belanger
2ce082c277
Remove unused imports / variables (#60654) 
This is to help with the migration to collections.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
 2019-08-15 14:58:57 -04:00
Paul Belanger
37b30d18f3
Remove unused variable (#60485) 
This is to keep our linters happy for ansible_collection vyos migration.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
 2019-08-15 14:47:21 -04:00
Andreas Jaeger
8b78ba095c Fix capitalization of SUSE (#60625) 
The openSUSE project was always capitalized openSUSE, and SUSE does not
use the lowercase "u" since over 15 years. Let's update the docs for
this.
 2019-08-15 09:04:58 -05:00
Simon Dodsley
c2160274c6 Update purefa_facts to show details on connected arrays (#60368) 2019-08-15 00:30:30 -04:00
Jordan Borean
4ebac7d5b7
ansible-galaxy - more fixes for verbosity without sub type (#60604) 
* ansible-galaxy - more fixes for verbosity without sub type

* remove testing line
 2019-08-15 11:53:40 +10:00
Matt Clay
25b20adb94 Fix git module when using absolute repo path. 
This prevents a traceback when `repo` is set to an absolute path.
 2019-08-14 18:09:56 -07:00
Nathaniel Case
7d3c4a8882
Delay persistent connection until needed (#59153) 
* Delay calling connect() until absolutely necessary

* Implement transport_test to enable wait_for_connection

* plugin might be connected already for some reason?

* ensure_connect for httpapi

There's some become shenanigans still needing to be ironed out

* Fix tests for network_cli
 2019-08-14 16:58:03 -04:00
René Moser
f02f5c4b5d
cloudscale_server: add tags support (#60396) 2019-08-14 22:55:31 +02:00
René Moser
5298d312a2
cloudscale_server_group: add tags support (#60397) 2019-08-14 22:54:25 +02:00
Lukas Kämmerling
4a09c7a920 hcloud: Add hcloud_rdns Module (#60123) 2019-08-14 22:51:05 +02:00
Richard Bonett
814e24fab5 Add note about registering floating IP (#60494) 
* Add note about registering floating IP

* Remove trailing whitespace

* adds info to 'wait' param, edits
 2019-08-14 14:30:17 -05:00
Chris Archibald
206594c5f0 New Module: Volume Autosize (#59936) 
* add new module

* update volume
 2019-08-14 15:21:51 -04:00
Chris Archibald
fed6598e28 fixes (#60146) 2019-08-14 10:26:12 -04:00
Miguel Angel Muñoz González
4cae96109b FortiOS modules for 2.9 - 1 (#60469) 
* FortiOS modules for 2.9 - 1

* Fix empty choices and avoid E337,E338 warnings

* Ansible comments on version_added and ignore.txt only on this PR files

* Add version_added also for state attribute

* Avoid null choices on dlp_sensor

* Change required flag according to argspec
 2019-08-14 19:44:51 +05:30
Ganesh Nalawade
5923a64b20 Update junos_facts gather_network_resources choices (#60467) 
*  Add negation choice for individual resource names
 2019-08-14 19:28:55 +05:30
Paul Belanger
55d3ecff01 Remove unused variables / imports (#60505) 
These helps with the clean up of migrating eos to a collection.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
 2019-08-14 19:26:34 +05:30
Chris Archibald
645eebdbbb new options (#60142) 2019-08-14 09:51:38 -04:00
Chris Archibald
ae794369f8 new module: na_ontap_vserver_cifs_security (#59817) 
* new module

* fixes
 2019-08-14 09:02:56 -04:00
Rohit
69bc24f607
lag interfaces resource module (#59175) 
* lag interfaces resource module

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity check imports

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dict_diff usage issue fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* new task

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* overridden updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dict update

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* facts merged

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* rebased and merged

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* new failures added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* obsolete file removed

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dependency added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
 2019-08-14 17:31:49 +05:30
Martin Nečas
d8d00c36fa ovirt_vm add linux boot param warning (#60474) 
* ovirt_vm add kernel param check

* update check

* update docs phrase

* use douple quotes
 2019-08-14 06:24:29 -04:00
Alexandre Mulatinho
b2f1993b20 FreeIPA: Add dynamic update to zones in IPA (#59489) 
This feature add a new option to `ipa_dnszone` called
**dynamicupdate** as requested by issue #46768.

It allow user to change between default option `false`
to `true` if user/sysadmin wishes to make zone dynamically
updated.

Fixes #46768

Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
 2019-08-14 15:38:06 +05:30
Alexandre Mulatinho
7b0a5fb487 ipa_dnsrecord.py: ttl is not required to change zones in ipa (#59924) 
this fixes the error reported on issue #56872, is user not pass the argument
module 'record_ttl' it simples removes from json dictionary to make the
correct post request.

Fixes #56872
Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
 2019-08-14 15:37:33 +05:30
Ryan Butler
abf7cf97df VMware: Fix typo in vmware_host_dns_facts.py (#60542) 
Correct *search_doamin* to *search_domain*
 2019-08-14 14:56:04 +05:30
Felix Fontein
99fb0fcb2f docker_logout: report change on successful logout (#60381) 
* Mark logout as changed when docker logout does not return 'Not logged in to '.

* Add changelog.

* Improve logout detection.

* Also return output of 'docker logout'.
 2019-08-14 05:23:38 -04:00
Stefan Horning
6337fbbfe5 Fix naming in example code documentation section for aws_codebuild and aws_codepipeline modules (#60495) 2019-08-14 05:23:25 -04:00
Trishna Guha
d5d88f9b11
Add nxos_interfaces resource module (#60421) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2019-08-14 13:38:22 +05:30
Sam Doran
0f35e4b7b9 apt_facts - Fix cache related performance regression (#60511) 
* apt_facts - Fix cache related performance regression

* Another minor performance improvement
 2019-08-14 03:43:52 -04:00
Jordan Borean
737a500a30
template - move backup to its own doc (#59893) 
* template - move backup to its own doc

* Use the backup doc fragment for template
 2019-08-14 09:48:37 +10:00
Brian Coca
a8d01cf2a2 Made galaxy token file location configurable (#59387) 
* Made galaxy token file location configurable

  also made file handling 'unicode safe'

* only create a token on demand

* convert into decorator in case other funcs need
 2019-08-14 09:47:40 +10:00
Jordan Borean
14a7722e39
ansible-galaxy tidy up arg parse with better validation (#59957) 
* ansible-galaxy tidy up arg parse with better validation

* Add support back in for -v before sub aprser

* Added deprecation warning for manually parsed verbosity
 2019-08-14 06:36:29 +10:00
René Moser
7a2483c47e purefa_phonehome: implement check mode support (#57585) 2019-08-13 13:27:18 -04:00
pguermo
8923d13537 proxmox_kvm: While a VM is beeing created, vm has no name item (#58196) 
* While a VM is beeing created, vm as no name attribute

* Add changelogs fragment
 2019-08-13 19:22:17 +02:00
Iain Madder
1b1216d2d1 Update file.py's help doc, and narrow down diff logic, for recent pull 56353 (#59069) 
* Limiting when path_content is generated

path_content will be empty and unnecessary in all scenarios except when changing the state of a folder to absent, so adding in a check to limit when this parameter is defined
 2019-08-13 12:59:13 -04:00
Simon Dodsley
848c945a2c Fix updating hosts idempotency in purefa_host (#60367) 2019-08-13 10:53:11 -04:00
Matt Martz
ba81084a49
Provide nice error when the shell plugin is incompatible with the con figured become plugin (#60441) 
* Provide nice error when the shell plugin is incompatible with the configured become plugin. Fixes #57770

* Add todo

* Add missing import
 2019-08-13 09:37:53 -05:00
Nathaniel Case
6b5c7f7c42
Add new module eos_interfaces (#59729) 
* Move module_utils

* Add eos_interfaces and deprecate eos_interface

* Add boilerplate, update ignores.txt

* Try to reconcile eos provider documentation with argspec

* Try to work around unknown interfaces

* Move param_list_to_dict to utils
 2019-08-13 10:09:52 -04:00
Chris Archibald
2e819c87db new options (#60145) 2019-08-13 09:35:01 -04:00
Gonéri Le Bouder
df2a09e998 vmware: avoid unnecessary copy() call (#60476) 
Two vmware modules uses copy() to duplicate an internal instance of a
pyvmomi object. This to be able to modify the object during an iteration.

See: https://github.com/ansible/ansible/pull/60196/files#r312643761

Closes: #60399
 2019-08-13 09:27:22 -04:00
Shaun M
fa783c027b Adding waiter to cluster remove process (#57324) 
* Adding waiter to cluster remove process

* blank line contains whitespace

* update aws_eks integration test

* Refactor aws_eks test suite to use pip

* update version testing

* missing parens...

* add changelog fragment

* Add waiter to module_utils, fix exception handling.

* Correct EKS waiter checks
 2019-08-13 23:11:21 +10:00
Felix Fontein
2d98734ad5 Amazon modules: rename _facts with ansible_facts result to _info (#60178) 
* aws_s3_bucket_facts -> aws_s3_bucket_info

* cloudformation_facts -> cloudformation_info

* cloudfront_facts -> cloudfront_info

* ecs_service_facts -> ecs_service_info

* efs_facts -> efs_info

* Add changelog and porting guide entry.

* lambda_facts -> lambda_info

* Improve examples.

* Add subsection on renamed modules.

* Add sentence on registering variables.

* Fix ReST.

* Instead of renaming lambda_facts, deprecate it and replace with new module.

* Rename internal variable.

* Re-add sanity ignores for lambda_facts.
 2019-08-13 08:01:37 -04:00
Martin Nečas
dee13ea4f8 ovirt vm update kernel docs (#60407) 
* ovirt vm update kernel docs

* update doc phrase

* update docs
 2019-08-13 07:11:05 -04:00
Martin Nečas
e3d13cbcdc Ovirt host update force docs (#60202) 
* update docs

* update pep8 syntax

* update pep8 syntax
 2019-08-13 06:35:05 -04:00
Martin Nečas
5972567ab6 ovirt_vm update tempalte search by datacenter (#60461) 2019-08-13 06:16:25 -04:00
Nilashish Chakraborty
6110dcc789
Add iosxr_lldp_interfaces resource module (#60411) 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2019-08-13 14:58:55 +05:30
Matt Davis
a40baf22fa
various mod_args fixes (#60290) 
* various mod_args fixes

* filter task keywords when parsing actions from task_ds- prevents repeatedly banging on the pluginloader for things we know aren't modules/actions
* clean up module/action error messaging. Death to `no action in task!`- actually list the candidate modules/actions from the task if present.

* remove shadowed_module test

* previous discussion was that this behavior isn't worth the complexity or performance costs in mod_args

* fix/add test, remove module shadow logic

* address review feedback
 2019-08-13 09:57:49 +01:00
Ganesh Nalawade
9efa00e762
Add [junos_lldp_global] model (#59712) 
* Add [junos_lldp_global] model

*  Add new resource module junos_lldp_global
*  Targets model https://github.com/ansible/network/pull/30
*  Deprecate junos_lldp module

* Run lldp integration test only if protocol supported
 2019-08-13 13:05:17 +05:30
Trishna Guha
0acf7be56a
Add nxos_lacp_interfaces resource module (#60313) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2019-08-13 12:13:35 +05:30
yanzhangi
4512f664a7 Update ce_bfd_global to fix bugs (#60412) 2019-08-13 02:11:51 -04:00
sky-joker
c27b5ae1a3 add option proxy to get_certificate module (#60076) 
* add option proxy to get_certificate module

* Add python 2.7 or higher to requirements

* Modify requirements and add create_default_context module import check processing

* add changelog file for get_certificate

* Modify changelog file
 2019-08-13 01:34:04 -04:00
Daniel
262d2a6837 Update docs with file deletion details as recommended in #59051 (#60168) 2019-08-12 15:57:29 -05:00
Dan Hemberger
8346898605 [docs] Fix subversion.py export example (#60438) 
The svn export example was missing the `export: yes` parameter. It was accidentally omitted when the syntax was changed in ad6999e2eb.
 2019-08-12 15:52:36 -05:00
James Cassell
8bca160363 add vfat to selinux special_context_filesystems (#59823) 
vfat is the format of the /boot/efi partition on UEFI hosts and does
not support SELinux labels

add an environment variable for this config option
 2019-08-12 14:45:27 -04:00
The Magician
6cb5b67b22 Bug fixes for GCP modules (#60115) 2019-08-12 14:34:20 -04:00
The Magician
be459c00bf Bug fixes for GCP modules (#60337) 2019-08-12 14:31:35 -04:00
The Magician
687da46a85 Bug fixes for GCP modules (#60338) 2019-08-12 13:41:41 -04:00
helterskelter01
0855820574 Update package_facts.py (#60402) 
Fixed a type in the description about the package_facts module where information was typed informatino.
 2019-08-12 10:51:25 -05:00
Alexander Kapshuna
d320222eb3 gitlab_runner: document minimal dependency version (#60371) 2019-08-12 10:50:34 -05:00
Alexander Kapshuna
273a2d7a79 gitlab_runners (#60370) 
Fix choices formatting in plugin option.
 2019-08-12 10:49:12 -05:00
Adrian L Lange
7e69d67f28 Fix firewalld rich_rule example (#60379) 
The rich rule example didn't specify the `family` field, which firewalld will fail on if not provided.
 2019-08-12 10:44:39 -05:00
Marius Gedminas
c71622b31a user: createhome=no home=/no/such/dir (#60310) 
Fixes #60307.

This bug was introduced in commit d2edf1d435
("User - Create parent directories if they do not exist in the specified
home path (#51043)") and did not make it into any releases.
 2019-08-12 10:37:45 -04:00
Chris Archibald
13403b3688 update to command (#60141) 2019-08-12 10:30:00 -04:00
Chris Archibald
5df9075386 New Module: na_ontap_ports (#59814) 
* new module

* fixes
 2019-08-12 10:23:24 -04:00
Nathan Swartz
abc5654738 Fix netapp_e_iscsi_target chap secret size and clearing functionality. (#57135) 2019-08-12 09:52:40 -04:00
Nilashish Chakraborty
09f712c7f3
Add iosxr_lldp_global resource module (#60074) 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2019-08-12 18:03:23 +05:30
Dmitriy Rabotyagov
8d3fa2251e Search project in domain when it's defined (#59876) 
Since there might be several projects with the same name in different
domains, it's required to define domain_id during project search.
Otherwise openstacksdk will raise "Multiple matches found" error
 2019-08-12 07:05:36 -04:00
Miguel Angel Muñoz González
60a1545092 Fortinet's new module for fortios_switch_controller_vlan (#59630) 
* Fortinet's new module for fortios_switch_controller_vlan

* Update fortios_switch_controller_vlan.py

* Update fortios_switch_controller_vlan.py
 2019-08-12 14:58:02 +05:30
Miguel Angel Muñoz González
f1a4ab0aa5 Fortinet's new module for fortios_switch_controller_virtual_port_pool (#59601) 
* Fortinet's new module for fortios_switch_controller_virtual_port_pool

* Update fortios_switch_controller_virtual_port_pool.py

* Update fortios_switch_controller_virtual_port_pool.py
 2019-08-12 14:56:11 +05:30
Miguel Angel Muñoz González
079a4408ab Fortinet's new module for fortios_switch_controller_switch_profile (#59683) 
* Fortinet's new module for fortios_switch_controller_switch_profile

* Update fortios_switch_controller_switch_profile.py

* Update fortios_switch_controller_switch_profile.py
 2019-08-12 14:55:19 +05:30
René Moser
602aded6ec
vultr: vultr_block_storage_facts to info (#60230) 2019-08-12 10:36:21 +02:00
Pavan Bidkar
0a90ec90c0 VMware: handle KeyError in get_vm API (#60204) 
Fixed if conditions for all VM params
 2019-08-12 14:03:13 +05:30
Ganesh Nalawade
8cbfa75038
Add [junos_lacp] model (#59705) 
* Add [junos_lacp] model

*  Add new resource module junos_lacp.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/28

* Fix CI issues

* Fix CI failures
 2019-08-12 13:54:44 +05:30
Felix Fontein
84d89190c7 openssh_keypair: Forgot version_added in #59268. (#60394) 2019-08-12 10:22:27 +02:00
sushma-alethea
622a493ae0 icx: new module icx_ping (#59975) 
* new module

* new module

* new terminal

* new terminal

* new cliconf

* new cliconf

* cliconf

* cliconf

* icx cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx test units module

* icx units module

* icx units module

* icx banner unit test

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* added notes

* removed icx rst

* new changes

* new changes

* deleted icx rst

* icx .rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* changes resolved

* PR comments resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* Update platform_index.rst

PR comment resolved

* new module icx_ping

* new changes

* Fixed bot error
 2019-08-12 12:01:15 +05:30
Ganesh Nalawade
fdf48ed0b4
Add [junos_lacp_interfaces] resource module (#59708) 
* Add [junos_lacp_interfaces] resource module

*  Add new resource module junos_lacp_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/36

* Fix sanity test failure
 2019-08-12 11:24:34 +05:30
Maxim Babushkin
dda80c46e9 openssh_keypair - Add key `comment` to return output (#59268) 
If the comment will be provided during the key creation, it will be
diplayed in the return values.
Same will be on the comment change.
 2019-08-11 13:47:34 +02:00
René Moser
8da48b1a40
inventory: cloudscale: extend examples (#60306) 2019-08-11 11:17:47 +02:00
yanzhangi
e956753e83 Update ce_acl_advance to fix bugs (#60377) 2019-08-11 03:38:22 -04:00
Maxim Babushkin
27e414200f openssh_keypair - Add public key and key comment validation (#57993) 
- Split the key validation to separate private and public.
- In case public key does not exist, recreate it.
- Validate comment of the key.
- In case comment changed, update the private and public keys.
 2019-08-10 18:57:35 -04:00
Steve Holton
a3d55a5ddb fix spelling: certifivate -> certificate (#60369) 
##### SUMMARY
spelling fix

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
 2019-08-10 18:39:26 -04:00
yanzhangi
7a37ad1f93 update ce_acl_advance to fix bugs (#60353) 2019-08-10 00:54:39 -04:00
The Magician
86ead40c2b New Module: gcp_compute_snapshot_info (#60342) 2019-08-09 19:26:59 -04:00
The Magician
30ad73f1c1 Bug fixes for GCP modules (#60339) 2019-08-09 19:17:44 -04:00
The Magician
5d4c3ad97e Bug fixes for GCP modules (#60340) 2019-08-09 19:17:36 -04:00
Simon Dodsley
1b45abc4f3 Fix major bug in the last update of this module. (#60223) 2019-08-09 18:11:33 -04:00
Felix Fontein
8b68feb67e
acme_certificate: allow to download alternate certificate chains (#56334) 
* Improve link handling.

* Also fetch alternate certificate chains.

* Add retrieve_all_alternates option.

* Simplify code.

* Forgot when condition.

* Add tests for retrieve_all_alternates.

* Fixes.

* Moved utility function for link parsing to module_utils.

* Fix grammar.
 2019-08-09 23:54:48 +02:00
Sebastian Neuser
e9fc095123 Improve docker_compose module documentation (#60064) 
* Improve docker_compose module documentation

* Swap usage of C() and I()

* Further improvements

* Mentions of files (docker-compose.yml) are now rendered correctly.
* Compose files are now called just that.

* Further clarify options "services", "stopped" and "restarted"

* Update lib/ansible/modules/cloud/docker/docker_compose.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/docker/docker_compose.py

Co-Authored-By: Felix Fontein <felix@fontein.de>
 2019-08-09 23:51:58 +02:00
Felix Fontein
3290b8343c
docker: fix sanity errors (#60047) 
* Remove sanity check errors.

* More linting.

* Forgot to update places.

* Remove choices which aren't provided in argspec.
 2019-08-09 23:50:11 +02:00
Paul Belanger
4f78b694f0
Remove unused imports / variables from vyos modules (#60333) 
This code is not used, lets remove it.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
 2019-08-09 16:47:08 -04:00
Alex Stephen
2e90efd4a7 Changing GCP Facts modules to Info Modules (#60172) 
* file changes, porting guide, changelog fragment, renaming autoscaler, removing rst links
* Apply suggestions from code review

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-Authored-By: Felix Fontein <felix@fontein.de>
 2019-08-09 15:13:08 -05:00
Chris Archibald
b6202dde32 Allow firmware update for (SP, ACP, Shelf, Disk) (#58597) 
* update

* Revert "update"

This reverts commit 84848f8291.

* correct module

* fixes
 2019-08-09 16:04:46 -04:00
Yaakov Selkowitz
93d9d64038 facts: fix double-counting of CPUs on POWER systems (#58360) 
On POWER systems, /proc/cpuinfo provides a 'processor' entry as a
counter, and a 'cpu' entry with a description (similar to 'model name'
on x86). Support for POWER in get_cpu_facts was added via the 'cpu'
entry in commit 8746e692c1.  Subsequent
support for ARM64 in commit ce4ada93f9
used the 'processor' entry, resulting in double-counting of cores on
POWER systems.

When unit tests were later written for this code in
commit 55306906cf, the erroneous values
were just accepted in the test instead of being diagnosed.

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
 2019-08-09 13:01:29 -04:00
Shachaf92
b5f42869dc win_dns_record PTR docs update (#60158) 
* win_dns_record PTR docs update

* Update win_dns_record.py
 2019-08-09 11:04:09 -05:00
Nathan Swartz
d61df0a9ba Lun mapping upstream dev (#57096) 
* Fix hosts with same lun number conflict in netapp_e_lun_mapping.

This patch fixes an issue of when multiple hosts are created and then
subsequently volume(s) are mapped to them using the same specified number.

* Fix netapp_e_host module bug when lun=0

* Add thin-volumes to the netapp_e_lun_mapping update_mapping_info method.
 2019-08-09 08:25:38 -04:00
Chris Archibald
48021a4200 add modify to snapshot policy (#59149) 2019-08-09 07:56:31 -04:00
Fred-sun
f088621610 Update azure_rm_webapp related document (#59027) 
* Update azure_rm_webapp related document

* resolve format error

* remove whitespace

* update new

* updated according by comments

* update new according by comments

* add support time
 2019-08-09 07:30:57 -04:00
Jordan Borean
dbd082efe4
Ansible.AccessToken - Added shared util for managing a Windows access token (#60302) 
* Ansible.AccessToken - Added shared util for managing a Windows access token

* Fix tests when running in CI

* More fixes for older servers

* More fixes for Server 2008
 2019-08-09 21:10:44 +10:00
Felix Fontein
49e16922b2 Remove no longer necessary check (since elements is procesed for path). (#59953) 2019-08-09 09:40:26 +02:00
Ganesh Nalawade
309a58eafd
Add [junos_l2_interfaces] resource module (#59693) 
* Add [junos_l2_interfaces] resource module

*  Add new resource module junos_lag_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/12
*  Deprecate junos_l2_interface module

* Fix CI failures

* Fix CI issues
 2019-08-09 13:09:19 +05:30
Matt Clay
3777c2e93d Fix plugin names when loading all plugins. (#59950) 
* Fix plugin names when loading all plugins.

Add an integration test to verify plugin __package__ and __name__ are correct.

* Make sure filter and test names are unique.

* Remove __package__ test.

On Python 2.x __package__ is not set, but it is on Python 3.x.
 2019-08-09 07:23:12 +01:00
yanzhangi
9aabe70452 update ce_aaa_server_host to fix bugs (#60272) 2019-08-08 22:52:25 -04:00
Abhijeet Kasurde
647b78a09c
VMware: Check if datastore is valid (#58872) 
Check validation of datastore selected using autoselect_datastore API.

Fixes: #58541

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2019-08-09 07:56:52 +05:30
Andrew Gaffney
b38cb37728
Transform octal escape sequences in mtab fields (#60122) 2019-08-08 16:31:42 -05:00
Matt Martz
707e33793d
Undeprecated the skip argument for first_found. Fixes #58942. Fixes #59949. (#60161) 2019-08-08 13:55:11 -05:00
James Cassell
c954c07271 TRANSFORM_INVALID_GROUP_CHARS: document "ignore" option (#57318) 
Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
 2019-08-08 13:50:20 -04:00
Strahinja Kustudic
54d9d7805d systemd module will now wait on deactivating state (#59471) 
If a service is in the 'deactivating' state running systemctl stop foo,
would wait for the foo service to actually stop before it exits. The
module didn't behave like that and it considered the deactivating state
as if the service wasn't running. This change will align the module with
the systemctl behaviour.
 2019-08-08 12:56:17 -04:00
Jiri Hnidek
577bb88ad8 Added support for syspurpose to redhat_subscribtion module (#59850) 
* Added several unit tests
* Added documentation for new syspurpose option and suboptions
* Simplified specification of module arguments
* Added new changelog file with fragments
 2019-08-08 11:43:05 -04:00
Nathan Swartz
10543c8a4c Facts dev upstream (#57082) 
* Improved netapp_e_facts module.

Added the following facts:
  - storage system segment size
  - cache block size capabilities
  - workload tags
  - storage array hosts
  - host groups
  - list of mapped volumes for each initiator

* Remove proxy specific facts from netapp_e_facts module

* Add unit tests for netapp_e_facts module.
 2019-08-08 11:36:23 -04:00
Drew
6932a5b357 add npipe support to docker_swarm_service (#60073) 
* add npipe support to docker_swarm_service

* add changelog fragment

* tweak changelog fragment formatting

* Update lib/ansible/modules/cloud/docker/docker_swarm_service.py

Co-Authored-By: Felix Fontein <felix@fontein.de>
 2019-08-08 17:25:13 +02:00
yanzhangi
c2e7683926 update ce_aaa_server to fix bugs (#60270) 
* update ce_aaa_server to fix bugs

* update ce_aaa_server to fix bugs
 2019-08-08 11:03:42 -04:00
yanzhangi
66c3e9bb9b update ce_acl to fix bugs (#60274) 2019-08-08 11:03:29 -04:00
Grey Christoforo
29f89b33ba pacman: fix package state detection (#51311) 2019-08-08 16:48:57 +02:00
Ganesh Nalawade
6f0aae256d
Add [junos_lldp_interfaces] model (#59720) 
* Add [junos_lldp_interfaces] model

*  Add new resource module junos_lldp_interface
*  Targets model https://github.com/ansible-network/resource_module_models/pull/40
*  Deprecate junos_lldp_interface module

* Fix CI issues
 2019-08-08 18:23:54 +05:30
Nathan Swartz
f6ae6eb3e0 Remove automatic default group assignment in netapp_e_host module (#60239) 2019-08-08 08:48:09 -04:00
Trishna Guha
87a568da0b
Add nxos_lacp resource module (#59717) 
* Add nxos_lacp resource module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add commands in module doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2019-08-08 16:52:16 +05:30
Manu Lange
6a5cd9a820 prevent recursive logging csharp stackoverflow. (#59503) 
* prevent recursive logging situation.

* Add changelog
 2019-08-08 09:50:41 +10:00
Chris Archibald
2cae0739e9 updates (#60143) 2019-08-07 19:44:44 -04:00
Stuart Pittaway
2c90ddd44d Allow encryption of volumes based off snapshots (#58983) 
Since May 10, 2019 AWS have allowed encrypted volumes to be created from snapshots.  BOTO3 allows this, but the EC2 module does not.  This change removes the restriction.

https://aws.amazon.com/about-aws/whats-new/2019/05/launch-encrypted-ebs-backed-ec2-instances-from-unencrypted-amis-in-a-single-step/
 2019-08-07 16:38:17 -07:00
kfattig
d5a02fb3c8 Updated Docs to clarify how 'become' is handled (#60006) 2019-08-08 08:48:21 +10:00
ximon18
2cca9176a7 Added a Docker Machine dynamic inventory plugin (#54946) 
* Added my Docker Machine dynamic inventory plugin (from https://github.com/ximon18/ansible-docker-machine-inventory-plugin) to begin the process of proposing it for inclusion in Ansible core. There are no integration tests yet. The docker_swarm inventory plugin has such tests but has some concerning note in its 'aliases' file about disabling docker due to test instability and also I wouldn't know at his point how to get Docker Machine installed on the integration test platform.
 2019-08-07 18:14:14 -04:00
silverwizard
5d8302120b Removed breaking type check from nagios module (#49568) 
* Removed extraneous type check from nagios module, in order to allow python 3.x

* Removed now useless import types

* Added changelog fragment

* Update changelog.

* Rebased and removed check due to module adding earlier guardrails

* Updated changelog to mention earlier fix adding now completely removed guardrails

* Remove superfluous type checks. Fix docs type.

* Update ignore.txt.
 2019-08-07 22:43:14 +02:00
Nilashish Chakraborty
7b90e8aec4
Add iosxr_lacp_resource module (#59724) 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2019-08-08 00:13:06 +05:30
Moritz Maisel
5a6003d0ed fix misleading example in docker_image doc (#60207) 
Using docker_image to tag an image as "latest" only updates an existing
tag when used with "force_tag: yes" option. As "latest" is present in
most cases, the option is added to the example to prevent unexpected
behaviour.
 2019-08-07 13:44:37 -04:00
Martin Krizek
164881d871 Remove UnsafeProxy (#59711) 
* Remove UnsafeProxy

Move the work from UnsafeProxy to wrap_var and add support for bytes.
Where wrap_var is not needed, use AnsibleUnsafeBytes/AnsibleUnsafeText
directly.

Fixes #59606

* item is not always text

* Address issues from reviews

* ci_complete
 2019-08-07 10:39:01 -05:00
Nathan Swartz
e80f8048ee Fix netapp_e_volume wait-for-initialization to complete issue. (#58304) 
* Fix netapp_e_volume wait-for-initialization to complete issue.

* Add unit tests for wait_for operations in netapp_e_volume module.
 2019-08-07 11:28:39 -04:00
Stanislav S. Yarmonov
18e0d679dd hcloud: Fix missing labels propagation in inventory plugin. (#57586) 2019-08-07 15:51:09 +02:00
Wojciech Wypior
ce1f25cffd adds module to manage apm acls (#59992) 2019-08-07 06:48:55 -07:00
Wojciech Wypior
77b323459f adds more modules to bigip provision (#59996) 2019-08-07 06:45:27 -07:00
Wojciech Wypior
7b97abf6a2 adds apm module to manage network access components for APM (#59993) 2019-08-07 06:44:57 -07:00
Wojciech Wypior
47e3ed8100 adds module to manage device self signed certificates (#59994) 2019-08-07 06:44:41 -07:00
Wojciech Wypior
0d92abad7d adds module to manage snat translations (#59995) 2019-08-07 06:43:10 -07:00
Wojciech Wypior
57cbfae797 added user information collection to bigip_device_info (#60016) 2019-08-07 06:42:43 -07:00
Jill R
4308b87d72 Don't truncate cidr_ipv6 addresses in ec2_group.py (#59106) 
* Better cidr_ipv6 validation in ec2_group.py

* Improve warning/error handling, add changelog

* Update unit test for ipv6 validation

* Fix logic that was causing non /128 cidrs with host bits to not be handled
 2019-08-07 08:39:55 -04:00
Marat Sharafutdinov
8751319820 Add wait_sleep parameter for the k8s module (#59714) (#59854) 2019-08-07 21:27:54 +10:00
MyronFanQiu
8c0ec5fd82 delete the check for the resource group (#58492) 2019-08-07 05:36:14 -04:00
Hugh
041ede30b3 Update azure_rm_appserviceplan_facts.py (#58847) 
<!--- Your description here -->

+label: docsite_pr
 2019-08-07 05:25:36 -04:00
Diane Wang
d5bff7a87f VMware: vmware_export_ovf fix timeout and export path issue (#60062) 
* fix timeout and export path issue

* change path type
 2019-08-07 05:05:42 -04:00
Martin Nečas
279617a94e add docs (#60192) 2019-08-07 04:41:33 -04:00
Jordan Borean
45d0e5994a
win_user - use proper error code when failing to validate creds (#60181) 2019-08-07 18:28:44 +10:00
sushma-alethea
92187ae53e icx: new module icx_command (#59903) 
* new module

* new cliconf

* cliconf

* icx cliconf

* icx test units module

* icx units module

* icx banner unit test

* added notes

* new changes

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* new module

* new cliconf

* cliconf

* icx cliconf

* icx test units module

* icx units module

* icx banner unit test

* added notes

* new changes

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* new module icx_command

* PR issue

* new PR fix
 2019-08-07 13:27:24 +05:30
Martin Nečas
fb87bafaae ovirt vnic network filter fix (#59727) 
* init network filter fix

* add check_params

* update migratable state

* update pass through check

* update pep8 syntax

* allow remove description

* update_check change default attr for network_filter and qos

* update_check qos and network filter update

* add docs about exeption

* remove blank space

* update docs and add comments to conditions

* update comment

* update migratable var for pass_through enabled
 2019-08-07 03:49:36 -04:00
Daniel Mellado Area
7b583e114d Remove description from junos_l3_interfaces (#60058) 
The description will be just handled by the _interfaces module, this one
will be just dealing with l3 config options.
 2019-08-07 13:10:49 +05:30
The Magician
d165223f74 New Module: gcp_compute_autoscaler_facts (#60097) 2019-08-07 01:09:23 -04:00
dx0xm
24274b72c9 UCS: new module ucs_vlan_find (#59220) 
* UCS: new module to find vlan(s) based on different criteria
* extending ucs doc
* doc update
* Minor fix
 2019-08-07 09:02:23 +05:30
Chris Archibald
5673482460 bug fix (#60140) 2019-08-06 17:53:29 -04:00
Matt Martz
923e21836b
Move plugin loader playbook dir additions back to Playbook instead of PlaybookCLI (#59557) 
* Move plugin loader playbook dir additions back to Playbook instead of PlaybookCLI. Fixes #59548

* Restore cli additions
 2019-08-06 15:58:15 -05:00
Alex Stephen
61d60d07d1 no logging for service account contents (#60149) 
* no logging for service account contents

* changelog

* fixes
 2019-08-06 15:27:11 -05:00
Jordan Borean
94f5e2d9ed
ansible-galaxy - ignore cert failures for login (#59959) 2019-08-07 05:59:34 +10:00
Nathan Swartz
acbffce079 Host dev upstream (#57086) 
* Improve netapp_e_host module

Add host type strings for windows, windows cluster, linux and vmware to netapp_e_host module
Make host port information case-insensitive in netapp_e_host module
Fix port removal and default group.
Fix port reassignment in netapp_e_host module.
Fix port label or address change within existing host object in module netapp_e_host
Add unit and integration tests

* Created new unit test for netapp_e_host module
 2019-08-06 15:01:22 -04:00
Barry Peddycord III
80e5b2ade5 Update broken NCLU documentation link (#60009) 2019-08-06 13:46:31 -04:00
Wojciech Wypior
2af67f0dce fixes issue with RD encoding in names (#59990) 
fixes issue with file download function on ASM file transfer endpoints
corrects doc fragments
removes not used parameters
corrects various sanity failures previously ignored across multiple modules
 2019-08-06 10:11:02 -07:00
monobaila
54b04f227e Update validate example in copy.py (#60053) 2019-08-06 11:32:40 -04:00
Timal Peramune
faebe22439 Conflicting Documentation (#60135) 
##### SUMMARY
"state" parameter isn't "required" since the default is already set to "present"
 2019-08-06 11:32:12 -04:00
Timal Peramune
828e346f2c Conflicting Documentation (#60136) 
##### SUMMARY
"state" parameter isn't "required" since the default is already set to "present"
 2019-08-06 11:31:13 -04:00
Timal Peramune
1c0b733489 Conflicting Documentation (#60137) 
##### SUMMARY
"state" parameter isn't "required" since the default is already set to "present"
 2019-08-06 11:27:50 -04:00
Nathan Swartz
a9aeabb456 Improve netapp_e_storagepool and add units. (#57095) 
Refactored module to use eseries base class
Removed E322 and E326 for netapp_e_storage module from the ignore.txt file
Updated version_added quotes in netapp_e_storagepool
 2019-08-06 10:02:14 -04:00
Nilashish Chakraborty
2c432f8bc7
Add vyos_l3_interfaces resource module (#59929) 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2019-08-06 19:30:58 +05:30
Daniel Mellado Area
e3681c049c
Add junos vlans resource module (#59041) 2019-08-06 16:00:01 +02:00
Abhijeet Kasurde
2a1393e0e1
VMware: Check dvswitch presence before accessing it (#60052) 
Check if dvswitch object is not None before accessing it's
properties such as UUID. This can be due to two reason

1. Permission issues
2. There is no association between given distributed virtual portgroup
distributed virtual switch

Fixes: #59952

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2019-08-06 10:38:50 +05:30
kfattig
dd7b9627ad Runas docs (#60082) 
* Mention seclogon requirement in runas docs

* Mention seclogon requirement in Win become docs
 2019-08-06 10:44:17 +10:00
Alex Stephen
ac5228390c Removing validate-module exceptions on GCP modules (#60113) 
* facts modules with new types
* remove ignores on sanity tests
* removing new modules
 2019-08-05 16:17:06 -07:00
The Magician
2a64a84667 New Module: gcp_cloudtasks_queue_facts (#60095) 2019-08-05 18:38:09 -04:00
The Magician
4317a97c42 New Module: gcp_compute_autoscaler (#60096) 2019-08-05 18:38:00 -04:00
The Magician
26a2d84dba New Module: gcp_compute_snapshot (#60098) 2019-08-05 18:37:51 -04:00
The Magician
820cfbbb77 Bug fixes for GCP modules (#60089) 2019-08-05 18:26:14 -04:00
The Magician
8241fd88de Bug fixes for GCP modules (#60090) 2019-08-05 18:26:06 -04:00
The Magician
fcc869ab7a Bug fixes for GCP modules (#60091) 2019-08-05 18:25:57 -04:00
The Magician
0234937ca3 Bug fixes for GCP modules (#60092) 2019-08-05 18:25:49 -04:00
The Magician
de8d428157 Bug fixes for GCP modules (#60093) 2019-08-05 18:25:41 -04:00
The Magician
c1a99c390c Bug fixes for GCP modules (#60088) 2019-08-05 18:16:26 -04:00
The Magician
5e0bcc60b5 New Module: gcp_cloudtasks_queue (#60094) 2019-08-05 16:47:52 -04:00
Andrey Klychkov
d2cc9f5f06 Bugfix 60043: turn off the default db warning where it doesn't make sense (#60105) 2019-08-05 16:28:00 -04:00
Felix Fontein
aecdfd397e ecs_taskdefinition_facts: rename to ecs_taskdefinition_info (#60023) 
* Rename ecs_taskdefinition_facts to ecs_taskdefinition_info.
 2019-08-05 12:47:35 -07:00
Nathan Swartz
41235ac05a Improve netapp_e_hostgroup and add unit tests. (#57094) 
* Improve netapp_e_hostgroup and add unit and integration tests.

netapp_e_hostgroup was refactored for maintainability and improved
documentation clarity.

* Remove ignore sanity check E338 for netapp_e_hostgroup module

* Add __future__ import (absolute_import, division, print_function) to test_netapp_e_hostgroup unit test.
 2019-08-05 13:19:23 -04:00
Xu Yuandong
13c8f7b00c It is necessary to undo mmi-mode enable after running commands. (#60071) 2019-08-05 11:52:25 -04:00
Xu Yuandong
16e237e095 set mmi-mode enable to run commands nad unset after running. (#60075) 2019-08-05 11:52:11 -04:00
Andrew Gaffney
32a8d8ae2a
Move definition of UnixHTTPSConnection behind guard (#60049) 
This allows module_utils/urls.py to not immediately fall over when run
against a python without SSL support.
 2019-08-05 10:46:47 -05:00
Matt Martz
df6b8d2a4a
Fix async output with adhoc callbacks. Fixes #15988 (#59935) 2019-08-05 10:36:41 -05:00
Chris Archibald
be24db8886 New module na_ontap_object_store (#59048) 
* New module object store

* fixes

* fix tests
 2019-08-05 09:27:38 -04:00
Lukas Kämmerling
38848a4b0c hcloud: Add basic hcloud_route module (#59908) 2019-08-05 14:35:05 +02:00
Trishna Guha
e46237d705
Fix nxos_facts httpapi (#60055) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2019-08-05 18:01:29 +05:30
Lukas Kämmerling
8a5bde798a hcloud: Add hcloud_server_network module (#60061) 2019-08-05 14:06:22 +02:00
Lukas Kämmerling
0377c51c3a hcloud: Add hcloud_subnetwork module (#59781) 2019-08-05 11:13:28 +02:00
Trishna Guha
021b1810c9
Add nxos_vlans resource module (#59294) 
* Add nxos_vlans resource module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comments

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix CI failure and udpate tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add commands in module doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2019-08-05 12:50:16 +05:30
Mike Wiebe
9610f2b8ac NX-OS Telemetry Resource Module (#59126) 
* Combined telemetry module commit

* Minor fixes

* Add back whitespace

* Add telemetry subscription support and simplify

* Remove comment line

* Make ansibot happy

* Create common build_args method

* More ansibot fixes

* Refactored integration tests, remove old files

* Add subscription tests

* Add integration tests

* Update module docs

* Test updates

* Address review comments

* Comment should be one line, not two

* Address Trishna comments

* State deleted should purge all config

* Remove misleading comment

* Doc fixes

* Fix source int bug and remove local debug msg

* Add additional integration test checks
 2019-08-05 11:35:46 +05:30
Simon Dodsley
178db5f3ed Fix bug in purefa_facts where remote pgroup without a schedule is skipped (#60030) 2019-08-04 04:29:23 -04:00
Wojciech Wypior
ee0c19e519 corrected lib imports to work with python 2.x (#60017) 2019-08-02 22:11:03 -07:00
Wojciech Wypior
1268993506 added previously omitted parameter in gtm topology module (#60015) 2019-08-02 22:09:20 -07:00
Wojciech Wypior
95ef456bb7 fixes options parameter idempotency issue on v14.x (#60019) 2019-08-02 22:06:07 -07:00
Wojciech Wypior
d224a7ccf6 fixes idempotency issues with IPV6 addresses (#60021) 2019-08-02 22:03:33 -07:00
Wojciech Wypior
2e54ac37b0 refactors bigip_firewall_log_profile to use correct patterns (#60014) 
doc correction in bigip_pool
changes functions in bigip_message_routing_route
 2019-08-02 14:49:05 -07:00
Wojciech Wypior
c9a9621a02 fixes issue with recieve parameter idempotency (#59999) 
fixes assert statements in unit tests
 2019-08-02 13:29:40 -07:00
Sam Doran
a9fe21bc62
docker_compose - use valid variable in exception message (#60020) 2019-08-02 15:57:22 -04:00
Andrey Klychkov
41e198b429 Issue 59955: add example to postgresql_query module (#59979) 2019-08-02 14:30:17 -04:00
Matt Davis
8d1f658ce4
move CLI entrypoints under ansible package (#60004) 
* needed so ansible-test can always find the right ones to copy to a target
* renamed the underlying scripts to be properly accessible as Python modules
 2019-08-02 11:27:02 -07:00
Timal Peramune
1b246d89e3 Conflicting documentation (#59982) 
##### SUMMARY
The "mode" parameter is already 'push' by default, so "required: true" isn't necessary.
 2019-08-02 12:49:20 -04:00
Matt Martz
38eee51057
Fix issue with empty cow_whitelist (#59946) 
* Fix issue with empty cow_whitelist. Fixes #45631

* Account for None
 2019-08-02 11:13:08 -05:00
Felix Fontein
f3e20346cb
Google: gcpubsub_facts -> gcpubsub_info (#57668) 
* Rename gcpubsub_facts -> gcpubsub_info.

* Update porting guide and add changelog fragment.
 2019-08-02 17:27:28 +02:00