Commit graph

280 commits

Author SHA1 Message Date
Monty Taylor
dd9c292861 Update docstring to show port ranges as optional 2015-07-06 18:53:31 -04:00
David Shrewsbury
6933407cd4 Correct port matching logic
Port matching logic did not take into account recent shade change
to equate (None, None) to (1, 65535) when Nova is the backend.

Also, this encapsulates the port matching logic into a single function
and heavily documents the logic.
2015-07-06 18:50:03 -04:00
David Shrewsbury
8664c88417 Change required parameters for rules module
The ports and protocol are no longer required (and now depends on
a new version of shade).
2015-07-06 18:50:03 -04:00
Monty Taylor
9f03302b68 Use int in the parameter list instead of casting 2015-07-06 18:50:03 -04:00
dagnello
2e8daa2330 Resolving issues in rule comparison algorithm
Port range min/max values are at times represented as string and
compared to int equivalents.  This fix explicitly ensures all
port range values are ints for proper comparisons.
2015-07-06 18:50:03 -04:00
David Shrewsbury
f027e75976 Compare ports as strings
Ports as returned from shade are ints. They are strings as they come
in to the module.
2015-07-06 18:50:03 -04:00
David Shrewsbury
9d0c8b0507 Fix syntax error 2015-07-06 18:50:03 -04:00
Monty Taylor
0e5942d7e7 Return rule object 2015-07-06 18:50:03 -04:00
David Shrewsbury
16b3b72294 Update secgroup rules module for latest shade
This allows the rules module to work against either nova or neutron
for handling security groups. New parameters for 'direction' and
'ethertype' are added.

Check mode is supported with this version.
2015-07-06 18:50:03 -04:00
David Shrewsbury
5b6c6cac20 Recongnize None and -1 port equivalency
shade 0.7.0 represents disabled min/max ports as None (in the
neutron style) rather than -1. Recognize this as the same as -1.
2015-07-06 18:50:03 -04:00
David Shrewsbury
5758b4ebdc Fix id value reference 2015-07-06 18:50:03 -04:00
David Shrewsbury
8f2e70a1c1 Update rules mode for latest shade
Shade 0.7.0 normalized the security group data that is returned,
when using nova, to look more like neutron security group data.
This adjusts for that change.
2015-07-06 18:50:03 -04:00
dagnello
b98e6663e8 Minor fixes for os_security_group_rule module
Was not able to use this module as it was.  The changes submitted
resolved the issues I ran into in order to get it working.
2015-07-06 18:50:03 -04:00
dagnello
d35df1f217 Minor fixes for os_security_group_rule module
Was not able to use this module as it was.  The changes submitted
resolved the issues I ran into in order to get it working.
2015-07-06 18:50:02 -04:00
Davide Guerri
a9301ba918 Fix invalid syntax in openstack_module_kwargs call 2015-07-06 18:50:02 -04:00
Monty Taylor
08b4bb42c4 Fix example code syntax 2015-07-06 18:50:02 -04:00
Monty Taylor
08b2f31915 Add OpenStack Security Group Rule module 2015-07-06 18:50:02 -04:00
Mike Putnam
6c0e264806 Add missing GPLv3 License header
Fixes #1643
2015-07-03 22:57:53 -05:00
David Shrewsbury
653060dc47 Update os_router to the latest version
This version uses the latest shade for a cleaner interface,
support for check mode, and updating an existing router.
2015-07-03 10:26:08 -04:00
Monty Taylor
edce6a41cf Add OpenStack Router module
Also deprecate old quantum_router module
2015-07-03 10:26:07 -04:00
Toshio Kuratomi
ff69ce7912 Merge pull request #1638 from j2sol/bugfix/os_server_afip_doc
Document auto_floating_ip argument
2015-07-01 08:15:53 -07:00
Toshio Kuratomi
968386cba3 Merge pull request #1631 from emonty/features/single-cloud-details
Add filter ability to OpenStack os-client-config module
2015-07-01 08:07:37 -07:00
Toshio Kuratomi
02b6df3160 Fix indentation levels in os_keypair 2015-07-01 05:00:39 -07:00
Toshio Kuratomi
edad5c80ff Few minor things from review of the pull request 2015-06-30 13:18:56 -07:00
Toshio Kuratomi
8703fb3c76 Merge pull request #1045 from emonty/feature/os_keypair
Add OpenStack Keypair module
2015-06-30 13:17:27 -07:00
Jesse Keating
ddc78c82a4 Document auto_floating_ip argument 2015-06-29 14:06:50 -07:00
David Shrewsbury
7970924bd5 Use newest documentation style for return value. 2015-06-29 15:55:15 -04:00
David Shrewsbury
e6fc129013 Add a note about the return value. 2015-06-29 14:49:13 -04:00
Monty Taylor
7b0b75ceed Fix dict syntax typo 2015-06-29 10:34:24 -04:00
Davide Guerri
304e187a52 Fix reuse argument documentation 2015-06-26 14:53:48 +01:00
Davide Guerri
e3d9b51cbb Update os_floating_ip with new shade methods 2015-06-26 12:53:20 +01:00
David Shrewsbury
bed420cd53 Update os_keypair for latest shade
Uses the latest version of shade for cleaner code. Also, always
return the key dict whether we create the key, or it already exists.
The example using public_key_file is corrected to use a full path
since ~ is not converted for us.
2015-06-25 12:19:20 -04:00
Monty Taylor
850ed126e2 Remove duplicate shade requirement 2015-06-19 17:39:57 -04:00
Monty Taylor
94a8b6dccc Make sure we're always returning objects too 2015-06-19 17:08:36 -04:00
dagnello
d7f65af6d9 Resolving secgroup.id issue in this module
secgroup['id'] was not being returned in all cases where the
specified security group exists.
2015-06-19 17:07:20 -04:00
Brian Coca
6449a01311 Merge pull request #1536 from emonty/feature/os_security_group
Return OpenStack secgroup, not just id
2015-06-19 01:52:43 -04:00
Monty Taylor
02d0a73906 Move the order of argument processing 2015-06-18 08:01:27 -04:00
Davide Guerri
82dc5c4394 Avoind using lookup() in documentation
lookup() is currently broken (current Ansible devel branch), so better to avoid
it in our examples.
2015-06-18 08:01:27 -04:00
Monty Taylor
a226701efe Add OpenStack Keypair module
Also deprecate old nova_keypair module.
2015-06-18 08:01:24 -04:00
Monty Taylor
759c2de7f9 Add filter ability 2015-06-18 07:56:50 -04:00
Monty Taylor
d8c51a67f3 Actually use changed variable 2015-06-17 08:47:14 -04:00
Monty Taylor
1a11f07d29 Return the secgroup for all present states 2015-06-17 08:02:34 -04:00
Monty Taylor
5609d1dc5a Return resource objects from OpenStack modules
It's not uncommon for people to want to do additional things after
creating a module. Also, add a note about it to the dev notes.
2015-06-17 05:24:08 -04:00
Monty Taylor
ef22008cac Return secgroup, not just id 2015-06-17 04:25:55 -04:00
Brian Coca
898e338318 minor doc fixes 2015-06-16 18:56:24 -04:00
Monty Taylor
ff0fc73d64 Add OpenStack Floating IP Module
Also deprecate the two old quantum floating ip modules.
2015-06-16 15:50:31 -07:00
Brian Coca
d393df4bce Merge pull request #1053 from emonty/feature/os_security_group
Add OpenStack Security Group module
2015-06-16 18:19:53 -04:00
Brian Coca
7adc911372 Merge pull request #1047 from emonty/feature/os_object
Add OpenStack Object module
2015-06-16 18:18:14 -04:00
Brian Coca
0367a923c7 Merge pull request #1044 from emonty/feature/os_ironic_node
Add Ironic Node module
2015-06-16 18:17:12 -04:00
Brian Coca
74b7a72c3f Merge pull request #1043 from emonty/feature/os_ironic
Add Ironic module
2015-06-16 18:16:21 -04:00
Greg DeKoenigsberg
28a869a030 Updating cloud modules with proper github author information 2015-06-15 14:41:22 -04:00
Julia Kreger
47113727ee Updating os_ironic_node module
Updating the os_ironic_node module to the most recent version
including support for power and maintenance states.
2015-06-14 13:03:42 +03:00
Monty Taylor
7f8b63b757 Add OpenStack Group content module 2015-06-14 00:12:48 +03:00
Monty Taylor
5b6c0c3697 Add developer docs for the OpenStack modules 2015-06-11 02:29:28 +02:00
David Shrewsbury
bf699e55f6 Remove os_security_group_rule module
The rules module will have it's own branch.
2015-06-10 14:14:01 -04:00
David Shrewsbury
e5cedc617a Remove 'result' value
This value is pretty much useless, and a holdover from the old
module code. Let's remove it.
2015-06-10 14:02:37 -04:00
Monty Taylor
62073565e1 Update version added 2015-06-09 19:43:27 -04:00
David Shrewsbury
5be1b64b85 Update the docstring for os_security_group
Indicate that idempotence is on security group names, and give
an example for updating a security group description.
2015-06-09 16:18:38 -04:00
David Shrewsbury
c298741aa6 Update for latest shade API
Shade version 0.7.0 introduces new API methods for creating,
deleting, and updating security groups. Let's use those and
clean up the module.
2015-06-09 15:24:38 -04:00
Julia Kreger
c040ae5374 Updating os_ironic module
Updating os_ironic module to the most recent version accounting for
changes in Ansible devel branch and the shade library since the
original creation of the module.
2015-06-05 23:22:54 -04:00
Monty Taylor
4e6f879feb Add Ironic module 2015-06-05 23:22:54 -04:00
Brian Coca
ccfc9d2f6b Merge pull request #1436 from emonty/feature/os_client_config
Add OpenStack Client Config module
2015-06-05 22:19:18 -04:00
Monty Taylor
86fc12e279 Update doc params and version_added 2015-06-05 16:01:15 -04:00
Monty Taylor
3ffebeac5b Use the delete method from shade
Sigh. Turns out glance v1 and glance v2 delete images differently too.
2015-06-05 15:58:10 -04:00
Monty Taylor
bd26df1c57 Don't update image properties if we're deleting 2015-06-05 15:58:10 -04:00
Monty Taylor
0bdf9f4d27 Add OpenStack Image module
Also deprecate old glance_image module
2015-06-05 15:58:10 -04:00
Monty Taylor
1e14e51150 Add OpenStack Security Group support
Two modules - one for security groups and one to manage rules in a
security group.
2015-06-04 12:27:10 -04:00
Monty Taylor
1b5b1cbfe8 Add missing state parameter 2015-06-04 12:10:07 -04:00
Monty Taylor
9e56b42574 AnsibleModule takes a dict as a param 2015-06-04 11:42:39 -04:00
James Cammarata
3256db99e2 Fixing digital_ocean documentation and a bug in os_subnet 2015-06-01 15:34:16 -07:00
Toshio Kuratomi
55d48a7a82 Finish up cleanups to modules:
* Add python>= 2.6 to documented requirements when a module's deps need
  python>= 2.6 so we know when a module can use python2.6+ syntax
* Remove BabyJSON usage
* Change modules to use if __name__ == '__main__' so that they can
  potentially be unittested

The BabJSON changes Fixes #1211
2015-06-01 15:34:16 -07:00
Brian Coca
145361aea3 Revert "Add deprecated documentation for _quantum_subnet"
cause it was already added

This reverts commit 3fa32c4984.
2015-06-01 15:24:15 -07:00
Toshio Kuratomi
9927e109b7 Add deprecated documentation for _quantum_subnet 2015-06-01 15:22:37 -07:00
Brian Coca
4348475ed3 doc fixes 2015-06-01 15:06:42 -07:00
David Shrewsbury
3692518643 Update os_subnet module for latest shade
Shade can now handle creating, updating and deleting subnets.
This cleans up the module to take advantage of that.
2015-06-01 15:03:44 -07:00
David Shrewsbury
abbf8a40ca Rename os_subnet to os_subnet.py 2015-06-01 15:03:44 -07:00
Monty Taylor
ef1c7eef5b Add OpenStack Subnet module
Also deprecated old quantum_subnet module
2015-06-01 14:59:14 -07:00
Monty Taylor
ce556a053e Return a list of OpenStack clouds
The main use of this is to feed jinja templating, so structure the
data returned slightly better for that purpose.
2015-06-01 11:01:17 -05:00
Monty Taylor
718c13bdf2 Add OpenStack Client Config module
All of the ansible OpenStack modules are driven by a clouds.yaml config
file which is processed by os-client-config. Expose the data returned by
that library to enable playbooks to iterate over available clouds.
2015-05-28 16:14:20 -04:00
Brian Coca
58c6c3dd03 Merge pull request #1046 from emonty/feature/os_network
Add OpenStack Network module
2015-05-26 13:46:28 -04:00
Jesse Keating
a14aee5239 Add an openstack servers actions module
This module supports a few of the server actions that are easy to
initially impiment. Other actions require input and provide return
values in the API calls that will be more difficult to impliment, and
thus are not part of this initial commit.
2015-05-21 16:19:57 -07:00
Monty Taylor
6606e4f68d Add OpenStack Network module
Also, deprecate the old quantum network module
2015-05-20 11:41:24 -07:00
Brian Coca
5011593ee3 fixed typo on novaclient var 2015-05-19 10:52:48 -04:00
James Cammarata
576ca33bdc Fixing digital_ocean documentation and a bug in os_subnet 2015-05-12 10:32:43 -05:00
Toshio Kuratomi
1f99382dfb Finish up cleanups to modules:
* Add python>= 2.6 to documented requirements when a module's deps need
  python>= 2.6 so we know when a module can use python2.6+ syntax
* Remove BabyJSON usage
* Change modules to use if __name__ == '__main__' so that they can
  potentially be unittested

The BabJSON changes Fixes #1211
2015-05-11 13:21:17 -07:00
Brian Coca
ec5cd89d7c Revert "Add deprecated documentation for _quantum_subnet"
cause it was already added

This reverts commit 3fa32c4984.
2015-05-05 17:14:04 -04:00
Toshio Kuratomi
3fa32c4984 Add deprecated documentation for _quantum_subnet 2015-05-05 10:50:24 -07:00
Brian Coca
2dc0343d63 added deprecated doc entry 2015-05-04 19:42:26 -04:00
Brian Coca
a6eafb87c8 minor doc fixes 2015-05-04 12:06:57 -04:00
David Shrewsbury
28488f1b84 Update os_server for shade flavor API changes
Latest shade fixes the flavor API so that raw objects are not
returned.
2015-05-04 11:36:57 -04:00
Monty Taylor
3834680f43 Add OpenStack Server module
Also deprecated old nova_compute module
2015-05-04 11:36:57 -04:00
Brian Coca
9a216915e9 doc fixes 2015-05-04 11:06:02 -04:00
Brian Coca
3496bac18d Merge pull request #1057 from emonty/feature/os_server_volume
Add OpenStack Server Volume module
2015-05-04 10:57:13 -04:00
Brian Coca
0060c47b8c Merge pull request #1058 from emonty/feature/os_subnet
Add OpenStack Subnet module
2015-05-04 10:56:25 -04:00
Brian Coca
6ed317df7c Merge pull request #1059 from emonty/feature/os_volume
Add OpenStack Volume module
2015-05-04 10:56:08 -04:00
Brian Coca
75319519cc Merge pull request #1182 from sky-shiny/os_validate_fip_network
Validate openstack floating ip against provided network name.
2015-05-04 10:48:00 -04:00
Pascal Borreli
f29a6ec54d Fixed typos 2015-05-04 12:54:03 +01:00
Brian Coca
1fe7da5bea Merge pull request #1180 from sky-shiny/os_multi_region_support
Adding openstack multiregion support for floating ip module.
2015-04-30 08:48:29 -04:00
David Shrewsbury
c451fbdd61 Update os_server_volume for latest shade
The shade volume API was updated to return a dict rather than the
object as returned by cinder.
2015-04-23 10:52:08 -04:00
David Shrewsbury
f4600edeb8 Update os_volume for latest shade
The shade volume API was updated to return a dict rather than the
object as returned by cinder.
2015-04-23 10:37:43 -04:00
Brian Coca
178d3ea133 minor doc fixes 2015-04-22 16:40:59 -04:00
Brian Coca
b0cf0ae912 Merge pull request #1056 from emonty/feature/os_server_facts
Add OpenStack Server facts module
2015-04-22 15:21:40 -04:00
mcameron
6498303786 Net_id already present, remove unnecessary lookup. 2015-04-21 13:22:04 +01:00
mcameron
cb2ba9fe31 Valodate fip is on the correct network 2015-04-21 13:21:56 +01:00
mcameron
394152f4ac Adding openstack multiregion support 2015-04-21 11:46:38 +01:00
Andrey Trubachev
1c8a8e8900 Fix mess of ipv6 and ipv4 addresses in private_ip 2015-04-20 15:28:56 +01:00
David Shrewsbury
c241296a20 Update os_subnet module for latest shade
Shade can now handle creating, updating and deleting subnets.
This cleans up the module to take advantage of that.
2015-04-16 09:19:29 -04:00
David Shrewsbury
b854a28dfb Rename os_subnet to os_subnet.py 2015-04-16 09:17:57 -04:00
David Shrewsbury
4a233a5a8f Recognize when volume attach/detach is not necessary
Do not attempt to attach an already attached volume.
Likewise, do not attempt to detach a volume that is not
attached.

This version adds support for check mode.
2015-04-07 14:37:06 -04:00
Brian Coca
c01a18d5ca minor docfixes 2015-04-02 21:07:41 -04:00
Monty Taylor
d7e65eab41 Add OpenStack Volume module 2015-03-31 19:42:41 -04:00
Monty Taylor
5d7b6aae04 Add OpenStack Subnet module
Also deprecated old quantum_subnet module
2015-03-31 19:42:09 -04:00
Monty Taylor
f6cf1411a1 Add OpenStack Server Volume module 2015-03-31 19:41:44 -04:00
Monty Taylor
cb6ebb1c03 Add OpenStack Server facts module 2015-03-31 19:41:17 -04:00
Monty Taylor
f2c6619826 Add OpenStack Object module 2015-03-31 19:36:24 -04:00
Monty Taylor
c9f1e441f5 Add OpenStack Auth module
Use this to pre-auth or to get a copy of the service catalog.
2015-03-31 19:32:05 -04:00
Monty Taylor
4656797389 Add Ironic Node module 2015-03-31 19:30:22 -04:00
Brian Coca
5641b1ff73 undeprecated openstack modules as new ones are not making into release 2015-03-19 15:15:17 -04:00
Monty Taylor
2e4091f31d One more OpenStack deprecation notice
Fixes #858
2015-02-27 07:05:03 -05:00
Monty Taylor
cae8241ea7 Add deprecation notices for old OpenStack modules 2015-02-26 21:12:27 -05:00
Monty Taylor
dd4a6e86bd Deprecate old OpenStack modules
There are a completely new set of modules that do all of the things like
keystone v3 and auth_plugins and the like correctly. Structurally
upgrading these would have been massively disruptive and there is no
real good way to do so without breaking people.

These modules should be kept around for several releases - they still
work for people - and they should get bug fixes. But they should not
take new features. New features should go to the os_ modules.
2015-02-26 10:00:49 -05:00
Jorge-Rodriguez
57f0d22482 Added optional parameter scheduler_hints. 2015-02-20 12:51:18 +02:00
mcameron
24f8792bab More general output. 2015-02-16 15:08:39 +00:00
mcameron
8eb7870a5e Useful log output. 2015-02-16 14:58:53 +00:00
Harri Hämäläinen
b354423bae Fixed typo in comment 2014-12-11 18:59:42 +02:00
Francois Deppierraz
f69a7553f7 Fix auto_floating_ip documentation
The default value is 'no' instead of the currently documented 'yes'.

See cloud/openstack/nova_compute.py line 543:

        auto_floating_ip                = dict(default=False, type='bool'),
2014-12-03 16:06:50 +01:00
John Batty
08b2752080 Fix get_flavor_id() when flavor_ram is specified
Without this fix, _get_flavor_id() fails to find a matching flavor if
both:
* the flavor_ram parameter is specified
* the first flavor in the list does not match.

The bug is simply that the module.fail_json() call lies within the loop
iterating through the flavors.  This call should only be made if the
loop completes and no matching flavors have been found.
2014-11-13 13:26:20 +00:00
Francois Deppierraz
2dee52616d Fix a typo in nova_compute documentation string
Without this patch, ansible-doc was failing this way:

$ ansible-doc nova_compute
Traceback (most recent call last):
  File "/home/francois/WORK/dev/ansible/bin/ansible-doc", line 324, in <module>
    main()
  File "/home/francois/WORK/dev/ansible/bin/ansible-doc", line 316, in main
    text += get_man_text(doc)
  File "/home/francois/WORK/dev/ansible/bin/ansible-doc", line 112, in get_man_text
    desc = " ".join(opt['description'])
KeyError: 'description'
2014-11-10 09:30:29 +01:00
Brian Coca
19ed60196c added __init__.py to new cloud subcategories so builds work again 2014-11-05 11:07:19 -05:00
Brian Coca
0c4adcb2c6 made subcategories for cloud modules for better organization 2014-11-04 11:18:09 -05:00