Commit graph

45640 commits

Author SHA1 Message Date
Chris Van Heuveln
6c5de9e6eb NxosCmdRef: fix python2 ordereddict import (#58397)
* NxosCmdRef: fix ordereddict import checks for pre-2.7

* Fix ws
2019-07-03 09:41:29 +05:30
Brian Coca
ee4cba1b85 ensure bytes in run_command (#58411)
* ensure we pass bytes to run_command

* changed tests for new behaviour

* dont b the pytest

* fixes by sivel
2019-07-02 17:07:48 -05:00
s-hertel
7ec31194a5 Ensure only running instance facts are retrieved to match the following assertion
Otherwise lingering terminated instances may be in the result
Use the instance profile arn or the role name, but not the role arn
Mark tests as unstable
2019-07-02 17:48:07 -04:00
Will Thames
a6d757e074 Ensure block device instance creation outputs instances
Not waiting outputs results in a format that will never
be matched by the tests

Ensure instances get tidied up

Allow ec2:ReportInstanceStatus

ec2_instance: Improve test cleanup on failing tests

Improve describe/modify attribute error handling

Address feedback on PR
2019-07-02 17:48:07 -04:00
Andrea Tartaglia
da1a621bd9 Removed nested role for ec2_instance tests
Also moved environment setup and environment cleanup to separate task
files

Added CI group

Updated c4.large instances to t3.nano, use ENA enabled AMI

Updated AMIs with Amazon Linux AMI

Updated us-east-1 AMI id

Specify EBS size

typo, volume_size

Removed 'state: running', updated AMI with amz ami

Also added several wait: false to speed things up

Check for instance state, correctly

Accept pending as valid state

tags_and_vpc_settings do not wait for instance to complete

wait for termination protected instance

Updated IAM role name to match with policy

Skip env cleanup when in CI

Do not wait instance in external_resource_attach

ENI remove is done in env_cleanup/CI

wait some time for instance_profile instnace to be up

Updated ebs_optimized_images

Corrected task name

Added aws_cleanup var in cloud-config-aws

typo in runme

default aws_cleanup to true
2019-07-02 17:48:07 -04:00
Chris Archibald
30a7670f36 fixes (#58598) 2019-07-02 17:35:37 -04:00
lijok
63bdd0d6cd VMware: looking up maxMksConnections in incorrect location (#58061)
maxMksConnections is contained in vim.vm.ConfigInfo not vim.vm.VirtualHardware

Fixes: #58060

Signed-off-by: lijok <28689084+lijok@users.noreply.github.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-02 11:49:00 -07:00
Fred-sun
b2554ab3b7 Update azure_rm_trafficmanagerprofile related document (#58616)
* Update azure_rm_trafficmanagerprofile related document
2019-07-02 13:13:35 -04:00
Martin Nečas
4e230dbfb6 ovirt add version added to ipv6 (#58626) 2019-07-02 13:04:14 -04:00
Andrey Klychkov
e5203a0f39 postgresql_ext: add a changelog fragment for PR 58381 (#58634) 2019-07-02 13:03:01 -04:00
Matt Martz
0e9cfd3ee8
Fix sanity tests that are failing with LC_ALL set (#58604) 2019-07-02 10:56:12 -05:00
dpoon
a9fcd1d197 Handle mode-setting of symlink to RO filesystem (#58564)
Fix for https://github.com/ansible/ansible/issues/58562
2019-07-02 11:15:39 -04:00
GarretSchumann
6e9bcc2579 Check nfs_version properly (#58574)
* Check nfs_version properly
original commit: 63f81d20db

* Add a space to fix the identation
2019-07-02 10:37:11 -04:00
Pluggi
7f15331510 Add build.target option to docker_image module (#58487)
Signed-off-by: Antoine Bardoux <pluggi512@gmail.com>
2019-07-02 09:42:35 -04:00
Andrey Klychkov
4da6d8cbf9 postgresql_ext: add version parameter (#58381)
* postgresql_ext: add version new option

* postgresql_ext: add version new option, fix ssl tests

* postgresql_ext: add version new option, fix tests

* postgresql_ext: add version new option, fix examples

* postgresql_ext: add version new option, fix the doc

* postgresql_ext: add version new option, fix examples

* postgresql_ext: add version new option, fix typo in tests
2019-07-02 15:24:46 +02:00
Martin Nečas
051172f9bf ovirt vm migrate with state present (#58136)
* ovirt vm migrate with state present init

* add migrate comment
2019-07-02 06:14:19 -04:00
Martin Nečas
fb1610a9ac Ovirt host event log (#57935)
* host event log init

* show more events

* add time check

* correct pep8 syntax

* use event id as first elem

* init start event in constr

* update pep8 syntax

* remove precreate
2019-07-02 06:01:52 -04:00
Martin Nečas
2e25638abc Ovirt add vm cloud init ipv6 (#58112)
* update cloud init ipv6

* update examples cloud init

* add ipv6 docs version added
2019-07-02 05:59:52 -04:00
Martin Nečas
231afd7751 ovirt update vm migration domunetation (#58577)
* init update docs

* Update lib/ansible/modules/cloud/ovirt/ovirt_vm.py

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-07-02 05:57:44 -04:00
Abhijeet Kasurde
540ceb8622 Remove unnecessary pass (#58620)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-02 11:01:33 +02:00
Jordan Borean
c3978fed4b
Load Ansible module_utils for ps_argspec validator (#58571)
* Load Ansible module_utils for ps_argspec validator

* fix validation for modules without Requires statement

* Moved future comment to proper location
2019-07-02 12:22:38 +10:00
Jordan Borean
c260721ce5
win_domain_user: do not hide error on failures (#58357)
* win_domain_user: do not hide error on failures

* Was a bit too overzealous in the removal

* Remove uneeded sanity ignore rule
2019-07-02 07:40:51 +10:00
Felix Fontein
5d5a7d6ebe
openssl_privatekey: forgot to add secp256r1 (#58605)
* Forgot to add secp256r1. This one is the interoperable one.

* Add changelog.
2019-07-01 23:08:54 +02:00
Andrey Klychkov
10af2636d1 Add unit tests for human_to_bytes (#58584) 2019-07-01 13:50:54 -04:00
Sam Doran
c1a23cd763 Add two new Azure groups to prevent timeouts
ci_complete
2019-07-01 10:38:24 -07:00
Fred-sun
6557322e79 Update azure_rm_trafficmanagerendpoint related document (#58447) 2019-07-01 11:31:54 -05:00
Fred-sun
c86c079837 Update azure_rm_storageaccount related document (#58313)
* Update azure_rm_storageaccount and azure_rm_storageblob module documentation
2019-07-01 11:15:37 -05:00
Marek Anderson
3a919d4bec Doc - editorial for correct acronym introduction (#58519)
Introduce acronym GCP on first use. Introduce GCE acronym at all.
2019-07-01 10:37:13 -05:00
Michael Scherer
06651d1055 Fix traceback when using the module (#58588)
Since bricks_in_volume is a list, it can't be compared to a int.

    Traceback (most recent call last):
      File \"/root/.ansible/tmp/ansible-tmp-1561989216.06-31322871319024/AnsiballZ_gluster_volume.py\", line 114, in <module>
        _ansiballz_main()
      File \"/root/.ansible/tmp/ansible-tmp-1561989216.06-31322871319024/AnsiballZ_gluster_volume.py\", line 106, in _ansiballz_main
        invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
      File \"/root/.ansible/tmp/ansible-tmp-1561989216.06-31322871319024/AnsiballZ_gluster_volume.py\", line 49, in invoke_module
        imp.load_module('__main__', mod, module, MOD_DESC)
      File \"/usr/lib64/python3.7/imp.py\", line 234, in load_module
        return load_source(name, filename, file)
      File \"/usr/lib64/python3.7/imp.py\", line 169, in load_source
        module = _exec(spec, sys.modules[name])
      File \"<frozen importlib._bootstrap>\", line 630, in _exec
      File \"<frozen importlib._bootstrap_external>\", line 728, in exec_module
      File \"<frozen importlib._bootstrap>\", line 219, in _call_with_frames_removed
      File \"/tmp/ansible_gluster_volume_payload_d5mfag24/__main__.py\", line 610, in <module>
      File \"/tmp/ansible_gluster_volume_payload_d5mfag24/__main__.py\", line 551, in main
    TypeError: '<' not supported between instances of 'int' and 'list'
2019-07-01 10:36:59 -04:00
Pilou
5f8080aaa0 consul_session: improve documentation and add integration tests (#56392)
* consul_session: Python 2.6 is always required on managed node
* consul_session: document all types
* consul_session: add doc for 'id' parameter
* consul_session: improve parameter descriptions
    - use formatting functions in descriptions
    - 'name' parameter is required when state=node
* consul_session: use required_if
* consul_session: add integration tests
* consul_session: use 'retry' with network dependent tasks
* Use ansible-ci-files bucket for consul binaries

Co-Authored-By: Matt Clay <matt@mystile.com>
2019-07-01 10:27:15 -04:00
Tim Rupp
580b013837 rpm_key - add fingerprint parameter (#58373)
This parameter can be used to verify keys before they are imported by providing the long form fingerprint of the key.
2019-07-01 09:57:45 -04:00
mj84
d2ccf90610 Added missing SSL parameters to rabbitmq_binding (#58064)
In rabbitmq_binding.py the SSL parameters ca_cert, client_cert, client_key were only passed to requests for post requests.
This change updates the DELETE and GET requests to include these parameters as well.
2019-07-01 07:22:40 -04:00
Aaron Longchamps
045caaa400 VMware: Adding IP-Specific properties to ESXi host firewall config (#56733)
* Adds IP-Specific properties to firewall config

Fixes: #51240
2019-07-01 16:13:58 +05:30
Diane Wang
39fbdc22ff VMware: Add new module vmware_guest_screenshot (#57449)
Signed-off-by: Tomorrow9 <tommorrow7@gmail.com>
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-01 15:58:05 +05:30
Sumit Jaiswal
539f37ede3
PR to implement ansible_net_model for iosxr facts module (#58488)
* resolves 57767

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* added test

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-07-01 12:26:04 +05:30
Mikhail Naletov
d582efcc51 Use atexit to logout after zabbix module run (#58525) 2019-06-30 13:35:05 -04:00
Felix Fontein
f0801879c7 Rename xenserver_guest_facts -> xenserver_guest_info (#57032)
* Rename xenserver_guest_facts -> xenserver_guest_info.

* Add changelog.

* Forgot one test.
2019-06-30 10:04:30 -04:00
Gonéri Le Bouder
2401154fc4 VMware: rename VMWare to VMware (#58535)
Follow the nomenclature convention decided in https://github.com/ansible/ansible/pull/56814
2019-06-30 19:30:42 +05:30
Simon Dodsley
35dcd231be purefa_user: Fix Incorrect parameter used causing crashes. (#57588) 2019-06-29 17:32:22 +02:00
Ganesh Nalawade
80d6a2f344
Add network resource modules utils function (#58273)
* Add network resource modules utils function

*  `FactsBase` parent class to handle
    facts gathering
*  `ConfigBase` parent class for resource
   module config handling
*  utils funtions for resource modules

* Fix review comments

* Fix CI issues and review comments

* Fix review comments

* Fix CI issues and minor updates
2019-06-29 18:20:15 +05:30
YuandongXu
78c8ee9261 ce_snmp_target_host: update to fix bug: None has no 'lower()' function. (#57904)
* update to fix bug: None has not 'lower()' function.

* add a changelog fragment.

* update changlog fragment.

* Update 57904-ce_snmp_target_host.yml
2019-06-29 09:36:28 +02:00
Sam Doran
8cfd0ba039 Allow for test groups with double digits (#58532) 2019-06-28 16:24:14 -07:00
Sam Doran
ab6a9ef130
Get minor version number for CentOS and Debian (#57814)
* Get the most detailed version number from distro.version() for CentOS and Debian
* Update tests and fixtures
* Update fixture generation script to gather distro info and work with Python 3
* Update LinuxMint fixtures
* Cleanup fixture formatting
* Improvements based on feedback from abadger:
    - use unicode since that is what distro returns
    - use frozenset with a tuple
    - include link Debian to bug
2019-06-28 19:21:35 -04:00
YuandongXu
2f91266aa9 ce_vxlan_gateway: update the regular expression to match the more accurate. (#58226)
* Update the regular expression to match the more accurate

* Update the regular expression to match the more accurate

* Update the regular expression to match the more accurate
2019-06-28 17:11:00 -04:00
YuandongXu
23139cdbb9 update to fix a bug (#58228) 2019-06-28 17:10:48 -04:00
YuandongXu
b7630ccb36 update to fix a bug (#58230) 2019-06-28 17:10:33 -04:00
YuandongXu
715de33467 ce_netstream_aging: update to fix a bug. (#58231)
* update to fix a bug

* update to for shippable.
2019-06-28 17:10:23 -04:00
YuandongXu
36cfa9e931 ce_bgp: update bgp to fix bugs (#57317)
* update bgp to fix bgus

* add a changelog fragment for bgp
2019-06-28 16:47:35 -04:00
YuandongXu
bb33c922f7 ce_static_route: fix some bugs. (#58251)
* add a util function to ce.

* add a util function to ce.

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update

* update for shippable.
2019-06-28 16:47:10 -04:00
YuandongXu
442d275ae3 update vrrp (#57916) 2019-06-28 16:35:20 -04:00