cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
6864 commits 47 branches 390 tags 440 MiB
Commit graph

6864 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jérémie Astori
72fb7a0a17 Fix physical walk on acl module for Linux 
`-h` is for BSD [1] while `-P`/`--physical` is for Linux [2].
This commit fixes that option now that acl module is (temporarily)
only supported for Linux.
I will re-add `-h` when fixing BSD support.

[1]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[2]: http://linuxcommand.org/man_pages/setfacl1.html
 2015-08-20 23:35:53 +00:00
Jérémie Astori
8eefd44aef Make sure entry is not sent when acl state=query 2015-08-20 22:59:00 +00:00
Jérémie Astori
0e659ad872 Make sure permission-less entries are accepted when state=absent 
Also, remove that try condition as, at that stage, no permissions with
other than 2 or 3 fields are sent to the function.
 2015-08-20 22:58:49 +00:00
Jérémie Astori
e95bcaeb8a Remove support for d[efault]: in entry permissions 
It is not documented in [the Ansible doc page][1] nor
[the BSD setfacl man entry][2] (which means it might not be compatible
with BSD) so removing it does not break the API.

On the other hand, it does not conform with POSIX 1003.1e DRAFT
STANDARD 17 according to the [Linux setfacl man entry][3] so safer to
remove.

Finally, the most important reason: in non POSIX 1003.e mode, only ACL
entries without the permissions field are accepted, so having an
optional field here is very much error-prone.

[1]: http://docs.ansible.com/ansible/acl_module.html
[2]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[3]: http://linuxcommand.org/man_pages/setfacl1.html
 2015-08-20 22:22:28 +00:00
Jérémie Astori
3ac990556d Fix wrong expectation regarding entry format in acl module 2015-08-19 00:26:04 +00:00
Jérémie Astori
421d3f12cf Fix wrong processing of lines returned by setfacl in test mode 2015-08-19 00:25:18 +00:00
Jérémie Astori
50c6425673 Fix minor whitespace issues 2015-08-19 00:24:08 +00:00
Brian Coca
5913f5e5e1 deal with more failures when apt module fails to instantiate pkg 
fixes #1499
 2015-08-18 14:59:35 -04:00
Brian Coca
65270a172e Merge pull request #1857 from SamYaple/devel 
Revert "escapeds changes"
 2015-08-18 11:47:52 -04:00
Brian Coca
ff3b88c4d7 Merge pull request #1925 from kostyrevaa/devel 
Fix documentation of authorized_key.py
 2015-08-17 11:36:07 -04:00
Александр Костырев
31ec203583 Fix documentation of authorized_key.py 
man for sshd http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man8/sshd.8?query=sshd
says there's no "host" option but "from".
 2015-08-17 18:00:04 +03:00
Brian Coca
d61fde42ef updated encoding comment and expanded authors field 2015-08-14 22:01:05 -04:00
Brian Coca
d4a39d23df Merge pull request #150 from astorije/recursive_acl 
Add recursive support for ACL module
 2015-08-14 20:21:01 -04:00
Jérémie Astori
acfc2166b0 Set version number in recursive option description 2015-08-14 23:40:47 +00:00
Jérémie Astori
f8027a7f0a Ensure Python 2.4 compatibility and Linux-restricted support 
- Make build_entry compatible with Python 2.4
- Re-add missing warning/comment that was forgotten while refactoring
- Replace `all()` with a good ol' for-loop Python 2.4 compatibility
- Make a condition check more explicit (when `state` is `query`)
- Make sure this module can only be run with on a Linux distribution
- Add a note about Linux-only support in the documentation
- Set the version in which recursive support was added, 2.0
 2015-08-14 22:06:51 +00:00
Brian Coca
8ff80c2c91 updated docs for package 2015-08-13 14:57:55 -04:00
Brian Coca
c120a9b946 Merge pull request #1911 from mgedmin/patch-1 
Fix obvious copy-paste error in module docs
 2015-08-13 12:57:52 -04:00
Marius Gedminas
9bcf69a155 Fix obvious copy-paste error in module docs 2015-08-13 19:47:49 +03:00
Brian Coca
5d7cb981d3 made continue into a pass (there was no loop) 2015-08-13 10:05:30 -04:00
Brian Coca
6d7428527d minor doc fixes 2015-08-12 23:55:01 -04:00
Brian Coca
2fd171a5e1 Merge pull request #878 from EvanK/system-cron--disabled 
cron module: Add disabled option for commented jobs
 2015-08-12 23:50:47 -04:00
Brian Coca
01506abc4f Merge pull request #1895 from bcoca/gpg2_fallback 
added gpg2 as fallback
 2015-08-12 22:56:58 -04:00
Brian Coca
cd0a1947c2 Merge pull request #1899 from austinhyde/fix-service-rcconf-newlines 
Service module incorrectly handles lines not ending in a newline
 2015-08-12 19:34:34 -04:00
Brian Coca
7a2687178e avoid shlex exceptions in rc parsing (happens with multiline entries) 
fixes #1898
 2015-08-12 18:10:24 -04:00
Brian Coca
090926b938 Merge pull request #1906 from mjschultz/patch-1 
Return an iterable instead of None
 2015-08-12 13:24:52 -04:00
Michael J. Schultz
63d7bbea19 Return an iterable instead of None 
By default `.get()` will return `None` on a key that doesn't exist. This
causes a `TypeError` in the `for` loop a few lines down. This change simply
returns an iterable type to avoid the error.
 2015-08-12 12:13:29 -05:00
Brian Coca
0c403781a7 Merge pull request #1905 from evverx/fix-legacy-services-enabled 
Fix service.enabled on: Debian 8, Ubuntu 15.04
 2015-08-12 10:18:50 -04:00
Evgeny Vereshchagin
55e8863cb4 Fix service.enable on: Debian 8, Ubuntu 15.04 
Workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751638
See https://github.com/systemd/systemd/issues/937
 2015-08-12 14:13:19 +00:00
Brian Coca
072c4f38ea Merge pull request #62 from 0x46616c6b/user-add-skeleton-support 
Add support for skeleton directory (useradd -k) in user module
 2015-08-12 09:17:35 -04:00
Brian Coca
d139825169 fixed typo 2015-08-11 11:53:52 -04:00
Brian Coca
afb9b8e2f3 added gpg2 as fallback 
fixes #1796
 2015-08-11 11:53:52 -04:00
Austin Hyde
5c25057868 Always end rc.conf entries with a new line 2015-08-10 17:42:26 -04:00
Brian Coca
7f01246bb5 updated win_file version_added 
fixes #1893
 2015-08-10 10:11:40 -04:00
Toshio Kuratomi
dea5f5d15e Another way that the serialization of the boto results can fail 2015-08-07 12:27:57 -07:00
Toshio Kuratomi
8412adc4f9 Quote checksum description to fix docs 2015-08-06 21:10:03 -07:00
Toshio Kuratomi
484b2451b4 Merge branch 'pr/141' into devel 2015-08-06 14:49:52 -07:00
muffl0n
4f0cf6d2ca Allow additional hashing algorithms. Directly use hashlib and check if 
used algorithm is supported.
 2015-08-06 14:49:07 -07:00
Toshio Kuratomi
4c622a0338 Another launchconfig field needs to be explicitly converted for json serialization 
Fixes #1848
 2015-08-06 08:41:23 -07:00
Toshio Kuratomi
34b4d9c8b2 Merge pull request #1882 from sebi-hgdata/sebi/docker_memory_version_check 
mem_limit client version check
 2015-08-06 07:52:15 -07:00
sebi
599d60efc0 mem_limit client version check 2015-08-06 16:46:01 +03:00
Brian Coca
016b4ede2e minor doc fix 2015-08-05 17:36:16 -04:00
Toshio Kuratomi
f39e5ffa1d Modify the default for synchronize's dest_port again 2015-08-05 13:05:59 -07:00
Toshio Kuratomi
ed2d8121b3 Update docs to reflect precedence for synchronize's dest_port param 2015-08-05 12:46:01 -07:00
Toshio Kuratomi
0071fd0bf7 Allow mode as a synchronize parameter (handled in action plugin) 2015-08-05 11:54:36 -07:00
Chris Church
7adb789870 Merge pull request #1850 from cchurch/windows_check_mode 
Add check mode support for Windows modules.
 2015-08-04 19:07:18 -04:00
Brian Coca
762e43c50f Merge pull request #1860 from tedder/patch-1 
fix ugly documentation
 2015-08-03 12:56:04 -04:00
Toshio Kuratomi
1001eae3c8 Set a default value for DEFAULT_DOCKER_API_VERSION so we can create the AnsibleModule without docker-py 2015-08-03 08:44:48 -07:00
Sam Yaple
2c35cfce9a Revert "escapeds changes" 
While this change doesn't break the creation, it does break
idempotency. This change will convert '*.*' to '`*`.*' which is
functionally the same, however when the user_mod() function looks up
the current privileges with privileges_get() it will read '*.*'

Since '*.*' != '`*`.*' it will go through the process of updating the
privleges always resulting in a 'changed' result.

This reverts commit db9ab9b262.
 2015-08-03 10:49:37 +00:00
Ted Timmons
40519de8e7 fix ugly documentation 
current version dumps a character per line in the docs: http://docs.ansible.com/ansible/cloudformation_module.html
 2015-08-01 17:30:15 -07:00
Robert Jailall
d10f3f7a7e Refactor ec2_snapshot to make it more testable 2015-08-01 08:11:17 -07:00