Commit graph

39631 commits

Author SHA1 Message Date
Matt Clay
75d1cb3b05 Fix tower_project integration test.
Changes required due to https://github.com/ansible/ansible/pull/45158
2018-09-07 19:31:06 -07:00
Kevin Breit
6c67674eab meraki_mr_l3_firewall - Integration test fix (#45366)
* Fix integration test as wrong module was called

* Create block section for failures on integration test for mr_l3_firewall integration test
2018-09-08 03:44:50 +02:00
Will Thames
1463c2e4a8
Use a sensible default for k8s merge_type (#45284)
* Use a sensible default for k8s merge_type

The sensible default for merge_type is `['strategic-merge', 'merge'].
However, we can't make this the default default, as we need to support
users who are using openshift 0.6.0, where the merge_type parameter is
unsupported.

* Refactor k8s test suite for merge_type tests

Allow tests with pre-merge-type openshift and post-merge-type
openshift.
2018-09-08 10:08:09 +10:00
jctanner
ab133def0b vmware_guest test - Use the cluster name instead of the path (#45368) 2018-09-08 04:06:16 +05:30
Alexander Bethke
a3a189fc83 Add integration tests for flatpak_remote module
PR #42315
2018-09-07 23:01:36 +02:00
Meecr0b
2f6b8591b1 tower_credential: expect ssh_key_data to be a string instead of path (#45158)
* expect ssh_key_data to be a string instead of path

ssh_key_data should be a string filled with the private key
the old behavior can be archived with a lookup

Fixes #45119

* clarifies ssh_key_data description, adds newline
2018-09-07 13:41:09 -04:00
Jesse Morgan
ac4e611f9d not sure if typo or pun. (#45358)
Fixing header to be SNapshot
+label: docsite_pr
2018-09-07 13:29:19 -04:00
Matt Martz
7a61763fba
Don't require requests in hacking/report.py (#45350)
* Don't require requests in hacking/report.py

* move ansible import
2018-09-07 11:51:41 -05:00
Alexander Bethke
19acd5d4f7 Add integration tests for flatpak module
PR #42169
2018-09-07 17:49:26 +02:00
Matt Martz
2ac647def8
Ensure loop with delegate_to can short circuit the same as without delegate_to. Fixes #45189 (#45231) 2018-09-07 10:16:03 -05:00
Alicia Cozine
9a76441c02
rewrite of the developer guide, part 1 (#45179)
* rewrite of the developer guide, part 1
2018-09-07 08:57:36 -05:00
kryptsi
1325ddbb0b VMware: new plugin for setting an object's role/permission (#39988) 2018-09-07 19:03:58 +05:30
Ryan Brown
4d7e261074 [aws] Remove deprecated ec2_vpc_dhcp_options_facts alias of ec2_vpc_dhcp_option_facts (#45322) 2018-09-07 09:09:28 -04:00
Ryan Brown
8d363f7693 [aws] Remove deprecated ec2_vpc_dhcp_options alias of ec2_vpc_dhcp_option (#45321) 2018-09-07 09:08:09 -04:00
Pieter Avonts
1a810f8f11 VMware: Rewrite get_resource_pool method for correct resource_pool selection (#39792)
* rewrite get_resource_pool method for correct resource_pool selection
* only keep name if path is given for cluster, esxi_hostname or resource_pool
* Revert "only keep name if path is given for cluster, esxi_hostname or resource_pool"
* This reverts commit 50293ec763c024b0eaceac5d775ccc0ad3ff8bd7.
* if the name argument contains a path, only use the last part for matching
* remove path from cluster argument in tests
* remove find_objs in favour of reusing find_obj with an extra folder argument
* fix find_obj ignoring first if name is not given
2018-09-07 18:23:26 +05:30
Trishna Guha
d5bfd93e28
cli_config module doc update (#45345)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-09-07 17:09:08 +05:30
Abhijeet Kasurde
fd985db72d
VMware: Refactor disc logic (#39285)
* Refactoring related to network device
* Assign unique random temporary key while creating SCSI or/and IDE controller devices
* Add testcase for this change

Fixes: #38679

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-07 17:04:02 +05:30
Trishna Guha
f18856d0e2
Add ambiguous command check as the error message is not persistent on nexus devices (#45337)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-09-07 16:35:37 +05:30
Armin Ranjbar Daemi
778b789c84 VMware: New module vmware_guest_vnc (#36282) 2018-09-07 16:00:37 +05:30
Richard Schwab
97fcc3ef66 Correct version_added for strategy host_pinned (#45333) 2018-09-07 09:15:46 +02:00
Zim Kalinowski
fca1dc4cf2 consolidating dns recordset tests (#45331) 2018-09-07 14:49:38 +08:00
John Imison
38a714833d pyvcloud requirement documented (#44347) 2018-09-07 01:01:49 -04:00
Zim Kalinowski
d309530bb6 consolidate availabilityset tests (#45327) 2018-09-07 12:52:00 +08:00
Zim Kalinowski
8adc7901ed consolidate dnszone tests (#45328) 2018-09-07 12:50:51 +08:00
Mike Klebolt
b14206a578 [New Module] vmware_guest_tools_upgrade (#42698)
New module to manage VMware guest tools upgrade.
2018-09-07 09:54:50 +05:30
Abhijeet Kasurde
e653a93044
VMware: update vmware_local_role_manager with action (#44566)
With this fix user can add, remove and set privileges to
an existing role with privileges.

Fixes: #44391

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-07 09:33:50 +05:30
kobayashi
46856b0747 Delete parameters created with init (#42777) 2018-09-07 09:31:34 +05:30
Tim Rupp
e21b99b098 Corrects documentation for parameters and examples (#45311)
Documentation for the bigiq modules was a little out of date.
This patch corrects the examples and parameters.
2018-09-06 17:24:49 -04:00
Sloane Hertel
8b341619ae Fix backwards compatibility without providing prefix since boto3 does more parameter validation than boto (#45308)
Use .get() instead of assuming a rule has a Transitions or Filter key (both of which are optional)
2018-09-06 15:44:26 -04:00
Andrew McGilvray
71c4355d58 check for change of role arn in ecs task definition (#44942)
* check role arn for ecs task definition

If the task role in a ECS task definition changes ansible should create a new revsion of the task definition.
2018-09-06 15:43:30 -04:00
Ian Wienand
c34e0f5e11 plugins/callbacks : fix some key documentation (#45267)
These are supposed to be a dictionary with section/key entries;
correct a few typos.
2018-09-06 15:38:25 -04:00
Jose Delarosa
553097f929 Adding maintainer for Redfish modules (#45299) 2018-09-07 05:37:33 +10:00
Vinay Dandekar
4ce09ea62d [aws] ec2_metadata_facts URL encode the metadata URL to avoid errors (#43394)
- If a field in the URL has a space it would result in a 400 without making it URL safe
- Fixes #42371 and #43378
2018-09-06 15:24:25 -04:00
Rob
7e426b0381 Fix health check configurations being ignored - #43244 (#43247)
* Fix health check configurations being ignored - #43244

* Ensure health_check_protocol is not None before check

* Simplify long indented if statement
2018-09-06 15:19:04 -04:00
Ryan Brown
079299db4d
[aws] ec2_group multi-account and peered VPC bugfix (#45296)
* Add tests to replicate bug #44788 

* Handle when userId is same account due to in-account peering

* Module defaults for main.yml

* Turn off VPC peering tests in CI
2018-09-06 15:06:03 -04:00
Adam Miller
12e2d6d01f fix version number because this was backported
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-09-06 11:35:39 -07:00
Ganesh Nalawade
a3c137c1ab
Fix diff_ignore_lines option issue for candidate configuration (#45201)
* Fix diff_ignore_lines option issue for candidate configuration

*  diff_ignore_lines option is to handle the running config fetch from
   remote host and ignore the lines that are auto updated eg: commit time and date
*  This option should not be used while processing candidate (input) configuration

* Fix review comment
2018-09-06 23:54:56 +05:30
Brian Coca
64c594d226
correct and clarify deprecation (#45234)
* correct and clarify deprecation
2018-09-06 13:24:44 -04:00
Adam Miller
db34d3923a Improve dnf group output for clarity
Add note about group removal bug upstream dnf

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-09-06 09:27:24 -07:00
Rémy Léone
eb882e4b01 Select image facts by region (#44965) 2018-09-06 11:57:43 -04:00
Brian Coca
44510448b0 prefer ansible_facts namespace and dict notation (#44980)
* prefer ansible_facts namespace and dict notation

* fixed mistranslation
2018-09-06 10:26:58 -05:00
Markus Suonto
0d81386144 Add single quotes around package name (#45152)
<!--- Your description here -->
`pip install ansible[azure]` results in `zsh: no matches found: ansible[azure]` at least in my computer (zsh on Ubuntu). I don't know if it is the case with all shells, but at least for me it is. Since square brackets `[]` are special characters in bash, I propose adding single quotes to make sure that package name is always interpreted as literal. The same error is also resolvable by setting noglob.
2018-09-06 10:09:40 -05:00
Trishna Guha
c98494d5bf
fix python26 nxos terminal plugin bug (#45271)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-09-06 16:15:01 +05:30
Deepak Agrawal
23d54ed1d4
iosxr dci failure on devel/2.7 (#45268) 2018-09-06 13:35:25 +05:30
Abhijeet Kasurde
270082a51c
VMware: Handle systemError in host_config_manager (#45263)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-06 08:59:53 +05:30
Brian Coca
9a6530be77 clarify free strategy (#44645)
* clarify free strategy
* wordsmithing
* shorten line per Shippable
2018-09-05 20:24:37 -05:00
Yunge Zhu
2955d7cd1b add publish url in webapp facts output (#45131)
* add publish url in webapp facts output

* update name

* fix test
2018-09-06 08:04:09 +08:00
Matt Clay
4173a30941 Remove obsolete default container. 2018-09-05 15:29:00 -07:00
Tim Rupp
4154cab278
Updates documentation formatting and dependencies (#45252)
The documentation formatting was a bit incorrect and the dependencies
mentioned were out of date. This fixes that.
2018-09-05 17:57:42 -04:00
Matt Clay
3f8edb440a Switch default test container to quay.io. 2018-09-05 14:31:10 -07:00