Commit graph

25476 commits

Author SHA1 Message Date
Miguel Angel Muñoz González
d413e322a9 Fortinet's FortiOS log syslogd filter (#52267)
* Fortinet's FortiOS log syslogd filter

* Avoid null choices
2019-02-15 12:28:43 +00:00
Miguel Angel Muñoz González
505a9b25b3 Fortinet's FortiOS log syslogd override filter (#52268)
* Fortinet's FortiOS log syslogd override filter

* Avoid null choices
2019-02-15 12:26:22 +00:00
Miguel Angel Muñoz González
356978fbae Fortinet's FortiOS log syslogd override setting (#52269) 2019-02-15 12:25:33 +00:00
Miguel Angel Muñoz González
85ad67e245 Fortinet's FortiOS log syslogd setting (#52270) 2019-02-15 12:25:15 +00:00
Miguel Angel Muñoz González
747d96a8e2 Fortinet's FortiOS log threat weight (#52271) 2019-02-15 12:25:02 +00:00
Miguel Angel Muñoz González
256f492a19 Fortinet's FortiOS log webtrends setting (#52273) 2019-02-15 12:24:37 +00:00
Miguel Angel Muñoz González
73e82e8250 Fortinet's FortiOS report layout (#52294) 2019-02-15 12:23:09 +00:00
Miguel Angel Muñoz González
644545172f Fortinet's FortiOS report setting (#52295) 2019-02-15 12:22:54 +00:00
Miguel Angel Muñoz González
b0cd22cbb8 Fortinet's FortiOS report style (#52296) 2019-02-15 12:22:36 +00:00
Miguel Angel Muñoz González
25a9f88d74 Fortinet's FortiOS report theme (#52298) 2019-02-15 12:22:27 +00:00
Dag Wieers
25323155d2 doc_fragments: Clean up parameter types (cloud) (#52177)
* module_utils: Clean up parameter types (cloud)

This PR includes:

- Parameter types added
- Copyright format fixes
- Short license statement
- Description fixes (only for a few files, then I stopped :-))

* More cloud stuff

* Fix reported issue

* Fix quotes

* Use correct type

* Fix quotes

* Fix quotes

* Fix quotes

* Fix typo

* Fix boolean
2019-02-15 12:21:20 +00:00
Dag Wieers
203caf2570
Fix module issues (#52209) 2019-02-15 12:57:20 +01:00
Dag Wieers
cedd9d9926
crypto: Fix known issues in modules (#52302)
* crypto: Fix known issues in modules

This fixes a few issues reported by 'validate-modules'.

* Fix whitespace
2019-02-15 11:46:44 +01:00
Dag Wieers
9c1033422b doc_fragments: Clean up parameter types (network) (#52176)
* module_utils: Clean up parameter types

This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
- Description fixes (only for a few files, then I stopped :-))

* More network stuff

* Fix typo

* Fix PEP8

* Fix booleans

* Fix typo
2019-02-15 09:52:48 +00:00
Zim Kalinowski
2f3960558d
Fix for PostgresSQL server update and storage_mb (#51653) 2019-02-15 17:46:52 +08:00
Zim Kalinowski
1f5cda37b3
Fix for MySQL server update and storage_mb (#51661) 2019-02-15 17:33:21 +08:00
japokorn
68d43130d0 New LUKS devices management module (#48991)
* New LUKS devices management module

- new module that uses cryptsetup (LUKS) functions for management
of encrypted devices
- unit tests included

* New LUKS devices management module

- modified interface by removing 'open' option and moving its functionality
into 'state' option
2019-02-15 09:25:14 +00:00
Zim Kalinowski
0c8c72a0bf
Fixing managed disk facts (#51781) 2019-02-15 17:07:30 +08:00
Dag Wieers
27dfdb6a6a doc_fragments: Clean up parameter types (database) (#52178)
* module_utils: Clean up parameter types (database)

This PR includes:

- Parameter types added
- Copyright format fixes
- Short license statement
- Description fixes (only for a few files, then I stopped :-))

* Fix validate-modules test ignores
2019-02-15 08:32:45 +00:00
Dag Wieers
fbca8a4615 doc_fragments: Clean up parameter types (storage) (#52179)
* module_utils: Clean up parameter types (storage)

This PR includes:

- Parameter types added
- Copyright format fixes
- Short license statement
- Description fixes (only for a few files, then I stopped :-))

* Fix quotes

* Fix rST issue
2019-02-15 08:31:12 +00:00
Jordan Borean
de118734e9
Ansible.Basic - add required_by to module spec (#51407)
* Ansible.Basic - add required_by to module spec

* fix typo in docs
2019-02-15 13:00:25 +10:00
Chris Archibald
994063bbf9 Add junction path to ontap_volume_clone (#51391)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* add new option

* Fix issues
2019-02-14 21:12:50 -05:00
Dag Wieers
cd9471ef17 Introduce new 'required_by' argument_spec option (#28662)
* Introduce new "required_by' argument_spec option

This PR introduces a new **required_by** argument_spec option which allows you to say *"if parameter A is set, parameter B and C are required as well"*.

- The difference with **required_if** is that it can only add dependencies if a parameter is set to a specific value, not when it is just defined.
- The difference with **required_together** is that it has a commutative property, so: *"Parameter A and B are required together, if one of them has been defined"*.

As an example, we need this for the complex options that the xml module provides. One of the issues we often see is that users are not using the correct combination of options, and then are surprised that the module does not perform the requested action(s).

This would be solved by adding the correct dependencies, and mutual exclusives. For us this is important to get this shipped together with the new xml module in Ansible v2.4. (This is related to bugfix https://github.com/ansible/ansible/pull/28657)

```python
    module = AnsibleModule(
        argument_spec=dict(
            path=dict(type='path', aliases=['dest', 'file']),
            xmlstring=dict(type='str'),
            xpath=dict(type='str'),
            namespaces=dict(type='dict', default={}),
            state=dict(type='str', default='present', choices=['absent',
'present'], aliases=['ensure']),
            value=dict(type='raw'),
            attribute=dict(type='raw'),
            add_children=dict(type='list'),
            set_children=dict(type='list'),
            count=dict(type='bool', default=False),
            print_match=dict(type='bool', default=False),
            pretty_print=dict(type='bool', default=False),
            content=dict(type='str', choices=['attribute', 'text']),
            input_type=dict(type='str', default='yaml', choices=['xml',
'yaml']),
            backup=dict(type='bool', default=False),
        ),
        supports_check_mode=True,
        required_by=dict(
            add_children=['xpath'],
            attribute=['value', 'xpath'],
            content=['xpath'],
            set_children=['xpath'],
            value=['xpath'],
        ),
        required_if=[
            ['count', True, ['xpath']],
            ['print_match', True, ['xpath']],
        ],
        required_one_of=[
            ['path', 'xmlstring'],
            ['add_children', 'content', 'count', 'pretty_print', 'print_match', 'set_children', 'value'],
        ],
        mutually_exclusive=[
            ['add_children', 'content', 'count', 'print_match','set_children', 'value'],
            ['path', 'xmlstring'],
        ],
    )
```

* Rebase and fix conflict

* Add modules that use required_by functionality

* Update required_by schema

* Fix rebase issue
2019-02-15 10:57:45 +10:00
Emmanouil Kampitakis
1219aa811a Feature/alphanumeric password in passwordstore (#38121)
* Alphanumeric only password may be generated

* Bump the ansible version this will have been added to 2.8
2019-02-14 17:02:24 -05:00
Guillaume Martinez
f7328693f2 gitlab_runner: refresh deprecated documentation notes (#52221) 2019-02-14 05:04:55 -05:00
Matt Clay
3e778d3f8f Fix pycodestyle E117 issues. 2019-02-13 23:35:39 -08:00
Jordan Borean
7b8e814a10 Ansible.Basic: make module options case insensitive with dep warning (#51583)
* Ansible.Basic: make module options case insensitive with dep warning

* Add porting guide info
2019-02-13 21:55:43 -05:00
Yunge Zhu
bccf6d31bd add azure_applicationsecuritygroup module (#51214)
* add applicationsecurity group module

* fix lint
2019-02-13 19:34:44 -05:00
Matt Clay
1a4163cb88 Fix misuse of is not testing a string. 2019-02-13 15:10:01 -08:00
Adam Miller
ea0e2bf2b3 yum always return changes dict, not only in check mode (#51987)
Previously the yum module would provide a `changes` dict when
executed in check mode but omit it when not in check mode in favor
of the `results` data which is raw output from the yum command. This
pull request makes that output uniform.

Fixes #51724

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-02-13 17:46:32 -05:00
René Moser
9e71ec71a3
cloudstack: ensure return api_timeout is int (#52191) 2019-02-13 23:11:22 +01:00
Felix Fontein
132d920113 Also return some information in case the docker daemon does not run, is not in swarm mode or not a swarm manager. (#52189) 2019-02-13 16:49:45 -05:00
Chris Archibald
6a06e9f485 New Module: na_ontap_nvme (#51182)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Add new module nvme
2019-02-13 20:36:58 +00:00
Miguel Angel Muñoz González
1b5575c669 Fortinet's FortiOS log fortianalyzer2 setting (#52159) 2019-02-13 20:15:37 +00:00
Miguel Angel Muñoz González
d875ca3e58 Fortinet's FortiOS log fortianalyzer override setting (#52164) 2019-02-13 20:12:20 +00:00
Miguel Angel Muñoz González
aac3ff364f Fortinet's FortiOS log fortianalyzer setting (#52165) 2019-02-13 20:11:03 +00:00
Miguel Angel Muñoz González
cd06cdf1dc Fortinet's FortiOS log fortianalyzer3 filter (#52160)
* Fortinet's FortiOS log fortianalyzer3 filter

* Avoid fields with empty choices

* Avoid fields with empty choices
2019-02-13 19:58:59 +00:00
Simon Westphahl
02e87b7d70 Raise AnsibleConnectionError on winrm connnection errors (#51744)
* Raise AnsibleConnectionError on winrm con errors

Currently all uncaught exceptions of the requests library that is used
in winrm will lead to an "Unexpected failure during module execution".

Instead of letting all exceptions bubble up we catch the connection
related errors (inkl. timeouts) and re-raise them as
AnsibleConnectionError so Ansible will mark the host as unreachable and
exit with the correct return code.

This is especially important for Zuul (https://zuul-ci.org) to
distinguish between failures and connection/host related errors.

* Update lib/ansible/plugins/connection/winrm.py

Co-Authored-By: westphahl <westphahl@gmail.com>

* Add changelog fragment
2019-02-13 14:55:55 -05:00
Miguel Angel Muñoz González
2de41ae8f4 Fortinet's FortiOS log fortianalyzer3 setting (#52161) 2019-02-13 19:55:31 +00:00
Miguel Angel Muñoz González
b51e3137a4 Fortinet's FortiOS log fortiguard override setting (#52169) 2019-02-13 19:54:41 +00:00
Miguel Angel Muñoz González
d643108d5c Fortinet's FortiOS log fortiguard setting (#52170) 2019-02-13 19:54:27 +00:00
Miguel Angel Muñoz González
402c41d97f Fortinet's FortiOS log gui display (#52171) 2019-02-13 19:54:19 +00:00
Matt Clay
3f387f225c Fix safe_eval on Python 3.8. 2019-02-13 11:54:03 -08:00
René Moser
02f51e865c cloudscale: combine docs in fragment (#52069)
* cloudscale: combine docs in fragment

* workaround false negative E305
2019-02-13 13:52:01 -06:00
Sandra McCann
6c17c55b51 move modules to community support (#52184) 2019-02-13 13:24:17 -06:00
おすし
c2a409a9e0 Fix: Yum module does not use proxy when username is not set #51548 (#51994)
* add test of yum with proxy

* Properly handle unauthenticated yum proxy config

Fixes #51548

* shell executable is bash
2019-02-13 14:10:47 -05:00
Felix Fontein
d7fd4d0550 docker_*: always use client.fail() over module.fail_json(), allow to always return data on failure (#51999)
* Always use client.fail() instead of module.fail_json().

* Allow to pass on results on module failure.

* Linting.
2019-02-13 14:10:23 -05:00
Sam Doran
ad386290b4
Update command/shell docs with note about modules for rebooting(#51499)
- Update integration test syntax
2019-02-13 13:54:36 -05:00
Kevin
c512471428 Add two more failure conditions to unarchive (#51914) 2019-02-13 13:40:26 -05:00
Matt Martz
cdb53ff1a4
Restore behavior for detecting only localhost, and no limit match. Fixes #52152 (#52172)
* Restore behavior for detecting only localhost, and no limit match. Fixes #52152

* Add test for non-matching limit
2019-02-13 11:52:30 -06:00
Jordan Borean
847d089d6b Re-add support for setting shell from play context (#52139)
* Re-add support for setting shell from play context

* Add integration tests

* Add more tests for shell override

* fix sanity issue
2019-02-13 11:49:13 -06:00
Matt Martz
b34d141eed
Disallow use of remote home directories containing .. in their path (CVE-2019-3828) (#52133)
* Disallow use of remote home directories containing .. in their path

* Add CVE to changelog
2019-02-13 10:38:28 -06:00
Juan Antonio Osorio
9f081ca04f identity: Add GSSAPI suport for FreeIPA authentication (#52031)
* identity: Add GSSAPI suport for FreeIPA authentication

This enables the usage of GSSAPI for authentication, instead of having
to pass the username and password as part of the playbook run.

If there is GSSAPI support, this makes the password optional, and will
be able to use the KRB5_CLIENT_KTNAME or the KRB5CCNAME environment
variables; which are standard when using kerberos authentication.

Note that this depends on the urllib_gssapi library, and will only
enable this if that library is available.

* identity: Add documentation for GSSAPI authentication for FreeIPA

This documentation describes how to use GSSAPI authentication with the
IPA identity modules.

* identity: Add changelog for GSSAPI support for IPA

This adds the changelog entry for the GSSAPI authentication feature for
the IPA identity module.
2019-02-13 15:38:13 +00:00
Chris Archibald
7d55dc1a38 Add ontap version to gather facts (#51181)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Add FlexGroup to Gather facts:

* fix call error
2019-02-13 15:33:38 +00:00
Chris Archibald
93237edcda New Module: na_ontap_qos_policy_group (#51392)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* add new module na_ontap_qos_policy_group

* fix issues
2019-02-13 15:32:25 +00:00
Chris Archibald
311a076dae New Module: na_ontap_nvme_subsystem (#50887)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* New module na_ontap_nvme_subsystem

* updates

* update author

* fix author
2019-02-13 14:36:48 +00:00
Alan Rominger
af9ff07c74 Send openstack inventory logs to stderr (#51827) 2019-02-13 13:36:37 +00:00
Abhijeet Kasurde
32fce43311
hashi_vault: fix multiple spaces in params (#51524)
Fixes param parsing in hashi_vault

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-13 18:32:00 +05:30
Miguel Angel Muñoz González
196e82ec8a Fortinet's FortiOS User Tacacs+ (#52071) 2019-02-13 11:37:03 +00:00
Miguel Angel Muñoz González
edcf07500f Fortinet's FortiOS Firewall Schedule Group (#52072) 2019-02-13 11:36:52 +00:00
Miguel Angel Muñoz González
05381db474 Fortinet's FortiOS fortios firewall service group (#52090) 2019-02-13 11:36:35 +00:00
Miguel Angel Muñoz González
3718a6b79f Fortinet's FortiOS fortios firewall shaper per ip shaper (#52092) 2019-02-13 11:36:14 +00:00
Miguel Angel Muñoz González
a5ed17e462 Fortinet's FortiOS fortios firewall shaper traffic shaper (#52093) 2019-02-13 11:36:03 +00:00
Miguel Angel Muñoz González
ac25361de5 Fortinet's FortiOS firewall shaping policy (#52094) 2019-02-13 11:35:45 +00:00
Miguel Angel Muñoz González
6dc44b18e1 Fortinet's FortiOS firewall shaping profile (#52095) 2019-02-13 11:35:36 +00:00
Miguel Angel Muñoz González
62f15c26b4 Fortinet's FortiOS firewall sniffer (#52096) 2019-02-13 11:35:29 +00:00
Miguel Angel Muñoz González
b8ffc1a917 Fortinet's FortiOS firewall ssh host key (#52097) 2019-02-13 11:35:20 +00:00
Miguel Angel Muñoz González
31180fa10f Fortinet's FortiOS firewall ssh local ca (#52098) 2019-02-13 11:35:00 +00:00
Miguel Angel Muñoz González
c21e41f4b8 Fortinet's FortiOS firewall ssh local key (#52099) 2019-02-13 11:34:06 +00:00
Miguel Angel Muñoz González
097a7c9d81 Fortinet's FortiOS firewall ssh setting (#52102) 2019-02-13 11:33:35 +00:00
Miguel Angel Muñoz González
312f2e9d1f Fortinet's FortiOS firewall ssl server (#52104) 2019-02-13 11:33:18 +00:00
Miguel Angel Muñoz González
1640ad6cfc Fortinet's FortiOS firewall ssl setting (#52105) 2019-02-13 11:33:01 +00:00
Miguel Angel Muñoz González
6fd031c820 Fortinet's FortiOS firewall ssl ssh profile (#52106) 2019-02-13 11:32:49 +00:00
Miguel Angel Muñoz González
bc0c1bd501 Fortinet's FortiOS firewall ttl policy (#52107) 2019-02-13 11:32:17 +00:00
Miguel Angel Muñoz González
8413d62727 Fortinet's FortiOS firewall wildcard fqdn custom (#52108) 2019-02-13 11:31:58 +00:00
Miguel Angel Muñoz González
47d1ab4c3d Fortinet's FortiOS firewall wildcard fqdn group (#52110) 2019-02-13 11:31:33 +00:00
Miguel Angel Muñoz González
abcdedfdf0 Fortinet's FortiOS ftp proxy explicit (#52113) 2019-02-13 11:31:23 +00:00
Miguel Angel Muñoz González
a1e2d290fc Fortinet's FortiOS system settings (#52112) 2019-02-13 11:31:04 +00:00
Miguel Angel Muñoz González
951ace650b Fortinet's FortiOS icap profile (#52114) 2019-02-13 11:30:42 +00:00
Miguel Angel Muñoz González
b18e8259cd Fortinet's FortiOS icap server (#52115) 2019-02-13 11:30:06 +00:00
Miguel Angel Muñoz González
30ab7135f0 Fortinet's FortiOS ips custom (#52118) 2019-02-13 11:29:53 +00:00
Miguel Angel Muñoz González
7d3247d3a5 Fortinet's FortiOS ips decoder (#52119) 2019-02-13 11:29:26 +00:00
Miguel Angel Muñoz González
4a9014fca1 Fortinet's FortiOS ips global (#52120) 2019-02-13 11:29:05 +00:00
Miguel Angel Muñoz González
7babf66d93 Fortinet's FortiOS ips settings (#52122) 2019-02-13 11:28:51 +00:00
Miguel Angel Muñoz González
364eb6e4a0 Fortinet's FortiOS ips rule settings (#52123) 2019-02-13 11:28:31 +00:00
Pilou
51270be883 tower modules: check that 'verify_ssl' defined in ~/.tower_cli.cfg isn't ignored (#50687)
* Check that verify_ssl defined in tower_cli.cfg isn't ignored

* Avoid to override verify_ssl value defined in tower_cli.cfg

By default, tower-cli library enables SSL certificates check. But
verify_ssl false value defined in config files read by default by
tower-cli library (for example /etc/tower/tower_cli.cfg) was ignored
because overriden by the tower_verify_ssl parameter default value.

* fix a typo in comment
2019-02-13 10:26:43 +00:00
Ondra Machacek
797a5218fb kubevirt: Add new kubevirt_vm module (#50768)
This module is managing virtual machines using KubeVirt.

Signed-off-by: Ondra Machacek <omachace@redhat.com>
2019-02-13 10:17:01 +00:00
Ross Williams
6e409a91ba Correct usage of sorted() in mongodb_user (#46792)
* Correct usage of sorted() in mongodb_user

sorted() can't be called on a list of dicts
without supplying a key parameter. This is
explained really well in the Sorting HOWTO
https://docs.python.org/3.6/howto/sorting.html#key-functions

This commit fixes #46791

* Fix PEP8 issues
2019-02-13 10:28:35 +01:00
Dag Wieers
21d43e6d94 win_product_facts: Fix RETURN information (#52058) 2019-02-13 19:09:30 +10:00
Straff
d4a07f9573 Added support for user-specified log file in win_package (#51104)
* Added support for user-specified log file in win_package - feature (#38353)

* added integration tests for win_package log_path support feature (#38353), and applied review feedback

* win_package log_path support feature (#38353) - fixed typo in win-package.py documentation

* win_package log_path support feature (#38353) - improved an integration test and better doc in win-package.py
2019-02-13 19:08:07 +10:00
Amol Kahat
563725ba98 Fixed typo from adress to address (#52143)
Signed-off-by: Amol Kahat <akahat@redhat.com>
2019-02-13 13:57:13 +05:30
Jiri Tyr
f49469f7bf Updating update_url for jenkins_plugin (#52086) 2019-02-13 01:32:34 -05:00
Matt Clay
04112d47a7 Fix more incorrect uses of is operator. 2019-02-12 20:04:20 -08:00
Will Thames
46fbcf08bc
aws_kms enhancements (#31960)
* Allow creation and deletion of keys (deletion just schedules for
  deletion, recreating an old key is just cancelling its deletion)
* Allow grants to be set, thus enabling encryption contexts to be
  used with keys
* Allow tags to be added and modified
* Add testing for KMS module
* Tidy up aws_kms module to latest standards
2019-02-13 13:06:58 +10:00
Matt Clay
0a461380a3 Fix incorrect use of is for comparisons.
See https://bugs.python.org/issue34850 for details.
2019-02-12 16:33:13 -08:00
Matt Davis
cd7a144515
fix docker default remote_user (#52137)
Fix bogus default value in config- exposed by become plugins (#50911) actually using this value in more cases.
2019-02-12 16:29:27 -08:00
Wojciech Sciesinski
a431e802ed Add posibilities to run the integration tests for PowerShell < 5.0 (#50808)
* Add posibilities to run the integration tests for PowerShell < 5.0

* Update of tests - based at a review comments for #50612

* The correction of YAML structure
2019-02-12 15:51:03 -05:00
Wojciech Sciesinski
a7528cdd25 Update the NuGet package provider when needed (#50759)
* Update the NuGet package provider when needed

* Update NuGet provider conditionally
2019-02-12 12:22:22 -08:00
Andrew Gaffney
9c35f18dd6 Custom jinja Undefined class for handling nested undefined attributes (#51768)
This commit creates a custom Jinja2 Undefined class that returns
Undefined for any further accesses, rather than raising an exception
2019-02-12 15:04:00 -05:00
Abhijeet Kasurde
4e0e09d2de docs: update docs about pipelining (#51856)
Additional documentation about `keep_remote_files` and
`pipelining` configurations.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-12 12:49:00 -05:00