Commit graph

49304 commits

Author SHA1 Message Date
Abhijeet Kasurde
7dcf32294b
Update URLs in documentation (#67376)
Partially fixes: #67357

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-18 09:00:30 +05:30
Jordan Borean
6b111e46ba
Win tests - prepare for collection migration in tests (#67506) 2020-02-18 10:29:30 +10:00
Baptiste Mille-Mathias
bb70c0b996
[doc] Set consistent return codes for modules (#67444)
Set consistent possible return codes for these similar two modules.
2020-02-17 17:50:52 -06:00
Jan Meerkamp
cbc38d2e5a
Windows: Add multi-domain forest Support (#65138)
* Add multi-domain forest Support
cloned extra_args so there is no check for credentials needed.
Fixed Formatting
added missing extra_args to pure state

* minor Fixes
do not clone $extra_member_args again
do not overide $name
better description

* added Changelog
fixed typo in Documentation
2020-02-18 08:43:17 +10:00
Sandra McCann
a60feeb3c1
Specify lowercase only for Galaxy namespaces (#67485)
* specify lowercase only for galaxy namespaces
* doh... include meta file
2020-02-17 15:26:47 -06:00
Bill Dodd
b5b23efdcc
Add SimpleUpdate command (#65074)
* add SimpleUpdate command

* add AllowableValues check for Targets property
2020-02-17 21:19:47 +00:00
Sam Doran
c64202a495
ansible-galaxy - fix role list bug (#67391)
Properly list roles even when the role name is the same or a substring of the
path to the role.
2020-02-17 16:16:14 -05:00
Jordan Borean
343de73f2d
Rebalance Windows groups for devel run (#67496) 2020-02-18 07:10:12 +10:00
Matt Clay
640e9c7722 Restore AIX tests in CI. 2020-02-17 13:05:28 -08:00
Sloane Hertel
b0abc1f5f6
Fix bug in iam_role - _list_policies was not returning anything (#67495) 2020-02-17 15:43:26 -05:00
Geoffrey Purdy
82ca00e4fe
Update windows_faq.rst (#67482)
Steers users around the error:  Could not install packages due to an EnvironmentError: [Errno 13] Permission denied: '/usr/local/lib/python2.7/dist-packages/xmltodict.py'
Consider using the `--user` option or check the permissions. -->
2020-02-17 13:38:46 -06:00
Jordan Borean
423a900791
Clarify b64encode with Python 2 (#67488) 2020-02-17 13:31:03 -06:00
Matt Clay
36ed3321fd
Disable failing zabbix_user test. (#67487)
* Disable zabbix_user test on aix.

* Disable failing zabbix_user test.
2020-02-17 11:11:13 -08:00
Sloane Hertel
6a8b1f867e
[aws_s3] fix deleting versioned objects before deleting bucket (#54435)
* [aws_s3] fix deleting the current objects and the previous versions from a version-enabled bucket

* use existing paginated_list function to keep compatibility with the other places it is called

* changelog

* Add noteworthy change to the porting guide

* Reword that with acozine's suggestion

Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
2020-02-17 13:16:09 -05:00
Martin Nečas
3bf6802cb2
ovirt_disk: correct description of storage_domain (#67454)
* ovirt_disk: correct description of storage_domain
* add changelog

Signed-off-by: mnecas <necas.marty@gmail.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-17 11:19:57 -06:00
Sandra McCann
39fef58bea
Add note that devel branch should not be used in real environments (#67483) 2020-02-17 10:53:16 -06:00
Lukas Kämmerling
62cc120dce
Add support for networks to hcloud inventory (#67453) 2020-02-17 13:39:37 +00:00
Rohit
e76630c4e4
VyOS: firewall_rules module added (#65680)
* firewall_rules module added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* state fact gathering code

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* facts and operation code added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* unit tests added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* delete opr updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2020-02-17 08:08:08 -05:00
Max Bubenick
eff51c0122
Fix proxysql module cursor_class (#67339)
* Fix proxysql module cursor class

* Adding changelog file

* adding extension to changelog file
2020-02-17 13:55:44 +01:00
Jordan Borean
38f26ffcc7
win_domain_object_info: new module (#67450)
* win_domain_object_info: new module

* Added basic integration tests
2020-02-17 18:22:11 +10:00
Brian Scholer
be26f4916f
win_dns_client DHCP improvements + more (#66451)
* Fix DHCP support in win_dns_client + more

* Fix bugs and test failures, add changelog fragment

* Add idempotency tests for DHCP

* Address review feedback; dedup address-family code

* Remove legacy function

* Remove old reference
2020-02-17 15:35:54 +10:00
Jordan Borean
e3d5dc0ed0
win_domain_controller: Added domain_log_path (#67448) 2020-02-17 07:25:22 +10:00
Ali
4733af3376
Added support for GitHub Enterprise to github_deploy_key module (#59564) 2020-02-16 17:33:06 +00:00
Christian Köberl
569f0cf808
azure_rm_rg_info: fix KeyError: 'ansible_facts' (#66729)
* azure_rm_rg_info: fix KeyError: 'ansible_facts'

Fix facts for using old azure_rm_resourcegroup_facts, closes #66727

* fix intendation
2020-02-16 17:03:31 +01:00
Sylvia van Os
ff0576802f
Support changing fetch_url settings for Rendeck modules (#66357) 2020-02-16 15:07:36 +01:00
CWollinger
274a07e7c7
Add module ipwcli_dns.py to manage DNS records on Ericsson IPWorks (#67135)
* Create ipwcli_dns.py

* add newline at the end

* Update after review and support AAAA

* Update lib/ansible/modules/net_tools/ipwcli_dns.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* add integration tests and change param user to username

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-02-16 15:05:44 +01:00
Lukas Bestle
31a6a37329
Add integration tests for the mas module (#67442)
* Add integration tests for the mas module

See https://github.com/ansible/ansible/pull/19768.

* Implement review feedback
2020-02-15 22:57:58 +01:00
Michael Heap
a43f76cbf9
Add mas module for installing applications via the Mac App Store (#19768)
* Add `mas` module for installing applications via the Mac App Store

Currently, only the `install` command is available, and you must provide IDs
when installing applications.

* mas module: Update metadata

Brings the metadata in line with the current style.

* mas module: General refactor, support more states

- `check_mode` is now fully supported
- Support for states `absent` and `latest` (using `mas uninstall` and `mas upgrade`)
- Support for a list of apps to manage
- Remove return value as other packaging modules don’t support it either
- Return msg with details on the changes on success
- Code was refactored to be easier to read and maintain

* mas module: Add upgrade_all option

* mas module: Fix linting errors

* mas module: Implement review feedback

Co-authored-by: Lukas Bestle <account-github@lukasbestle.com>
2020-02-15 19:44:20 +00:00
Ronnie P. Thomas
807f4ea658
Don't send JOIN and PART commands if channel is not set (#62334)
Currently, the irc module is sending JOIN and PART commands even if the channel
key is not set in the irc module. This causes the module to send JOIN and PART
commands to the #None channel. This module can send PRIVMSGs to either a
channel or a list of nicks, so sending JOIN and PART doesn't make sense in
cases where channel is undefined. The same goes for the TOPIC command, which is
used to set a topic for channels.

This patch ensures that the JOIN, PART and TOPIC commands are only sent if the
channel is defined.
2020-02-15 12:39:28 -05:00
tottoto
cc86748109
Fix url handling in lxd_container and lxd_profile module (#66097)
* Fix url handling in lxd_container module

* Fix url handling in lxd_profile module
2020-02-15 12:39:05 -05:00
koenw
eaf879a7a7
Fix uptimerobot stacktrace on decode (#66244)
* Fix uptimerobot stacktrace on decode

`req.read()` always returns bytes whereas the json module expects
strings.

I don't know how this worked before.

* Use `module_utils._text.to_native` instead of decode
2020-02-15 11:10:23 -05:00
Daniel Sternig
11483921f2
Added additional error handling inside the hcloud.py inventory plugin… (#66381)
* Added additional error handling inside the hcloud.py inventory plugin. Otherwise, errors may happen, if the HCloud API is not able to correctly identify the server image.

* Corrected the previous commit to not check for None on variables that are always set. Additionally, used image.description if image.name was not set, instead of the previously added default string.
2020-02-15 11:09:18 -05:00
Cody Hill
a753ff7cbf
Fix packet dynamic inventory "Slug" issue. (#63916)
* Fixed 'slug' bug in packet_net.py that was caused by a breaking change in the Packet API.

* Removed some debugging and comments I had left.

* Missed a spot!
2020-02-15 14:58:44 +00:00
Pilou
5aa60a5fa7
ovirt: don't ignore instance_cpus parameter (#64366) 2020-02-15 14:57:19 +00:00
Ilija Matoski
e1a815381a
Thresholds need to be passed for the log alert type (#64851)
* Thresholds need to be passed for the log alert type

* removed whitespace from linting error
2020-02-15 14:56:16 +00:00
Vitaly Shestovskiy
95d4908987
Fix packet.net dynamic inventory projects limit. (#64889)
* Added parameters to list more than 10 projects per run

* Fix slug issue due to packet api change. Same as https://github.com/ansible/ansible/pull/63916
2020-02-15 14:55:40 +00:00
Mads Jensen
f978b6c789
Use https for Ansible Slack icon. (#65625) 2020-02-15 14:53:18 +00:00
Emmanuel MICKIEWICZ
8647d0a873
Removing a cron file when the 'name' parameter is specified is now allowed (#57471). Added integration tests to validate new behavior. (#65640)
Also added user input validation to return a clear error when deleting an environment variables without specifying a name.
2020-02-15 14:52:36 +00:00
Phil
fe6848badd
sefcontext: fix fatal failure for socket file type (#65690)
fix #65689
2020-02-15 14:51:06 +00:00
Timm Drevensek
9541377a20
Port keycloak to python3 (#66452) 2020-02-15 14:44:18 +00:00
bitchkat
6b017db05b
support rabbitmq 3.8.x in version check (#66855)
* support rabbitmq 3.8.x in version check

* Removed extraneous white space
2020-02-15 14:42:32 +00:00
Felix Fontein
b1de5d43fc
openssh_keypair and openssl_privatekey: add regenerate option (#67038)
* Add regenerate option to openssh_keypair and openssl_privatekey.

* Add changelog.
2020-02-15 14:39:36 +00:00
Felix Fontein
55cb8c5388
docker_login: fix permissions for ~/.docker/config.json (#67353)
* Fix permissions for ~/.docker/config.json.

* Add changelog, remove debug output.
2020-02-15 14:38:58 +00:00
Lujeni
25181e1b70
mongodb_user: Ensure to close database connection (closes #59353) (#65665) 2020-02-15 09:10:27 -05:00
Jill R
c9b38bd74e
ec2_snapshot and ec2_snapshot_info test suite (#65896)
* ec2_snapshot and ec2_snapshot_info test suite

* Add a fact to make tests easier to follow.
Test all return values, and add missing RETURN docs to module.
2020-02-15 13:21:23 +00:00
Na-Ne
c2ad25020b
removed the multiline if condition as it seems unnecessary and also prevents the warning message (#66543)
* removed "this_dns_name" variable comparision with empty string.  #66537

* removed the imultiline if condition as it seems unnecessary.  #66537
2020-02-15 13:19:17 +00:00
Milan Ilic
717b7fee9f
Update redis module to support memory size units (#66975) 2020-02-15 13:15:12 +00:00
Pascal Stauffer
24ce97a49b
open_iscsi: Set default port as string (#67270) 2020-02-15 13:06:16 +00:00
Andrew Klychkov
59bcc9f739
Bugfix of 67377: postgresql_set converts value to uppercase if "mb" or "gb" or "tb" is in the value string (#67418)
* Bugfix of 67377: postgresql_set converts value to uppercase if "mb" or "gb" or "tb" is in the value string

* fix CI

* add changelog
2020-02-15 13:03:53 +00:00
Tomer Brisker
a4f5c2e993
Post reports to newer Foreman API endpoint (#64955)
The `/api/v2/reports` endpoint has been deprecated a long time ago and should
no longer be used. This changes to callback to use the correct API
endpoint and paramerter.
2020-02-15 13:01:27 +00:00