Brian Coca
cd076dbcfa
Merge pull request #14421 from bcoca/terminate
...
Terminate
2016-02-11 12:36:32 -05:00
Brian Coca
a8aa5ff4eb
fix cartesian lookup
...
it seems that this was not working in 1.9 but we swallowed up the error
fixes #14437
2016-02-11 10:35:37 -05:00
Peter Sprygada
cf251258a8
initial add of new action plugin junos_template
...
This adds a new action plugin, junos_template that allows the
the junos_template module to perform the templating function. It
implements net_template
2016-02-11 08:28:35 -05:00
Peter Sprygada
8f9badb2b4
update shared module junos to handle root logins
2016-02-11 07:36:56 -05:00
Peter Sprygada
9c36c0aa80
minor bug fixes and updates to shell
2016-02-11 07:36:47 -05:00
chouseknecht
5a45ca8bb1
Move Conditional class to netcfg. Added error handling for connect and execute methods.
...
Fix comments
2016-02-11 00:19:25 -05:00
Toshio Kuratomi
9286143b53
Merge pull request #14374 from robinro/fix-mount-without-permission-bug
...
add ismount function in module_utils
2016-02-10 17:32:19 -08:00
Toshio Kuratomi
6276585882
Module params should default to str in most cases.
2016-02-10 15:22:42 -08:00
Brian Coca
64c976a6c3
Merge pull request #14416 from bcoca/diff_size_fix
...
read full file when doing diff
2016-02-10 15:42:29 -05:00
Brian Coca
38120c1075
termination handling
...
- moved to base cli class to handle centrally and duplicate less code
- now avoids duplication and reiteration of signal handler by reassigning it
- left note on how to do non-graceful in case we add in future
as I won't remember everything i did here and don't want to 'relearn' it.
2016-02-10 15:35:30 -05:00
Brian Coca
3079a03773
read full file when doing diff
...
but avoid reading file at all or full file when file is too big for diffing
2016-02-10 12:05:45 -05:00
Toshio Kuratomi
371c7315b0
Merge pull request #14261 from kamsz/devel
...
Add validate_certs param to skip SSL verification in VMware
2016-02-10 08:50:48 -08:00
Toshio Kuratomi
486304ba1c
Clarify error message when module replacer encounters a bad import line for module_utils code
2016-02-10 08:46:17 -08:00
Brian Coca
d9dcb2a427
Revert "centralized TERM signal handling"
...
This reverts commit 5a88478ccc
.
is WIP, not ready for use yet
2016-02-10 09:48:42 -05:00
James Cammarata
2adddac94c
Catch exceptions during module execution so they don't fail the worker
...
Fixes #14120
2016-02-10 09:22:57 -05:00
Brian Coca
5a88478ccc
centralized TERM signal handling
2016-02-09 18:21:33 -05:00
Brian Coca
1b8dec9c88
avoid termination message when term is internal
2016-02-09 18:10:36 -05:00
Brian Coca
b4b24a0889
moved to base class for shell plugins
...
fish now sets env vars correctly
fish checksum now works
fixed and cleaned up imports
fixed typo
2016-02-09 17:39:51 -05:00
Brian Coca
f50b381dba
Merge pull request #13678 from Etherdaemon/fix_datetime_objects
...
fix for datetime exception in ecs_tasks
2016-02-09 17:07:28 -05:00
James Cammarata
a54f472b08
Submodule pointer update for devel
2016-02-09 13:30:50 -05:00
Matthew Stoltenberg
d36394d6a6
strip BECOME-SUCCESS at lower level
...
Fixes #14395
2016-02-09 13:03:18 -05:00
James Cammarata
162dd2594f
Filter become success string from the stdout of script results
...
Fixes #14390
2016-02-09 12:34:15 -05:00
Kamil Szczygiel
9f1eea43fa
support for python < 2.7
2016-02-09 08:49:26 +01:00
Toshio Kuratomi
0f15e59cb2
Also hide the before state of files with --diff and no_log
2016-02-08 22:05:46 -08:00
Toshio Kuratomi
06b2400aae
Need to apply to_str to each element of the list so that we don't mix types in the join()
...
"Third time's the charm"
2016-02-08 20:28:55 -08:00
Brian Coca
81a40ac235
fix winrm erorr formatting
2016-02-08 23:00:19 -05:00
Brian Coca
5014919099
Merge pull request #14347 from bcoca/die_now
...
fix termination on user/signal interrupt
2016-02-08 17:18:11 -05:00
Jonathan Davila
b220051c14
Added more info to the no action detected error
...
Error fix
2016-02-08 16:51:10 -05:00
Tom Paine
8e3cc3eecd
Update profile_tasks.rst
2016-02-08 19:19:05 +00:00
Toshio Kuratomi
1aaf5a399c
Merge pull request #14317 from resmo/feature/fail_on_missing_params
...
module_utils/basic: add generic method for checking for missing param…
2016-02-08 10:33:48 -08:00
Robin Roth
f3f3e3c660
fix typo
2016-02-08 19:10:04 +01:00
Robin Roth
c0ebb74ad0
add ismount function from python Lib/posixpath.py
...
needed for https://github.com/ansible/ansible-modules-core/pull/2737
2016-02-08 18:58:36 +01:00
Brian Coca
46ce9a0016
Merge pull request #13883 from shaba/devel
...
Add support ssh configs from /etc/openssh.
2016-02-08 10:27:44 -05:00
Tom Paine
5a88cd8ad9
Rename profile_tasks.md to profile_tasks.rst
2016-02-08 15:02:50 +00:00
James Cammarata
1ea21f1f8c
Also chmod the args file path when using become for old-style modules
...
Fixes #14348
2016-02-08 10:00:26 -05:00
Brian Coca
5a1887cc76
correctly handle term signals
...
- adhoc now terminates gracefully
- avoid race condition on terminations by ignoring errors if
worker might have been reaped between checking if active and termination call
- ansible-playbook now properly exits on sigint/term
- adhoc and playbook now give exceptions that we should not normally capture
and rely on top level finally to reap children
- handle systemexit breaks in workers
- added debug to see at which frame we exit
partial fix for #14346
2016-02-08 09:51:16 -05:00
James Cammarata
45755bc0e5
Merge pull request #14353 from felixfontein/devel
...
Include's tags argument allows only one tag to be specified.
2016-02-08 08:52:12 -05:00
Toshio Kuratomi
ccbc7d217b
Update submodule refs
2016-02-07 14:30:28 -08:00
Toshio Kuratomi
d1c2d16706
Allow setting run_command environment overrides for the life of an AnsibleModule
2016-02-07 12:46:04 -08:00
Felix Fontein
8eea1c7e01
Allowing multiple tags to be specified in include's tags argument.
2016-02-06 21:19:03 +01:00
Brian Coca
ad37a91514
really only want to prevent None typep here
...
false is sometimes needed
2016-02-05 14:33:10 -05:00
Tom Paine
9eca815377
Update profile_tasks.md
...
Converted to RST.
2016-02-05 18:06:10 +00:00
James Cammarata
c79d9a9c62
Handle run_once scenarios in the free strategy
...
* Raise an error if the action is using BYPASS_HOST_LOOP, to prevent
unexpected behavior from those actions
* Show a warning regarding tasks marked as run_once, as the free strategy
does not yet support that behavior
* Minor tweak to linear strategies run_once code to make sure we don't
raise an error if an action isn't found
2016-02-05 11:19:50 -05:00
James Cammarata
27f9cc05f8
Make sure run_once tasks also set any_errors_fatal so all hosts fail
...
Currently implemented only in the linear strategy (free strategy simply
ignores run_once/BYPASS_HOST_LOOP actions).
Fixes #14252
2016-02-05 10:58:24 -05:00
Brian Coca
d2846dbf30
Merge pull request #14280 from bcoca/always_tag_setup
...
WIP: tag the setup task with always
2016-02-05 10:33:34 -05:00
Peter Sprygada
18094d8595
Merge pull request #14313 from chouseknecht/net_template_changes
...
When in context of a role, create backup dir within role_path
2016-02-04 20:21:12 -05:00
Brian Coca
5679b5414c
avoid errors from possible None/False args
2016-02-04 19:39:56 -05:00
James Cammarata
75b6f61619
Fix the way we re-add variables from PlayContext to the variable dict
...
* If the internal value is None, do not add the variable
* Make sure all aliases for a given variable name are set (if they're
not already set in the dictionary)
Fixes #14310
2016-02-04 17:17:33 -05:00
Rene Moser
11522b22c3
module_utils/basic: add generic method for checking for missing params when argspec can not be used.
2016-02-04 22:54:03 +01:00
Toshio Kuratomi
e2a7ba35db
Fix --diff to respect no_log task parameter.
2016-02-04 12:44:45 -08:00
chouseknecht
4f61fb6cce
Add safety check on _backup key.
2016-02-04 14:47:43 -05:00
chouseknecht
0766219f58
When in context of a role, create backup dir within role_path
2016-02-04 14:47:43 -05:00
Toshio Kuratomi
4b7b3794c9
Update submodule refs
2016-02-04 11:10:50 -08:00
Brian Coca
89c57666c3
fixed py3 compatibility
2016-02-04 13:14:56 -05:00
Brian Coca
70ac47ae61
allow atomic_move to not be atomic ...
...
just 'cause people build bad systems that insist on not allowing
updates in an atomic manner and force us to do them in a very
unsafe way that has race conditions and can lead to many issues.
if using this option you should really be opening a bug report with
the system that only allows for this type of update.
and now i shower though i doubt i'll feel clean
2016-02-04 13:05:24 -05:00
Peter Sprygada
f30d5b1d94
Merge pull request #14012 from privateip/action_nxos_config
...
initial add of action plugin nxos_template
2016-02-04 11:41:41 -05:00
Peter Sprygada
c7180cf1a5
Merge pull request #14011 from privateip/action_ops_config
...
initial add of action plugin ops_template
2016-02-04 11:41:29 -05:00
Peter Sprygada
a48b521e62
Merge pull request #14010 from privateip/action_ios_config
...
initial add of action plugin ios_template
2016-02-04 11:41:08 -05:00
Peter Sprygada
30d03b93b4
Merge pull request #14009 from privateip/action_eos_config
...
initial add of action plugin eos_template
2016-02-04 11:40:21 -05:00
Peter Sprygada
ed3842aa87
Merge pull request #14008 from privateip/action_net_config
...
initial add of action plugin net_template
2016-02-04 11:40:07 -05:00
Brian Coca
6149685652
Merge pull request #14293 from dagwieers/fix-eval-json-booleans
...
Defined JSON booleans in global context for python eval()
2016-02-04 11:33:30 -05:00
Dag Wieers
2e171610e0
Also add 'null' as a possible JSON value
2016-02-04 14:19:46 +01:00
James Cammarata
699a854bf3
Fixing bugs in play iteration and strategies
...
* Fixed a bug in PlayIterator when ITERATING_ALWAYS, where the block
was advanced but the incorrect data structure elements were cleared
* Cleaned up the logic of is_failed() in PlayIterator
* Fixed a bug in the free strategy which had not been updated to use
the base strategy _execute_meta() method
* Stopped strategies from using is_failed() to determine if tasks should
still be fetched for a host
Fixes #14040
2016-02-03 18:42:27 -05:00
James Cammarata
da9ae14ff6
Adding new feature - meta: clear_host_errors
...
Allows for the clearing of any failed/unreachable hosts
2016-02-03 14:59:38 -05:00
Dag Wieers
dc48d27dd2
Defined JSON booleans in global context for python eval()
...
We define 'false' and 'true' as variables so that python eval() recognizes them as False and True.
This fixes #14291 .
2016-02-03 19:11:55 +01:00
Brian Coca
26cd465068
Merge pull request #14281 from dagwieers/fix-first-found-list
...
Handle when the lookup-plugin is used in jinja-style
2016-02-03 11:13:57 -05:00
Dag Wieers
dee5dba82a
Handle when the lookup-plugin is used in jinja-style
...
This fixes #14190 .
2016-02-03 17:10:40 +01:00
Brian Coca
dc6f0c1290
avoid logging color codes
2016-02-03 10:55:30 -05:00
Tobias Wolf
c902f926ca
Do not print empty diffs with _display.display()
2016-02-03 16:20:16 +01:00
Tobias Wolf
28169492f9
Do not insert newlines when diff is empty
2016-02-03 16:20:16 +01:00
Tobias Wolf
67594e8ec2
Fix handling of difflist containing multiple before/after pairs
...
Commit ansible/ansible@c337293 introduced a difflist feature. The return
value was not adequately outdented to append any diff after the first.
2016-02-03 16:20:16 +01:00
Peter Sprygada
4bda4a13e5
initial add of action plugin net_template
...
The net_config local action handles templating for network configuration
file. It will also allow network device configurations to be backed up
to the control host
Note: this plugin was originally named net_config but has been refactored to
net_template
2016-02-02 22:27:05 -05:00
Brian Coca
84f8241ff8
tag the setup task with always
...
fixes #14228
2016-02-02 16:31:22 -05:00
Toshio Kuratomi
42e312d3bd
Change $() into backticks. Backticks should work for both POSIX and non-POSIX compatible shells.
...
Fixes #14176
2016-02-02 12:38:21 -08:00
Toshio Kuratomi
147dba5d97
Merge pull request #14277 from ansible/default-shell-type
...
Establish sh as the default shell plugin.
2016-02-02 12:19:00 -08:00
Toshio Kuratomi
5b1d8cfd5c
Establish sh as the default shell plugin.
...
This is a fix for one of the problems pointed out in #14176
2016-02-02 11:46:09 -08:00
Brian Coca
8d4bc2003f
better fix for ansible-pull inventory handling
...
now it mirrors what it did in previous versions
and properly uses inventory and limit options
2016-02-02 14:22:15 -05:00
Brian Coca
197bed6fd8
make executable setting connection dependant
...
winrm shoudl not use executable, rest should?
fixes #14233
2016-02-02 13:13:02 -05:00
James Cammarata
b2c0abe998
Don't mark host as having gathered facts when peeking at next task
...
Fixes #14243
2016-02-02 10:22:52 -05:00
Kamil Szczygiel
fa13aa8c00
rename param from skip_ssl to validate_certs
2016-02-02 15:47:56 +01:00
Brian Coca
a584ab3420
Merge pull request #11113 from sysadmin75/11104_osx_facts_bridge
...
Fixes OSX fact gathering for the bridge interface.
2016-02-02 00:46:21 -05:00
Brian Coca
f628704a71
added option groups to make --help readable
...
Also moved -K to become to keep short option in view of removing the
separate sudo/su prompt options
2016-02-02 00:09:14 -05:00
Brian Coca
eafc31f3f8
Merge pull request #14197 from bcoca/safer_data_load
...
load now does not modify the incomming data
2016-02-02 00:02:23 -05:00
Brian Coca
dc15eb806e
deprecate all bare variable conversions (not debug)
...
now deprecation message appears with variable name in all spots where this occurs
debug's var= option is excluded as this is only place where bare variables shold actually
be accepted.
2016-02-01 18:59:14 -05:00
Brian Coca
28cf4bc00b
fix incorrect environment processing
...
it was assumed it could only be a dict or string (it starts out as a list)
also a 2nd assumption that bare vars only would appear in one of the dict keys.
removed deprecation warnings from here as they should be signaled in the bare conversion itself.
2016-02-01 18:54:09 -05:00
Brian Coca
6a62ad6c4b
hide internal params once used
2016-02-01 15:17:23 -05:00
Brian Coca
e0ed88e668
normalize error message on src != dir when local
...
now action plugin returns same error as module
2016-02-01 13:43:35 -05:00
Matt Martz
ddfab5faf1
Use isinstance type checks in bool filter so we can handle unsafe proxy objects. Fixes #14240
2016-02-01 12:32:59 -06:00
Peter Sprygada
b2f1c0691d
initial add of action plugin ops_template
...
Adds new local action ops_config for handling openswitch configurations using
either dc or cli based configurations. Implements the common net_config
local action.
Note this refactors the ops_config plugin to ops_template
2016-02-01 11:54:56 -05:00
Peter Sprygada
4f2a75923e
initial add of action plugin ios_template
...
Adds a new local action ios_config for working with cisco ios configuration
files. Implements the common net_confing local action
Note this plugin was refactored from ios_config to ios_template
2016-02-01 11:54:02 -05:00
Peter Sprygada
54f7a7b6d2
initial add of action plugin nxos_template
...
Adds new local action for working with cisco nxos configurations. Implemements
the net_config local action.
Note this action plugin was refactored from nxos_config to nxos_template
2016-02-01 11:52:50 -05:00
Peter Sprygada
be82caefd2
initial add of action plugin eos_template
...
Adds a new local action for eos_config module to handle templating configs
and backing up running configurations. Implements the local action
net_config
Note this action was refactored from eos_config to eos_template
2016-02-01 11:51:52 -05:00
Peter Sprygada
1733bf4053
minor update for nxos
...
This fixes a minor bug in the nxos config module to ensure that both the
cli and nxapi transport return the running config as a string and not
a list object.
2016-01-31 22:59:49 -05:00
Peter Sprygada
633b16d116
add exeception handling for invalid commands over nxapi
...
This commit will catch invalid commands being send over nxapi and call
fail_json on the module. The nxos shared module will now return the
failure
2016-01-31 20:10:20 -05:00
Brian Coca
49c15c8137
Merge pull request #14220 from bcoca/ansible_pull_once
...
harcoding inventory/hosts when pulling from repo
2016-01-30 11:35:12 -05:00
Toshio Kuratomi
9e3932ffca
Some attributes of callbacks aren't in v2. Port plugins to the v2 way to do that
...
Update porting guide with info on callback porting
2016-01-29 19:45:12 -08:00
Toshio Kuratomi
fb57818ea3
Explicitly set validate_certs=False as the boto default is True
...
Fixes #14089
2016-01-29 16:37:15 -08:00
Brian Coca
7964a35918
harcoding inventory/hosts when pulling from repo
...
return to pre 2.0 behaviour which did not factor inventory into the repo pull
2016-01-29 18:46:56 -05:00
Brian Coca
1aae6499ca
fixed code for v1 callback runtime compatiblity
...
old exception code obsoleted by exception avoidance
errors on callback produce warnings and don't stop play
2016-01-29 16:55:23 -05:00
James Cammarata
5587b08335
Make sure setup tasks inherit properly from their parent play
...
Fixes #13602
2016-01-29 15:38:46 -05:00