Commit graph

27120 commits

Author SHA1 Message Date
Peter Sprygada
817881d64f fixes problem where wrong ACL could be selected (#3099)
This fixes a bug where the wrong acl name could be matched in the running
config if the desired acl name is a starting subset.
2016-12-08 11:34:56 -05:00
Tim Rupp
6f0477a780 Fixes the enabled_vlans argument (#3061)
This argument had a couple of issues with it. First, as it was
being interpreted in the code, it did not check for idempotency.

Second, the model of having the parameters be "all_*" is going to
hinder the ability to "undo", so-to-speak, what the user did while
maintaining legibility.

Consider if the user specified "all_enabled_vlans='net1'" and then
decided they wanted to backout of this decision. What is the proper
argument to fulfill this wish? "all_enabled_vlans='...?'

This patch changes the all_enabled_vlans argument to be "enabled_vlans",
ensures that idempotency works, and also provides for a way to "undo" a
change to the enabled VLANs by allowing the user to specify the special
case VLAN named "ALL" (all capitals).

This makes the parameter more intuitive because the users will specify
which vlans they want to make the virtual available on

  * enabled_vlans="net1"

but also allows them to "undo" what they did by setting it back with
the case of all

  * enabled_vlans="ALL"
2016-12-08 11:34:56 -05:00
Tim Rupp
223d5cc7ee Adds copyright line for F5 contributed modules (#3081)
I was asked to do this as part of the contribution effort in house
2016-12-08 11:34:56 -05:00
Tim Rupp
de08965ab3 Corrects the required SDK version (#3095)
The SDK version that was mentioned originally was incorrect
2016-12-08 11:34:56 -05:00
Pieter Hollants
c2992fbb81 zypper_repository: Prepend --gpg-auto-import-keys before refresh command (#3088)
Fixes #3086.
2016-12-08 11:34:55 -05:00
Robin Roth
48ee364950 Add documention for enabled option in zypper_repository (#3083) 2016-12-08 11:34:55 -05:00
René Moser
d2eeabf129 slack: fix handling of html entities and escaping (#3032)
for < > & ' and "
2016-12-08 11:34:55 -05:00
Jonathan Mainguy
d4b94ec6bb fix timezone for centos6 (#3078) 2016-12-08 11:34:55 -05:00
John R Barker
66eaa464ee Typos in doc's strings (#3071) 2016-12-08 11:34:55 -05:00
Toshio Kuratomi
d52fc0f8a6 Update shippable config (#3063) 2016-12-08 11:34:55 -05:00
THEBAULT Julien
bfb1ad6690 Fix mongodb user compatibility check (#2731)
- Check the compatibility asap
2016-12-08 11:34:55 -05:00
Bryan Hundven
50092ed629 Fix the comment in the example. (#3050)
Fix the typo: `Crate` -> `Create`. Make a complete sentence.

Signed-off-by: Bryan Hundven <bryanhundven@gmail.com>
2016-12-08 11:34:55 -05:00
Ryan Brown
cdd874e61d Fix owner on gce_img 2016-12-08 11:34:55 -05:00
Rob
20cfe15e56 If parameters for policy, tags or versioning are not supplied, do not change the existing values defined for the bucket (#2938) 2016-12-08 11:34:55 -05:00
John R Barker
3a3612f57b asa_template is now deprecated (#2992)
* asa_template is now deprecated

* Delete asa_template

Since asa_template was added during 2.2 development, rather than
deprecate them
2016-12-08 11:34:55 -05:00
John R Barker
94bd3a70e5 Correct typos (#3055) 2016-12-08 11:34:55 -05:00
Ondra Machacek
7f51ec8bab ovirt_vms: wait for VM to be created for states stopped/suspended (#3044) 2016-12-08 11:34:55 -05:00
Thierno IB. BARRY
c0cfd1db45 elasticsearch_plugin: rewrite module to not use unsupported parameters (#2839)
* elasticsearch_plugin: rewrite module to not use unsupported parameters (#1785)

Avoid using parameters when they are not needed (#1785)

* elasticsearch_plugin: add version only during plugin installation and parse plugin name for its removal

* elasticsearch_plugin: join command args before running it
2016-12-08 11:34:55 -05:00
Tim Rupp
781dd9c459 Distinguish between untagged and tagged vlans
We were incorrectly making VLANS always be untagged when they could
be either tagged or untagged. This change corrects the arguments to
the vlan module to allow for specifying either untagged or tagged
interfaces. The arguments are mutually exclusive
2016-12-08 11:34:55 -05:00
Michael Scherer
9ec65db778 Use 'path' type for file arguments 2016-12-08 11:34:55 -05:00
Michael Scherer
c8bfab9c08 Add missing deps, since we use openssl to verify the date 2016-12-08 11:34:54 -05:00
Ryan Saunders
b48e1e9b65 Fix documentation typos and broken URL (#3039) 2016-12-08 11:34:54 -05:00
René Moser
91277fc0c7 twilio: fix false negative failure - sms was sent successfully (#3033) 2016-12-08 11:34:54 -05:00
Lujeni
e226211c5b Fix mongodb_user ssl_cert_reqs param (#2963) (#2965) 2016-12-08 11:34:54 -05:00
Michael Scherer
ead83cd148 Fix error in description of acme_directory (#3034) 2016-12-08 11:34:54 -05:00
Matt Clay
10ac3ba617 Revert "Set PRIVILEGED=true for Linux integration tests. (#3031)"
This reverts commit 7df7b52a5e.
2016-12-08 11:34:54 -05:00
steve-dave
587636b525 ec2_win_password.py - handle missing or unparseable key file more intuitively (#2729) 2016-12-08 11:34:54 -05:00
shane-walker
f108f8ef72 Fixes #1375, will check for new and outdated packages when running. (#3020) 2016-12-08 11:34:54 -05:00
Matt Clay
eedca027ee Set PRIVILEGED=true for Linux integration tests. (#3031)
This should allow test_mount tests to run on Shippable.
2016-12-08 11:34:54 -05:00
Matt Clay
841ec9ef1b Fix handling of ansible-doc errors. (#3030) 2016-12-08 11:34:54 -05:00
Lujeni
477d174fbc Fix mongodb_user default role value when update_password is set (#2997) 2016-12-08 11:34:54 -05:00
jctanner
981d1d3f96 vmware_guest: set the cpu and memory settings on clone (#3027)
Fixes #3026
2016-12-08 11:34:54 -05:00
Ryan S. Brown
bdec3a7cbb Fix ec2_asg_facts when name parameter is None
Closes #3021
2016-12-08 11:34:54 -05:00
Tim Rupp
15df1c84ad Fixes the bigip_selfip module to respect traffic groups (#3009)
The code for traffic groups was not being tested and therefore
had errors associated with it. It is now covered in coverage tests
and bugs that were found in it have been fixed.

See this issue for details
https://github.com/F5Networks/f5-ansible/issues/28
2016-12-08 11:34:54 -05:00
nitzmahone
4ff086c1a8 Fix win_chocolatey version comparison
fixes #2995
2016-12-08 11:34:54 -05:00
Matt Clay
b2b3d99839 Add shellcheck to sanity checks. (#3013)
Also disable deprecation warnings during module validation.
2016-12-08 11:34:54 -05:00
Tim Rupp
5abc8a1927 Corrects an implied map() usage as list (#3010)
In the six package, the map() function returns an iterator instead
of a list. This code was continuing to use the map() return value
as if it were a list and this broke the address_class facts.

This patch changes the code to use the list() method on the return
value of map().
2016-12-08 11:34:53 -05:00
Tom Melendez
fd92b66332 Change 'values' to 'record_data' for gcdns module. (#3003)
Using values caused problems while creating an integration playbook as it is a reserved word.  Seeing as this module is not yet released, it's prudent to make this change now.  'record_data' is more descriptive and uses the _data convention that we've established for instances.

No functionality in the module has changed.
2016-12-08 11:34:53 -05:00
Ondra Machacek
e7afabf060 Fix example in ovirt_auth module (#3001)
This patch fix missing quotes in ovirt_auth revoke token example
2016-12-08 11:34:53 -05:00
Robin Roth
a9cd8abb75 List python-xml in requirements for zypper* (#2937) 2016-12-08 11:34:53 -05:00
René Moser
59e6203a17 composer: update docs about issues on macOS if installed by homebrew (#2987) 2016-12-08 11:34:53 -05:00
Ondra Machacek
999a6488cf Ovirt auth/vms/disks modules (#2836)
* Add oVirt module to manage VMs

This patch add oVirt module to manage Virtual Machines

* Add oVirt module to manage authentication

This patch add oVirt module to manage authentication

* Add oVirt module to manage disks

* Added VM state management and fixups
2016-12-08 11:34:53 -05:00
perbly
ec05027c7e added enabled vlan functionality for f5 vip (#2988)
* added vlan functionality for f5 vip

* line 91, : was missing after description
2016-12-08 11:34:53 -05:00
Matt Clay
2152291960 Remove script previously used by Travis. 2016-12-08 11:34:53 -05:00
Lujeni
aa6aedf26c Improve mongodb_user exception (#2962)
- Better error message
2016-12-08 11:34:53 -05:00
Matt Clay
46d0b4dc16 Test module docs on Shippable. (#2976) 2016-12-08 11:34:53 -05:00
Matt Clay
5d78239f07 Combined notes to avoid duplicate key warning. (#2980) 2016-12-08 11:34:53 -05:00
Rob
e07c71dd99 Modification of describe_gateways key so that it is consistent with w… (#2936)
* Modification of describe_gateways key so that it is consistent with what create_gateway returns.
Also added AnsibleModule spec to require bgp_ip on state=present as defined in the doc

* Don't remove CustomerGateways key to preserve backward compatibility
2016-12-08 11:34:53 -05:00
jctanner
4cb3e87ca4 vmware_guest: do not assume disk params contain a datastore (#2974)
* vmware_guest: do not assume disk params contain a datastore
* Fix missed line during connection refactor
2016-12-08 11:34:53 -05:00
Matt Clay
f3e2f5d002 Remove Travis config since we only use Shippable. (#2975) 2016-12-08 11:34:53 -05:00