Brian Coca
84f8241ff8
tag the setup task with always
...
fixes #14228
2016-02-02 16:31:22 -05:00
Toshio Kuratomi
42e312d3bd
Change $() into backticks. Backticks should work for both POSIX and non-POSIX compatible shells.
...
Fixes #14176
2016-02-02 12:38:21 -08:00
Toshio Kuratomi
147dba5d97
Merge pull request #14277 from ansible/default-shell-type
...
Establish sh as the default shell plugin.
2016-02-02 12:19:00 -08:00
Toshio Kuratomi
5b1d8cfd5c
Establish sh as the default shell plugin.
...
This is a fix for one of the problems pointed out in #14176
2016-02-02 11:46:09 -08:00
Brian Coca
8d4bc2003f
better fix for ansible-pull inventory handling
...
now it mirrors what it did in previous versions
and properly uses inventory and limit options
2016-02-02 14:22:15 -05:00
Brian Coca
197bed6fd8
make executable setting connection dependant
...
winrm shoudl not use executable, rest should?
fixes #14233
2016-02-02 13:13:02 -05:00
James Cammarata
b2c0abe998
Don't mark host as having gathered facts when peeking at next task
...
Fixes #14243
2016-02-02 10:22:52 -05:00
Brian Coca
a584ab3420
Merge pull request #11113 from sysadmin75/11104_osx_facts_bridge
...
Fixes OSX fact gathering for the bridge interface.
2016-02-02 00:46:21 -05:00
Brian Coca
f628704a71
added option groups to make --help readable
...
Also moved -K to become to keep short option in view of removing the
separate sudo/su prompt options
2016-02-02 00:09:14 -05:00
Brian Coca
eafc31f3f8
Merge pull request #14197 from bcoca/safer_data_load
...
load now does not modify the incomming data
2016-02-02 00:02:23 -05:00
Brian Coca
dc15eb806e
deprecate all bare variable conversions (not debug)
...
now deprecation message appears with variable name in all spots where this occurs
debug's var= option is excluded as this is only place where bare variables shold actually
be accepted.
2016-02-01 18:59:14 -05:00
Brian Coca
28cf4bc00b
fix incorrect environment processing
...
it was assumed it could only be a dict or string (it starts out as a list)
also a 2nd assumption that bare vars only would appear in one of the dict keys.
removed deprecation warnings from here as they should be signaled in the bare conversion itself.
2016-02-01 18:54:09 -05:00
Brian Coca
6a62ad6c4b
hide internal params once used
2016-02-01 15:17:23 -05:00
Brian Coca
e0ed88e668
normalize error message on src != dir when local
...
now action plugin returns same error as module
2016-02-01 13:43:35 -05:00
Matt Martz
ddfab5faf1
Use isinstance type checks in bool filter so we can handle unsafe proxy objects. Fixes #14240
2016-02-01 12:32:59 -06:00
Peter Sprygada
1733bf4053
minor update for nxos
...
This fixes a minor bug in the nxos config module to ensure that both the
cli and nxapi transport return the running config as a string and not
a list object.
2016-01-31 22:59:49 -05:00
Peter Sprygada
633b16d116
add exeception handling for invalid commands over nxapi
...
This commit will catch invalid commands being send over nxapi and call
fail_json on the module. The nxos shared module will now return the
failure
2016-01-31 20:10:20 -05:00
Brian Coca
49c15c8137
Merge pull request #14220 from bcoca/ansible_pull_once
...
harcoding inventory/hosts when pulling from repo
2016-01-30 11:35:12 -05:00
Toshio Kuratomi
9e3932ffca
Some attributes of callbacks aren't in v2. Port plugins to the v2 way to do that
...
Update porting guide with info on callback porting
2016-01-29 19:45:12 -08:00
Toshio Kuratomi
fb57818ea3
Explicitly set validate_certs=False as the boto default is True
...
Fixes #14089
2016-01-29 16:37:15 -08:00
Brian Coca
7964a35918
harcoding inventory/hosts when pulling from repo
...
return to pre 2.0 behaviour which did not factor inventory into the repo pull
2016-01-29 18:46:56 -05:00
Brian Coca
1aae6499ca
fixed code for v1 callback runtime compatiblity
...
old exception code obsoleted by exception avoidance
errors on callback produce warnings and don't stop play
2016-01-29 16:55:23 -05:00
James Cammarata
5587b08335
Make sure setup tasks inherit properly from their parent play
...
Fixes #13602
2016-01-29 15:38:46 -05:00
Toshio Kuratomi
ceef202024
Update submodule refs
2016-01-29 09:59:58 -08:00
Toshio Kuratomi
315fd15f69
Merge pull request #12909 from photoninger/sles11.4-fix_2nd_try
...
Fix for SLES 11.4, which has now also an /etc/os-release file.
2016-01-29 09:11:51 -08:00
Brian Coca
dd4787701f
fix unicode input for template lookup
...
fixes #14207
2016-01-29 10:42:52 -05:00
James Cammarata
0c237c4531
Merge pull request #14191 from paulcalabro/devel
...
Added hyphen (-) as a valid character for permissions
2016-01-29 00:55:53 -05:00
Brian Coca
db375c22af
load now does not modify the incomming data
...
also removed json loader as yaml loader can do both
2016-01-28 19:43:17 -05:00
Toshio Kuratomi
2c825539ff
When setting up the local connection for the rsync we need to set the shell as well.
...
Fixes #13490
2016-01-28 16:02:57 -08:00
Paul Calabro
901d349f45
Adding a hyphen in the perms pattern section, since doing something like
...
go=- is a quick way to strip all permissions for non-owners.
2016-01-28 13:05:10 -07:00
Toshio Kuratomi
5ecfa8ddfc
Merge pull request #14189 from ansible/unicode-pager
...
Changes to convert to unicode at the borders
2016-01-28 11:46:34 -08:00
Toshio Kuratomi
605fb08487
Merge pull request #14168 from ansible/safer-squashing
...
Squashing was occuring even though pkgs didn't have a template that would be affected by squash
2016-01-28 10:57:43 -08:00
Toshio Kuratomi
fa9822df0f
Changes to convert to unicode at the borders
...
The module docs and vault changes solve issues where tracebacks can
happen. The galaxy changes are mostly refactoring to be more pythonic
with a small chance that a unicode traceback could have occurred there
without the changes. The change in __init__.py when we actually call
the pager makes things more robust but could hide places where we had
bytes coming in already so I didn't want to change that without auditing
where the text was coming from.
Fixes #14178
2016-01-28 10:56:46 -08:00
Toshio Kuratomi
e7a9031d61
Update submodule refs
2016-01-28 09:43:29 -08:00
Toshio Kuratomi
0e410bbc8a
Squashing was occuring even though pkgs didn't have a template that would be affected by squash
...
This broke other uses of looping (looping for delegate_to in the
reported bug)
Fixes #13980
2016-01-27 21:55:00 -08:00
Brian Coca
c857b20043
fixed issue with vars prompt warning causing error
...
sometimes display object is not magically available, use it explicitly,
no need to be classmethod anymore
fixes #14147
2016-01-27 16:13:06 -05:00
Toshio Kuratomi
3f3e3e3d5b
Return an error when synchronize is used with something other than an ssh connection
...
Suggested in #2832
2016-01-27 12:48:15 -08:00
Brian Coca
6bf2f45ff5
fix for so su works in more cases
...
should not fail anymore on csh, fish nor the BSDs
fixes #14116
2016-01-27 14:13:01 -05:00
Peter Sprygada
4fa6902c96
address minor bugs in nxos shared module
...
This addresses two issues with the nxos shared module. The first issue is
argument precedence checking. The module should prefer explicit arguments
over arguments passed vi the provider. This is now fixed to honor that
precedence. The second issue is collecting output from nxapi and returning
the response. Prior to this change the entire json structure was returned.
Now just the output is returned to align it better with cli based output
2016-01-27 11:25:56 -05:00
Peter Sprygada
c59916c43d
fixes issue with eos shared module argument precedence
...
The eos shared module should prefer to use explicit task arguments over
arguments provided through the provider. This fixes a problem where
that was not the case
2016-01-27 11:25:47 -05:00
James Cammarata
a61e51efb7
Don't try to generate retry files if the tqm hasn't been initialized
...
Fixes #14144
2016-01-27 09:56:50 -05:00
Toshio Kuratomi
cb2b19ced8
Fix for inventory hosts on localhost with alternate ports.
...
Fixes https://github.com/ansible/ansible-modules-core/issues/2831
2016-01-26 13:53:42 -08:00
James Cammarata
3ed3a5f43a
Make retry file generation not use StringIO
2016-01-26 14:52:41 -05:00
James Cammarata
78d499140c
Re-implementing the retry file feature for 2.0
...
Fixes #13944
2016-01-26 14:11:28 -05:00
James Cammarata
07a9a54b0e
Fix lookup of parent attribute when parent doesn't have the attr
...
Fixes #14100
2016-01-26 13:10:23 -05:00
Brian Coca
66104191d1
fixed permissions check for ansible.log
...
fixes #13990
2016-01-26 11:22:52 -05:00
Brian Coca
46fde754af
Merge pull request #14044 from skorochkin/devel
...
Adding support for scm-based role source urls (ansible-galaxy)
2016-01-26 10:41:05 -05:00
Tobias Wolf
5b293b56d6
Handle the key 'prepared' in the 'diff' result from modules
...
So far, when a 'diff' dict is returned with module results, it is
checked for 'before' and 'after' texts, which are processed in
_get_diff() by python difflib. This generates the changes to display
when CLI users specify --diff.
However, some modules will generate changes that cannot easily be
expressed in a conventional diff. One example is the output of the
synchronize module, which presents changed files in a common log format
as in `rsync --itemize-changes`.
Add a check for a diff['prepared'] key, which can contain prepared diff text
from modules.
2016-01-26 09:29:37 +01:00
Toshio Kuratomi
c44110bc81
Update submodule refs to pick up the synchronize internal parameter
2016-01-25 19:57:28 -08:00
Toshio Kuratomi
a23a5d1b93
Merge pull request #13968 from ansible/synchronize-become-is-reversed
...
synchronize: First cut at not doing sudo on the control machine but on the remote machine instead.
2016-01-25 19:52:03 -08:00