Commit graph

45235 commits

Author SHA1 Message Date
xuxiaowei0512
05e6339c49 option is marked as required but specifies a default (#57257)
* required and default are conflicting
2019-06-05 10:43:45 -04:00
xuxiaowei0512
229d20b6d9 update ce_facts (#57187) 2019-06-05 10:42:13 -04:00
xuxiaowei0512
9c3ae4c1f4 update lib/ansible/plugins/action/ce.py to fix a bug. (#57183)
* update lib/ansible/plugins/action/ce.py
2019-06-05 10:41:33 -04:00
Kevin Breit
919f70c357 New module - meraki_malware (#56929)
* Initial commit for meraki_malware module
- Allows for manipulation of malware configuration

* Add full documentation and improve code coverage

* Add diff support

* Type change

* Sanity check fixes

* Convert org_id from str to int for consistency

* Sanity fixes again

* Fix argument type errors

* Remove ignore items for some Meraki modules so shippable is happy
2019-06-05 10:36:39 -04:00
Kevin Breit
8bcf9b5734 meraki_network - Restructure execution logic (#56818)
* Restructure meraki_network to be simpler and work for all int tests

* Enable all integration tests and enhance error reports

* Slight tweaks to integration tests
2019-06-05 10:33:55 -04:00
Daniel Mellado Area
091bebcbf7 Add support for vlan update on ovs bridges (#57168)
This commit adds support for vlan update on openvswitch_bridge module.
2019-06-05 10:32:14 -04:00
Kevin Breit
72f2d05b6f meraki_content_filtering - Enable check mode (#54638)
* Add support for check mode.

* Add diff support
- Need to analyze diff for accuracy
- Updated check mode changed value

* Improve test coverage

* Remove a duplicate integration test
2019-06-05 10:31:50 -04:00
Kevin Breit
6da2d40500 meraki_admin - Enable check mode (#54499)
* Add support for check mode

* Add changelog fragment

* Add diff support
- Fix a few changed status
- Removed auth_key check since that's done in module_utils now
2019-06-05 10:23:54 -04:00
Ed Costello
30aeab4709 Make aws_ses_identity module work when region is provided via environment or config. (#51627)
fixes #51531
2019-06-05 09:51:58 -04:00
Martin Krizek
46f8bd47ce file: return 'useful' error message for recursion error (#57222)
* file: return 'useful' error message for recursion error

Fixes #56397

* Fix line length

* Re-phrase the error message
2019-06-05 09:30:09 -04:00
Martin Krizek
18f2ed63e0
file: fix setting relative paths for src for hard links (#56055) 2019-06-05 15:26:40 +02:00
Martin Krizek
705d0201cf
file: fix setting attributes for symlinked file (#57217) 2019-06-05 15:25:43 +02:00
Fred-sun
206f18dcca Update azure_rm_mysqlserver related document (#57382) 2019-06-05 09:10:12 -04:00
Fred-sun
9b6a295ca5 Update azure_rm_mysqlfirewallrule related document (#57384) 2019-06-05 09:08:53 -04:00
Sviatoslav Sydorenko
dfaa72297c Fix an RST link to the changelog config in docs 2019-06-05 15:08:09 +02:00
Martin Nečas
6e9eac74f0 ovirt vmpools creating vm options (#55815)
* ovirt vm pools add vm vars

* remove cloud init persist

* ovirt vm pools add nics

* ovirt vm pools add vm docs

* ovirt vm pools update docs

* ovirt vm pools update cloud_init docs

* update ovirt_vm_pools docs

* correct ovirt vm pools version_added
2019-06-05 03:27:27 -04:00
Jordan Borean
b5b75daaa5
win_chocolatey - honour version when bootstrapping chocolatey and fix package listing (#57208)
* win_chocolatey - honour version when bootstrapping chocolatey

* skip upgrade all step

* Fix install latest step

* Remove test changes now that Chocolatey is released

* tweak the package version detection
2019-06-05 09:10:10 +10:00
Matt Clay
b1e6ad9754
Limit Python 2.6 units to modules & module_utils. (#57377) 2019-06-04 15:15:36 -07:00
James Cassell
1fb0335243 group_chars: default change warning only when needed 2019-06-04 14:04:17 -07:00
Jill R
47cfbd6605
Add integration test provider for vmware (#55772)
* Add integration test provider for vmware

This change adds a new remote cloud provider option for vmware,
supporting dynamic environments running on worldstream.nl as well as
static environments specific by the user in a cloud-config template.
2019-06-04 13:49:30 -07:00
Abhijeet Kasurde
b8b0a2a20c aws: Update description for iam_role (#57346)
If IAM Role is created without description using aws cli or UI,
then Ansible failed to update description for such IAM role.
This fixes such condition.

Fixes: #52942

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-04 11:52:03 -07:00
Chris Archibald
57b3160f13 new feature (#57320) 2019-06-04 13:57:54 -04:00
dw
3fadf4a1cb Fix file descriptor leak in lineinfile module. (#57328) 2019-06-04 12:45:19 -04:00
Alan Rominger
256d1a9947 Add Chris Meyers to the tower team (#57349) 2019-06-04 11:59:50 -04:00
Fred-sun
1ddb37cdc2 Update azure_rm_mariadbserver related document (#57333) 2019-06-04 11:41:26 -04:00
Abhijeet Kasurde
695cd7f1da VMware: Notify team_vmware on connection plugin issues and PRs (#57279)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-04 11:35:32 -04:00
Nick Dokos
22b45f2c06 Clarify description of 'state' in the package module (#57241) 2019-06-04 09:45:49 -04:00
Fred-sun
2cb3094b68 Update azure_rm_mysqlconfiguration related document (#57335) 2019-06-04 09:41:00 -04:00
Fred-sun
15034fb5b5 Update azure_rm_mysqldatabase related document (#57338) 2019-06-04 09:37:22 -04:00
Abhijeet Kasurde
ee8a607cca ipaddr: Handle network address in ipmath (#57149)
* Updated testcase, documentation

Fixes: #54457

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-04 14:01:18 +05:30
Sumit Jaiswal
e620e27609
PR to fix the bug 57215 & 56300 under Nios Host_Record module (#57221)
* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* shippable error fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* review comment fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-04 10:52:16 +05:30
Sandeep Kasargod
78f6a7cbb1 New module for managing export groups in Vexata storage arrays. (#55481)
* Vexata export group module.
* Fix messages / error handling paths.
2019-06-04 10:05:40 +05:30
Chris Van Heuveln
6bb13bbb84 nxos_vlan: fix broken purge behavior (issue #57101) (#57229)
* nxos_vlan: fix broken purge behavior (issue #57101)

Symptoms/Analysis:
- `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1.
- `nxos` devices do not allow removing vlan 1 and raise a cli exception error
- Previous fix #55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g.
 - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true`
 - results in proper purging but vlan 4 is not created

Solutions:
- ignore vlan 1 when purging
- remove the `not purge` check from state present logic

Added additional unit tests and integration tests.
Tested against all regression platforms.

* PEP fixes

* Add agg_show_vlan_brief.txt fixture

* Add warning for removing vlan 1

* change method name check
2019-06-04 09:14:09 +05:30
Aaron Smith
333f54ec3b cloud/amazon/aws_config_recorder: add empty resourceTypes list if undefined (#50286) 2019-06-03 15:45:38 -07:00
Matt Clay
858e3a7272 Correct virtualenv usage in integration tests. 2019-06-03 15:23:04 -07:00
Mikhail Naletov
8cf6f56a01 Added sort option for zabbix_screen module (#56237)
* Added sort option for zabbix_screen module

* FIX: sort variable

* Added changelog file

* Fixed misspelling

* Update lib/ansible/modules/monitoring/zabbix/zabbix_screen.py

Changed spelling in the documentation

Co-Authored-By: flowerysong <junk+github@flowerysong.com>
2019-06-03 21:23:20 +02:00
Felix Fontein
7b40b569b2
Rename memset_*_facts to memset_*_info (#57030)
* Rename memset_*_facts to memset_*_info

* Add changelog.
2019-06-03 21:19:49 +02:00
Abhijeet Kasurde
5162d21ea3 VMware: vSphere Automation SDK installation docs (#57280)
* VMware: adds instructions for installing vSphere Automation SDK to the dynamic inventory scenario
2019-06-03 13:52:30 -05:00
Stefan Horning
ddfaa83ccf s3_bucket: add encryption capabilities to the module (#55985)
* s3_bucket: add encryption capabilities to the module
2019-06-03 11:25:09 -07:00
Fred-sun
3587f346c0 Update azre_rm_mariadbfirewallrule related document (#57288) 2019-06-03 12:51:02 -05:00
Fred-sun
ceb91ef80a Update azure_rm_mariadbdatabase relate document (#57287) 2019-06-03 12:49:38 -05:00
Martin Nečas
ea939c7e3e ovirt vnic profile update readme (#57298)
removes second of two identical examples
2019-06-03 11:35:10 -05:00
Ilya Reshetnikov
bf0e846a39 Update playbooks_filters.rst (#57200)
* Update playbooks_filters.rst to show JSON in the "JSON Query Filter" example data structure
2019-06-03 11:15:11 -05:00
Sam Doran
ce24b43f2e
Set community support for NetApp unit tests (#57198) 2019-06-03 11:52:32 -04:00
Piotr Gbyliczek
ec511e84bc Update azure_rm_appgateway.py (#56780)
* Update azure_rm_appgateway.py documentation to explain the dependency of authentication_certificates on cookie_based_affinity being enabled
2019-06-03 10:44:15 -05:00
Fred-sun
2d5c9e06fa Update azure_rm_manageddisk related document (#57206)
* Update azure_rm_manageddisk related documentation
2019-06-03 10:32:02 -05:00
Abhijeet Kasurde
0f10c4e8d2 aws: Handle exceptions while describing metric alarm (#57304)
Handle exceptions raised while describing the metric alarms rather than
printing tracebacks.

Fixes: #55786

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-03 11:23:53 -04:00
Thad Guidry
78b003858d Mention other ways to handle private key files (#57238)
Often when I am helping others learn Ansible, they are using nodes spun up on Amazon/Google/etc.  where private key files (pem) are needed.  Mentioning just a bit more on how to handle those private key files on the intro_getting_started page will help more folks get started faster.
I even reviewed the changes with my learning team and they all agreed this helped clarify immediately for them how to really get started with Ansible from a practical perspective.
2019-06-03 10:17:13 -05:00
Andrey Klychkov
3e06013eb6 unittests for module_utils.common.removed.removed_module function (#57214) 2019-06-03 11:12:12 -04:00
schowave
e6166b40cc Fixes typo in get_url (#57305)
Fixes Typo, need instead of ned
2019-06-03 20:36:48 +05:30