Commit graph

1454 commits

Author SHA1 Message Date
Stephen Fromm
9a3ad060dc Catch exception if form factor id is unknown 2012-08-02 07:06:55 -07:00
Michael DeHaan
38ed7ca7df Merge pull request #759 from lorin/error-feedback
If task action is invalid, output the name in error message
2012-08-02 05:39:53 -07:00
Lorin Hochstein
aed6ee7f74 Report only name in task error, all on one line 2012-08-02 08:37:43 -04:00
Lorin Hochstein
fa9fe9d246 If task action is invalid, output the name and action. 2012-08-01 23:51:25 -04:00
Michael DeHaan
fa79d57d13 changelog / remove a failed=False 2012-08-01 22:35:07 -04:00
Michael DeHaan
b7c3fd1246 failed should not be in the result returns for a module upon success 2012-08-01 22:30:22 -04:00
Michael DeHaan
fe87a16a3e Make yum module use one-pass with with_items 2012-08-01 22:27:25 -04:00
Michael DeHaan
91d31d8164 Merge pull request #761 from skvidal/devel
redo of yum module - uses more system calls but should handle
2012-08-02 05:13:23 -07:00
Seth Vidal
c91befda5c redo of yum module - uses more system calls but should handle
random plugin vomit better.
also should handle multiple withitems in a single execution, now.
2012-08-02 01:47:48 -04:00
Will Thames
4fedb17e38 Apply templating to module arguments in playbook
Module arguments should have variable substitution applied
Also, replacing task.action with the templated task.name seems wrong
2012-08-01 22:22:46 -04:00
Michael DeHaan
e820c282be Merge pull request #760 from sfromm/fixes
A couple fixes for the file module
2012-08-02 04:54:16 -07:00
Michael DeHaan
f092a69d77 Merge pull request #763 from willthames/sudo_missing_user
Raise exception when sudo user does not exist
2012-08-02 04:50:06 -07:00
Michael DeHaan
9e0bf168ca Merge pull request #764 from willthames/fail_copy_on_directory
Revert acceptance of directory as dest for copy
2012-08-02 04:49:17 -07:00
Will Thames
0e26ef9bdd Revert acceptance of directory as dest for copy
Although library/copy can be corrected to understand that dest is
a directory, I can't see how to let _execute_copy know this and let the
file module know.

As a better solution than before #733, the copy module now explicitly (rather
than silently) fails when dest is a directory.
2012-08-02 16:54:03 +10:00
Will Thames
d43d81a9a4 Raise exception when sudo user does not exist
sudo can fail before getting to the password prompt if a user does not exist
<pre>
[will@tangerine ansible (sudo_missing_user)]$ sudo -u bobbins echo hello
sudo: unknown user: bobbins
sudo: unable to initialize policy plugin
</pre>
Fix raises a distinct exception when that occurs
2012-08-02 16:19:15 +10:00
Stephen Fromm
d0892c19ad Add setype to file's argument_spec and remove secontext
secontext is used internally and should not be in argument_spec
2012-08-01 22:24:09 -07:00
Stephen Fromm
52afacf475 Fix module_fail_json call when symlink src does not exist 2012-08-01 22:23:02 -07:00
Michael DeHaan
bf25193ec1 changelog updates 2012-08-01 20:34:39 -04:00
Michael DeHaan
25acfa8170 Join with_items for the apt module, yum pending, and various fixes to the yum module to support aliases 2012-08-01 20:33:13 -04:00
Michael DeHaan
86ec639176 add error handling if you try to load files in the wrong data format 2012-08-01 19:51:52 -04:00
Michael DeHaan
08c5fe875b yell if input data for host or group vars are not hashes 2012-08-01 19:46:33 -04:00
Michael DeHaan
ed14312ad6 reinstate invalid argument checks where possible, daisy chainee/chained modules turn it off 2012-08-01 19:42:31 -04:00
Michael DeHaan
08999a2a2f Merge pull request #748 from dagwieers/make-rpm
Implement git commit date into RPM release
2012-08-01 16:29:16 -07:00
Michael DeHaan
3ff03d14e3 Merge pull request #751 from Ernest0x/ignore_errors_task_option
added an 'ignore_errors' option to tasks
2012-08-01 16:28:35 -07:00
Michael DeHaan
77029a4227 Merge pull request #752 from go2sh/apt-patch
Enable apt module to handle multiply packages (comma separated)
2012-08-01 16:27:29 -07:00
Michael DeHaan
128a606a59 Merge pull request #756 from sfromm/issue755
Issue755 - fixes for service module
2012-08-01 16:27:13 -07:00
Michael DeHaan
53c62f2655 Merge pull request #757 from pas256/devel
Smiting Debian packaging instructions that did not work
2012-08-01 16:26:50 -07:00
Peter Sankauskas
b1b543c289 Smiting Debian packaging instructions that did not work, and replacing
them with the correct instructions. Changing file to .md to match 'docs'
file.
2012-08-01 16:12:10 -07:00
Stephen Fromm
abe8d8d4d6 Return extra information from service module
If _do_enable() is run and returns rc == 0, set changed=True
Add enabled and state to result if they are supplied when the module is
run.
2012-08-01 14:58:32 -07:00
Stephen Fromm
42ad1c879f Fix service module for issue 755 and another bug
Allow use of service module with just enable parameter, per issue #755.
Also fixed two other issues:
- fixed parameter to be 'enabled' per docs, not 'enable'.
- fixed if block that checks whether to run _do_enable() to check
  whether the parameter is set, not the value of the enable value which
  may be None or False.  If enabled=no, the service would never be
  disabled.
2012-08-01 14:44:26 -07:00
Petros Moisiadis
2ac4acbf97 fixes for tests 2012-08-01 22:17:16 +03:00
Christoph Seitz
6baaea90ae Tweaked error massages. 2012-08-01 18:45:32 +02:00
Christoph Seitz
b973910283 Some optimizations to previous code. 2012-08-01 18:43:39 +02:00
Petros Moisiadis
5f4bf813b1 added an 'ignore_errors' option to tasks
Failed tasks with ignore_errors=True, allow the remaining tasks in the
play to be executed as if no failure happened. A failure notice is still
written to the output as well as an '...ignoring' message.
2012-08-01 19:13:07 +03:00
Christoph Seitz
418445d3c5 Enable apt module to handle multiply packages (comma separated) 2012-08-01 18:09:30 +02:00
Michael DeHaan
2d9ceafbd4 Merge pull request #749 from jpmens/get_urlcomma
get_url except fix
2012-08-01 06:39:01 -07:00
Michael DeHaan
f60517aa33 temporarily disable failing check on some things 2012-08-01 09:33:20 -04:00
Jan-Piet Mens
31c0e523c2 Fix exeptions, replace 'as' by ',' as reported on IRC for Python 2.4.3 on Centos5 2012-08-01 15:30:16 +02:00
Dag Wieërs
6b774f8cf5 Place the freshly built RPM directly into rpm-build/
So we get the exact behavior as the SRPM build
2012-08-01 15:25:19 +02:00
Dag Wieërs
ec7c8eb8ca Implements git commit date into RPM release
With this patch one can do `make rpm` and get an RPM file that looks like:

  rpm-build/noarch/ansible-0.6-0.git201208010541.el6.noarch.rpm

My goal was not to rewrite the original SPEC file, and/or the tarball. In other
projects what I tend to do is prepare the SPEC file in the tarball with the
correct version/release so that rpmbuild works on the (released) tarball as
well. If this is wanted, we will have to rewrite the SPEC file on the fly as
part of creating the tarball. If there is no git or .git/ available, we will
use the current time.
2012-08-01 14:58:02 +02:00
Michael DeHaan
cfea9c54bb Update README.md 2012-08-01 09:16:21 -03:00
Michael DeHaan
0a3ebdb6d5 Module consistency and make daisy chaining work with invalid arguments detection. 2012-08-01 00:22:02 -04:00
Michael DeHaan
db9955d3df Merge pull request #743 from akhayyat/devel
Allow = symbols in variable values in host inventory
2012-07-31 20:41:31 -07:00
Ahmad Khayyat
6728b6cdda Allow = symbols in variable values in host inventory 2012-07-31 23:36:26 -04:00
Michael DeHaan
7d2877fbf9 Merge pull request #742 from willthames/fix_test_one
fixing test_one
2012-07-31 20:32:59 -07:00
Will Thames
845a7ac5ae test_one not working as tests after skipped test failing, because
on_skipped callback being passed an extra item parameter that it wasn't
expecting.
Fixed it so that on_skipped in TestCallbacks accepts and ignores the
extra parameter
Extra parameter was added in 4b9b9a8a5b
but not really clear why from commit message
2012-08-01 12:35:17 +10:00
Michael DeHaan
8700de964c Teach the common module code to warn users about typo'd arguments and also set everything to None automatically such
that code doesn't have to do a lot of params.get('foo', None) everywhere.
2012-07-31 21:23:34 -04:00
Michael DeHaan
190d72761f Reformat changelog so it's easier to tell what is new 2012-07-31 21:00:55 -04:00
Michael DeHaan
dc3e142486 Merge pull request #741 from tima/low-level-stderr
concatenating stdout and stderr in runner/__init__'s _low_level_exec_command
2012-07-31 17:32:29 -07:00
Timothy Appnel
b30f4688cd concatenating stdout and stderr in runner/__init__'s _low_level_exec_command. 2012-07-31 16:59:45 -04:00