Will Thames
0e26ef9bdd
Revert acceptance of directory as dest for copy
...
Although library/copy can be corrected to understand that dest is
a directory, I can't see how to let _execute_copy know this and let the
file module know.
As a better solution than before #733 , the copy module now explicitly (rather
than silently) fails when dest is a directory.
2012-08-02 16:54:03 +10:00
Michael DeHaan
ed14312ad6
reinstate invalid argument checks where possible, daisy chainee/chained modules turn it off
2012-08-01 19:42:31 -04:00
u348095
3cb51acd78
Allow copy dest argument to be a directory
...
Could have used shutil.copy rather than shutil.copyfile, but this
implementation preserves the md5 comparison to avoid unnecessary copies
2012-07-31 14:47:01 +10:00
Michael DeHaan
9f149c9f1a
imports not needed
2012-07-21 17:25:47 -04:00
Michael DeHaan
d0f4358730
Port the copy module over to the new "common module" logic.
2012-07-21 17:07:42 -04:00
John Kleint
375a1eaf43
Use iterative MD5 hashing.
2012-07-09 13:27:47 -04:00
Dave Hatton
55694db7c3
switch to hashlib.md5 or md5 instead of OS md5 commands
2012-07-09 08:52:00 +01:00
Dave Hatton
ecaa794f7f
copy always returned change=true
2012-07-06 13:43:19 +01:00
Dave Hatton
9d85a55434
switch to shutil.copy rather than os.system(cp)
2012-07-04 12:26:25 +01:00
Dave Hatton
263fcab594
md5 allow copy if file is missing
2012-07-03 20:07:08 +01:00
Jeremy Smitherman
3003aa2d47
Added IndexError catch for copy module, IndexError is thrown if a destination file doesn't exist
2012-07-03 14:12:19 -04:00
Dave Hatton
d47de18b6c
improve error trapping for md5
2012-07-03 12:44:37 +01:00
Ingo Gottwald
a42167ca73
Copy module: Extended error handling and fixed error messages
2012-06-25 20:45:05 +02:00
Ingo Gottwald
270266e920
Added to copy module: Error handling for missing permissions on the copy destination
2012-06-23 21:39:37 +02:00
Michael DeHaan
25083953fc
Merge pull request #495 from nafeger/devel
...
make copy module implemented closer to other newer modules when returning results
2012-06-20 13:12:24 -07:00
Nathan A. Feger
26816b72ec
attempt to make copy more idiomatic.
2012-06-20 14:17:15 -05:00
Fred Alger
834f6a216d
Make shell outs to md5sum work on FreeBSD and OS X
...
Tested with OS X local connection and Linux remote. The paths to the
md5sum and md5 commands are hardcoded to the most common location. This
will definitely fail if the commands are elsewhere, or if the md5
command doesn't support the -q 'quiet' option.
2012-06-15 00:04:01 -04:00
Stephen Fromm
aea022b002
Apply logging of arguments to modules (issue #122 )
...
The ohai and facter modules use /usr/bin/logger to log the fact that
they have been invoked. I added 'import os' to the ping module
so that it could have the same syslog statements as the other modules.
I separated the condensed:
shlex.split(open(argfile, 'r').read())
into two separate statements similar to the other modules.
2012-05-09 15:19:20 -07:00
Seth Vidal
c701e59592
very minor indentation issue in librar/copy
2012-04-27 16:45:28 -04:00
Michael DeHaan
7794493952
Don't try to expand path for None values
2012-04-20 08:02:12 -04:00
Michael DeHaan
445e48b991
Call os.path.expanduser in modules so things work as expected even when using ./hacking/test-module script
2012-04-20 07:57:39 -04:00
Jeroen Hoekx
38a33c54a6
Make copy module idempotent.
...
Check md5sum before overwriting a file. Unconditionally copying changes the timestamp.
2012-03-31 13:59:41 +02:00
Michael DeHaan
4bde4926c3
Modules don't have to return JSON, key=value pairs is ok.
2012-03-14 21:16:15 -04:00
Michael DeHaan
aeea46678d
Fix the copy module to use the argsfile method
2012-03-14 19:09:44 -04:00
Michael DeHaan
eaa7714ff8
Laying the groundwork for async mode, async status script still needs to be done, and async_wrapper
...
still needs to daemonize. Then, once done, playbook can be taught how to poll async within the
timing window.
2012-03-03 12:25:56 -05:00
Michael DeHaan
be4cb64c92
Relicensing to GPLv3, all previous committers ok'd on mailing list.
2012-02-28 19:08:09 -05:00
Michael DeHaan
ba4e36a9a9
Rename 'ensure' to 'state' because I think it's a bit cleaner and doesn't imply
...
all modules take a common parameter name. But more or less we still work idempotently
in modules.
2012-02-26 22:31:42 -05:00
Michael DeHaan
61d064d011
Fixed up KV munging in runner, misc fixes to copy, setup, and template modules
2012-02-26 19:55:26 -05:00
Michael DeHaan
e5f62f20b1
make copy & template module take key/value parameters so we're consistent. Only the command
...
module works differently now
starter manpage for modules
allow template file location to be passed into template & setup modules
2012-02-26 19:21:44 -05:00
Michael DeHaan
deb71da91e
trim md5sum string so it does not contain the filename
...
also fix a bug/typo in the reporting from playbook
2012-02-26 12:10:57 -05:00
Michael DeHaan
b44ae0af90
applying indentation patch from skvidal
2012-02-25 17:16:23 -05:00
Michael DeHaan
6cceaa5f6a
Implment copy with an actual minion-side module such that we can get md5sum's and
...
onchange events like Puppet's file providers do.
2012-02-24 05:15:28 -05:00
Michael DeHaan
3807824c6d
Added file copy support w/ readme updates
2012-02-23 16:07:10 -05:00
