Commit graph

47495 commits

Author SHA1 Message Date
Will Thames
a684bb9f5b Ensure k8s apply works with check mode (#60572)
* Ensure k8s apply works with check mode

Update the new predicted object with fields from the previous object
before applying in check mode

Don't log output of `file` with `state: absent` on huge virtualenvs!

Fixes #60510

* Use openshift client fix to improve apply for check mode

Use new apply_object method to get a better approximation
of the expected object in check mode.

Requires released upgrade to openshift

* Add changelog fragment for k8s apply check mode fix

* Update changelogs/fragments/60510-k8s-apply-check-mode.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-09-19 05:30:31 +02:00
Toshio Kuratomi
bebb11b918 Disable setting of -s in shebang
RPM builds on Fedora and RHEL create a python shebang line with -s

This is not good for ansible since ansible has a lot of optional
features which need extra dependencies installed.  If the user installs
those extra dependencies to their home directory or to /usr/local then
the -s will keep them from being used.
2019-09-18 20:27:56 -07:00
Rohit
978def38d8
error message updated (#62536)
* error message updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* error message updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-09-19 08:34:31 +05:30
Matt Clay
1c64dba3c9 Fix plugin names for collection plugins. (#60317)
* Fix plugin names for collection plugins.

Add an integration test to verify plugin __name__ is correct for collection plugins.

* Fix collection loader PEP 302 compliance.

The `find_module` function now returns `None` if the module cannot be found. Previously it would return `self` for modules which did not exist.

Returning a loader from `find_module` which cannot find the module will result in import errors on Python 2.x when using implicit relative imports.

* add changelog

* sanity/units/merge fixes
2019-09-18 17:47:56 -07:00
yanzhangi
cbe8271745 update ce_static_route to fix bugs (#62498) 2019-09-18 20:31:44 -04:00
Sam Doran
b7897e3a8d cron - Only run get_bin_path() once (#62554) 2019-09-18 19:04:26 -04:00
Jordan Borean
064e443ea5
psexec - Fix kerb and interactive support (#62556) 2019-09-19 08:41:02 +10:00
Matt Davis
d0c7b42e58
fix collection jinja2 cache issue (#62543)
* prevents premature lookup (and potential KeyError) of Jinja filter/test function cache that's not fully populated
2019-09-18 14:39:59 -07:00
Jordan Borean
bad338aca6
win_exec_wrapper - Be more defensive when trying to get output errors (#62376)
* win_exec_wrapper - Be more defensive when trying to get output errors

* Fix up property search
2019-09-19 06:53:56 +10:00
Jordan Borean
bf5b6695ec Add hint for config option priority (#62463)
* Add hint for config option priority

* Fix some spelling issues
2019-09-18 16:36:08 -04:00
Old Schepperhand
864928365e Improve dconf documentation to include conversion problems (#62316) 2019-09-18 16:04:44 -04:00
Jordan Borean
d16ee65ecd Add link to become plugins in become docs (#62462) 2019-09-18 15:53:16 -04:00
Marco Tulio R Braga
a4a216640f chore/doc-module: sts_assume_role.py (#62475)
Update `Example` section with with the correct module usage.
2019-09-18 15:50:34 -04:00
Jean-Frédéric
951a80c8b0 cron - Use the default crontab executable in cron and cronvar modules (#59765)
In some remote environments, the `crontab` executable is
overloaded with a custom executable, which typically does
some pre/post processing before forwarding to crontab.

Instead of using the hardcoded `/usr/bin/crontab`, this uses
the `get_bin_path` utility to locate the default crontab executable.
2019-09-18 15:35:06 -04:00
Rohit
b24f7d2800
vyosnoconfig tracebackfix (#62518)
* vyosnoconfig tracebackfix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* vyos noconfig tracebackfix test cases added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test/integration/targets/vyos_lldp_global/tests/cli/empty_config.yaml
2019-09-18 21:58:39 +05:30
chkp-orso
55f285a384 fix if equals error code if command not found (#62529) 2019-09-18 18:00:42 +02:00
chkp-orso
2232232b45 fix delete to pass the right parameters (#62525) 2019-09-18 20:59:59 +05:30
chkp-orso
cf8e84fc62 fix session_uid (#62523) 2019-09-18 20:38:31 +05:30
Jordan Borean
2e1c6a7839 Add fix for specifying current dir in collections_paths (#62478) 2019-09-18 08:04:22 -07:00
Sloane Hertel
66e5427ffb
cloudformation_info - fix KeyError (#62290)
* cloudformation_info - fix KeyError

* changelog
2019-09-18 09:58:58 -04:00
Andrey Klychkov
b87b359df5 postgresql: move CI tests of *_owner, *_info, *_ping, *_query to separate targets (#62500) 2019-09-18 14:22:13 +01:00
Paul Belanger
05ef39551a
Remove unused variable from nxos module_utils (#62474)
This variable isn't used, remove it to make linters happy.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-18 09:11:47 -04:00
Lukas Kämmerling
d5449eed11 tests: hcloud: Enable hcloud_floating_ip_info tests (#62494) 2019-09-18 13:55:05 +02:00
Mike Wiebe
97b15e9f0c [stable-2.9] Stabilize nxos initiated copy for nxos_file_copy plugin (#62355)
* Retry spawn connection on failure

* Add debug logs

* Additional debug logs

* Close session before respawn attempt

* More debug info and increase loops

* Remove debug info and reset error dict on reconnect

* Add epdb debuger

* Add epdb debuger

* Add epdb debuger

* Wait before sending password and close pexpect session

* Fix comment typo

* Scrub error logs

* Scrub error logs

* Add more specific initial connect pattern

* Fix shippable errors

* Dont make remote_scp_server_password a hard requirement

* Add saftey check
2019-09-18 17:07:50 +05:30
Lukas Kämmerling
fd7e156ccd Add hcloud_floating_ip module (#62409) 2019-09-18 11:26:53 +02:00
Pascal Van Acker
24ff3f257b fix azure_rm_rediscache notify notify_keyspace_events type (should be str) (#58922) 2019-09-18 17:01:28 +08:00
Matt Clay
7d40f6d53e Remove obsolete MANIFEST.in entries. 2019-09-17 21:49:05 -07:00
Pilou
e51fa5c972 luks_device: ansibot wasn't able to extract author (#62464)
Ansibullbot ignores lines without 'author' or dash [1].

The following command allows to check that no other module is impacted:

    rgrep -A1 -P "^author:[[:space:]]*$" lib/ansible/modules/ |grep -P "\.py-[[:space:]]*[^-][[:space:]A-Za-z\"'@()]+$" -B1

Related: https://github.com/ansible/ansibullbot/issues/1106.

[1] 02ae638641/ansibullbot/utils/moduletools.py (L828)
2019-09-18 00:32:24 -04:00
yanzhangi
2d85cb3ded Update ce_info_center_global to fix bugs (#61283)
* Update ce_info_center_global to fix bugs

* Update ce_info_center_global to fix bugs

* Update ce_info_center_global to fix bugs
2019-09-18 00:15:14 -04:00
yanzhangi
9bf0e69601 Update ce_bgp_neighbor to fix bugs (#60634) 2019-09-18 00:05:56 -04:00
yanzhangi
8233389446 Update ce_netstream_export to fix bugs (#61652)
* Update ce_netstream_export to fix bugs

* Update ce_netstream_export to fix bugs
2019-09-17 23:56:15 -04:00
yanzhangi
80fa2a0816 Update ce_netstream_aging to fix bugs (#61653)
* Update ce_netstream_aging to fix bugs

* Update ce_netstream_aging to fix bugs
2019-09-17 23:56:09 -04:00
yanzhangi
027cd16b1a Update ce_snmp_target_host to fix bugs (#61842) 2019-09-17 23:20:58 -04:00
yanzhangi
a260209098 Update ce_bgp_neighbor_af to fix bugs (#60937)
* Update ce_bgp_neighbor_af to fix bugs

* Update ce_bgp_neighbor_af to fix bugs

* Update ce_bgp_neighbor_af to fix bugs
2019-09-17 23:02:36 -04:00
yanzhangi
3cde0b5693 Update ce_evpn_global to fix bugs (#61013) 2019-09-17 22:52:32 -04:00
yanzhangi
80ead00838 Update ce_mtu to fix bugs (#61442) 2019-09-17 22:52:16 -04:00
yanzhangi
12512f7319 Update ce_vxlan_arp to fix bugs (#61995)
* Update ce_vxlan_arp to fix bugs

* Update ce_vxlan_arp to fix bugs
2019-09-17 22:52:11 -04:00
yanzhangi
e559fafbc4 Update ce_vxlan_vap to fix bugs (#61996) 2019-09-17 22:52:04 -04:00
yanzhangi
90958b01c1 Update ce_evpn_bgp to fix bugs (#61136) 2019-09-17 22:08:27 -04:00
yanzhangi
1a8c1c7365 Update ce_evpn_bgp_rr to fix bugs (#61168) 2019-09-17 22:08:12 -04:00
yanzhangi
8eec5d2ab2 Update ce_interface_ospf to fix bugs (#61431) 2019-09-17 22:07:48 -04:00
yanzhangi
698e3eae5e Update ce_ntp to fix bugs (#61654) 2019-09-17 21:56:51 -04:00
yanzhangi
9d9863fec1 Update ce_ospf to fix bugs (#61684) 2019-09-17 21:56:44 -04:00
yanzhangi
e1ca38e53a Update ce_snmp_traps to fix bugs (#61843) 2019-09-17 21:56:30 -04:00
yanzhangi
5f35916b22 update ce_bgp to fix bugs (#60573)
* update ce_bgp to fix bugs

* update ce_bgp to fix bugs

* update ce_bgp to fix bugs

* update ce_bgp to fix bugs

* Update ce_bgp to fix bugs
2019-09-17 21:46:34 -04:00
yanzhangi
db0f290ca3 Update ce_vrf_af to fix bugs (#61683) 2019-09-17 21:45:18 -04:00
yanzhangi
466c3e63ce Update ce_stp to fix bugs (#61774) 2019-09-17 21:45:06 -04:00
Xu Yuandong
b2d145d924 ce_mlag_interface:update to fix a bug (#60144)
* update to fix a bug

* ansible-test Ignoring 'blacklisted-name' on 'lib/ansible/modules/network/cloudengine/ce_mlag_interface.py' is unnecessary

* update

* update

* update for shippable

* update for shippable

* Update ce_mlag_interface.py

* Update ce_mlag_interface.py

* Update ce_mlag_interface.py

* Update ce_mlag_interface.py
2019-09-17 21:24:34 -04:00
Matt Clay
acd459f909
Add missing changelog fragments. (#62471)
* Add missing default-test-container 1.9.2 fragment.
* Add missing default-test-container 1.9.3 fragment.
2019-09-17 17:33:58 -07:00
Matt Clay
3b86dc3e12
WIP - Fix ansible-doc bugs and add integration tests. (#62461)
* Add integration tests for ansible-doc.

* Enable tests that now pass

* Cleanup processing of plugin docs

* Mostly separate the steps of processing plugin docs

  1) Acquire source data
  2) Transform and calculate additonal data
  3) Format data for output
  4) Output data

  format_plugin_doc() is still mixing transformation and formatting but
  that should be fixed in a devel-only change

* Raise exceptions in _get_plugin_doc() on errors.

* Remove check to exclude on blacklisted extensions.  We already request
  only .py files

* If there is no DOCUMENTATION entry in the plugin, raise an exception
  from _get_plugin_doc().  Everywhere we use _get_plugin_doc(), this is
  treated as an error

* If there is no ANSIBLE_METADATA raise an exception as well as
  displaying of docs assumes that this has been set.

* If there is neither DOCUMENTATION nor ANSIBLE_METADATA, warn about the
  lack of METADATA and error on the lack of DOCUMENTATION.  Lack of
  DOCUMENTATION is more important so it is what the user should see.

* Add a few special cases for backwards compat.  These should probably
  be made errors in 2.10:
  * no docs but has metadata shows no documentation rather than an error
  * empty plugin file shows no doumentation rather than an error

* Simplify backwards compatibility logic.
2019-09-17 15:45:30 -07:00