Commit graph

5337 commits

Author SHA1 Message Date
Michael DeHaan
b9e72cdd98 Warn when there is a space in the mount module opts parameter. 2013-06-01 11:33:17 -04:00
Michael DeHaan
9f567f05d6 Document group_vars and host_vars additional paths. 2013-06-01 10:40:39 -04:00
Michael DeHaan
6cd3ba5b06 Allow the group_vars and host_vars directories to be stored alongside the playbook as well as inventory. 2013-06-01 10:38:16 -04:00
Michael DeHaan
9736ec03a9 Merge pull request #3089 from kentfrazier/unsafe-extra-vars-fix
Keep ansible-playbook from bombing without extra-vars
2013-06-01 06:06:00 -07:00
Kent Frazier
3316b87059 Keep ansible-playbook from bombing without extra-vars
A recent change to ansible-playbook to support json extra-vars
also inadvertently broke the script when no extra-vars are
provided. Simply checking to make sure it is defined and truthy
should take care of the issue.
2013-05-31 22:37:16 -05:00
Michael DeHaan
9122efb24a Merge pull request #3083 from mvo5/feature/facts-add-statvfs
add "size_{total,free}" to the "mount" facts
2013-05-31 14:22:58 -07:00
Michael DeHaan
5edc130476 Merge pull request #3081 from qjcg/arch-optdepends
Added optional dependencies for fireball mode to PKGBUILD.
2013-05-31 14:21:27 -07:00
Michael DeHaan
f9ddfc6cab Merge pull request #3080 from bigpandaio/devel
Issue #3079: Initializing key_exists in case the S3 bucket does not exis...
2013-05-31 14:21:02 -07:00
Michael DeHaan
049b77be6d Merge pull request #3076 from mmoya/userspace-arch-facts
Provide userspace_{architecture,bits} facts
2013-05-31 14:20:38 -07:00
Michael DeHaan
514f18acac Merge branch 'solaris-network-facts' of git://github.com/chrisgardner/ansible into devel 2013-05-31 17:16:13 -04:00
Michael DeHaan
47b9db0d98 Remove debug statement in previous patch. 2013-05-31 17:13:54 -04:00
Michael DeHaan
eec53347b5 Merge branch 'devel' of git://github.com/trbs/ansible into groups 2013-05-31 17:13:41 -04:00
Stephen Fromm
43d96ba335 cleanup to dmi fact discovery
When invoking dmidecode, first use module.get_bin_path() and secondly
use module.run_command.
Remove sub function execute() from get_dmi_facts().
Simplify get_dmi_facts() by only using two mechanisms to determine dmi
facts:  first try /sys/devices/virtual/dmi and if not available, use
dmidecode executable.
2013-05-31 17:10:34 -04:00
Michael DeHaan
2c9a6ba2e9 Merge pull request #3085 from benjixx/remove-unused-git-function
remove unused git function is_current_branch (looks like it returns alwa...
2013-05-31 14:05:53 -07:00
Benjamin Schwarze
a0c89e742e remove unused git function is_current_branch (looks like it returns always True anyway which might be wrong) 2013-05-31 22:27:56 +02:00
Michael DeHaan
80bebc1806 Merge pull request #3069 from benjixx/consistently-get-bin-path-for-git
consistently use module.get_bin_path('git', True) to get git path before...
2013-05-31 13:21:00 -07:00
Michael DeHaan
d078ad5a13 Merge pull request #3068 from lorin/authkey-default
authorized_key: Set manage_dir default value
2013-05-31 13:16:44 -07:00
Michael DeHaan
4afc0a5c03 Merge pull request #3044 from chrisgardner/solaris_facts
Solaris facts
2013-05-31 13:15:58 -07:00
Michael DeHaan
d5182f5c92 Update changelog 2013-05-31 16:08:29 -04:00
Michael DeHaan
fbba92b61e Add an example of JSON extra variables on the command line. 2013-05-31 16:07:40 -04:00
Michael DeHaan
b19609b98b Slight docs tweak 2013-05-31 16:05:07 -04:00
Michael DeHaan
0837c9785f Merge pull request #3040 from bfabio/devel
Support JSON in --extra-vars.
2013-05-31 13:06:05 -07:00
node
a58baae2c4 Make the actual user used for executing play available as 'ansible_ssh_user' variable 2013-05-31 16:03:56 -04:00
Michael DeHaan
957a7bf373 Merge pull request #3020 from rtheys/virt-state
Support state parameter in list_vms command
2013-05-31 13:03:48 -07:00
Benjamin Schwarze
3cae9d6d0d use module.get_bin_path('git', True) once and pass git_path to functions 2013-05-31 21:42:15 +02:00
Michael DeHaan
69d514100c Refine error message. 2013-05-31 15:23:24 -04:00
Michael DeHaan
0b30c74e86 Merge branch 'rc.d-systemd' of git://github.com/glensc/ansible into sysd 2013-05-31 15:20:48 -04:00
Michael Vogt
6acf9a9b3b use statvfs.f_bavail to match the output of "df -B1" 2013-05-31 21:20:40 +02:00
Michael DeHaan
ee6ea97435 Merge pull request #3082 from pol/devel
Handle '#' in var strings by splitting on ' #'
2013-05-31 12:14:23 -07:00
Michael Vogt
73a12b04a4 add "size_{total,free}" to the "mount" facts 2013-05-31 21:01:45 +02:00
Pol Llovet
4432c01ceb Handle '#' in var strings by splitting on ' #'
If someone has a " #" in a quoted var string, it
will interpret that as a comment and refuse to
load the inventory file due to an unbalanced
quote. Noisy failure > unexpected behavior.
2013-05-31 12:34:45 -06:00
John Gosset
424109d8de Added optional dependencies for fireball mode to PKGBUILD. 2013-05-31 12:53:52 -04:00
Shahar Kedar
fe6ca38bec Issue #3079: Initializing key_exists in case the S3 bucket does not exist 2013-05-31 16:37:37 +03:00
Michael DeHaan
4a5b567f0c Merge pull request #3078 from bennojoy/devel
bug fix nova_compute
2013-05-31 05:25:24 -07:00
bennojoy
0b93c68d57 bug fix nova_compute 2013-05-31 17:39:00 +05:30
Michael DeHaan
7628ccbfe4 Merge pull request #3075 from dahpgjgamgan/doc_yaml_fix
advanced playbooks docs yaml snippets always use ---
2013-05-31 04:39:37 -07:00
Maykel Moya
d0843a7f55 Provide userspace_{architecture,bits} facts
When running inside a chroot userspace architecture might not
match that of the actual host.

This patch provides userspace_bits as reported by python's
platform.architecture(). Also provides userspace_architecture fact
if host is an x86 machine.
2013-05-31 12:24:43 +02:00
Jan Duzinkiewicz
8ebd1792eb advanced playbooks docs yaml snippets always use --- 2013-05-31 10:54:13 +02:00
Chris Gardner
1b8adab2cc Add Solaris network facts. IPv4 and IPv6 both working. 2013-05-31 00:57:23 +01:00
trbs
b537aff586 Fix for #3062 additional groups should only be added once.
Also consolidated duplicate groups code into one get_groups_set() method.
Removed unused call to user_group_membership.
Removed sorting operations on set functions cause sets are inherently unordered.
Minor style improvements to match the rest of the code.

The new function will make the order of group names passed to the system command less determistic.
Which was already the case for modify_user_usermod() but not for other methods.
It will also strip out duplicate group names automatically which was not always the case previously.
2013-05-30 19:18:18 -04:00
Lorin Hochstein
8c9cceacbf authorized_key: Set manage_dir default value
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
2013-05-30 16:16:14 -04:00
Michael DeHaan
b8630d2bc4 Merge pull request #3067 from pol/devel
Remove inline comments from inventory tokenizing.
2013-05-30 13:16:14 -07:00
Pol Llovet
ba78360c52 Remove inline comments from inventory tokenizing. 2013-05-30 14:12:23 -06:00
Michael DeHaan
ad1a02aa55 Merge pull request #3064 from sfromm/issue2990
Verify /proc/modules is readable (issue #2990)
2013-05-30 11:12:30 -07:00
Michael DeHaan
77ffef5379 Merge pull request #3065 from sfromm/issue2983
Use get_bin_path to find mkfs command (issue #2983)
2013-05-30 11:12:14 -07:00
Stephen Fromm
00b3a450c7 Verify /proc/modules is readable (issue #2990) 2013-05-30 10:25:48 -07:00
Stephen Fromm
3127bab6d6 Use get_bin_path to find mkfs command (issue #2983) 2013-05-30 10:25:35 -07:00
Michael DeHaan
0c03a5cfc2 Merge pull request #3049 from stoned/cmd-expanduser-once
No need to expanduser() command's chdir argument twice
2013-05-30 05:48:47 -07:00
Michael DeHaan
27640de0a3 Merge pull request #3058 from markmandel/devel
Updated vagrant external plugin
2013-05-30 05:47:02 -07:00
Chris Gardner
2b71ab6765 Fix typo. Solaris 9 should now correctly ignore 'brand' and use 'implementation'. 2013-05-30 08:51:03 +01:00