Commit graph

40044 commits

Author SHA1 Message Date
Johannes Brunswicker
bacbd4e9fc Add ssl support to consul_kv lookup (#42456)
* implemented lookup_consul_kv
* added missing version_added for consul_url ini section
* added default value for ANSIBLE_CONSUL_CLIENT_CERT and added some more documentation
* removed trailing whitespaces
* fixed indention
* Fixes in Documentation
* removed trailing whitespace
* removed trailing whitespace
2018-10-02 11:01:03 -04:00
Peter Jenkins
0a55431d83 Correct invalid example in jenkins_script docs (#46193) 2018-10-02 08:04:28 -05:00
Erwan Quelin
87416a4b91 Fix typo in the author's github username.
Ansibot is looking at the author's github username to query reviews for
modules in the same namespace.
2018-10-02 13:57:27 +02:00
cadl42
a7221dd289 Ignore empty result of rabbitmqctl list_user_permissions (#35598)
Fix #34863
2018-10-02 15:08:50 +05:30
mrmagooey
b2dc7075df vcenter_folder - fix error events being generated, incorrect parent folders (#45951)
* fix error events being generated when vmware folders exist
* fix incorrect parent folders being identified (wrong type)
2018-10-02 14:47:35 +05:30
Egor Zaitsev
6df1f6b203 New module: routeros_facts – collect facts from RouterOS devices (#46114)
* feat(routeros): implement routeros_facts module

* fix(routeros): review by felixfontein

* fix(routeros): review by ganeshrn

* fix(routeros): review by felixfontein
2018-10-02 13:44:23 +05:30
Will Thames
411397a975 Use recursive_diff for kubernetes (#45645)
Move recursive_diff from cloudfront_distribution to
common.dict_transformations and reuse it in k8s modules
2018-10-02 03:24:52 -04:00
Jordan Borean
c20433e5e4 remove comments from multiplle yaml string that breaks tests for now 2018-10-01 18:16:23 -07:00
Zim Kalinowski
2a4bf670bb
clean up doc - removed required: false (#46357) 2018-10-01 15:39:40 -07:00
Juan Martinez
25a192034f Use specified loopvar in include_role example loop 2018-10-01 17:39:10 -04:00
Pilou
b76c4c840e WIP: Check that union Jinja filter can be chained (#46298)
* Check that union Jinja filter can be chained

* set filters: fix unexpected templating type error

this error occurs with Jinja 2.10 since 32ec69d827,
for example when union filters are chained:

$ ansible all -i localhost, -mdebug -a"msg={{ []|union([])|union([]) }}"
localhost | FAILED! => {
    "msg": "Unexpected templating type error occurred on ({{ []|union([])|union([]) }}):
            unsupported operand type(s) for +: 'set' and 'list'"
}
2018-10-01 16:30:24 -04:00
Will Thames
d388e09940 Add the k8s label to the k8s files
k8s label for inventory plugin, module_utils
and modules
2018-10-01 15:04:48 -04:00
Nathaniel Case
cdaf5bd806
Add configuration to override location of ansible-connection (#46128)
* Add configuration to override location of ansible-connection

* Check var or argv[0] before $PATH
2018-10-01 14:29:59 -04:00
Brian Coca
d3d812b604 avoid tests when ncclient is not installed 2018-10-01 13:43:26 -04:00
Artur Juraszek
c0de93310f Mention YAML as a AWS CloudFormation template language (#46345) 2018-10-01 12:23:56 -04:00
David Baumann
c97f2b4c01 Fix callout json plugin show global stats (#43123)
* fix callback Plugin json to support global stat set by set_stats module

* refactor to not break compatiblity, add trailing comma on output dict

* Remove sorted, as it not needed

* refactor, to sivels better code

* clean some code messup

* add changelog fragment

* added missing new line

* fix pep8 stuff
2018-10-01 11:06:14 -05:00
Chris Scheib
6b00d4df5d Add logstash_plugin example for lower heap size
In a scenario where you've set your logstash heap size high, you may need to set your heap lower in order to execute logstash-plugin while logstash is still running.

Here's an example of someone running into insufficient memory while executing logstash-plugin: https://discuss.elastic.co/t/logstash-plugin-and-jvm-options/99646

This scenario is probably fairly common, so it may be worth documenting as an example.

+label: docsite_pr
2018-10-01 12:01:24 -04:00
Simon Dodsley
a9b7356f2d Add label pure_storage for all related files. Add team_purestorage macro 2018-10-01 11:55:47 -04:00
Rémy Léone
6e855658a9 Add new member to botmeta 2018-10-01 11:48:11 -04:00
Jason Meridth
667c40e80b Fix typo in ec2_vpnc_nat_gateway module (#46304)
- Added space between `format` and `in` on return item `create_time`
2018-10-01 09:16:04 -05:00
Daniel Jaouen
404b7140b6 homebrew_cask: Fixes #38772 2018-10-01 09:49:06 -04:00
abarbare
c5d5d08b6b feat: add scaleway security_group_rule management (#45694)
* feat: add scaleway security_group_rule management
2018-10-01 12:37:48 +01:00
Remo Wenger
83e584577a docker_container: ambiguous parameter "stop_timeout" (#43874)
* docker_container: Honour stop_timeout when creating docker containers (#43814)

* Adjusting description to what actually happens.

See docker-py changelog for 2.7.0: 'APIClient.stop will
no longer override the stop_timeout value present in the
container’s configuration.'

* Add a test whether stop_timeout can be configured for the container.

* Added changelog.

* Integrate with comparisons (by default, ignore stop_timeout value for restarts; will be configurable with PR ansible/ansible#44789).

* Fix config change code and tests (#2)

* Improving wildcard test.
* Using correct config.
2018-09-30 12:03:53 +01:00
Matthew Krupcale
277bb3066c seboolean: Fix issue with changing persistent SELinux boolean values (#22779)
Previously, when the active SELinux value was the same as the desired value, regardless of the value of `persistent`, the module would simply exit successfully, assuming no need for update. This made the assumption that the active and persistent values should be the same, but that is not always the case. This modification treats both the active and persistent values separately when checking for the need to update. Note that the persistent update mode, however, will still update the active as well as the persistent value. If this is not desired, it is possible to separately toggle the active value alone.

Other changes:
* Make the check mode actually perform checks for changes
* Organizes semanage commands into set of logical steps
2018-09-28 19:04:33 -04:00
Daniel Jakots
2769a4e2cc Add support for OpenBSD (#46147) 2018-09-28 16:07:44 -04:00
Sam Doran
8b1ae30e2e
Use bytes rather than native string for result (#46281)
This prevents a stack trace in Python 3 when the result is an empty file since
the file is open in binary mode and a native string in Python 3 is str,
not bytes.
2018-09-28 16:04:50 -04:00
Brian Coca
2d01966e87 better error on empty playbook
fixes #45480
2018-09-28 15:21:57 -04:00
Enno Gröper
1ff331e66a Update playbooks_delegation.rst (#46254)
Fix example variable lookup.

+label: docsite_pr
2018-09-28 13:38:52 -05:00
Alicia Cozine
66eb5681f4 yes, we do run validate_modules in Shippable (#46280) 2018-09-28 14:09:14 -04:00
Dag Wieers
ff06320b03 Add less judgmental hint to use script + template 2018-09-28 19:19:58 +02:00
Dag Wieers
d6bd52ad59 Add unit tests 2018-09-28 19:19:58 +02:00
Dag Wieers
84437855c9 Add integration tests
By checking the cmd result with the original we cause these tests to
fail on older releases without this PR.
2018-09-28 19:19:58 +02:00
Dag Wieers
b72e989e18 Ensure _raw_params retain exact spaces
This fixes a few issues related to multi-line YAML strings that eat
whitespace and add whitespaces after newlines (that weren't there).
2018-09-28 19:19:58 +02:00
Sam Doran
77f73f6d2a
Use unicode instead of bytes (#46234)
The stdout and stderr values returned from self._low_level_execute() are text, not bytes. This results in an error in Python 3 since str and bytes cannot be concatenated.

Changing to unicode type allows this to work without error on Python 2 and Python 3.
2018-09-28 12:51:17 -04:00
Metzger, Simon
00d78d7ef3 added period in description. Changed integration test to work correctly. 2018-09-28 18:45:13 +02:00
Metzger, Simon
285af0b6fb added parameter leaf_port_blk_description in module and integration tests 2018-09-28 18:45:13 +02:00
Metzger, Simon
be2c73ac18 be compliant to pep8 and pylint. Added integration tests. 2018-09-28 18:45:13 +02:00
Metzger, Simon
cdd66295f2 changed documentation strings 2018-09-28 18:45:13 +02:00
Metzger, Simon
4d7cd4bea7 added new module aci_access_port_block_to_access_port 2018-09-28 18:45:13 +02:00
Andrii Trykush
90126f37cd Corrected typo
Corrected typo
ansible_serach_path --> ansible_search_path
+label: docsite_pr
2018-09-28 12:41:05 -04:00
Vlad Mencl
ef131c7556 module/systemd: fix logic determining if a service needs to be enabled (#46245)
* modules/systemd: fix logic: allow scope to default to 'system'

Fix logic introduced in 7ea909418e: if 'scope' param is not specified,
it defaults to system, but the value of module.params['scope'] is None,
not 'system' - so allow for that.

* modules/systemd: fix logic: disabled means disabled

Fix logic determining whether a service with both systemd and initd files is enabled or disabled.

In situations where systemd thinks service is disabled, but rc.d symlinks mark it as enabled,
this module wrongly assumes the service is enabled.

Fix this logic: disabled means disabled

Only when the output from does NOT include disabled, consider the status of rc.d symlinks.

This essentially replicates the fixes done to the systemd handling in the "service" module in 3c89a21e0c

Fixes #22303

Fixes #44409
2018-09-28 12:05:48 -04:00
Dave Buckley
dae2172045 fix wording for silencing a sensu client (#46250) 2018-09-28 09:39:46 -05:00
Brendan Jurd
ab96bbdef9 Clean up Vault docs in User Guide. (#46188)
* Fix spelling of 'separate' throughout.

* Various cleanups in the User Guide for Vault.

- Fix spelling of 'algorithm'
- Fix indentation of nested list in payload format
- Fix mysterious refernce to 'b_pkey1'.
- Fix reference to newline as '\n': the backslash is lost when rendered
to the docs website. Specify the hex value for newline instead of the
backslash escape.

* Fix formatting

* Update vault.rst
2018-09-28 10:16:58 -04:00
Kevin Breit
a690917b5f Meraki scenario guide - Changed section markup types (#46158)
* Changed section markup types, small fixes for style
- Add dashes per style guide
- Add TOC in case this grows
2018-09-28 08:58:41 -05:00
Ondra Machacek
142d1f1f1c ovirt_host: Fix fail condititon of upgrade (#46104)
Signed-off-by: Ondra Machacek <omachace@redhat.com>
2018-09-28 09:59:59 +01:00
Felix Fontein
e76596a115 No longer necessary since #33792 and #45628. (#45603) 2018-09-28 09:12:31 +01:00
Felix Fontein
84682464c7 docker_container: allow to configure comparison for existing containers (#44789)
* Added comparison configuration.

* Improving user feedback on specifying a wrong option.

* Avoid bare except.

* Added basic integration tests.

* Adding wildcard support.

* Warn if ignore_image=yes is overridden.

* Added changelog fragment.
2018-09-28 08:33:38 +01:00
Sloane Hertel
9efc3dc761
Fix ec2_group for EC2-Classic accounts (#46242)
* Fix ec2_group for EC2-Classic accounts

* changelog
2018-09-27 23:11:04 -04:00
Jordan Borean
23c94295dc
Revert "powershell - fix for ANSIBLE_KEEP_REMOTE_FILES on older Pythons (#45942)" (#46238)
This reverts commit ce515a626c.
2018-09-28 09:04:03 +10:00
Pilou
15d46ce428 k8s/oc plugins: fix 'ResourceField' is not JSON serializable (#46145)
Fixes #44408
2018-09-27 18:43:29 -04:00